D19214: [sddm-theme] Replace login button label with icon

rooty added a comment. How odd - I can reproduce this bug on neon but not on Arch, and I have no idea why REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D19214 To: rooty, #vdg, #plasma Cc: ngraham, filipf, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenB

D17930: Be less memory-hungry when compiling the Keyboard KCM's gemoetry parser

ngraham abandoned this revision. ngraham added a comment. Can't reproduce the original issue anymore, and apparently this wasn't really the right solution anyway. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17930 To: ngraham, #plasma, hein, davidedmundson

D19214: [sddm-theme] Replace login button label with icon

ngraham added a comment. However, if we do end up going with this, then we rally need to fix this bug first, since it becomes significantly worse and more noticeable with this patch: F6630977: gets taller.webm

D19214: [sddm-theme] Replace login button label with icon

ngraham added a comment. FWIW I really really like this visual style. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D19214 To: rooty, #vdg, #plasma Cc: ngraham, filipf, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreu

D19077: Redesign the theme preview window

ngraham added a comment. Getting there! In D19077#417120 , @filipf wrote: > In D19077#417105 , @ngraham wrote: > > > This introduces a new warning: > > WARNING: viewBackgroundColor is depreca

D19214: [sddm-theme] Replace login button label with icon

rooty updated this revision to Diff 52355. rooty added a comment. Add comment to lock screen code too REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19214?vs=52354&id=52355 BRANCH loginbutton-icon (branched from master) REVISION DETAIL https:

D19214: [sddm-theme] Replace login button label with icon

rooty updated this revision to Diff 52354. rooty added a comment. Explain usage of IconItem REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19214?vs=52264&id=52354 BRANCH loginbutton-icon (branched from master) REVISION DETAIL https://phabrica

D19077: Redesign the theme preview window

filipf updated this revision to Diff 52351. filipf added a comment. save some vertical space, don't use max line count and elision REPOSITORY R123 SDDM Configuration Panel (KCM) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19077?vs=52249&id=52351 BRANCH master REVISION DETAI

D19214: [sddm-theme] Replace login button label with icon

filipf added a comment. In D19214#417762 , @ngraham wrote: > It would probably be worth mentioning that in a comment--or fixing the PC2 button to always vertically center the icon. Alternatively, maybe the PlasmaComponents3 button works better?

D18245: [DrKonqi] Create QApplication in a scope to fix possible deadlock

croick added a subscriber: ossi. croick added a comment. I dug in the history of KCrash and realized, that closing all the file descriptors was introduced (7bbf112e5e97d40b9a4f9fdd167b064a1019843b ) to make the X11 wi

D19214: [sddm-theme] Replace login button label with icon

ngraham added a comment. It would probably be worth mentioning that in a comment--or fixing the PC2 button to always vertically center the icon. Alternatively, maybe the PlasmaComponents3 button works better? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D

D18245: [DrKonqi] Create QApplication in a scope to fix possible deadlock

croick added a comment. The following steps allow creating the backtraces. Simply attaching to KDevelop does not work, since that sends a SIGSTOP to all threads (and releases the dead lock). Attaching to DrKonqi after closing the dialog does not work since the process already is defunct:

D19233: [plasmoidviewer] Add --nobuttons flag to hide button bar

Zren created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Zren requested review of this revision. REVISION SUMMARY This also fixes the `Background { id: backgroundButtons }` not hiding by binding it's visibility to `buttons.visible`. Is the "bugfi

D19011: Thunderbolt KCM and KDED module

ngraham added a comment. In D19011#417634 , @dvratil wrote: > "Stored" is a term for a remembered device. When you authorize a device, the authorization is "stored", or remembered, so you don't have to authorize it again next time. Maybe "Rememb

D19230: [Digital Clock] Replace 12/24hr tri-state checkbox in config UI with combobox

ngraham added a comment. Thanks @zren. Moving "Use locale default" to the middle position makes everything work perfectly. I tested the upgrade use cases and the combobox is always pre-populated with the correct value. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator

D19230: [Digital Clock] Replace 12/24hr tri-state checkbox in config UI with combobox

ngraham updated this revision to Diff 52329. ngraham edited the test plan for this revision. ngraham added a comment. Put "Use locale default" in the middle so everything works properly (it looks kinda cool there too) REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://pha

D19011: Thunderbolt KCM and KDED module

dvratil added a comment. "Stored" is a term for a remembered device. When you authorize a device, the authorization is "stored", or remembered, so you don't have to authorize it again next time. Maybe "Remember" would be a better term, then? REPOSITORY R119 Plasma Desktop REVISION DETAIL

D19194: Adjust date string height to match time string with vertical panel

Zren added inline comments. INLINE COMMENTS > anthonyfieroni wrote in DigitalClock.qml:305 > You should check if panel orientation, now it's broken horizontal view? This is inside a `State { when: plasmoid.formFactor == PlasmaCore.Types.Vertical }` REPOSITORY R120 Plasma Workspace REVISION

D19230: [Digital Clock] Replace 12/24hr tri-state checkbox in config UI with combobox

Zren added a comment. https://doc.qt.io/qt-5/qt.html#CheckState-enum `i18n("Use locale default")` should be in the middle (`currentIndex=1`). 12h should be `currentIndex=0`, and 24h should be `currentIndex=2` https://github.com/KDE/plasma-workspace/blob/master/applets/digital-clock/

D19230: [Digital Clock] Replace 12/24hr tri-state checkbox in config UI with combobox

ngraham created this revision. ngraham added reviewers: Plasma, Zren. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY The use of a tri-state checkbox for the three possible states (12hr, 24hr, use locale defa

D19096: Improvements for long label items in Application Dashboard

trmdi added inline comments. INLINE COMMENTS > hein wrote in ItemGridDelegate.qml:117 > What do the hover changes do in this patch? :) It helps to display the tooltip. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19096 To: trmdi, ngraham, hein, #plasma, #vdg

D19096: Improvements for long label items in Application Dashboard

trmdi updated this revision to Diff 52321. trmdi edited the test plan for this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19096?vs=52167&id=52321 REVISION DETAIL https://phabricator.kde.or

D19096: Improvements for long label items in Application Dashboard

hein added inline comments. INLINE COMMENTS > ItemGridDelegate.qml:117 > + > +onContainsMouseChanged: { > +if (!containsMouse) { What do the hover changes do in this patch? :) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19096 To: trmdi,

D18644: GlobalDrawerActionItem: properly reference icon by using group property.

This revision was automatically updated to reflect the committed changes. Closed by commit R169:15a36dd020c4: GlobalDrawerActionItem: properly reference icon by using group property. (authored by pwegner, committed by apol). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabrica

D19148: Make shadow sizes linear

ngraham added a comment. On the one hand, it's true that the window shadows are now noticeably darker than KStyle shadows. On the other hand I'm not sure this is //necessarily// a problem. Ultimately the KStyle shadows are a largely an aesthetic matter, and don't present any problems of not

D18644: GlobalDrawerActionItem: properly reference icon by using group property.

pwegner added a comment. I can't push that myself, I don't have write access. REPOSITORY R169 Kirigami BRANCH arcpatch-D18644_1 REVISION DETAIL https://phabricator.kde.org/D18644 To: pwegner, #kirigami, mart Cc: plasma-devel, dkardarakos, apol, davidedmundson, mart, hein

D19226: [about-distro] let distributions choose VERSION_ID or VERSION

This revision was automatically updated to reflect the committed changes. Closed by commit R102:99f10f1e5580: [about-distro] let distributions choose VERSION_ID or VERSION (authored by sitter). REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19226?vs=52300&

Re: powerdevil screen brightness linear vs nonlinear adjustment idea

Hi, PowerDevil maintainer here. Unfortunately, I haven't had much time to look after PowerDevil, but I agree that a logarithmic scale for screen brightness makes sense. Perhaps PowerDevil can even abstract that way from the user, so the UI in Battery Monitor for instance stays linear 0-100%

D19226: [about-distro] let distributions choose VERSION_ID or VERSION

sitter created this revision. sitter added a reviewer: apol. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sitter requested review of this revision. REVISION SUMMARY by default we display VERSION_ID because it is the pure numeric representation while VERSION may cont

Re: Doxygen code style

On Tue, Feb 19, 2019 at 12:00 PM Roman Gilg wrote: > > Commit > https://phabricator.kde.org/R108:7b20e1f66f83657591001f473d31555c295e5569 > changes Doxygen comments style in KWin to the uniform pattern > > /** > * > **/ > > with two stars at the end. > > Looking at upstream examples > http://www

D19181: [about-distro] run logo lookup via osrelease

This revision was automatically updated to reflect the committed changes. Closed by commit R102:d5b56b448c90: [about-distro] run logo lookup via osrelease (authored by sitter). REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19181?vs=52277&id=52298 REVISIO

Fwd: Plasma 5.16 Kickoff Meeting Notes

Plasma 5.16 Kickoff bshah d_ed sho ilya_b nicofee kbroulik ngraham notmart acheronuk romangg * 5.15 review No fires Good media coverage Good meta testing New contributors Everything is awesome * 5.16 schedule agreed * 5.16 deps Qt 5.12 * LTS Ubuntu LTS feature freeze Feb 2020 openSuSE may wan

D15907: Compare float values in DecorationButton contains check

romangg added a subscriber: zzag. romangg added a comment. In D15907#417286 , @zzag wrote: > Alright, I'm done. Maybe you misunderstood the last comment. Your autotest does not test the case if the size of the button is negative. Since th

D19148: Make shadow sizes linear

zzag added a comment. ... though if vdg is okay with the proposed shadows, feel free to push. REPOSITORY R31 Breeze BRANCH shadow-sizes (branched from master) REVISION DETAIL https://phabricator.kde.org/D19148 To: ndavis, #vdg, #breeze, ngraham Cc: filipf, ngraham, zzag, rooty, plasma

D15907: Compare float values in DecorationButton contains check

zzag resigned from this revision. zzag added a comment. Alright, I'm done. I don't understand what's the point of review where comments are ignored. The fact that reviewer has to address review comments strikes me odd the most, like it's his/her/their responsibility. It's really sad that

D19160: [about-distro] update osrelease parser for latest values in spec

This revision was automatically updated to reflect the committed changes. Closed by commit R102:d1ce16a6e558: [about-distro] update osrelease parser for latest values in spec (authored by sitter). REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19160?vs=520

D19182: [about-distro] run variant through os-release

This revision was automatically updated to reflect the committed changes. Closed by commit R102:affa7b1139b4: [about-distro] run variant through os-release (authored by sitter). REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19182?vs=52144&id=52279 REVISI

D19181: [about-distro] run logo lookup via osrelease

sitter marked an inline comment as done. sitter added inline comments. INLINE COMMENTS > apol wrote in Module.cpp:153 > Put os.logo as the fallback? hm, yeah, I do wonder why I wrote it the way I did. REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D19181 To: sitte

D15907: Compare float values in DecorationButton contains check

romangg added a comment. QRectF with negative size is untested. REPOSITORY R129 Window Decoration Library REVISION DETAIL https://phabricator.kde.org/D15907 To: romangg, #kwin, zzag, davidedmundson Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensr

D19181: [about-distro] run logo lookup via osrelease

sitter updated this revision to Diff 52277. sitter added a comment. use os.logo as fallback REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19181?vs=52143&id=52277 BRANCH os-release-logo REVISION DETAIL https://phabricator.kde.org/D19181 AFFECTED

D19148: Make shadow sizes linear

zzag added a comment. In D19148#417272 , @ndavis wrote: > But then we run into a problem where small shadows aren't visible enough to serve their purpose. Just increase opacity of shadow from ambient light. :-) > How about we just ge

D19148: Make shadow sizes linear

ndavis added a comment. In D19148#417251 , @zzag wrote: > Well, I guess that depends on the light. After all we don't try to model "physically correct" shadows. > > Anyway, I've asked that question about opacity because most folks do the sam

D15907: Compare float values in DecorationButton contains check

zzag added a comment. void DecorationButtonTest::testContains_data() { QTest::addColumn("geometry"); QTest::addColumn("pos"); QTest::addColumn("contains"); QTest::newRow("left edge (integer)") << QRectF(0, 0, 10, 10) << QPointF(0, 5) << true;

D19160: [about-distro] update osrelease parser for latest values in spec

sitter added a comment. @apol I agree, alas, there was not much interest when I brought it up ;) https://markmail.org/thread/ixd2d5t2u7b3tuww REPOSITORY R102 KInfoCenter BRANCH os-relesae REVISION DETAIL https://phabricator.kde.org/D19160 To: sitter, apol Cc: apol, plasma-devel, jra

D19148: Make shadow sizes linear

zzag added a comment. Well, I guess that depends on the light. After all we don't try to model "physically correct" shadows. Anyway, I've asked that question about opacity because most folks do the same thing. Also, this is what I did in kstyle. Even though kstyle and kdecoration shadow