D20930: Update WireGuard to match NetworkManager 1.16 interface

andersonbruce added a comment. In D20930#462365 , @ngraham wrote: > I'm afraid I don't have the ability to test this; could you post a new screenshot? Thanks! Here's a screenshot of the dialog with three peers:F6814829: Tabs.png

D21075: [QQC2 Slider Style] Fix wrong handle positioning when initial value is 1

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Very nice. @mart, does this look like the right fix? REPOSITORY R858 Qt Quick Controls 2: Desktop Style BRANCH fix-qqc2-slider-when-from-is-1 (branched from master) REVISION

D21056: [System Load Viewer] Port settings window to QQC2+Kirigami FormLayout and modernize UI

This revision was automatically updated to reflect the committed changes. Closed by commit R114:864c0bf28a09: [System Load Viewer] Port settings window to QQC2+Kirigami FormLayout and… (authored by ngraham). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE

D21056: [System Load Viewer] Port settings window to QQC2+Kirigami FormLayout and modernize UI

ngraham updated this revision to Diff 57745. ngraham marked an inline comment as done. ngraham added a comment. Remove unused import REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21056?vs=57692=57745 BRANCH monitor-modernize-settings-window

D20930: Update WireGuard to match NetworkManager 1.16 interface

ngraham added a comment. I'm afraid I don't have the ability to test this; could you post a new screenshot? Thanks! REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D20930 To: andersonbruce, jgrulich, #vdg Cc: ngraham, plasma-devel, jraleigh,

D20930: Update WireGuard to match NetworkManager 1.16 interface

andersonbruce added a comment. A fairly large update was made to change the input of peer data to a use a QTabWidget interface to switch between peers rather than a spin box. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D20930 To:

D20930: Update WireGuard to match NetworkManager 1.16 interface

andersonbruce updated this revision to Diff 57741. andersonbruce added a comment. Change to tab bar interface for peers REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20930?vs=57434=57741 BRANCH TwoTabs REVISION DETAIL

D16997: [kcm] Expose interface to control output property retention

romangg added a comment. Another detail is that currently in a display arrangement with multiple screens one of the screens could use arrangement-unique values while another screen could use global ones. This is imo too complicated. Either the user wants to write/read to global values for

D21075: [QQC2 Slider Style] Fix wrong handle positioning when initial value is 1

filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY Old code was not reading value properly when initial value was 1, misplacing the handle as a result. BUG: 405471 REPOSITORY

D21056: [System Load Viewer] Port settings window to QQC2+Kirigami FormLayout and modernize UI

filipf accepted this revision. filipf added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > ColorSettings.qml:24 > +import QtQuick.Controls 2.5 as QQC2 > +import QtQuick.Layouts 1.3 > + Don't need the import anymore REPOSITORY R114 Plasma Addons BRANCH

D21074: [System Monitor] Port settings window to QQC2+Kirigami FormLayout and modernize UI

ngraham created this revision. ngraham added reviewers: VDG, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY - Port to QQC2+Kirigami FormLayout style, except for the SpinBox which cannot handle decimal

D16997: [kcm] Expose interface to control output property retention

romangg added a comment. In D16997#462264 , @ngraham wrote: > In D16997#462197 , @romangg wrote: > > > [...] > > That's good wording. The only issue I see is that a display arrangement, which

D19796: [Device Notifier] Restore Solid notification messages

thsurrel updated this revision to Diff 57736. thsurrel added a comment. Fix comments. Thank you for the review! REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19796?vs=57722=57736 BRANCH arc_removed_devices REVISION DETAIL

D21062: [Lock, login & logout screen] Add visual feedback to action buttons when pressed

filipf marked 3 inline comments as done. filipf added a comment. I'm going to look into the different easing curves a bit more because I sometimes see the semi-scaled circle if clicking too fast. INLINE COMMENTS > broulik wrote in ActionButton.qml:76 > Can't you just `scale` the item

D21062: [Lock, login & logout screen] Add visual feedback to action buttons when pressed

filipf updated this revision to Diff 57735. filipf added a comment. - remove ID - height = width - use and animate scale instead of height & width REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21062?vs=57699=57735 BRANCH

D20969: [potd] Modernize configuration settings

This revision was automatically updated to reflect the committed changes. Closed by commit R114:13609c5ae7b9: [potd] Modernize configuration settings (authored by filipf). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20969?vs=57557=57734 REVISION

D20969: [potd] Modernize configuration settings

ngraham added a comment. Thanks, shipit! REPOSITORY R114 Plasma Addons BRANCH modernize-potd-config (branched from master) REVISION DETAIL https://phabricator.kde.org/D20969 To: filipf, #plasma, #vdg, ngraham Cc: abetts, davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel,

D16997: [kcm] Expose interface to control output property retention

ngraham added a comment. In D16997#462197 , @romangg wrote: > In D16997#459604 , @ngraham wrote: > > > @romangg and I talked and now I understand the feature and think it's a good idea. It needs to

D19796: [Device Notifier] Restore Solid notification messages

anthonyfieroni added inline comments. INLINE COMMENTS > DeviceItem.qml:50 > > -readonly property bool hasMessage: statusSource.lastUdi == udi && > statusSource.data[statusSource.last] ? true : false > -readonly property var message: hasMessage ? > statusSource.data[statusSource.last]

D16997: [kcm] Expose interface to control output property retention

romangg added a comment. In D16997#459604 , @ngraham wrote: > @romangg and I talked and now I understand the feature and think it's a good idea. It needs to be exposed to the user in a way that's immediately apparent though. Here's my

D16995: Consider identical display models in ControlConfig

romangg added a comment. In D16995#364739 , @mart wrote: > does this cause incompatibilities with old configs? No, this is only about the new control files. Config files already differentiate between different connectors. But after

D21062: [Lock, login & logout screen] Add visual feedback to action buttons when pressed

broulik added a comment. Looks lovely! INLINE COMMENTS > ActionButton.qml:69 > +Rectangle { > +id: highlightCircle > +anchors.centerIn: iconCircle This item isn't referenced, so it doesn't need to have an id > ActionButton.qml:71 > +anchors.centerIn: iconCircle

D21062: [Lock, login & logout screen] Add visual feedback to action buttons when pressed

abetts added a comment. +1 REPOSITORY R120 Plasma Workspace BRANCH add-pressed-state-to-action-buttons (branched from master) REVISION DETAIL https://phabricator.kde.org/D21062 To: filipf, #vdg, #plasma, ngraham, davidedmundson Cc: abetts, plasma-devel, jraleigh, GB_2, ragreen,

D19796: [Device Notifier] Restore Solid notification messages

thsurrel updated this revision to Diff 57722. thsurrel added a comment. Rebase REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19796?vs=53978=57722 BRANCH arc_removed_devices REVISION DETAIL https://phabricator.kde.org/D19796 AFFECTED FILES

D21062: [Lock, login & logout screen] Add visual feedback to action buttons when pressed

ngraham accepted this revision. ngraham added a comment. Lovely! These kinds of very subtle animations are super classy IMO. REPOSITORY R120 Plasma Workspace BRANCH add-pressed-state-to-action-buttons (branched from master) REVISION DETAIL https://phabricator.kde.org/D21062 To:

D16997: [kcm] Expose interface to control output property retention

romangg updated this revision to Diff 57720. romangg added a comment. Rebase on series changes. REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16997?vs=57671=57720 BRANCH 1controlKcm REVISION DETAIL https://phabricator.kde.org/D16997 AFFECTED FILES

D16995: Consider identical display models in ControlConfig

romangg updated this revision to Diff 57718. romangg added a comment. Rebase on series changes. REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16995?vs=57667=57718 BRANCH 1controlNameSpecific REVISION DETAIL https://phabricator.kde.org/D16995

D16996: Add method to write retention to configuration control files

romangg updated this revision to Diff 57719. romangg added a comment. Rebase on series changes. REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16996?vs=57670=57719 BRANCH 1controlWrite REVISION DETAIL https://phabricator.kde.org/D16996 AFFECTED

D16994: Split Control class into configurations and outputs control classes

romangg updated this revision to Diff 57717. romangg added a comment. Rebase on series changes. REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16994?vs=57665=57717 BRANCH 1controlClass REVISION DETAIL https://phabricator.kde.org/D16994 AFFECTED

D16993: Add a common directory for functionality being used by kcm and daemon

romangg updated this revision to Diff 57716. romangg added a comment. Rebase on series changes. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16993?vs=57663=57716 BRANCH 1commonInterfacesWithClass REVISION DETAIL https://phabricator.kde.org/D16993 AFFECTED FILES

D16992: Introduce secondary control channel of the KScreen daemon

romangg updated this revision to Diff 57715. romangg added a comment. - Add Undefined output retention value - Control::convertVariantToOutputRetention function CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16992?vs=57662=57715 BRANCH 1controlRetention REVISION DETAIL

D16991: Introduce concept of global and individual output data retention

romangg updated this revision to Diff 57714. romangg added a comment. - Set rotation default value for output CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16991?vs=57661=57714 BRANCH 1dirIndividualOutputs REVISION DETAIL https://phabricator.kde.org/D16991 AFFECTED FILES

Plasma 5.15.5

https://kde.org/announcements/plasma-5.15.5.php Sources for Plasma 5.15.5 are out now with the final set of bug fixes in the 5.15 series

KDE CI: Plasma » systemsettings » stable-kf5-qt5 SUSEQt5.12 - Build # 24 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/systemsettings/job/stable-kf5-qt5%20SUSEQt5.12/24/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Tue, 07 May 2019 09:35:12 + Build duration: 19 min and counting CONSOLE OUTPUT

KDE CI: Plasma » powerdevil » stable-kf5-qt5 SUSEQt5.12 - Build # 18 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/powerdevil/job/stable-kf5-qt5%20SUSEQt5.12/18/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Tue, 07 May 2019 09:35:00 + Build duration: 17 min and counting CONSOLE OUTPUT

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 FreeBSDQt5.12 - Build # 19 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20FreeBSDQt5.12/19/ Project: stable-kf5-qt5 FreeBSDQt5.12 Date of build: Tue, 07 May 2019 09:31:44 + Build duration: 4 min 21 sec and counting CONSOLE OUTPUT

KDE CI: Plasma » drkonqi » stable-kf5-qt5 WindowsMSVCQt5.11 - Build # 4 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/stable-kf5-qt5%20WindowsMSVCQt5.11/4/ Project: stable-kf5-qt5 WindowsMSVCQt5.11 Date of build: Tue, 07 May 2019 09:31:34 + Build duration: 2 min 26 sec and counting CONSOLE

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 SUSEQt5.12 - Build # 17 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20SUSEQt5.12/17/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Tue, 07 May 2019 09:31:44 + Build duration: 2 min 54 sec and counting CONSOLE OUTPUT

D21062: [Lock, login & logout screen] Add pressed visual feedback to action buttons

filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY The action buttons were missing a visual indication of when they were being pressed so this patch adds it by drawing an animated

D21044: Remove kde connect context menu entries when host dies

This revision was automatically updated to reflect the committed changes. Closed by commit R856:7b11fee2b906: Remove kde connect context menu entries when host dies (authored by broulik). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE

D21061: [Task Manager] Use libnotificationmanager for notification badges and application job reporting

broulik updated this revision to Diff 57697. broulik edited the test plan for this revision. broulik added a comment. - Read correct setting for enabling/disabling jobs REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21061?vs=57696=57697 REVISION

D21061: [Task Manager] Use libnotificationmanager for notification badges and application job reporting

broulik created this revision. broulik added reviewers: Plasma, hein, mvourlakos. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY This removes the setting from the individual plasmoid and has it follow global