D21668: Modernize and redesign the Night Color config window

This revision was automatically updated to reflect the committed changes. Closed by commit R119:cd6a8e081536: Modernize and redesign the Night Color config window (authored by filipf). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21668?vs=59689=59698

D21668: Modernize and redesign the Night Color config window

romangg added a comment. Looks nice! :) REPOSITORY R119 Plasma Desktop BRANCH modernize-redesign-nightcolor-config (branched from master) REVISION DETAIL https://phabricator.kde.org/D21668 To: filipf, #vdg, ngraham, romangg, mart, #plasma, davidedmundson Cc: davidedmundson,

D21668: Modernize and redesign the Night Color config window

filipf added a comment. Thanks for having a look guys :) In D21668#478879 , @ngraham wrote: > Much better! Is there a reason why we need a ColumnLayout to hold those two FormLayouts in `main.qml`? Could all the stuff in the second one just

D21725: Use a native application for starting plasma

apol updated this revision to Diff 59693. apol added a comment. --verbose REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21725?vs=59597=59693 BRANCH apol/startkde REVISION DETAIL https://phabricator.kde.org/D21725 AFFECTED FILES

D21668: Modernize and redesign the Night Color config window

ngraham added a comment. Still, this looks great as-is. Probably landable now IMO, and a big improvement. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D21668 To: filipf, #vdg, ngraham, romangg, mart, #plasma Cc: davidedmundson, plasma-devel, LeGast00n,

D21668: Modernize and redesign the Night Color config window

ngraham added a comment. Much better! Is there a reason why we need a ColumnLayout to hold those two FormLayouts in `main.qml`? Could all the stuff in the second one just go into the first one instead? Then you could get rid of the Columnlayout entirely REPOSITORY R119 Plasma Desktop

D21668: Modernize and redesign the Night Color config window

filipf updated this revision to Diff 59689. filipf edited the summary of this revision. filipf added a comment. spacing of the main ColumnLayout needs to be 0 REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21668?vs=59688=59689 BRANCH

D21668: WIP: Modernize and redesign the Night Color config window

filipf updated this revision to Diff 59688. filipf added a comment. make the form layouts respond to window resizing REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21668?vs=59682=59688 BRANCH modernize-redesign-nightcolor-config (branched from

D21326: Make limtedrowcountproxymodel usable from QML

davidedmundson abandoned this revision. davidedmundson added a comment. Discover has a pagniation model which if you only use the first page covers this case. Lets try and get that one in frameworks instead REPOSITORY R120 Plasma Workspace REVISION DETAIL

D21758: [ksmserver] Drop internal loading of alternative window managers

This revision was automatically updated to reflect the committed changes. Closed by commit R120:e89473103c5b: [ksmserver] Drop internal loading of alternative window managers (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D21757: [ksmserver] Drop multi X screen support

This revision was automatically updated to reflect the committed changes. Closed by commit R120:0916d9702a60: [ksmserver] Drop multi X screen support (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21757?vs=59628=59684

D21668: WIP: Modernize and redesign the Night Color config window

ngraham added a comment. If I had to guess, it's because they're inside a column that doesn't span the full width of the page. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D21668 To: filipf, #vdg, ngraham, romangg, mart, #plasma Cc: davidedmundson,

D21668: WIP: Modernize and redesign the Night Color config window

filipf added a comment. In D21668#478822 , @davidedmundson wrote: > > getting there; all is aligned now, it's just that the content needs to be unstiffened > > What does that mean > > Please remove the WIP tag when things are ready for

D21668: WIP: Modernize and redesign the Night Color config window

davidedmundson added a comment. > getting there; all is aligned now, it's just that the content needs to be unstiffened What does that mean Please remove the WIP tag when things are ready for review. Generally this looks good to me, ++ REPOSITORY R119 Plasma Desktop

D21668: WIP: Modernize and redesign the Night Color config window

filipf updated this revision to Diff 59682. filipf added a comment. getting there; all is aligned now, it's just that the content needs to be unstiffened REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21668?vs=59404=59682 BRANCH

D21668: WIP: Modernize and redesign the Night Color config window

filipf added a comment. OK, so everything works nice if the form layouts simply reside in main.qml as components. It's when we spawn them through loaders that we get binding loops and misalignment (even if twinFormLayouts is specified!). The loader is not specifying geometry to the layouts

D21134: [Notifications] Tweak paddings

alex-l added a comment. Just a mockup but is this middle ground solution good enough? F6885918: immagine.png ( I also suggested to move the disappearing indicator at the bottom here ) REPOSITORY R120

D19745: Fix system tray UI/UX & refactor

broulik added a comment. Will you address the broken event delivery to the compact applet item? INLINE COMMENTS > ratijastk wrote in AbstractItem.qml:22 > Not exactly. But old layouts used to have a load of restrictions, for sure. "Old layouts"? You only use `Layouts 1.2` features as far as

D21110: On config read adjust outputs positions to global value changes

romangg updated this revision to Diff 59671. romangg added a comment. Rebase on master. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21110?vs=57836=59671 BRANCH 1controlAdjustPositions REVISION DETAIL https://phabricator.kde.org/D21110 AFFECTED FILES kded/output.cpp

D16997: [kcm] Expose interface to control output property retention

romangg updated this revision to Diff 59670. romangg added a comment. Rebase on master. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16997?vs=57835=59670 BRANCH 1controlKcm REVISION DETAIL https://phabricator.kde.org/D16997 AFFECTED FILES common/control.cpp

D16996: Add method to write retention to configuration control files

romangg updated this revision to Diff 59669. romangg added a comment. Rebase on master. REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16996?vs=57834=59669 BRANCH 1controlWrite REVISION DETAIL https://phabricator.kde.org/D16996 AFFECTED FILES

D16995: Consider identical display models in ControlConfig

romangg updated this revision to Diff 59667. romangg added a comment. Rebase on master. REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16995?vs=57833=59667 BRANCH 1controlNameSpecific REVISION DETAIL https://phabricator.kde.org/D16995 AFFECTED FILES

D16994: Split Control class into configurations and outputs control classes

romangg updated this revision to Diff 59665. romangg added a comment. Rebase on master. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16994?vs=57832=59665 BRANCH 1controlClass REVISION DETAIL https://phabricator.kde.org/D16994 AFFECTED FILES common/control.cpp

D16993: Add a common directory for functionality being used by kcm and daemon

romangg updated this revision to Diff 59664. romangg added a comment. Rebase on master. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16993?vs=57831=59664 BRANCH 1commonInterfacesWithClass REVISION DETAIL https://phabricator.kde.org/D16993 AFFECTED FILES common/control.cpp

D16992: Introduce secondary control channel of the KScreen daemon

romangg updated this revision to Diff 59663. romangg added a comment. Rebase on master. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16992?vs=57830=59663 BRANCH 1controlRetention REVISION DETAIL https://phabricator.kde.org/D16992 AFFECTED FILES kded/CMakeLists.txt

D16991: Introduce concept of global and individual output data retention

romangg updated this revision to Diff 59662. romangg added a comment. Rebase on master. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16991?vs=57829=59662 BRANCH 1dirIndividualOutputs REVISION DETAIL https://phabricator.kde.org/D16991 AFFECTED FILES kded/CMakeLists.txt

D16990: [kded] Separate configuration storage path

romangg updated this revision to Diff 59661. romangg added a comment. Rebase on master. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16990?vs=57660=59661 BRANCH 1configsLocation REVISION DETAIL https://phabricator.kde.org/D16990 AFFECTED FILES kded/config.cpp

D20237: Port to new KWorkspace API

hein updated this revision to Diff 59660. hein added a comment. - Fix typo - Rebase REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20237?vs=55487=59660 BRANCH master REVISION DETAIL https://phabricator.kde.org/D20237 AFFECTED FILES

D16989: [kded] Introduce Config wrapper class

romangg updated this revision to Diff 59653. romangg added a comment. Rebase on master. REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16989?vs=57655=59653 BRANCH 1configClass REVISION DETAIL https://phabricator.kde.org/D16989 AFFECTED FILES

D21761: move SolidUiServer::showActionsDialog to hotplug dataengine

sitter updated this revision to Diff 59651. sitter added a comment. handle error conditions since we use QSP::locate we can at most have 0-1 service. in the event that we have 0 we'll set the kjob into error state and return false as result. REPOSITORY R120 Plasma Workspace

D21765: drop kdelibs4support from filebrowser dataengine

This revision was automatically updated to reflect the committed changes. Closed by commit R120:3b21b593f656: drop kdelibs4support from filebrowser dataengine (authored by sitter). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21765?vs=59643=59649

D21766: do not use legacy app_icon helper on klipper

This revision was automatically updated to reflect the committed changes. Closed by commit R120:24874e13cbeb: do not use legacy app_icon helper on klipper (authored by sitter). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21766?vs=59646=59648

D21761: move SolidUiServer::showActionsDialog to hotplug dataengine

sitter added a comment. How do I correctly forward a visible error to the caller though? This ServiceJob tech is fairly beyond me. Showing a KNotification on error may be a solution, but surely there must be a better way. REPOSITORY R120 Plasma Workspace REVISION DETAIL

D21766: do not use legacy app_icon helper on klipper

sitter created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sitter requested review of this revision. REVISION SUMMARY kde4_add_app_icon is fairly deprecated. additionally the call itself was madness because it actually pulls the icon out of oxygen

D21765: drop kdelibs4support from filebrowser dataengine

sitter created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sitter requested review of this revision. REVISION SUMMARY this engine is not used anywhere! the engine used kfilemetadata to obtain metadata of a file. KFM however is entirely defunct

D21762: do not use long deprecated QString::toAscii

apol added inline comments. INLINE COMMENTS > waylandtasksmodel.cpp:350 > // cross-process DND. > -return QString("windowsystem/winid+" + uuid.toString().toAscii()); > +return QString("windowsystem/winid+" + uuid.toString().toLatin1()); > } It's using weird API we shouldn't be

D21764: Port all plasma workspace to new libkworkspace API

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY ContainmentActions had some old windows code was dropped as that's clearly

D21763: [kcms/ksmserver] Port to new kworkspace API

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY requestShutDown is replaced TEST PLAN Bodged the code so that it made my

D21762: do not use long deprecated QString::toAscii

sitter created this revision. sitter added a reviewer: hein. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sitter requested review of this revision. REVISION SUMMARY use toLatin1 instead TEST PLAN builds REPOSITORY R120 Plasma Workspace BRANCH Plasma/5.16

D21761: move SolidUiServer::showActionsDialog to hotplug dataengine

broulik added a comment. In D21761#478528 , @sitter wrote: > I suppose it should never happen that an action cannot be resolved, so maybe an assertion to that extent is sufficient? Given device notifier only invokes it on actions it

D21761: move SolidUiServer::showActionsDialog to hotplug dataengine

sitter added a comment. I am unsure about the error handling in `HotplugJob::start` I suppose it should never happen that an action cannot be resolved, so maybe an assertion to that extent is sufficient? REPOSITORY R120 Plasma Workspace REVISION DETAIL

D21761: move SolidUiServer::showActionsDialog to hotplug dataengine

sitter created this revision. sitter added a reviewer: broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sitter requested review of this revision. REVISION SUMMARY it was the only remaining user of that dialog helper. the connection between the two was fairly

D20804: RFC: Try getting the X keyboard grab multiple times

This revision was automatically updated to reflect the committed changes. Closed by commit R133:4af9ea1e2c9d: Try getting the X keyboard grab multiple times (authored by davidedmundson). REPOSITORY R133 KScreenLocker CHANGES SINCE LAST UPDATE

D21113: Allow hiding option items depending on available extension and version in the host

broulik added inline comments. INLINE COMMENTS > fvogt wrote in options.js:82 > AFAICT it doesn't conflict, but IMO it's a bit confusing if there's both a > global array `subsystemStatus` in extension.js and a function > `subsystemStatus()` in options.js. I'll rename this to

D21748: Replace the excludeRange mode setting when already available

This revision was automatically updated to reflect the committed changes. Closed by commit R119:08ec9a036bf5: Replace the excludeRange mode setting when already available (authored by bshah). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE