D22482: WIP: Show file dialog in directory mode when only directory is requested

jgrulich added a comment. The FileChooser portal will never ask for directories, it's currently not possible to expose a directory to the sandbox environment. If you look at [1], you can see it always uses native file dialog in case of directories, which means native file dialog will be

D22468: Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami

ngraham added a comment. In D22468#496130 , @davidedmundson wrote: > > Screen size and DPI combinations are so variable that I think it makes sense to support a higher level of precision. > > Talking of which, there were some updated plans

D22457: Make it possible to show the QR of a network connection

apol added inline comments. INLINE COMMENTS > broulik wrote in ShowQR.qml:27 > Can you instad do a `StackView` and show the barcode inside the applet like > Klipper does it? This would make it more consistent. I thought about that too, my use-case was though to give access to wifi on somebody

D22457: Make it possible to show the QR of a network connection

apol updated this revision to Diff 61836. apol added a comment. Fix visible logic REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22457?vs=61835=61836 BRANCH master REVISION DETAIL https://phabricator.kde.org/D22457 AFFECTED

D22457: Make it possible to show the QR of a network connection

apol updated this revision to Diff 61835. apol marked 5 inline comments as done. apol added a comment. addressed comments REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22457?vs=61773=61835 BRANCH master REVISION DETAIL

D22468: Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami

davidedmundson added a comment. > Ha, you're totally right. Amazing! Is this something to fix in Plasma frameworks? The problem relates to use of Handlers instead of old style MouseArea. I haven't finished investigating, but I have a bad feeling QQuickWindow/QQuickWidget is the

D22468: Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami

gvarsanyi added a comment. In D22468#496052 , @ngraham wrote: > I'm not sold on the proposal to use 1.25x increments, personally. For my personal use case, I like using 1.1x (13" 1080p screen) and I wouldn't want to lose that. Screen size and

D22468: Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami

davidedmundson added a comment. > Screen size and DPI combinations are so variable that I think it makes sense to support a higher level of precision. Talking of which, there were some updated plans with regards to the UI for X scaling in the meeting that everyone in this thread was at.

D22468: Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami

mvourlakos added a comment. In D22468#496123 , @ngraham wrote: > I guess I was thinking that it should be aligned to the slider itself, like this: > > Scale: |---o---| > 1x 1.5x2x >

D22468: Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami

filipf added a comment. There is an example in the Fuzzy Clock config: F7029166: image.png In D22468#496052 , @ngraham wrote: > I'm not sold on the proposal to use 1.25x increments, personally. For

D22468: Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami

ngraham added a comment. I guess I was thinking that it should be aligned to the slider itself, like this: Scale: |---o---| 1x 1.5x2x REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D22468 To: romangg, #plasma,

D22468: Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami

mvourlakos added a comment. In D22468#496052 , @ngraham wrote: > For the scale slider, I'd put the numbers underneath, and have threenumbers; one on each end and one in the middle. So if the maximum value was 2x, it would look like this: >

D22306: Do not skip code launching application in application dashboard

ngraham added a comment. #plasma ping REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D22306 To: luc4, ngraham, trmdi, #plasma Cc: hein, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot,

D22482: WIP: Show file dialog in directory mode when only directory is requested

volkov created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. volkov requested review of this revision. REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop BRANCH Plasma/5.15 REVISION DETAIL https://phabricator.kde.org/D22482 AFFECTED

D12916: Panel should not stop auto-hiding if a window wants attention

ngraham added a comment. This patch doesn't apply due to some path weirdness: Checking patch plasma-desktop-5.15.5_old/applets/taskmanager/package/contents/ui/main.qml => applets/taskmanager/package/contents/ui/main.qml... error:

D22458: [sddm-theme] Add slot for distro vendors to configure a logo to be shown on the SDDM login screen

cblack updated this revision to Diff 61825. cblack added a comment. More sizing tweaks REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22458?vs=61819=61825 BRANCH distro-logo-slot (branched from master) REVISION DETAIL

D22458: [sddm-theme] Add slot for distro vendors to configure a logo to be shown on the SDDM login screen

ngraham added a comment. Yeah, I woudn't actually mind showing the Plasma logo and text there by default at some point as long as it's small and tasteful. Our branding is pretty weak right now and any improvement there is welcome IMO. But yeah, that's a discussion for later. REPOSITORY

D22468: Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami

ngraham added a comment. For the scale slider, I'd put the numbers underneath, and have threenumbers; one on each end and one in the middle. So if the maximum value was 2x, it would look like this: |---o---| 1x 1.5x2x I'm not sold on the

D22458: [sddm-theme] Add slot for distro vendors to configure a logo to be shown on the SDDM login screen

filipf added a comment. Logo size still looks too big to me; IMO these things shouldn't be too much in the users' face and the logo shouldn't overpower the clock. Also I think the second screenshot doesn't accurately represent new code. You had `units.largeSpacing * 8` before => 8 * 8 =

D22481: Do not show play/pause button when no media is playing

ndavis added a comment. This is how the widget currently looks: F7028324: Screenshot_20190715_150118.png Without the controls or text, it would just be a box, which makes it impossible to know which widget it's supposed to be. REPOSITORY R120

D22481: Do not show play/pause button when no media is playing

davidedmundson added a comment. Why? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22481 To: shubham, broulik, #plasma, #vdg Cc: davidedmundson, #vdg, #plasma, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf,

D22481: Do not show play/pause button when no media is playing

shubham created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. shubham requested review of this revision. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D22481 AFFECTED FILES

D22480: Don't use KPluginInfo if we can use KPluginMetaData

apol created this revision. apol added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY KPluginInfo would force the load of the desktop file for information we don't need. TEST PLAN Plasma

D22210: Fix Name conflict between plasma.desktop and plasmawayland.desktop

asturmlechner added a comment. I'll have to do this downstream, anyway... REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22210 To: asturmlechner, #plasma, davidedmundson Cc: rdieter, fvogt, davidedmundson, plasma-devel, LeGast00n, jraleigh, fbampaloukas,

D22458: [sddm-theme] Add slot for distro vendors to configure a logo to be shown on the SDDM login screen

Codezela added a comment. please don't make this it look not good we can make it more smaller and put it on any corner REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22458 To: cblack, #vdg, #plasma Cc: Codezela, filipf, davidedmundson, broulik,

D22468: Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami

gvarsanyi added inline comments. INLINE COMMENTS > OutputPanel.qml:96 > +to: 3 > +stepSize: 0.2 > +live: true `stepSize` settings confuse me a bit. For perOutput it's 0.2, for global, it's 0.1. I recommend setting both to 0.25 increments. Both

D22458: [sddm-theme] Add slot for distro vendors to configure a logo to be shown on the SDDM login screen

cblack updated this revision to Diff 61819. cblack added a comment. Sizing tweaks REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22458?vs=61814=61819 BRANCH distro-logo-slot (branched from master) REVISION DETAIL

D22458: [sddm-theme] Add slot for distro vendors to configure a logo to be shown on the SDDM login screen

filipf added a comment. I'm testing this out now and there seems to be only one obstacle left, see inline comment INLINE COMMENTS > Main.qml:424 > +fillMode: Image.PreserveAspectFit > +height: units.gridUnit * 8 > +Behavior on opacity { units.gridUnit is

D22458: [sddm-theme] Add slot for distro vendors to configure a logo to be shown on the SDDM login screen

cblack updated this revision to Diff 61814. cblack added a comment. Add sourceSize.width to the party REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22458?vs=61813=61814 BRANCH distro-logo-slot (branched from master) REVISION DETAIL

D22458: [sddm-theme] Add slot for distro vendors to configure a logo to be shown on the SDDM login screen

filipf added inline comments. INLINE COMMENTS > cblack wrote in Main.qml:415 > I don't really have a defined width, but I guess I could define the height You'll notice that in my example I didn't have height defined, but the `sourceSize `code should still work because the `fillMode` magic does

D22458: [sddm-theme] Add slot for distro vendors to configure a logo to be shown on the SDDM login screen

cblack updated this revision to Diff 61813. cblack added a comment. Define sourceSize.height REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22458?vs=61809=61813 BRANCH distro-logo-slot (branched from master) REVISION DETAIL

D22458: [sddm-theme] Add slot for distro vendors to configure a logo to be shown on the SDDM login screen

cblack added inline comments. INLINE COMMENTS > filipf wrote in Main.qml:415 > to the height and width of the item I believe, at least that's what I did > here: https://github.com/KDE/sddm-kcm/blob/master/src/qml/main.qml#L54 I don't really have a defined width, but I guess I could define the

D22458: [sddm-theme] Add slot for distro vendors to configure a logo to be shown on the SDDM login screen

filipf added inline comments. INLINE COMMENTS > cblack wrote in Main.qml:415 > I haven't a clue what I should set `sourceSize` to ¯\_(ツ)_/¯ to the height and width of the item I believe, at least that's what I did here: https://github.com/KDE/sddm-kcm/blob/master/src/qml/main.qml#L54

D22458: [sddm-theme] Add slot for distro vendors to configure a logo to be shown on the SDDM login screen

cblack added inline comments. INLINE COMMENTS > broulik wrote in Main.qml:415 > Also set a `sourceSize` and probably `asynchronous: true` I haven't a clue what I should set `sourceSize` to ¯\_(ツ)_/¯ REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22458 To:

D22458: [sddm-theme] Add slot for distro vendors to configure a logo to be shown on the SDDM login screen

cblack updated this revision to Diff 61809. cblack added a comment. Rename config file properties to not say "distro" Use gridunit Use opacityanimator REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22458?vs=61774=61809 BRANCH

D22452: Fix text color in non-selected tabs in Firefox

ndavis added a comment. The latest version of this patch is better because it works well for people using the Breeze GTK theme with the Breeze colorscheme and it doesn't make the Breeze Dark GTK theme worse when combined with the Breeze Dark colorscheme. However, it does cause Breeze GTK to

D22458: [sddm-theme] Add slot for distro vendors to configure a logo to be shown on the SDDM login screen

cblack added inline comments. INLINE COMMENTS > broulik wrote in Main.qml:414 > Why not just a bool? the config object exposes `true` as `"true"`, not `true`, so ¯\_(ツ)_/¯ REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22458 To: cblack, #vdg, #plasma Cc:

D22467: Make captive portal notification persistent but low priority

This revision was automatically updated to reflect the committed changes. Closed by commit R116:87fa14955632: Make captive portal notification persistent but low priority (authored by ngraham). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE

D22468: Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami

broulik added a comment. In D22468#495897 , @romangg wrote: > Ha, you're totally right. Amazing! Is this something to fix in Plasma frameworks? Breeze kstyle. I bet the issue is that handlers don't accept the events and/or process them

D22468: Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami

romangg added a comment. In D22468#495791 , @davidedmundson wrote: > > On Wayland everything works fine. Might be a Qt bug in input handlers directly and not the code here. Other ideas? > > It'll be our code. Try running with --style=fusion

D22429: Make "Updates Available" notification persistent but low priority

ngraham added a comment. In D22429#495652 , @broulik wrote: > Oh God, please not make it persistent. This notification comes up every single time I start plasmashell and now I have to explicitly manually get rid of it. That's kind of

D22452: Fix text color in non-selected tabs in Firefox

ngraham added a comment. In D22452#495666 , @mthw wrote: > In D22452#495325 , @ngraham wrote: > > > Whether or not it's better is not relevant for this patch, which right now is only about fixing

D22458: [sddm-theme] Add slot for distro vendors to configure a logo to be shown on the SDDM login screen

davidedmundson added a comment. Idea makes sense. lets drop the word "distro" and then we can use it for corporation/city/whatever logos INLINE COMMENTS > Main.qml:423 > +Behavior on opacity { > +NumberAnimation { > +duration:

Meeting week 29 notes

kbroulik: - Not much to report, busy with company stuff romangg: - https://phabricator.kde.org/D22468 - This week KDE connect and next week KWin sprint nicofee: Done: - Re-write plasma-settings (death to ugly code! 145 additions, 1474 deletions) - Ported few mobile KCM to ConfigModule/SimpleKCM

D22445: WIP: Open from cache / Open Normally

sitter added a comment. I would break the problem apart: pretend you only have one cached report. By wanting to deal with multiple reports at once I imagine you are making this more complicated than it is. With a single report you have two discrete input source options: live and

D22453: [Applet] Use the more user-friendly term "recording" instead of "capture"

broulik added a comment. +1 REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D22453 To: ngraham, #plasma, #vdg, drosca Cc: broulik, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed,

D22458: [sddm-theme] Add slot for distro vendors to configure a logo to be shown on the SDDM login screen

broulik added inline comments. INLINE COMMENTS > Main.qml:414 > +id: logo > +visible: config.showdistrologo == "shown" > +source: config.distrologo Why not just a bool? > Main.qml:415 > +visible: config.showdistrologo == "shown" > +

D22468: Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami

davidedmundson added a comment. > On Wayland everything works fine. Might be a Qt bug in input handlers directly and not the code here. Other ideas? It'll be our code. Try running with --style=fusion and see if the problem magically goes away. If so, it'll be us not accepting the

D22468: Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami

romangg added a comment. On X11 I had problems moving the outputs in the overview. For some reason the click was not caught by the ui but KWin tries to move the whole window instead. On Wayland everything works fine. Might be a Qt bug in input handlers directly and not the code here. Other

D22000: [colors/Breeze] Change selected text color to black

ndavis abandoned this revision. ndavis added a comment. Abandoning because it can negatively affect other widget styles. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D22000 To: ndavis, #vdg, #breeze, #plasma, ngraham Cc: filipf, IlyaBizyaev, ngraham, cfeck, zzag,

D22034: Introduce ContainmentLayoutManager QML plugin

mart updated this revision to Diff 61786. mart added a comment. - never auto resize while on edit mode - try to restore size as soon as possible REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22034?vs=61642=61786 BRANCH

D12916: Panel should not stop auto-hiding if a window wants attention

michaelmoon updated this revision to Diff 61785. michaelmoon edited the summary of this revision. michaelmoon edited the test plan for this revision. michaelmoon changed the repository for this revision from R120 Plasma Workspace to R119 Plasma Desktop. michaelmoon added a comment. Add an

D22468: Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami

filipf added a comment. In D22468#495727 , @filipf wrote: > Yeah I may have improvised that with the Night Color KCM  > > The HIG way (and looking at other places) is to put the

D22468: Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami

romangg added inline comments. INLINE COMMENTS > broulik wrote in OutputPanel.qml:41 > `i18n` and everywhere else > i18n and everywhere else I saw in other KCMs the Kirigami label being set without the i18n macro and I hoped Kirigami would do this internally. But apparently not, so I will add

D22468: Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami

filipf added a comment. Yeah I may have improvised that with the Night Color KCM  The HIG way (and looking at other places) is to put the value to the right of the slider. In D22468#495721

D22468: Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami

mvourlakos added a subscriber: ngraham. mvourlakos added a comment. In D22468#495723 , @romangg wrote: > In D22468#495719 , @mvourlakos wrote: > > > This looks really nice, > > > > one question,

D22468: Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami

romangg added a comment. In D22468#495719 , @mvourlakos wrote: > This looks really nice, > > one question, having current values under the Slider does it follow a HIG rule or is it a proposition? I copied this style from Night Color

D22468: Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami

romangg added a comment. In D22468#495679 , @filipf wrote: > Looks better, in particular I like the approach with buttons for orientation because it saves the second or two of having to remember what's clockwise or counter-clockwise. > >

D22468: Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami

mvourlakos added a comment. This looks really nice, one question, having current values under the Slider does it follow a HIG rule or is it a proposition? REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D22468 To: romangg, #plasma, #kwin Cc: mvourlakos,

D22468: Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami

romangg added a comment. In D22468#495713 , @knambiar wrote: > The `Scale` slider UI position is different in X11 and Wayland. Is this intentional? Yea, on Wayland we can set the scale for each output individually. On X11 there is only

D22468: Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami

knambiar added a comment. The `Scale` slider UI position is different in X11 and Wayland. Is this intentional? REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D22468 To: romangg, #plasma, #kwin Cc: knambiar, broulik, filipf, plasma-devel, LeGast00n, jraleigh,

D22468: Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami

broulik added a comment. Pretty cool! INLINE COMMENTS > kcm.cpp:48 > +qmlRegisterType(); > +qmlRegisterType("org.kde.kscreen", 1, 0, > "KScreenOutput"); > + Given this is for the KCM only, I would suggest to name the import `org.kde.private.kcm.kscreen` > output_model.cpp:45 > +

D22468: Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami

filipf added a comment. Looks better, in particular I like the approach with buttons for orientation because it saves the second or two of having to remember what's clockwise or counter-clockwise. Only some minor things I noticed in the screenshots: - can the margins on the view

D22452: Fix text color in non-selected tabs in Firefox

mthw added a comment. In D22452#495325 , @ngraham wrote: > Whether or not it's better is not relevant for this patch, which right now is only about fixing the text color. It's best not to mix multiple changes like this, unless you want to

D22429: Make "Updates Available" notification persistent but low priority

broulik added a comment. Oh God, please not make it persistent. This notification comes up every single time I start plasmashell and now I have to explicitly manually get rid of it. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D22429 To: ngraham,

D22457: Make it possible to show the QR of a network connection

broulik added inline comments. INLINE COMMENTS > ShowQR.qml:25 > +import org.kde.kirigami 2.3 as Kirigami > +import org.kde.prison 1.0 as Prison > + Add this as `RUNTIME` Cmake dependency > ShowQR.qml:27 > + > +Window > +{ Can you instad do a `StackView` and show the barcode inside the applet

D21905: [Digital Clock] Open KOrganizer with event details on click

broulik added a comment. > this should not be merged until Plasma master can depend on KF5 5.61 Or you do a check of `enabled: typeof monthView.daysModel.showEventDetails === "function"` REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D21905 To: