D21860: Set a font for gtk applications in the fonts kcm

gikari added inline comments. INLINE COMMENTS > broulik wrote in fonts.cpp:607 > Are you sure `parent` is a `QGuiApplication`? I don't think so. Perhaps you > want to connect to `QGuiApplication::instance()` instead. Just tested. It works. So the plan is to remove explicit call from the font

D5961: PoC: Generic adoption of KUserFeedback for Discover

apol updated this revision to Diff 66273. apol added a comment. Remove the dialog and read the settings globally for Plasma. Moved the feedback settings to the About page. REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5961?vs=65968=66273

D24011: Provide a telemetrics kcm module for Plasma

apol created this revision. apol added reviewers: Plasma, vkrause. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY It offers 2 main features: - Configure the system-wide KUserFeedback kill-switch - Provide

D23798: Polish Displays KCM UI

ndavis added a comment. The orientation toolbuttons seem oversized. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D23798 To: ngraham, romangg, #vdg, #kwin Cc: filipf, ndavis, GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen,

D23798: Polish Displays KCM UI

ngraham added a comment. Need a hand with the `TODO:` in main.qml. Otherwise, this is ready for re-review, @romangg and #vdg REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D23798 To: ngraham, romangg, #vdg, #kwin Cc: filipf,

D23798: Polish Displays KCM UI

ngraham updated this revision to Diff 66269. ngraham added a comment. - Reduce height of screen visualizations - Conditionalize height of kcmshell window - Harmonize paddings REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23798?vs=66267=66269 BRANCH

D24009: RFC: Make Breeze Dark darker

cblack added a comment. Looks like an improvement to me. +1 REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D24009 To: filipf, cblack, ndavis, #vdg, ngraham, #plasma Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot,

D24009: RFC: Make Breeze Dark darker

filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY Discussions in #VDG and in Phabricator tasks have been hinting at the conclusion that our

D24005: Show a new version string description for updates where the old and new versions are identical

apol added a comment. Having 3 identical labels with slightly different conditions feels odd, maybe we should just take it into account if when assigning the property? REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D24005 To: ngraham, #vdg,

D23798: Polish Displays KCM UI

ngraham updated this revision to Diff 66267. ngraham added a comment. Fix FormLayout alignment REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23798?vs=66266=66267 BRANCH clean-up-ui (branched from master) REVISION DETAIL

D23798: Polish Displays KCM UI

ngraham updated this revision to Diff 66266. ngraham marked 3 inline comments as done. ngraham added a comment. Fix the model count binding in main.qml REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23798?vs=66265=66266 BRANCH clean-up-ui (branched from

D24008: Make renderDialGroove() area match the maximum renderDialContents() area

ndavis added a comment. In D24008#532936 , @ngraham wrote: > Doesn't this mean that the visual appearance of the dial will change depending on what the maximum value is? No, you can apply this patch and apply whatever maximum value you

D23257: Allow for easier syncing of Plasma font

filipf added a comment. So the SDDM patch has been merged, but I don't know when the next SDDM release will be. I would keep this on hold until this happens, just to be safe... does that make sense? REPOSITORY R123 SDDM Configuration Panel (KCM) BRANCH easier-font-syncing (branched

KDE CI: Plasma » drkonqi » kf5-qt5 WindowsMSVCQt5.13 - Build # 10 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.13/10/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Mon, 16 Sep 2019 20:52:29 + Build duration: 3 min 12 sec and counting CONSOLE OUTPUT

D24008: Make renderDialGroove() area match the maximum renderDialContents() area

ngraham added a comment. Doesn't this mean that the visual appearance of the dial will change depending on what the maximum value is? REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D24008 To: ndavis, #vdg, #breeze Cc: ngraham, plasma-devel, LeGast00n,

D21815: [sddm-theme] Start moving from QQC1 to QQC2

ndavis added a comment. > F7256235: image.png Is this screenshot outdated? Why does the selected item extend outside the width of the list? REPOSITORY R120 Plasma Workspace BRANCH arcpatch-D21815 REVISION DETAIL

D23798: Polish Displays KCM UI

ngraham updated this revision to Diff 66265. ngraham marked an inline comment as done. ngraham added a comment. Remove unneeded accessor and use `kcm.outputModel.rowCount()` instead REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23798?vs=65779=66265

D21815: [sddm-theme] Start moving from QQC1 to QQC2

cblack added a comment. @davidedmundson any objections? REPOSITORY R120 Plasma Workspace BRANCH arcpatch-D21815 REVISION DETAIL https://phabricator.kde.org/D21815 To: cblack, #plasma, #vdg, davidedmundson, filipf Cc: GB_2, ngraham, filipf, davidedmundson, plasma-devel, LeGast00n,

D23798: Polish Displays KCM UI

filipf added a comment. What I'm seeing in the screenshot is that the two form layouts aren't aligned. Can you interlink them with `twinFormLayouts`? REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D23798 To: ngraham, romangg, #vdg, #kwin Cc: filipf, ndavis, GB_2,

D24008: Make renderDialGroove() area match the maximum renderDialContents() area

ndavis created this revision. ndavis added reviewers: VDG, Breeze. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ndavis requested review of this revision. REVISION SUMMARY It bothered me that the groove for dials doesn't match the maximum area that the contents can

D23798: Polish Displays KCM UI

romangg added a comment. Reducing the screen area height makes it difficult to place outputs on top of each other. Making it a bit smaller is fine (and improving the logic of how much this it in comparison to overall kcm size) but I think this is too much. Alternatively the size of the

D21815: [sddm-theme] Start moving from QQC1 to QQC2

filipf added a comment. Yo @cblack I think you can land this. REPOSITORY R120 Plasma Workspace BRANCH arcpatch-D21815 REVISION DETAIL https://phabricator.kde.org/D21815 To: cblack, #plasma, #vdg, davidedmundson, filipf Cc: GB_2, ngraham, filipf, davidedmundson, plasma-devel,

D24007: [QQC2 Desktop Style] Port away from deprecated methods in Qt 5.14

dfaure closed this revision. REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D24007 To: dfaure, mart, davidedmundson Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai,

D23718: WIP: Beginning of the Baloo/Search KCM Rewrite

ngraham added a comment. FWIW, it would be good to fix some of the bugs listed here as part of the port: https://bugs.kde.org/buglist.cgi?component=kcm_baloo_id=1663634=systemsettings=--- REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D23718 To: tcanabrava,

KDE CI: Plasma » drkonqi » kf5-qt5 WindowsMSVCQt5.13 - Build # 9 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.13/9/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Mon, 16 Sep 2019 20:02:14 + Build duration: 6 min 12 sec and counting CONSOLE OUTPUT

D23718: WIP: Beginning of the Baloo/Search KCM Rewrite

ngraham added a comment. Getting there! Use an actual framed list view for the list of folders to not index, like the current one has. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D23718 To: tcanabrava, #plasma Cc: mart, ngraham, plasma-devel,

D24007: [QQC2 Desktop Style] Port away from deprecated methods in Qt 5.14

dfaure created this revision. dfaure added a reviewer: mart. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. dfaure requested review of this revision. REPOSITORY R858 Qt Quick Controls 2: Desktop Style BRANCH master REVISION DETAIL

D11410: [RFC] Add option to make applet fixed width

Pitel updated this revision to Diff 66260. Pitel added a comment. Reabse & polish UI REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11410?vs=31036=66260 BRANCH fixedSizeOverride2 REVISION DETAIL https://phabricator.kde.org/D11410 AFFECTED

D23897: Port mobile_wifi kcm to newer APIs

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R116:4ca3d7aa14c7: Port mobile_wifi kcm to newer APIs (authored by jbbgameich). REPOSITORY R116 Plasma Network

D23718: WIP: Beginning of the Baloo/Search KCM Rewrite

tcanabrava updated this revision to Diff 66258. tcanabrava added a comment. - Fix metadata installation - Fix model loading on Qml - Base work on the Qml - Name fixes - Move ui/main to contents - Fix wrong types in Qml - Plug the controllers - Link to the save button REPOSITORY

D23897: Port mobile_wifi kcm to newer APIs

nicolasfella accepted this revision. nicolasfella added a comment. Looks good to me. Jan agreed that we can land patches to the mobile stuff without his approval REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D23897 To: jbbgameich,

D24005: Show a new version string description for updates where the old and new versions are identical

ngraham created this revision. ngraham added reviewers: VDG, Discover Software Store, apol. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY This is common for Flatpak runtime updates, where it seems weird to

D24001: [Icons-Only Task Manager] Only show progress indicator for apps that are running

ngraham updated this revision to Diff 66253. ngraham added a comment. Check for `task.isWindow` instead REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24001?vs=66249=66253 BRANCH dont-show-progress-indicator-for-non-running-apps (branched from

D24001: [Icons-Only Task Manager] Only show progress indicator for apps that are running

ngraham added a comment. Yeah I was looking for something simple like `task.isRunning` but had to settle for checking for a pid in the absence of anything like that. If there's a better way to query for whether or not it's open, I'm all ears. REPOSITORY R119 Plasma Desktop REVISION

D23984: Redesign intro page

This revision was automatically updated to reflect the committed changes. Closed by commit R124:9af5acd5aaa7: Redesign intro page (authored by tienisto, committed by ngraham). REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23984?vs=66251=66252

D23984: [System Settings] redesign intro page

tienisto updated this revision to Diff 66251. tienisto added a comment. use Kirigami units for vertical margin REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23984?vs=66250=66251 BRANCH master REVISION DETAIL

D24001: [Icons-Only Task Manager] Only show progress indicator for apps that are running

broulik added a comment. Technically, it could be updated by a background service but I guess this is more likely got badges. +1 You might want to check for isWindow or something instead? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24001 To: ngraham,

D23984: [System Settings] redesign intro page

ngraham added inline comments. INLINE COMMENTS > introPage.qml:28 > color: Kirigami.Theme.backgroundColor > +property int verticalMargin: 50 > How about `Kirigami.Units.gridUnit * 3` instead? REPOSITORY R124 System Settings BRANCH master REVISION DETAIL

D23984: [System Settings] redesign intro page

tienisto updated this revision to Diff 66250. tienisto added a comment. change "Frequently used:" to "Frequently Used" REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23984?vs=66246=66250 BRANCH master REVISION DETAIL

D24001: [Icons-Only Task Manager] Only show progress indicator for apps that are running

ngraham created this revision. ngraham added reviewers: VDG, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Currently, Pinned Icons-Only Task Manager launchers are capable of showing progress

D23984: [System Settings] redesign intro page

GB_2 added inline comments. INLINE COMMENTS > introPage.qml:92 > wrapMode: Text.NoWrap > text: i18n("Frequently used:") > } Maybe change to "Frequently Used", so it's a header? REPOSITORY R124 System Settings BRANCH master REVISION DETAIL

D23897: Port mobile_wifi kcm to newer APIs

jbbgameich added a comment. ping REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D23897 To: jbbgameich, jgrulich, nicolasfella, #plasma:_mobile Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel,

D23520: Add time line to X axis

This revision was automatically updated to reflect the committed changes. Closed by commit R102:1c7f121073a7: Add time line to X axis (authored by alexde, committed by ngraham). REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23520?vs=66063=66248 REVISION

D23984: [System Settings] redesign intro page

tienisto added a comment. What do other people think about the light rectangle around the "frequently used" icons? Because I am in favor of this :) REPOSITORY R124 System Settings BRANCH master REVISION DETAIL https://phabricator.kde.org/D23984 To: tienisto, #vdg, GB_2, ngraham

D23984: [System Settings] redesign intro page

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. LGTM. Everyone else fine with this? REPOSITORY R124 System Settings BRANCH master REVISION DETAIL https://phabricator.kde.org/D23984 To: tienisto, #vdg, GB_2, ngraham Cc: filipf,

D23984: [System Settings] redesign intro page

tienisto updated this revision to Diff 66246. tienisto added a comment. use rounding again and delete unused id REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23984?vs=66245=66246 BRANCH master REVISION DETAIL

D23984: [System Settings] redesign intro page

ngraham added inline comments. INLINE COMMENTS > introPage.qml:85 > } > -width: Math.round(parent.width * 0.8) > +width: parent.width * 0.8 > + Why change this? Rounding generally fixes the problem of blurriness with fractional scaling due to non-integer pixels. >

D23984: [System Settings] redesign intro page

tienisto updated this revision to Diff 66245. tienisto added a comment. move Kirigami.Heading inside ColumnLayout REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23984?vs=66244=66245 BRANCH master REVISION DETAIL

D23984: [System Settings] redesign intro page

ngraham added a comment. TBH I kind of liked the rectangle too. REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D23984 To: tienisto, #vdg, GB_2, ngraham Cc: filipf, anthonyfieroni, davidedmundson, mart, Codezela, plasma-devel, LeGast00n, The-Feren-OS-Dev,

D23984: [System Settings] redesign intro page

tienisto added a comment. In D23984#532719 , @GB_2 wrote: > What about a design like this? F7363944: System Settings Intro Page Mockup.png I actually like the light rectangle more because it

D23984: [System Settings] redesign intro page

ngraham added inline comments. INLINE COMMENTS > introPage.qml:78 > } > -Kirigami.Separator { > -id: separator > -anchors.centerIn: parent > -width: Math.round(parent.width * 0.8) > +Kirigami.Heading { > +id: frequentlyUsed Why move this heading out

D23984: [System Settings] redesign intro page

tienisto updated this revision to Diff 66244. tienisto added a comment. Remove light rectangle; add Plasma icon; more Kirigami units REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23984?vs=66205=66244 BRANCH master REVISION DETAIL

D23389: Use visible buttons to switch the default device

This revision was automatically updated to reflect the committed changes. Closed by commit R115:4a13cbf391b4: Use visible buttons to switch the default device (authored by ngraham). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE

D23389: Use visible buttons to switch the default device

ngraham added a comment. Since it seems that there are no formal objections or change requests, I will land this in time for the 5.17 beta. REPOSITORY R115 Plasma Audio Volume Applet BRANCH arcpatch-D23389 REVISION DETAIL https://phabricator.kde.org/D23389 To: ngraham, drosca,

D23984: [System Settings] redesign intro page

GB_2 added a comment. As you can see in my design, I'd not add a rectangle in the backround, it looks weird to me and less clean than before. REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D23984 To: tienisto, #vdg, GB_2, ngraham Cc: filipf, anthonyfieroni,

D23984: [System Settings] redesign intro page

ngraham added a comment. Always good to add the plasma logo in more Plasma places, so I do like that part. REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D23984 To: tienisto, #vdg, GB_2, ngraham Cc: filipf, anthonyfieroni, davidedmundson, mart, Codezela,

D23984: [System Settings] redesign intro page

GB_2 added a comment. What about a design like this? F7363944: System Settings Intro Page Mockup.png REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D23984 To: tienisto, #vdg, GB_2, ngraham Cc: filipf, anthonyfieroni,

D23950: Only show "Add Widgets..." panel context menu option in panel edit mode

ngraham added a comment. In my mind, "locked" should be a semi-hidden state really only used by admins for locking down a machine's panel and widget configuration. The only reason why I currently use Locked mode is to get rid of the visible configure button in the panel. If it was hidden by

D23952: Remove panel toolbox and clean up editing options

ngraham added a comment. I agree that we can't only have this UI be in a context menu, and we need to expose it somewhere visible too (i.e. in System Settings like we discussed at the Plasma + Usability & Productivity sprint. I kind of like not showing the configure button in the panel

D11352: [RFC] Auto ordered systray

ngraham added a comment. Cool, will do! REPOSITORY R120 Plasma Workspace BRANCH stableSystray2 REVISION DETAIL https://phabricator.kde.org/D11352 To: Pitel, #vdg, #plasma, mart, ngraham Cc: ognarb, ngraham, wsdfhjxc, mart, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh,

D11352: [RFC] Auto ordered systray

mart added a comment. ok for me at beginning of 5.18 cycle, not yet for 5.17 REPOSITORY R120 Plasma Workspace BRANCH stableSystray2 REVISION DETAIL https://phabricator.kde.org/D11352 To: Pitel, #vdg, #plasma, mart, ngraham Cc: ognarb, ngraham, wsdfhjxc, mart, plasma-devel, LeGast00n,

D23997: Add document-share* icons

This revision was automatically updated to reflect the committed changes. Closed by commit R856:abb875246a30: Add document-share* icons (authored by ndavis). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23997?vs=66238=66239 REVISION

D11352: [RFC] Auto ordered systray

ngraham accepted this revision. ngraham added a comment. This seems sensible enough to me. @mart, do you think we can do this for 5.17, or should we wait until 5.18? REPOSITORY R120 Plasma Workspace BRANCH stableSystray2 REVISION DETAIL https://phabricator.kde.org/D11352 To: Pitel,

D23997: Add document-share* icons

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Lovely! REPOSITORY R856 Plasma Browser Integration BRANCH document-share (branched from master) REVISION DETAIL https://phabricator.kde.org/D23997 To: ndavis, broulik Cc:

D23984: [System Settings] redesign intro page

ngraham added a comment. +1, nice visual improvement. Needs a bit of code polishing first before it can land though. See inline comments: INLINE COMMENTS > introPage.qml:31 > +property int iconsRectRadius: 10 > > signal focusNextRequest() Don't hardcode values here; instead use

D23997: Add document-share* icons

ndavis created this revision. ndavis added a reviewer: broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ndavis requested review of this revision. REVISION SUMMARY BUG: 410840 REPOSITORY R856 Plasma Browser Integration BRANCH document-share (branched from

D23151: Implement Web Share API through Purpose

broulik updated this revision to Diff 66236. REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23151?vs=65650=66236 REVISION DETAIL https://phabricator.kde.org/D23151 AFFECTED FILES CMakeLists.txt extension/_locales/en/messages.json

D23996: Port away from deprecated KIO::suggestName

nicolasfella created this revision. nicolasfella added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. REVISION SUMMARY KFileUtils::suggestName() is a drop-in replacement, just moved to another library

D23868: [kfontinst] Port to use icons from the icon theme and make HiDPI aware

This revision was automatically updated to reflect the committed changes. Closed by commit R119:21d962fe33c8: [kfontinst] Port to use icons from the icon theme and make HiDPI aware (authored by Guo Yunhe i...@guoyunhe.me). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D23868: [kfontinst] Port to use icons from the icon theme and make HiDPI aware

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. LGTM! REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D23868 To: guoyunhe, #plasma, ngraham Cc: ngraham, plasma-devel, LeGast00n,

D23845: Add a mode to center actions and omit the title when using a ToolBar style

This revision was automatically updated to reflect the committed changes. Closed by commit R169:872cfbcbd7cf: Add a mode to center actions and omit the title when using a ToolBar style (authored by ngraham). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE

D23868: [kfontinst] Port to use icons from the icon theme and make HiDPI aware

guoyunhe updated this revision to Diff 66229. guoyunhe added a comment. Rename and move the find duplicate button REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23868?vs=66193=66229 BRANCH master REVISION DETAIL

D23868: [kfontinst] Port to use icons from the icon theme and make HiDPI aware

ngraham added a comment. Rename Scan Duplicates... to Find Duplicates... and move the button to the left of Install from File... and then I think this will be good. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D23868 To: guoyunhe, #plasma, ngraham Cc:

D23980: [Folder View] Don't explicitly initialize fontMetrics

ngraham accepted this revision. ngraham added a comment. Oh boy, wow. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D23980 To: broulik, #plasma, hein, apol, ngraham Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2,

5.17 beta announce

First draft of announce is up, improvements welcome http://apps.kde.org.uk/announcements/plasma-5.16.90.php Jonathan

D21860: Set a font for gtk applications in the fonts kcm

broulik added inline comments. INLINE COMMENTS > gikari wrote in fonts.cpp:607 > So, I wrote this: > > GtkConfig::GtkConfig(QObject *parent, const QVariantList&) : > KDEDModule(parent), configEditor {new ConfigEditor()} > { > qDebug() << "Parent: " << parent; >

D23727: Provide a simple test tool to see what autostart will look like

This revision was automatically updated to reflect the committed changes. Closed by commit R120:e7cc46fad0c2: Provide a simple test tool to see what autostart will look like (authored by apol). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D23727?vs=65441=66224#toc REPOSITORY R120

D23845: Add a mode to center actions and omit the title when using a ToolBar style

ngraham added a comment. In D23845#532373 , @mart wrote: > One thing i forgot: how does this look when a title is present? It doesn't; `titleLoader` doesn't load the title when using centered alignment. REPOSITORY R169 Kirigami

KDE CI: Plasma » plasma-workspace » kf5-qt5 SUSEQt5.12 - Build # 391 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20SUSEQt5.12/391/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 16 Sep 2019 13:04:37 + Build duration: 11 min and counting BUILD ARTIFACTS

D23849: Do not allow the greeter to send the same password multiple times (Fix GPG smart card access)

zzag added a comment. @jfranklin Ping me if you don't get any feedback in a day or two. REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D23849 To: jfranklin, #kwin, #plasma, zzag Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2,

D23849: Do not allow the greeter to send the same password multiple times (Fix GPG smart card access)

zzag added a comment. This change looks good to me, however I know only general bits of KScreenLocker. Perhaps someone else from #KWin or #Plasma could review this patch. REPOSITORY R133 KScreenLocker

KDE CI: Plasma » plasma-workspace » kf5-qt5 FreeBSDQt5.13 - Build # 129 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20FreeBSDQt5.13/129/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 16 Sep 2019 13:04:48 + Build duration: 4 min 57 sec and counting JUnit Tests Name:

D23849: Do not allow the greeter to send the same password multiple times (Fix GPG smart card access)

jfranklin added a comment. Friendly ping concerning this issue. Has anyone related to the screen locker project had some time to take a quick look at this? REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D23849 To: jfranklin, #kwin, #plasma, zzag Cc:

KDE CI: Plasma » plasma-workspace » kf5-qt5 FreeBSDQt5.13 - Build # 128 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20FreeBSDQt5.13/128/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 16 Sep 2019 12:55:44 + Build duration: 4 min 26 sec and counting CONSOLE OUTPUT

KDE CI: Plasma » plasma-workspace » kf5-qt5 FreeBSDQt5.13 - Build # 127 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20FreeBSDQt5.13/127/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 16 Sep 2019 12:26:47 + Build duration: 28 min and counting CONSOLE OUTPUT

KDE CI: Plasma » plasma-workspace » kf5-qt5 SUSEQt5.12 - Build # 390 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20SUSEQt5.12/390/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 16 Sep 2019 12:40:02 + Build duration: 4 min 27 sec and counting CONSOLE OUTPUT

KDE CI: Plasma » plasma-workspace » kf5-qt5 SUSEQt5.12 - Build # 389 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20SUSEQt5.12/389/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 16 Sep 2019 12:26:47 + Build duration: 1 min 10 sec and counting CONSOLE OUTPUT

D23982: [Notifications] Kill job after 2 seconds if application doesn't react to cancel request

This revision was automatically updated to reflect the committed changes. Closed by commit R120:49519b7a0691: [Notifications] Kill job after 2 seconds if application doesnt react to cancel… (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

[plasma-desktop] /: applets/kicker: remove the plugin

Git commit 84c8dade3ce0c9cad9da26b083c954655266c639 by Bhushan Shah. Committed on 16/09/2019 at 12:22. Pushed by bshah into branch 'master'. applets/kicker: remove the plugin plugin is now part of plasma-workspace, so other launcher can easily re-use models. CCMAIL: h...@kde.org CCMAIL:

KDE CI: Plasma » plasma-workspace » kf5-qt5 FreeBSDQt5.13 - Build # 126 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20FreeBSDQt5.13/126/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 16 Sep 2019 12:14:12 + Build duration: 8 min 49 sec and counting CONSOLE OUTPUT

D11352: [RFC] Auto ordered systray

Pitel updated this revision to Diff 66209. Pitel added a comment. Rebase on current master and squash REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11352?vs=30859=66209 BRANCH stableSystray2 REVISION DETAIL

D22762: Take in consideration flat() for the All Applications menu

This revision was not accepted when it landed; it landed in state "Needs Revision". This revision was automatically updated to reflect the committed changes. Closed by commit R120:b159222aa558: Take in consideration flat() for the All Applications menu (authored by tcanabrava). CHANGED PRIOR TO

KDE CI: Plasma » plasma-workspace » kf5-qt5 SUSEQt5.12 - Build # 388 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20SUSEQt5.12/388/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 16 Sep 2019 12:14:12 + Build duration: 4 min 31 sec and counting CONSOLE OUTPUT

D23984: [System Settings] redesign intro page

tienisto marked 4 inline comments as done. tienisto added a comment. Okay. Now I am using more Kirigami units now. About "KDE Plasma" vs "Plasma" I am not sure because Plasma is less known than KDE. Regarding the round corners, I have decreased the radius a little bit. Hope it is better

D6813: Use customized font size for Digital Clock applet

guoyunhe abandoned this revision. guoyunhe added a comment. It seems not possible to set font size because others insist the font size should grow with panel. Another alternative widget might be better way to push forward. REPOSITORY R120 Plasma Workspace REVISION DETAIL

D23984: [System Settings] redesign intro page

tienisto updated this revision to Diff 66205. tienisto added a comment. less rounded corners and decrease use of hard coded numbers REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23984?vs=66201=66205 BRANCH master REVISION DETAIL

D17704: Copy to clipboard always copy English texts

guoyunhe added a comment. Yes, this can be closed because another approach is more useful. REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D17704 To: guoyunhe, #plasma, davidedmundson Cc: davidedmundson, ngraham, gregormi, cfeck, plasma-devel, LeGast00n,

D23984: [System Settings] redesign intro page

filipf added a comment. +1 for redesigning the page a bit. What I really dislike about it right now is that there is no hover effect for the icons. Regarding the changes here, I'm unsure about the rounded rectangle. Doesn't seem like it fits with design everywhere else. Will

D23941: Compensate smaller icon sizes on mobile in the ActionButton

This revision was automatically updated to reflect the committed changes. Closed by commit R169:eb364c963630: Compensate smaller icon sizes on mobile in the ActionButton (authored by jbbgameich). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE

D23984: [System Settings] redesign intro page

tienisto marked 3 inline comments as done. tienisto added a comment. Thanks for your feedback. I was actually lighten the background instead of darken it :) But still, Qt.darker/Qt.lighter is much simpler! REPOSITORY R124 System Settings REVISION DETAIL

  1   2   >