D24181: Changing "Paste Without Formatting" in Notes applet to "Paste"

broulik added a comment. In D24181#536785 , @ltoscano wrote: > Out of curiosity: doesn't usually the default Paste action (ctrl-V) paste with formatting? Shouldn't the shortcut be changed instead? Yeah, normally Ctrl+Shift+V pastes withou

D24181: Changing "Paste Without Formatting" in Notes applet to "Paste"

ltoscano added a comment. Out of curiosity: doesn't usually the default Paste action (ctrl-V) paste with formatting? Shouldn't the shortcut be changed instead? REPOSITORY R114 Plasma Addons BRANCH notes-applet-tuning (branched from master) REVISION DETAIL https://phabricator.kde.org/D

D24178: Add ability to cycle through sources in mediacontroller applet

ngraham added reviewers: broulik, Plasma. ngraham added a comment. +1 for the desired end goal, but I have some implementation concerns: INLINE COMMENTS > ExpandedRepresentation.qml:121 > seekSlider.moved(); > +} else if (event.key === Qt.Key_W) { > +

D24181: Changing "Paste Without Formatting" in Notes applet to "Paste"

yerilov added a comment. Thanks Nate :) Actually it's rational to change `documentHandler.pasteWithoutFormatting()` handler as well, but I'm afraid I'm not good at coding to make such amendments. REPOSITORY R114 Plasma Addons BRANCH notes-applet-tuning (branched from master) REVISION

D24181: Changing "Paste Without Formatting" in Notes applet to "Paste"

ngraham added subscribers: Localization, aacid, ltoscano, yurchor. ngraham added a comment. Thanks for the patch! May it be the first of many. :) #localization team, I'd like to request a string freeze exception and land this on the `Plasma/

D24181: Changing "Paste Without Formatting" in Notes applet to "Paste"

yerilov created this revision. yerilov added a reviewer: ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. yerilov requested review of this revision. REVISION SUMMARY Since this action is the default for Ctrl+V shortcut it should be named just "Paste". Hence the

D24110: Enable removing multiple devices at once

ngraham accepted this revision. ngraham added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > devices.cpp:209 > > void KCMBlueDevilDevices::removeDevice() > +{ You could rename this function to `removeSelectedDevices()` and handle both single and multi-sel

D24127: Fix toggle button colours

ndavis added a comment. In D24127#536672 , @ngraham wrote: > @cblack if we're going to use this patch to do that, then the same treatment needs to be done for other buttonlike controls like comboboxes (with and without text entry), font buttons,

D24178: Add ability to cycle through sources in mediacontroller applet

dylanmcdougall created this revision. dylanmcdougall added a project: Plasma. dylanmcdougall requested review of this revision. REVISION SUMMARY FEATURE: 412260 REPOSITORY R120 Plasma Workspace BRANCH walk_through_media (branched from master) REVISION DETAIL https://phabricator.kde.org/

D24177: Add ability to cycle through sources in mediacontroller applet

dylanmcdougall created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. dylanmcdougall requested review of this revision. REPOSITORY R120 Plasma Workspace BRANCH walk_through_media (branched from master) REVISION DETAIL https://phabricator.kde.org/D24

D24127: Fix toggle button colours

ngraham added a comment. @cblack if we're going to use this patch to do that, then the same treatment needs to be done for other buttonlike controls like comboboxes (with and without text entry), font buttons, file picker buttons, etc. Also I feel like maybe the border thickness of the highl

D24127: Fix toggle button colours

cblack updated this revision to Diff 66712. cblack added a comment. Substitute border decoration for fill decoration REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24127?vs=66574&id=66712 BRANCH fix-toggle-state (branched from master) REVISION DET

D24146: Bug 410988, Button 'C' now does the same as 'AC'.

maximma updated this revision to Diff 66694. maximma added a comment. Fixed display of numbersА REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24146?vs=66625&id=66694 BRANCH calculatorApplet (branched from master) REVISION DETAIL https://phabric

D24165: Add SettingsUtil utility class

ognarb added a comment. +1 but I couldn't test it (changed my distro recently and can't get pbi to work yet). The js class is available in firefox since Firefox 45 https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Classes#Browser_compatibility so it should work in firefo

D24165: Add SettingsUtil utility class

broulik updated this revision to Diff 66690. broulik edited the summary of this revision. broulik added a comment. - Drop changed stuff for now - Catch exception directly in get and reject REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D

D24165: Add SettingsUtil utility class

broulik added a comment. In D24165#536531 , @fvogt wrote: > I can try if you'd like. That would be appreciated. INLINE COMMENTS > fvogt wrote in utils.js:19 > Wow, ES6 does indeed not support static members... Yeah... :/ > fvogt wrote

D24165: Add SettingsUtil utility class

fvogt added a comment. > Probably needs some Firefox ESR 60 testing to see whether it can deal with the class stuff... I can try if you'd like. INLINE COMMENTS > options.js:137 > }); > // When the extension is reloaded, any call to extension APIs throws > } catch (e)

D24157: [Cursor KCM] Restore live preview on hover

This revision was automatically updated to reflect the committed changes. Closed by commit R119:1cdf2ab8d716: [Cursor KCM] Restore live preview on hover (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24157?vs=0&id=66688 REVIS

D23274: [WIP] Add "Show intro page" button to System Settings sidebar

GB_2 added a comment. Looks like this is more complicated than I thought. If someone wants to comandeer this revision then please do. REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D23274 To: GB_2, #plasma, #vdg Cc: ngraham, mart, #vdg, plasma-devel, #plasma

D24165: Add SettingsUtil utility class

broulik created this revision. broulik added reviewers: Plasma, fvogt, ognarb. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY For reading, writing, and eventually getting notified of changes to settings. Prom

D24162: Hide "Lock Widgets" button from panel edit mode toolbar

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY In D23951 we hide "Lock Widgets" from the UI, so do the same thin

D18564: Remove support for KWin's QPA plugin for KWindowSystem

This revision was automatically updated to reflect the committed changes. Closed by commit R130:4a9ebaea1af7: Remove support for KWin's QPA plugin for KWindowSystem (authored by graesslin, committed by zzag). REPOSITORY R130 Frameworks integration plugin using KWayland CHANGES SINCE LAST UPDAT

D23952: Remove panel toolbox

GB_2 updated this revision to Diff 66671. GB_2 added a comment. Remove unrelated change REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23952?vs=66159&id=66671 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23952 AFFECTED FILES de

D24161: Make KCM look more like applet

sefaeyeoglu added inline comments. INLINE COMMENTS > MuteButton.qml:32 > +ToolTip.visible: hovered > +ToolTip.text: i18ndc("kcm_pulseaudio", "Mute audio stream", "Mute %1", > inputText.text) // a little hacky > checkable: true I actually think this is the wrong way of doing tooltip

D24161: Make KCM look more like applet

sefaeyeoglu updated this revision to Diff 9. sefaeyeoglu added a comment. Set domain for all i18n strings REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24161?vs=7&id=9 BRANCH feat-applet-ux REVISION DETAIL https://phabr

D24161: Make KCM look more like applet

davidedmundson added inline comments. INLINE COMMENTS > Applications.qml:87 > enabled: sourceOutputView.count > 0 > -text: i18nd("kcm_pulseaudio", "Recording") > disabledText: i18ndc("kcm_pulseaudio", "@label", "No > Applications Recording Audio") please do

D24161: Make KCM look more like applet

sefaeyeoglu added a comment. In D24161#536408 , @GB_2 wrote: > Please add reviewers and subscribers next time. Sorry. I didn't know who I should add so I just added #VDG as subscriber. REPOSITORY

D24161: Make KCM look more like applet

GB_2 added a comment. Please add reviewers, subscribers and screenshots next time. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D24161 To: sefaeyeoglu, #plasma, #vdg Cc: GB_2, #plasma, plasma-devel, #vdg, LeGast00n, The-Feren-OS-Dev, cblack, kon

D24161: Make KCM look more like applet

sefaeyeoglu created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sefaeyeoglu requested review of this revision. REVISION SUMMARY I was looking through changes in plasma-pa and noticed, that the KCM looks very different in contrast to the applet. TEST

D24147: fix compatibility with Qt5.11

mgallien added inline comments. INLINE COMMENTS > broulik wrote in ActionToolBar.qml:173 > I don't think you can replace arrow functions by a simple assignment. Isn't > this just a hack to turn that list into an `Array`? Thanks for the review. I was ignorant of arrow functions. The new version

D24147: fix compatibility with Qt5.11

mgallien updated this revision to Diff 6. mgallien added a comment. correct modifications from arrow function to a simple short one REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24147?vs=66627&id=6 BRANCH master REVISION DETAIL https://phabr

D24157: [Cursor KCM] Restore live preview on hover

ngraham added a comment. In D24157#536360 , @broulik wrote: > > when content doesn't entirely fit in the frame? > > How can that happen with the small number of previews? Like this: F7416735: Screenshot_20190923_075906.png

D24157: [Cursor KCM] Restore live preview on hover

broulik added a comment. > when content doesn't entirely fit in the frame? How can that happen with the small number of previews? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24157 To: broulik, #plasma, #vdg Cc: ngraham, plasma-devel, LeGast00n, The-Fe

D23718: WIP: Beginning of the Baloo/Search KCM Rewrite

ngraham added a comment. The frame's alignment and padding seem off: F7416705: Screenshot_20190923_075306.png Could we use a list more like the one used in the Virtual Desktops KCM and the slideshow wallpaper folder list? Then we would have a unifie

D24157: [Cursor KCM] Restore live preview on hover

ngraham added a comment. Nice. While you're at it, can you make the preview be more like the icon theme previews and automatically scroll vertically rather than getting cut off when content doesn't entirely fit in the frame? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabric

D23786: Remove some spacing on lockscreen that was causing elements to get cut off on small displays

This revision was automatically updated to reflect the committed changes. Closed by commit R120:cb96abf9c98f: Remove some spacing on lockscreen that was causing elements to get cut off on… (authored by kishoreg, committed by ngraham). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D24158: use KBusyIndicatorWidget for all busy indication uses

sitter added a comment. F7416572: vokoscreen-2019-09-23_15-02-14.gif F7416575: vokoscreen-2019-09-23_15-02-52.gif REPOSITORY R871 DrKonqi REVISION DETAIL https://phabricator.kde.org/D24158 To: sitter, #p

D24158: use KBusyIndicatorWidget for all busy indication uses

sitter created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sitter requested review of this revision. REVISION SUMMARY unlike the pixmapsequence this scales properly and is actually theme color sensitive (contrast on dark themes) and looks nicely inte

D24157: [Cursor KCM] Restore live preview on hover

broulik created this revision. broulik added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY When hovering a cursor in the delegate, it changes the mouse cursor to it. While at it, mode

D24147: fix compatibility with Qt5.11

broulik added inline comments. INLINE COMMENTS > ActionToolBar.qml:173 > icon.name: "overflow-menu" > -children: Array.prototype.map.call(root.actions, i => > i).concat(Array.prototype.map.call(hiddenActions, i => i)) > +children: Array.prototype.

D24156: Don't require QtGui for the PaginateModel test

leinir created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. leinir requested review of this revision. REVISION SUMMARY This is done by switching from the QStandardItemModel, which requires QtGui, to QStringListModel, which is in QtCore. The result is

D24110: Enable removing multiple devices at once

umanovskis added a comment. Rebased and adapted per suggestion above. REPOSITORY R97 Bluedevil REVISION DETAIL https://phabricator.kde.org/D24110 To: umanovskis, #vdg, #plasma Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeym

D24110: Enable removing multiple devices at once

umanovskis updated this revision to Diff 66653. umanovskis added a comment. - Update message box to a more user-friendly format REPOSITORY R97 Bluedevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24110?vs=66538&id=66653 BRANCH dev-multiselect REVISION DETAIL https://phab

Re: Fwd: Plasma 5.17 beta Discover system updates regression

El domingo, 22 de septiembre de 2019 16:13:09 (CEST), Luca Beltrame escribió: In data domenica 22 settembre 2019 14:20:21 CEST, Myriam Schweingruber ha scritto: (this might come in twice, due to gmane seemingly eating a message) FYI, this is now reported on both Arch and Neon, with several do

monday meeting notes for 23/9/2019

Kai Uwe: plasma-browser-integration: * Merged Purpose support for sharing stuff just in time for 5.17 beta * Needs new release for extension to work * Merged some of the KItinerary changes I made during Akademy for * Plan is that p-b-i offers you to add events, restaurant and hotel reservat

D23786: Remove some spacing on lockscreen that was causing elements to get cut off on small displays

filipf accepted this revision. filipf added a comment. Looks OK. I think it should be landed on the 5.17 branch since the bug it's solving is important. Weird that the login screen is fine, but I guess we can see if we need to tweak it later. REPOSITORY R120 Plasma Workspace REVISION DETA

D23718: WIP: Beginning of the Baloo/Search KCM Rewrite

nicolasfella added inline comments. INLINE COMMENTS > metadata.desktop:3 > +Name=Search > +Comment=Choose color scheme > + That comment sounds wrong :) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D23718 To: tcanabrava, #plasma, mart, ngraham Cc: nicolasfella

D23718: WIP: Beginning of the Baloo/Search KCM Rewrite

tcanabrava updated this revision to Diff 66643. tcanabrava added a comment. - Fix metadata installation - Fix model loading on Qml - Base work on the Qml - Name fixes - Move ui/main to contents - Fix wrong types in Qml - Plug the controllers - Link to the save button - Fix borde