D24370: [KCM] Display scale factor as a percentage, not a decimal

dhaumann added a comment. +1. This is also in line with typical zoom factors in other applications such as Okular, which also use percent values. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D24370 To: ngraham, #vdg, #plasma, romangg Cc: dhaumann, plasma-devel,

KDE CI: Plasma » plasma-workspace » kf5-qt5 SUSEQt5.12 - Build # 427 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20SUSEQt5.12/427/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 03 Oct 2019 05:38:57 + Build duration: 3 min 2 sec and counting CONSOLE OUTPUT

KDE CI: Plasma » plasma-workspace » kf5-qt5 FreeBSDQt5.13 - Build # 165 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20FreeBSDQt5.13/165/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 03 Oct 2019 05:38:57 + Build duration: 59 sec and counting CONSOLE OUTPUT

D24324: [GTK2] Add program to libexec for GTK2 recoloration

cblack added a comment. In D24324#541215 , @ndavis wrote: > In D24324#541214 , @cblack wrote: > > > In D24324#541212 , @ndavis wrote: > > > > > I'm not

D24324: [GTK2] Add program to libexec for GTK2 recoloration

ndavis added a comment. In D24324#541214 , @cblack wrote: > In D24324#541212 , @ndavis wrote: > > > I'm not sure how to verify if the assets have been generated correctly. What GTK2 programs did you

D24324: [GTK2] Add program to libexec for GTK2 recoloration

cblack added a comment. In D24324#541212 , @ndavis wrote: > I'm not sure how to verify if the assets have been generated correctly. What GTK2 programs did you test with? Look for a theme in `~/.local/share/themes` called `Breeze `. The

D24324: [GTK2] Add program to libexec for GTK2 recoloration

ndavis added a comment. I'm not sure how to verify if the assets have been generated correctly. What GTK2 programs did you test with? REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D24324 To: cblack, #breeze Cc: ndavis, plasma-devel, LeGast00n,

D24363: Fix several build system errors

alexeymin marked an inline comment as done. alexeymin added a comment. Right, so I was fooled by having qqc2-desktop-style listed as Tier 1 on our main documentation page https://api.kde.org/frameworks/index.html . If it is really Tier 3, then maybe it does not even make sense to make

D24363: Fix several build system errors

alexeymin updated this revision to Diff 67233. alexeymin added a comment. - Bring back missing KF5_DEP_VERSION REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24363?vs=67207=67233 BRANCH alexeymin/fix-cmake-errors REVISION

KDE CI: Plasma » plasma-workspace » kf5-qt5 SUSEQt5.12 - Build # 426 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20SUSEQt5.12/426/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 02 Oct 2019 22:05:02 + Build duration: 1 min 56 sec and counting CONSOLE OUTPUT

KDE CI: Plasma » plasma-workspace » kf5-qt5 FreeBSDQt5.13 - Build # 164 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20FreeBSDQt5.13/164/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 02 Oct 2019 22:05:01 + Build duration: 1 min 32 sec and counting CONSOLE OUTPUT

D24325: [runners/calculator] Port old style connect

This revision was automatically updated to reflect the committed changes. Closed by commit R120:e0f8167399ce: [runners/calculator] Port old style connect (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D24268: [libtaskmanager] Port to new connect syntax

This revision was automatically updated to reflect the committed changes. Closed by commit R120:0d9e0bce94af: [libtaskmanager] Port to new connect syntax (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D24375: [kcms/colors] Generate colored GTK2 assets based off of user's colorscheme

cblack created this revision. cblack added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. cblack requested review of this revision. REVISION SUMMARY The colors KCM will now call on a modified version of Breeze GTK's assets generation script when a

D24373: [KCM] Limit scale factor increment to 0.0625 on X11

ngraham updated this revision to Diff 67226. ngraham added a comment. Don't mention X11; it's too nerdy and technical REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24373?vs=67218=67226 BRANCH 0625-increment-on-x11 (branched from master) REVISION

D24373: [KCM] Limit scale factor increment to 0.0625 on X11

cullmann added a comment. I would just reformulate "Scale factors are limited to multiples of 6.25% on X11 to minimize visual glitches in applications." to "Scale factors are limited to multiples of 6.25% to minimize visual glitches in applications." I think adding X11

D24321: [KCM] Scale more coarsely with the slider, but more finely with a spinbox

ngraham added a comment. Here's a patch that changes the increment (along with a few dependencies that improve the UI in preparation for it): D24373 REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D24321 To: ngraham, #vdg,

D24374: WIP: Initial port of the Date and Time KCM

tcanabrava updated this revision to Diff 67223. tcanabrava added a comment. - Fix KAuth usage REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24374?vs=67219=67223 BRANCH kcm_dateandtime REVISION DETAIL https://phabricator.kde.org/D24374

D24374: WIP: Initial port of the Date and Time KCM

ngraham added a comment. Neato. See the mockups and discussion in T7248 . REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24374 To: tcanabrava Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas,

D24374: WIP: Initial port of the Date and Time KCM

tcanabrava created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. tcanabrava requested review of this revision. REVISION SUMMARY This is mostly the c++ part, missing the Qml - however this one should be easy to do - with the exception of the visual

D24373: [KCM] Limit scale factor increment to 0.0625 on X11

ngraham created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Because of the nature of floating point math and various Qt and X11 bugs, limiting the scale factor increment to 0.0625 (6.25%

D24371: [KCM] Make the warning message wider

ngraham created this revision. ngraham added reviewers: VDG, Plasma, romangg. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Making the message wider improves the presentation, especially for wordy languages

D24370: [KCM] Express scale factor as a percentage, not a decimal

ngraham created this revision. ngraham added reviewers: VDG, Plasma, romangg. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY This is the way GNOME and Windows present this information, and I think it's

D23378: Check if sddm user exists

filipf added a comment. Gonna land this in 24hrs if there are no objections. REPOSITORY R123 SDDM Configuration Panel (KCM) BRANCH sddm-user-check (branched from master) REVISION DETAIL https://phabricator.kde.org/D23378 To: filipf, #plasma, davidedmundson, ngraham, #vdg, fvogt Cc:

D23392: [energy KCM] Add battery Technology

ltoscano added a comment. What is the difference between "LeadAcid" and "Lead Acid"? REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D23392 To: meven, broulik, ngraham Cc: ltoscano, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2,

D23392: [energy KCM] Add battery Technology

This revision was automatically updated to reflect the committed changes. Closed by commit R102:42fe072ad0fe: [energy KCM] Add battery Technology (authored by meven). REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23392?vs=65189=67209 REVISION DETAIL

D24321: [KCM] Scale more coarsely with the slider, but more finely with a spinbox

cullmann added a comment. Ok ,works for me, too. Sorry for the noise! And thanks for the explanation! I think this is already much better than before, the details of the last finesse with the minimal step can be discussed elsewhere. REPOSITORY R104 KScreen REVISION DETAIL

D24333: sddm-theme: Set needsFullUserModel=false

fvogt added a comment. In D24333#541012 , @davidedmundson wrote: > I don't think I follow. > > How does the regular non-textfield version of the login screen still work? Surely containsAllUsers will always be false. It's only false

D24333: sddm-theme: Set needsFullUserModel=false

davidedmundson added a comment. I don't think I follow. How does the regular non-textfield version of the login screen still work? Surely containsAllUsers will always be false. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24333 To: fvogt, #plasma

D24363: Fix several build system errors

cgiboudeaux added a comment. Note: the metainfo file says this framework is tier 3. The subgroup value looks wrong INLINE COMMENTS > CMakeLists.txt:40-41 > +# IconThemes and ConfigWidgets are optional > +find_package(KF5IconThemes) > +find_package(KF5ConfigWidgets) > KF5_DEP_VERSION

D24363: Fix several build system errors

alexeymin reopened this revision. alexeymin added a comment. Phabricator, you're drunk, it is not pushed to master REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D24363 To: alexeymin, mart, #plasma, dfaure Cc: kde-frameworks-devel,

D24363: Fix several build system errors

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R858:9ddd3ba2f531: qqc2-desktop-style: Fix several builsystem errors (authored by Aleksey Minnekhanov

D24333: sddm-theme: Set needsFullUserModel=false

ngraham added subscribers: filipf, davidedmundson, ngraham. ngraham added a comment. Seems sane enough to me. @davidedmundson @filipf? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24333 To: fvogt, #plasma Cc: ngraham, davidedmundson, filipf,

D5961: Adoption of KUserFeedback for Discover

ngraham added a comment. In D5961#540961 , @apol wrote: > Discover is part of plasma and the information shared should be centrally configured. Then we need for the feedback KCM to mention Discover as a source of information that will be

D24361: [Style KCM] Port to new design

ngraham accepted this revision as: VDG. ngraham added a comment. This is fantastic. From a UI perspective, I think it's perfect. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24361 To: broulik, #plasma, #vdg Cc: ngraham, plasma-devel, LeGast00n,

D5961: Adoption of KUserFeedback for Discover

apol added a comment. In D5961#540955 , @ngraham wrote: > So this patch adds a semi-hidden menu item on the About page that opens the User Feedback KCM in a KCMShell window. I think this needs a better UX: > > 1. We finally need a real

KDE CI: Plasma » plasma-workspace » kf5-qt5 SUSEQt5.12 - Build # 425 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20SUSEQt5.12/425/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 02 Oct 2019 16:02:58 + Build duration: 15 min and counting BUILD ARTIFACTS

Re: ddcutil in Plasma Powerdevil

You might want to look at the launchpad packaging (https://launchpad.net/~rockowitz/+archive/ubuntu/ddcutil), which includes the library version and development package.  It is at the current release level (0.9.7). If the cmake error is not obvious, let me know what it is.  The locus of the

KDE CI: Plasma » plasma-desktop » kf5-qt5 SUSEQt5.12 - Build # 405 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20SUSEQt5.12/405/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 25 Sep 2019 14:03:26 + Build duration: 6 min 55 sec and counting JUnit Tests Name: (root)

D5961: Adoption of KUserFeedback for Discover

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. So this patch adds a semi-hidden menu item on the About page that opens the User Feedback KCM in a KCMShell window. I think this needs a better UX: 1. We finally need a

D5961: Adoption of KUserFeedback for Discover

ngraham added a comment. Actually that's fixed by D24010 . REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D5961 To: apol, #plasma, vkrause Cc: ngraham, mart, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh,

KDE CI: Plasma » plasma-workspace » kf5-qt5 FreeBSDQt5.13 - Build # 163 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20FreeBSDQt5.13/163/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 02 Oct 2019 16:02:58 + Build duration: 4 min 54 sec and counting JUnit Tests Name:

D24321: [KCM] Scale more coarsely with the slider, but more finely with a spinbox

cullmann added a comment. Ok, that explains why all my tries fail... I thought the hint above about looking for kcm_screen in the system was just if I have mixed up some stuff, but I always thought if the QT_PLUGIN_PATH is properly set like with prefix.sh the local plugins will be

D24321: [KCM] Scale more coarsely with the slider, but more finely with a spinbox

ngraham added a comment. In D24321#540936 , @cullmann wrote: > Ok, but given I have a system wide installed kcm anyways, from the distro, is there a way to use the own I have in my user local prefix? I could not find a way. I moved aside

D24321: [KCM] Scale more coarsely with the slider, but more finely with a spinbox

cullmann added a comment. Ok, but given I have a system wide installed kcm anyways, from the distro, is there a way to use the own I have in my user local prefix? That explains why I am too dumb to try the fractional scaling on Wayland with my installed master version, too. REPOSITORY

D5961: Adoption of KUserFeedback for Discover

ngraham added a comment. Now it fails to build in a different way. :) In file included from /home/nate/kde/build/discover/discover/plasmauserfeedback.cpp:30: /home/nate/kde/build/discover/discover/plasmauserfeedback.moc: In static member function ‘static void

D24321: [KCM] Scale more coarsely with the slider, but more finely with a spinbox

ngraham closed this revision. ngraham added a comment. I think the issue you're seeing is related to not having the new KCM installed properly, not anything this patch introduced. It's a bit tricky. You need to delete the old `kscreen.so` file or else the new one won't show up properly.

KDE CI: Plasma » plasma-workspace » kf5-qt5 SUSEQt5.12 - Build # 424 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20SUSEQt5.12/424/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 02 Oct 2019 15:35:03 + Build duration: 4 min 3 sec and counting CONSOLE OUTPUT

KDE CI: Plasma » plasma-workspace » kf5-qt5 FreeBSDQt5.13 - Build # 162 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20FreeBSDQt5.13/162/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 02 Oct 2019 15:35:03 + Build duration: 3 min 35 sec and counting CONSOLE OUTPUT

D5961: Adoption of KUserFeedback for Discover

apol updated this revision to Diff 67200. apol added a comment. Fix build REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5961?vs=66322=67200 BRANCH arcpatch-D5961 REVISION DETAIL https://phabricator.kde.org/D5961 AFFECTED FILES

D24321: [KCM] Scale more coarsely with the slider, but more finely with a spinbox

cullmann added a comment. Or I am maximal confused ;=) If I compile a master kscreen, have sourced the prefix.sh, shall I see the correct stuff in e.g. the kcm_testapp in bin of the kscreen build dir? If not, I am sorry, could somebody help me out how to test this properly?

D24321: [KCM] Scale more coarsely with the slider, but more finely with a spinbox

cullmann reopened this revision. cullmann added a comment. This revision is now accepted and ready to land. Besides, I think you missed half of the code, as for me, I still get a different widget here, as for my setup the OutputPanel.qml is used, not Panel.qml. (as I have two displays

D24321: [KCM] Scale more coarsely with the slider, but more finely with a spinbox

ngraham added a comment. In D24321#540896 , @cullmann wrote: > I don't get why we want to introduce artifacts we can very simple avoid by using a different base for the steps. > Is 0.0625 really that much worse than 0.05? I'll

D24321: [KCM] Scale more coarsely with the slider, but more finely with a spinbox

cullmann added a comment. I don't get why we want to introduce artifacts we can very simple avoid by using a different base for the steps. Is 0.0625 really that much worse than 0.05? REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D24321 To: ngraham, #vdg,

D24321: [KCM] Scale more coarsely with the slider, but more finely with a spinbox

This revision was automatically updated to reflect the committed changes. Closed by commit R104:7a9387ed727c: [KCM] Scale more coarsely with the slider, but more finely with a spinbox (authored by ngraham). REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE

D24321: [KCM] Scale more coarsely with the slider, but more finely with a spinbox

romangg accepted this revision. romangg added a comment. This revision is now accepted and ready to land. master REPOSITORY R104 KScreen BRANCH advanced-scaling-control (branched from master) REVISION DETAIL https://phabricator.kde.org/D24321 To: ngraham, #vdg, #plasma, romangg,

D24321: [KCM] Scale more coarsely with the slider, but more finely with a spinbox

romangg added a comment. In D24321#540871 , @cullmann wrote: > Hmm, could we perhaps adjust the minimal step to 0,0625. > That is 1/16 and with that, I never get any artifacts with KWrite in current master, as it nicely sums up. > Then you

D23392: [energy KCM] Add battery Technology

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Works perfectly. REPOSITORY R102 KInfoCenter BRANCH arcpatch-D23392 REVISION DETAIL https://phabricator.kde.org/D23392 To: meven, broulik, ngraham Cc: plasma-devel, LeGast00n,

D24321: [KCM] Scale more coarsely with the slider, but more finely with a spinbox

cullmann added a comment. To illustrate that, just try, with master of KTextEditor: export QT_SCALE_FACTOR=1.125 kwrite with some file => select 100 lines, zoom font in and out => I get no artifacts export QT_SCALE_FACTOR=1.0625 > same == export

D24321: [KCM] Scale more coarsely with the slider, but more finely with a spinbox

cullmann added a comment. Hmm, could we perhaps adjust the minimal step to 0,0625. That is 1/16 and with that, I never get any artifacts with KWrite in current master, as it nicely sums up. Then you don't need to round at all for output. REPOSITORY R104 KScreen REVISION DETAIL

D24321: [KCM] Scale more coarsely with the slider, but more finely with a spinbox

ngraham updated this revision to Diff 67195. ngraham marked an inline comment as done. ngraham added a comment. Address final review comments REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24321?vs=67191=67195 BRANCH advanced-scaling-control (branched

D24321: [KCM] Scale more coarsely with the slider, but more finely with a spinbox

romangg requested changes to this revision. romangg added a comment. This revision now requires changes to proceed. Last issue: we need to change in `kded/output.cpp` line 363 where it rounds on config write to one digit to round to two digits instead: `info[QStringLiteral("scale")] =

KDE CI: Plasma » plasma-workspace » kf5-qt5 SUSEQt5.12 - Build # 423 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20SUSEQt5.12/423/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 02 Oct 2019 14:12:14 + Build duration: 13 min and counting CONSOLE OUTPUT [...truncated

KDE CI: Plasma » plasma-workspace » kf5-qt5 FreeBSDQt5.13 - Build # 161 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20FreeBSDQt5.13/161/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 02 Oct 2019 14:12:14 + Build duration: 3 min 17 sec and counting CONSOLE OUTPUT

D24011: Provide a telemetrics kcm module for Plasma

This revision was automatically updated to reflect the committed changes. Closed by commit R120:15dd744a3ba4: Provide a telemetrics kcm module for Plasma (authored by apol). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D24011?vs=67184=67192#toc REPOSITORY R120 Plasma Workspace

D24321: [KCM] Scale more coarsely with the slider, but more finely with a spinbox

ngraham updated this revision to Diff 67191. ngraham added a comment. Allow values as low as 0.5 in the spinbox for the Wayland case REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24321?vs=67156=67191 BRANCH advanced-scaling-control (branched from

D24011: Provide a telemetrics kcm module for Plasma

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Okay, let's land this now and I'll send a follow-up patch to tweak the UI. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D24011 To:

D24363: Fix several builsystem errors

alexeymin added a comment. Second error is revealed after the first one is fixed: Scanning dependencies of target qqc2desktopstyleplugin [ 40%] Building CXX object plugin/CMakeFiles/qqc2desktopstyleplugin.dir/qqc2desktopstyleplugin_autogen/mocs_compilation.cpp.o [ 60%] Building

D24363: Fix several builsystem errors

alexeymin added a comment. First of all, if you try to build qqc2-desktop-style on a system with only Qt5 and other Tier 1 frameworks installed, you will get the following cmake configure log (https://paste.ubuntu.com/p/YRjSRWm9g6/): OS Kubuntu 18.04 LTS Custom-built Qt 5.14 in

D24265: support global edit mode

mart updated this revision to Diff 67189. mart added a comment. - don't raise the icons over the toolbox REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24265?vs=67186=67189 BRANCH mart/editMode REVISION DETAIL

D24011: Provide a telemetrics kcm module for Plasma

apol added inline comments. INLINE COMMENTS > ngraham wrote in main.qml:68 > These strings still need to be re-worded, and possibly collapsed, and > possible the whole UI needs to be re-thought. What if I want to submit > detailed system information but only basic usage information? Maybe we

D24363: qqc2-desktop-style: Fix several builsystem errors

alexeymin created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. alexeymin requested review of this revision. TEST PLAN without this patch, try to build with only Qt5 and Tier 1 frameworks installed and see it fails REPOSITORY R858 Qt Quick Controls

D24011: Provide a telemetrics kcm module for Plasma

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. I would remove the big text block from the form layout, since this makes it look off-center. Also it needs a bigger margin below it. See also the following inline comments:

D24265: support global edit mode

mart updated this revision to Diff 67186. mart added a comment. - state machine for right order of opacity and visible REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24265?vs=67069=67186 BRANCH mart/editMode REVISION DETAIL

D24264: edit mode action and dbus

mart updated this revision to Diff 67185. mart added a comment. - edit mode on mouse over when containment in edit mode REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24264?vs=67166=67185 BRANCH mart/editMode REVISION DETAIL

D24321: [KCM] Scale more coarsely with the slider, but more finely with a spinbox

romangg added a comment. I like the new approach. On Wayland the value range should start at `0.5` and go till `3`. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D24321 To: ngraham, #vdg, #plasma, romangg, ndavis Cc: dhaumann, davidedmundson, ouwerkerk, GB_2,

D24011: Provide a telemetrics kcm module for Plasma

apol updated this revision to Diff 67184. apol added a comment. Better looking margins REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24011?vs=67130=67184 BRANCH master REVISION DETAIL https://phabricator.kde.org/D24011 AFFECTED FILES

D24321: [KCM] Scale more coarsely with the slider, but more finely with a spinbox

romangg added a comment. In D24321#540654 , @cullmann wrote: > I like that UI, too. > For Wayland: Can somebody tell me how I can try there some fractional scaling? You are on KScreen master or beta channel? Because the new UI

D24361: [Style KCM] Port to new design

broulik created this revision. broulik added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY This ports the widget style KCM to use a grid view KCM with live preview thumbnails and

D24359: Fix a number of issues found by the OpenSuse security team in networkhelper

ahiemstra added a comment. Note that https://bugzilla.opensuse.org/show_bug.cgi?id=1152638 says `pcap_breakloop()` is unsupported when called from multiple threads. However, the actual libpcap documentation states: > Note also that, in a multi-threaded application, if one thread is

D24360: Backport ifdefs to fix build with current KF5

jriddell created this revision. jriddell added a reviewer: mart. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. jriddell requested review of this revision. REVISION SUMMARY Backport ifdefs to fix build with current KF5 TEST PLAN build it REPOSITORY R130

D24359: Fix a number of issues found by the OpenSuse security team in networkhelper

ahiemstra created this revision. ahiemstra added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ahiemstra requested review of this revision. REVISION SUMMARY See https://bugzilla.opensuse.org/show_bug.cgi?id=1151190 and its dependencies for

D24358: SVN_SILENT made messages (.desktop file) - always resolve ours

ahiemstra created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ahiemstra requested review of this revision. REVISION SUMMARY In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours

D23392: [energy KCM] Add battery Technology

meven requested review of this revision. meven added a comment. This is now ready to review since KF 5.62 was released. I have tested it. REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D23392 To: meven, broulik, ngraham Cc: plasma-devel, LeGast00n,

D24264: edit mode action and dbus

mart added a comment. edit mode on mouse over F7495076: vokoscreen-2019-10-02_10-09-54.mp4 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24264 To: mart, #plasma Cc: GB_2, ngraham, davidedmundson, plasma-devel,

D24264: edit mode action and dbus

mart updated this revision to Diff 67166. mart added a comment. - edit mode on mouse over when containment in edit mode REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24264?vs=67071=67166 BRANCH mart/editMode REVISION DETAIL

D24321: [KCM] Scale more coarsely with the slider, but more finely with a spinbox

cullmann added a comment. I like that UI, too. For Wayland: Can somebody tell me how I can try there some fractional scaling? REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D24321 To: ngraham, #vdg, #plasma, romangg, ndavis Cc: dhaumann, davidedmundson, ouwerkerk,