D25750: Make startplasma more flexible so it can be leveraged by plasma mobile

alexeymin added inline comments. INLINE COMMENTS > apol wrote in startplasma-wayland.cpp:91 > Please see > https://invent.kde.org/kde/plasma-phone-components/merge_requests/38 Indeed, I overlooked, probably lack of `{ }` around `for` loop confused me.. REPOSITORY R120 Plasma Workspace

D25750: Make startplasma more flexible so it can be leveraged by plasma mobile

bshah accepted this revision. bshah added inline comments. INLINE COMMENTS > bshah wrote in main.cpp:93 > I am bit unsure about this. We can simply write a configuration file in > /etc/xdg using the plasma-phone-settings package. On second thought, scratch all this. REPOSITORY R120 Plasma

D25750: Make startplasma more flexible so it can be leveraged by plasma mobile

bshah added inline comments. INLINE COMMENTS > main.cpp:93 > KConfigGroup startupConfGroup(startupConf, "Shell"); > -const QString defaultShell = startupConfGroup.readEntry("ShellPackage", > "org.kde.plasma.desktop"); > +const QString defaultShell =

D25459: fix(kcm): improve i18n of device combobox

guoyunhe added a comment. Should we reassign a reviewer? REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D25459 To: guoyunhe, kde-i18n-doc, #plasma, #localization, broulik Cc: romangg, broulik, ltoscano, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh,

D25310: Use the right value of EnableMagicMimeActions

This revision was automatically updated to reflect the committed changes. Closed by commit R120:895e31d6946b: Use the right value of EnableMagicMimeActions (authored by trmdi, committed by ngraham). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D25310: Use the right value of EnableMagicMimeActions

trmdi updated this revision to Diff 70933. trmdi added a comment. Remove unneeded code REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25310?vs=69759=70933 BRANCH fix-enableMagicMimeActions REVISION DETAIL https://phabricator.kde.org/D25310

D25758: Use the right value of enableMagicMimeActions

trmdi created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. trmdi requested review of this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D25758 AFFECTED FILES klipper/urlgrabber.cpp To: trmdi Cc:

D25750: Make startplasma more flexible so it can be leveraged by plasma mobile

apol marked an inline comment as done. apol added inline comments. INLINE COMMENTS > alexeymin wrote in startplasma-wayland.cpp:91 > Currently I can edit simple shell script (kwinwrapper) and remove the > argument to kwin_wayland. If this is going to be hardcoded in the executable, > it cannot

D25728: [Applet Configuration] Don't draw a full-on separator between the titlebar and window

manueljlin added a comment. I though that would just affect every app's titlebar without actually checking if the app has a toolbar, etc etc and just add/remove the divider everywhere and be done with it. However, if the app can actually send a hint to Kwin to make it hide or show the

D25728: [Applet Configuration] Don't draw a full-on separator between the titlebar and window

filipf added a comment. In D25728#572350 , @manueljlin wrote: > But that style of line / divider was going to be after the toolbars too, like kirigami apps, so removing it just would make that inconsistent later on. The divider needs to be

D25728: [Applet Configuration] Don't draw a full-on separator between the titlebar and window

manueljlin added a comment. But that style of line / divider was going to be after the toolbars too, like kirigami apps, so removing it just would make that inconsistent later on. If it's possible, fixing the color scheme and making it configurable should probably be the way to go.

D22506: Read BAMF_DESKTOP_FILE_HINT from environment

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R120:31c75e48c833: Read BAMF_DESKTOP_FILE_HINT from environment (authored by broulik). CHANGED PRIOR TO COMMIT

D25751: [Notifications] Split draggable thumbnail area into its own component

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY I'm planning to use it in job notifications, too. This should also make it easier to migrate

D25726: [Icon View] Fix titles of previously opened KCMs bleeding into QML KCMs

filipf added a comment. In D25726#572255 , @ngraham wrote: > 5.17 I say I think that makes sense. I tested this by comparing every KCM with 5.17 system settings and saw no issues. Breadcrumb navigation worked as well. REPOSITORY

D25750: Make startplasma more flexible so it can be leveraged by plasma mobile

mart accepted this revision as: mart. mart added a comment. This revision is now accepted and ready to land. +1 from me, would still like other opinions REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D25750 To: apol, #plasma, bshah, mart

D25750: Make startplasma more flexible so it can be leveraged by plasma mobile

alexeymin added inline comments. INLINE COMMENTS > apol wrote in startplasma-wayland.cpp:91 > This is not changing, --xwayland is already on by default. In fact it will be > possible to change the defaults by passing some arguments to > startplasma-wayland. Currently I can edit simple shell

D25750: Make startplasma more flexible so it can be leveraged by plasma mobile

apol marked an inline comment as done. apol added inline comments. INLINE COMMENTS > alexeymin wrote in startplasma-wayland.cpp:91 > having `--xwayland` always by default will unfortunately break my device port > (xwayland crashes for me for some reason) This is not changing, --xwayland is

D25745: Showcase KConfig Issue with CamelCase keys on ManagedConfigModule

apol commandeered this revision. apol added a reviewer: tcanabrava. apol added a comment. This can be closed now. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25745 To: apol, ervin, tcanabrava Cc: apol, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh,

D25750: Make startplasma more flexible so it can be leveraged by plasma mobile

alexeymin added inline comments. INLINE COMMENTS > startplasma-wayland.cpp:91 > +} else { > +args = QStringList { QStringLiteral("--xwayland"), > QStringLiteral("--libinput"), QStringLiteral("--exit-with-session=" > CMAKE_INSTALL_FULL_LIBEXECDIR "/startplasma-waylandsession") }; >

D25750: Make startplasma more flexible so it can be leveraged by plasma mobile

alexeymin added a comment. Good to see more flexibility! REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D25750 To: apol, #plasma, bshah Cc: alexeymin, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham,

D25750: Make startplasma more flexible so it can be leveraged by plasma mobile

apol created this revision. apol added reviewers: Plasma, bshah. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Allows specifying the shell through an environment variable. Allows forwarding command line

D25726: [Icon View] Fix titles of previously opened KCMs bleeding into QML KCMs

ngraham accepted this revision. ngraham added a comment. 5.17 I say REPOSITORY R124 System Settings BRANCH no-double-titles (branched from master) REVISION DETAIL https://phabricator.kde.org/D25726 To: filipf, #plasma, davidedmundson, ngraham Cc: ngraham, davidedmundson,

D25726: [Icon View] Fix titles of previously opened KCMs bleeding into QML KCMs

filipf updated this revision to Diff 70916. filipf added a comment. add space before final ) REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25726?vs=70915=70916 BRANCH no-double-titles (branched from master) REVISION DETAIL

D25726: [Icon View] Fix titles of previously opened KCMs bleeding into QML KCMs

ngraham added inline comments. INLINE COMMENTS > IconMode.cpp:144 > +// avoid double titles by setting the right face type before loading the > module > +if ( d->categoryView->model()->rowCount(activeModule) > 1) { > +d->moduleView->setFaceType(KPageView::List); pedantic

D25726: [Icon View] Fix titles of previously opened KCMs bleeding into QML KCMs

filipf updated this revision to Diff 70915. filipf added a comment. define condition without creating a variable REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25726?vs=70889=70915 BRANCH no-double-titles (branched from master) REVISION DETAIL

D25310: Use the right value of EnableMagicMimeActions

trmdi added a comment. Ah, I think like you, just following the existing code. :D In D25310#572211 , @davidedmundson wrote: > I can't really object, as you're just following the existing code, but I don't really understand why we're doing

D25740: Add item spacing to size hint

ngraham added a comment. 5.17 I'd say. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D25740 To: broulik, ndavis, hpereiradacosta Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai,

D25310: Use the right value of EnableMagicMimeActions

davidedmundson added a comment. I can't really object, as you're just following the existing code, but I don't really understand why we're doing this. INLINE COMMENTS > urlgrabber.cpp:106 > -KConfigGroup cg(KSharedConfig::openConfig(), "Actions"); > -

D25726: [Icon View] Fix titles of previously opened KCMs bleeding into QML KCMs

ngraham accepted this revision. ngraham added a comment. Otherwise LGTM REPOSITORY R124 System Settings BRANCH no-double-titles (branched from master) REVISION DETAIL https://phabricator.kde.org/D25726 To: filipf, #plasma, davidedmundson, ngraham Cc: ngraham, davidedmundson,

D25745: Showcase KConfig Issue with CamelCase keys on ManagedConfigModule

tcanabrava created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. tcanabrava requested review of this revision. REPOSITORY R119 Plasma Desktop BRANCH showcase_kcofig_issue REVISION DETAIL https://phabricator.kde.org/D25745 AFFECTED FILES

D25744: support userBackgroundhints in the scripting ui

mart added inline comments. INLINE COMMENTS > apol wrote in widget.h:71 > const& > > or should it be Plasma::Types::BackgroundHints? everthing else presents strings to the engine. i don't know if it's possible making enums work correctly with qjsengine (that is without qml) REPOSITORY

D25744: support userBackgroundhints in the scripting ui

apol added inline comments. INLINE COMMENTS > widget.h:71 > +QString userBackgroundHints() const; > +void setUserBackgroundHints(QString hint); > + const& or should it be Plasma::Types::BackgroundHints? REPOSITORY R120 Plasma Workspace REVISION DETAIL

D25744: support userBackgroundhints in the scripting ui

mart created this revision. mart added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY bind userBackgroundHints to the desktopscript interface TEST PLAN from the scripting console is

D25310: Use the right value of EnableMagicMimeActions

trmdi added a comment. Ping! REPOSITORY R120 Plasma Workspace BRANCH fix-enableMagicMimeActions (branched from master) REVISION DETAIL https://phabricator.kde.org/D25310 To: trmdi, #plasma, ngraham, apol Cc: ngraham, plasma-devel, #plasma, LeGast00n, The-Feren-OS-Dev, jraleigh,

D25447: [Baloo KCM] Add the ability to suspend, resume, and monitor indexing

davidedmundson requested changes to this revision. davidedmundson added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > ngraham wrote in constants.js:23 > I'm not sure exactly what that means or how to do it; can you help me with it? See D25743

D25447: [Baloo KCM] Add the ability to suspend, resume, and monitor indexing

ngraham added inline comments. INLINE COMMENTS > davidedmundson wrote in constants.js:23 > Why doesn't this come from the plugin? I'm not sure exactly what that means or how to do it; can you help me with it? REPOSITORY R119 Plasma Desktop REVISION DETAIL

D25447: [Baloo KCM] Add the ability to suspend, resume, and monitor indexing

ngraham updated this revision to Diff 70904. ngraham marked an inline comment as done. ngraham added a comment. ALso check for LowPowerIdle state REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25447?vs=70859=70904 BRANCH

D25726: [Icon View] Fix titles of previously opened KCMs bleeding into QML KCMs

ngraham added inline comments. INLINE COMMENTS > IconMode.cpp:144 > +// avoid double titles by setting the right face type before loading the > module > +const int categoryCount = > d->categoryView->model()->rowCount(activeModule); > + Since this is only used once, you don't really

D25740: Add item spacing to size hint

broulik created this revision. broulik added reviewers: ndavis, hpereiradacosta. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY This is what Adwaita Qt does [1] and it fixes the popup text being elided in

D25728: [Applet Configuration] Don't draw a full-on separator between the titlebar and window

anthonyfieroni added a comment. +1 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25728 To: filipf, #plasma, #vdg Cc: anthonyfieroni, broulik, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin,

D25728: [Applet Configuration] Don't draw a full-on separator between the titlebar and window

filipf added a comment. In D25728#572043 , @anthonyfieroni wrote: > So with the patch is it drawn when it is ticked in window decoration? Yes. With the patch there is only a top separator on the sidebar, not between the titlebar and

D25728: [Applet Configuration] Don't draw a full-on separator between the titlebar and window

anthonyfieroni added a comment. So with the patch is it drawn when it is ticked in window decoration? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25728 To: filipf, #plasma, #vdg Cc: anthonyfieroni, broulik, ngraham, plasma-devel, LeGast00n,

D25728: [Applet Configuration] Don't draw a full-on separator between the titlebar and window

filipf added a comment. In D25728#572036 , @anthonyfieroni wrote: > Is that configurable (Window decorations -> ^ Draw separator between titlebar and a window ? No, the separator is always drawn. REPOSITORY R119 Plasma Desktop

D25728: [Applet Configuration] Don't draw a full-on separator between the titlebar and window

anthonyfieroni added a comment. Is that configurable (Window decorations -> ^ Draw separator between titlebar and a window ? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25728 To: filipf, #plasma, #vdg Cc: anthonyfieroni, broulik, ngraham, plasma-devel,

D25736: Make it compile without deprecated method

mlaurent created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. mlaurent requested review of this revision. REVISION SUMMARY compile without deprecated method REPOSITORY R115 Plasma Audio Volume Applet BRANCH compile_without_deprecated_method

D23005: Fix typo in name of installed CMake Config: Deskop->Desktop

This revision was automatically updated to reflect the committed changes. Closed by commit R858:8b0372d2932e: Fix typo in name of installed CMake Config: Deskop-Desktop (authored by kossebau). REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE

D25729: Make it compile without qt deprecated method

This revision was automatically updated to reflect the committed changes. Closed by commit R134:f32965ea3a9f: Make it compile without qt deprecated method (authored by mlaurent). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE

D25709: Make it compile against qt5.14 without deprecated method

This revision was automatically updated to reflect the committed changes. Closed by commit R858:8eca435225b6: Make it compile against qt5.14 without deprecated method (authored by mlaurent). REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE

D25726: [Icon View] Fix titles of previously opened KCMs bleeding into QML KCMs

filipf updated this revision to Diff 70889. filipf added a comment. This revision is now accepted and ready to land. don't break the sidebar REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25726?vs=70870=70889 BRANCH no-double-titles (branched

D25726: [Icon View] Fix titles of previously opened KCMs bleeding into QML KCMs

filipf added a comment. So we also fix this by setting: ` d->moduleView()->setFaceType(KPageView::List);` But then then a sidebar shows up even if there is only 1 category. So just need to check for the number of categories and do `List` if > 1, otherwise `Plain`. REPOSITORY

D23005: Fix typo in name of installed CMake Config: Deskop->Desktop

kossebau added a comment. Np other opinion? Would then go with this in the next days... REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D23005 To: kossebau, mart, broulik Cc: apol, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh,

D25726: [Icon View] Fix titles of previously opened KCMs bleeding into QML KCMs

filipf planned changes to this revision. filipf added a comment. I just realized this kills the sidebar when there's more than 1 kcm under a category :( REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D25726 To: filipf, #plasma, davidedmundson Cc:

D25728: [Applet Configuration] Don't draw a full-on separator between the titlebar and window

filipf added a comment. In D25728#571848 , @ngraham wrote: > But... the "Before" image looks better. :/ > > Having the titlebar blend with the window kind of requires that nothing wants to be touching the titlebar, or else it just looks bad

D25726: [Icon View] Fix titles of previously opened KCMs bleeding into QML KCMs

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Oh, well done! I'd seen the bug report but hadn't been able to fix it. INLINE COMMENTS > IconMode.cpp:119 > d->categoryView = nullptr; > +