D26338: Ensure WM initializes before session starts

esjeon added a comment. Note that this is an RFC at the current state. This can be solved elsewhere (e.g. ksmserver), and is **tested only on X11** (I don't have machine that runs wayland w/o problems). I also don't like that plasma-session is calling QGuiApplication, which is required to

D26338: Ensure WM initializes before session starts

esjeon created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. esjeon requested review of this revision. REVISION SUMMARY This is an attempt to resolve bug 362857. A number of users have complained about restored application not supporting desktop

D26304: [PageRow] Disable swipe forwards/backwards gesture by default

ndavis added a comment. In D26304#585525 , @ouwerkerk wrote: > This completely alters one of the core propositions of how a Kirigami UX works. I may be mistaken, but if I understand it correctly drawers are supposed to be accessible via

D26305: Fix Ctrl+F shortcut conflict

ngraham updated this revision to Diff 72503. ngraham marked 2 inline comments as done. ngraham added a comment. Fix whitespace REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26305?vs=72422=72503 BRANCH fix-shortcut-conflict (branched from

D26305: Fix Ctrl+F shortcut conflict

apol added a comment. Patch looks good. INLINE COMMENTS > ngraham wrote in SettingsBase.cpp:422 > Dunno why phab is showing this; I didn't actually remove the trailing newline. kate and vim do in some occasions. REPOSITORY R124 System Settings REVISION DETAIL

D26304: [PageRow] Disable swipe forwards/backwards gesture by default

ouwerkerk added a comment. This completely alters one of the core propositions of how a Kirigami UX works. I may be mistaken, but if I understand it correctly drawers are supposed to be accessible via buttons. If gestures conflict, why remove page row navigation by gesture rather than

D26261: Rewrite GTK KCM

ngraham added a comment. Yeah tabs could work, especially if we ever get a functional icon grid for the GTK themes. You can copy how it's done in the Window Decorations and Audio KCMs. REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D26261 To:

D26324: [KCM/Component] filemanager: make dolphin the default filemananger

meven updated this revision to Diff 72497. meven added a comment. fix curly brace position REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26324?vs=72495=72497 BRANCH arcpatch-D26324 REVISION DETAIL https://phabricator.kde.org/D26324 AFFECTED

D26183: Fix build with Qt 5.14

broulik reopened this revision. broulik added a comment. This revision is now accepted and ready to land. Please use `qmlRegisterAnonymousType` REPOSITORY R112 Milou REVISION DETAIL https://phabricator.kde.org/D26183 To: tcanabrava, davidedmundson Cc: broulik, plasma-devel, LeGast00n,

D26324: [KCM/Component] filemanager: make dolphin the default filemananger

ervin added inline comments. INLINE COMMENTS > componentchooserfilemanager.cpp:32 > + > +QRadioButton *findDolphinRadio(const QList ) { > +auto it = std::find_if(radioButtons.begin(), radioButtons.end(), > [=](QRadioButton *radio) { And of course as I was about to hit "accept" I notice

D26324: [KCM/Component] filemanager: make dolphin the default filemananger

meven updated this revision to Diff 72495. meven added a comment. clean REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26324?vs=72494=72495 BRANCH arcpatch-D26324 REVISION DETAIL https://phabricator.kde.org/D26324 AFFECTED FILES

D26324: [KCM/Component] filemanager: make dolphin the default filemananger

meven updated this revision to Diff 72494. meven added a comment. clean REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26324?vs=72493=72494 BRANCH arcpatch-D26324 REVISION DETAIL https://phabricator.kde.org/D26324 AFFECTED FILES

D26324: [KCM/Component] filemanager: make dolphin the default filemananger

ervin requested changes to this revision. ervin added a comment. This revision now requires changes to proceed. Note the :: prefix is likely unnecessary in this context (doesn't hurt either). INLINE COMMENTS > componentchooserfilemanager.h:46 > private: > +QRadioButton*

D26324: [KCM/Component] filemanager: make dolphin the default filemananger

meven updated this revision to Diff 72493. meven marked an inline comment as done. meven added a comment. Correct namespace declaration, better variable naming, take list of QRadioButton by const ref REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D26324: [KCM/Component] filemanager: make dolphin the default filemananger

ervin requested changes to this revision. ervin added a comment. This revision now requires changes to proceed. Almost there. INLINE COMMENTS > componentchooserfilemanager.cpp:41 > > +QRadioButton * findDolphinRadio(QList dynamicRadioButtons) { > +auto it =

D26324: [KCM/Component] filemanager: make dolphin the default filemananger

meven updated this revision to Diff 72491. meven marked 2 inline comments as done. meven added a comment. Better implement helper function, replace unnused include by a more relevant one REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D26324: [KCM/Component] filemanager: make dolphin the default filemananger

ervin requested changes to this revision. ervin added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > componentchooserfilemanager.cpp:57 > + > +QRadioButton* CfgFileManager::findDolphinRadio() const { > +auto it = std::find_if(mDynamicRadioButtons.begin(),

D26324: [KCM/Component] filemanager: make dolphin the default filemananger

meven updated this revision to Diff 72489. meven added a comment. rebase on master REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26324?vs=72488=72489 BRANCH arcpatch-D26324 REVISION DETAIL https://phabricator.kde.org/D26324 AFFECTED FILES

D26324: [KCM/Component] filemanager: make dolphin the default filemananger

meven updated this revision to Diff 72488. meven added a comment. Use std::find_if REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26324?vs=72485=72488 BRANCH arcpatch-D26324 REVISION DETAIL https://phabricator.kde.org/D26324 AFFECTED FILES

D26324: [KCM/Component] filemanager: make dolphin the default filemananger

ervin added a comment. Damn, sorry mate... I meant find_if... dunno why I spluttered any_of... :-/ Indeed if you make a tiny wrapper function for find_if on the "storageId == org.kde.dolphin.desktop" condition, you can use it both in defaults and isDefaults. In one case it's just

D26329: [KCM/Component] Email: make isDefault work

This revision was automatically updated to reflect the committed changes. Closed by commit R119:10108d4b48ad: [KCM/Component] Email: make isDefault work (authored by meven). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26329?vs=72480=72486 REVISION

D26324: [KCM/Component] filemanager: make dolphin the default filemananger

meven updated this revision to Diff 72485. meven added a comment. Use std::any_of REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26324?vs=72467=72485 BRANCH arcpatch-D26324 REVISION DETAIL https://phabricator.kde.org/D26324 AFFECTED FILES

D26330: [MPRIS Data Engine] Ignore players with CanControl false in multiplexer

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY The multiplexer is responsible for global media control shortcuts which won't work with a player

D26323: [KCM/Component] Terminal port to KConfigXT, make isDefault work

This revision was automatically updated to reflect the committed changes. Closed by commit R119:19844315c557: [KCM/Component] Terminal port to KConfigXT, make isDefault work (authored by meven). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D26329: [KCM/Component] Email: make isDefault work

meven created this revision. meven added reviewers: ervin, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D26329 AFFECTED

D26324: [KCM/Component] filemanager: make dolphin the default filemananger

ervin accepted this revision. ervin added a comment. This revision is now accepted and ready to land. Note that I think std::any_of wrapped in a helper to get an iterator on the dolphin radio button would make that code simpler. To be checked maybe? Not mandatory at all, feel free to ignore

D26323: [KCM/Component] Terminal port to KConfigXT, make isDefault work

ervin added a comment. In D26323#585291 , @meven wrote: > In D26323#585271 , @ervin wrote: > > > One nitpick to address before pushing. > > > > Also I mark those accepted assuming there will be

D26323: [KCM/Component] Terminal port to KConfigXT, make isDefault work

meven marked an inline comment as done. meven added a comment. In D26323#585271 , @ervin wrote: > One nitpick to address before pushing. > > Also I mark those accepted assuming there will be another phase where the settings objects will

D26323: [KCM/Component] Terminal port to KConfigXT, make isDefault work

meven updated this revision to Diff 72468. meven added a comment. Make default button work, fix a carriage return missing REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26323?vs=72465=72468 BRANCH master REVISION DETAIL

D26324: [KCM/Component] filemanager: make dolphin the default filemananger

meven created this revision. meven added reviewers: ervin, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D26324 AFFECTED

D26323: [KCM/Component] Terminal port to KConfigXT, make isDefault work

ervin accepted this revision. ervin added a comment. This revision is now accepted and ready to land. One nitpick to address before pushing. Also I mark those accepted assuming there will be another phase where the settings objects will actually be properly matched to the GUI. Currently

D26234: [Applet] Unify 'raise maximum volume' and 'maximum volume'

meven added a comment. In D26234#584972 , @ngraham wrote: > In D26234#584969 , @ndavis wrote: > > > In D26234#584620 , @meven wrote: > > > > > I feel

D26322: [KCM/Component] Fix CfgFileManager::isDefaults

This revision was automatically updated to reflect the committed changes. Closed by commit R119:3bd210f13cca: [KCM/Component] Fix CfgFileManager::isDefaults (authored by meven). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26322?vs=72463=72466

D26323: [KCM/Component] Terminal port to KConfigXT, make isDefault work

meven created this revision. meven added reviewers: ervin, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D26323 AFFECTED

D26322: [KCM/Component] Fix CfgFileManager::isDefaults

meven updated this revision to Diff 72463. meven added a comment. Fix diff REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26322?vs=72462=72463 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26322 AFFECTED FILES

D26322: [KCM/Component] Fix CfgFileManager::isDefaults

meven updated this revision to Diff 72462. meven added a comment. Fix indentation HEAD^ REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26322?vs=72461=72462 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26322 AFFECTED FILES

D26322: [KCM/Component] Fix CfgFileManager::isDefaults

meven updated this revision to Diff 72461. meven added a comment. Include last commit only REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26322?vs=72460=72461 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26322 AFFECTED FILES

D26322: [KCM/Component] Fix CfgFileManager::isDefaults

meven updated this revision to Diff 72460. meven added a comment. [KCM/Component] Terminal port to KConfig XT, make isDefault work REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26322?vs=72458=72460 BRANCH master REVISION DETAIL

D26322: [KCM/Component] Fix CfgFileManager::isDefaults

meven created this revision. meven added a reviewer: ervin. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REVISION SUMMARY The first RadioButtons in the radioLayout is the last in mDynamicRadioButtons TEST PLAN Defaults work

D26295: [KCM/Datetime] Convert a foreach, port away from KStandardDirs

This revision was automatically updated to reflect the committed changes. Closed by commit R119:ec0e184791ad: [KCM/Datetime] Convert a foreach, port away from KStandardDirs (authored by meven). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D26295: [KCM/Datetime] Convert a foreach, port away from KStandardDirs

ervin accepted this revision. ervin added inline comments. INLINE COMMENTS > dtime.cpp:165 > + for (const QString _ntputility : possible_ntputilities) { > +auto ntpUtility = QStandardPaths::findExecutable(possible_ntputility, > path); > +if (!ntpUtility.isEmpty()) { nitpick again,

D26289: [KCM/Activity] Make default button work, modernize code

This revision was automatically updated to reflect the committed changes. Closed by commit R119:83b42833a00e: [KCM/Activity] Make default button work, modernize code (authored by meven). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D26295: [KCM/Datetime] Convert a foreach, port away from KStandardDirs

meven updated this revision to Diff 72455. meven added a comment. fix indentation REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26295?vs=72454=72455 BRANCH arcpatch-D26295 REVISION DETAIL https://phabricator.kde.org/D26295 AFFECTED FILES

D26295: [KCM/Datetime] Convert a foreach, port away from KStandardDirs

meven updated this revision to Diff 72454. meven marked an inline comment as done. meven added a comment. fix indentation REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26295?vs=72453=72454 BRANCH arcpatch-D26295 REVISION DETAIL

D26295: [KCM/Datetime] Convert a foreach, port away from KStandardDirs

meven updated this revision to Diff 72453. meven added a comment. make a if conv clearer, convert code to use QStringList more REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26295?vs=72396=72453 BRANCH arcpatch-D26295 REVISION DETAIL

D26229: Add immutability to kcm fonts

This revision was automatically updated to reflect the committed changes. Closed by commit R119:e9d1e940f90b: Add immutability to kcm fonts (authored by bport). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26229?vs=72196=72452 REVISION DETAIL

D26228: KCM Fonts ConfigModule to ManagedConfigModule

This revision was automatically updated to reflect the committed changes. Closed by commit R119:11092af79680: KCM Fonts ConfigModule to ManagedConfigModule (authored by bport). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26228?vs=72450=72451

D26228: KCM Fonts ConfigModule to ManagedConfigModule

bport updated this revision to Diff 72450. bport added a comment. Fix coding style REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26228?vs=72195=72450 REVISION DETAIL https://phabricator.kde.org/D26228 AFFECTED FILES kcms/fonts/fonts.cpp

D26142: KCM Icons: correctly highlight themes installed from Discover

This revision was automatically updated to reflect the committed changes. Closed by commit R119:5b98466e5ddc: KCM Icons: correctly highlight themes installed from Discover (authored by bport). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D24846: Port kcm icons to kconfigxt

This revision was automatically updated to reflect the committed changes. Closed by commit R119:38ba450787ae: Port kcm icons to kconfigxt (authored by bport). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D24846?vs=72189=72446#toc REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST

D24847: KCM Icons fix theme selected when we hit delete theme

This revision was automatically updated to reflect the committed changes. Closed by commit R119:9dacd46f4039: KCM Icons fix theme selected when we hit delete theme (authored by bport). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24847?vs=71669=72447

D26045: Add immutability to KCM Icons

This revision was automatically updated to reflect the committed changes. Closed by commit R119:097ad69d5e8b: Add immutability to KCM Icons (authored by bport). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26045?vs=71957=72448 REVISION DETAIL