D26892: Switch to the old-style button text for the KNSQuick buttons

victorr added a comment. F8013548: Screenshot_20200130_103821.jpeg REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26892 To: leinir, #plasma, davidedmundson Cc: victorr, aacid, yurchor, davidedmundson, kde-i18n-doc,

D26892: Switch to the old-style button text for the KNSQuick buttons

victorr added a comment. The window title is left with double text. Image taken without a network connection, therefore there are no thumbnails. F8013492: Screenshot_20200130_103307.jpeg REPOSITORY R119 Plasma Desktop REVISION DETAIL

D26892: Switch to the old-style button text for the KNSQuick buttons

victorr added a comment. Please add this patch as well. .downloadNewWhat: i18n("Wallpapers") +text: i18nd("plasma_wallpaper_org.kde.image","Get New Wallpapers...") F8013202: plasma-workspace-5.17.98-tr.patch

D26912: Use Qt5 signal syntax, format files, optimizations

mlaurent accepted this revision. mlaurent added a comment. This revision is now accepted and ready to land. seems ok for me now. Thanks REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26912 To: alex, mlaurent, davidedmundson Cc: plasma-devel, Orage,

KDE CI: Plasma » kinfocenter » kf5-qt5 FreeBSDQt5.13 - Build # 93 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kinfocenter/job/kf5-qt5%20FreeBSDQt5.13/93/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 30 Jan 2020 05:02:07 + Build duration: 1 min 20 sec and counting CONSOLE OUTPUT

KDE CI: Plasma » kinfocenter » kf5-qt5 SUSEQt5.12 - Build # 155 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kinfocenter/job/kf5-qt5%20SUSEQt5.12/155/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 30 Jan 2020 05:02:07 + Build duration: 1 min 18 sec and counting CONSOLE OUTPUT [...truncated

D26739: [applets/Task Manager] Refine tooltip highlight effect

ngraham added a comment. Nice find. Fixed in 093e2d917ff386e627a062f3337c9ff23294e95c . Hopefully that's done it! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26739 To:

D26739: [applets/Task Manager] Refine tooltip highlight effect

trmdi added a comment. In D26739#602951 , @ngraham wrote: > Argh, now I can see it too: F8008546: weird margin.webm > > No idea what's causing this. The code seems conceptually right to me. Maybe

D26739: [applets/Task Manager] Refine tooltip highlight effect

ngraham added a comment. Argh, now I can see it too: F8008546: weird margin.webm No idea what's causing this. The code seems conceptually right to me. Maybe something's getting rounded up instead of down or something. REPOSITORY R119 Plasma

D27016: Update from Plasma's ToolTip

trmdi created this revision. trmdi added a reviewer: Latte Dock. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. trmdi requested review of this revision. REVISION SUMMARY Add highlight effect when hovering over the tooltip's thumbnail REPOSITORY R878 Latte Dock

D26892: Switch to the old-style button text for the KNSQuick buttons

victorr added a comment. This is probably a typo? Now there are "Icons". - downloadNewWhat: i18n("Splash Screens") +text: i18n("Get New Icons...") REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26892 To: leinir, #plasma,

D27006: Add .arcconfig

This revision was automatically updated to reflect the committed changes. Closed by commit R1014:d96bd2d45e7e: Add .arcconfig (authored by ndavis). REPOSITORY R1014 Kirigami Gallery CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27006?vs=74623=74635 REVISION DETAIL

D26739: [applets/Task Manager] Refine tooltip highlight effect

filipf added a comment. In D26739#602243 , @trmdi wrote: > In D26739#602082 , @filipf wrote: > > > ^ I can't reproduce that, the patch works as intended for me. (we should investigate this though)

D27011: Update plasma startup sequence README

nicolasfella added inline comments. INLINE COMMENTS > README:37 > > The server is usually started from the 'startkde' script. It supports the > following options: > Isn't this startplasma now? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27011 To:

D27011: Update plasma startup sequence README

davidedmundson updated this revision to Diff 74632. davidedmundson added a comment. review comments REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27011?vs=74631=74632 BRANCH master REVISION DETAIL https://phabricator.kde.org/D27011

D27011: Update plasma startup sequence README

davidedmundson updated this revision to Diff 74631. davidedmundson added a comment. Fix another outdated lie REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27011?vs=74629=74631 BRANCH master REVISION DETAIL https://phabricator.kde.org/D27011

D27011: Update plasma startup sequence README

ognarb added a comment. I think I found some small typos INLINE COMMENTS > README:25 > +which may be 0, 1 or 2 (the default). Kded phase 0 means the module is > +always loaded by kded, even outside of KDE session. It should used only > +by kded modules which must be always running. Kded

D27011: Update plasma startup sequence README

davidedmundson created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY At least half of the stuff ksmserver docuemented was wrong. I like to think plasma-session/startup.cpp is now

D27007: [kcm/standardactions] Don't register kcminit hook when we don't have one

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY There is no exported function called standard_actions. kcminit will link

D27006: Add .arcconfig

ndavis created this revision. ndavis added reviewers: mart, Kirigami. Herald added projects: Plasma, Kirigami. Herald added a subscriber: plasma-devel. ndavis requested review of this revision. REVISION SUMMARY This repo was missing this file, so one had to manually specify the url in order to

D26823: Port connections to new syntax

hpereiradacosta added a comment. In D26823#599100 , @davidedmundson wrote: > > yeah ok. Just noted this. indeed. > > Sorry, I assumed you had seen the thread. > Hope you're ok with it? Sure thing ! The whole thing is more modern

D27003: [kstyle] Port to QWindow::startSystemMove()

zzag updated this revision to Diff 74622. zzag added a comment. Drop UseWMMoveResize option. REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27003?vs=74619=74622 REVISION DETAIL https://phabricator.kde.org/D27003 AFFECTED FILES kstyle/breeze.kcfg

D27003: [kstyle] Port to QWindow::startSystemMove()

zzag updated this revision to Diff 74619. zzag added a comment. Get rid of _cursorOverride REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27003?vs=74617=74619 REVISION DETAIL https://phabricator.kde.org/D27003 AFFECTED FILES

D27003: [kstyle] Port to QWindow::startSystemMove()

zzag added a comment. https://www.youtube.com/watch?v=tPh7U9otpy4 REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D27003 To: zzag, #kwin, #plasma, hpereiradacosta Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen,

D27004: [kstyle] Drop XCB and KWayland dependency

zzag created this revision. zzag added reviewers: Plasma, hpereiradacosta. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. zzag requested review of this revision. REVISION SUMMARY They are not used anywhere. REPOSITORY R31 Breeze REVISION DETAIL

D27003: [kstyle] Port to QWindow::startSystemMove()

zzag created this revision. zzag added reviewers: KWin, Plasma, hpereiradacosta. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. zzag requested review of this revision. REVISION SUMMARY QWindow::startSystemMove() is a new feature in Qt 5.15 that provides a

D26889: Change notification button text to "View Updates"

This revision was automatically updated to reflect the committed changes. Closed by commit R134:7126e11498ac: Change notification button text to View Updates (authored by ngraham). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE

D24070: [WIP] Don't use toolTipMainText to show info, rather use the second line

ngraham added a comment. Ping. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24070 To: ngraham, #vdg, #plasma, ndavis, mthw Cc: GB_2, ndavis, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot,

D26979: KWallet-PAM SELinux context transition support

davidedmundson added inline comments. INLINE COMMENTS > CMakeLists.txt:17 > +find_library(SELINUX selinux) > > find_program(SOCAT_EXECUTABLE socat) instead of message() set_package_properties(SELINUX PROPERTIES DESCRIPTION "some security thing" TYPE OPTIONAL

D26640: [applets/weather] Port weather station picker to QQC2+ListView

ngraham added a comment. Ping. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D26640 To: ngraham, #vdg, #plasma, broulik Cc: fvogt, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin,

D26845: [context menu] Remove last traces of "Lock Widgets" action from UI

ngraham added a comment. Ping. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26845 To: ngraham, mart, #plasma Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf,

D26882: [Applets/Folder] Re-arrange positioning of "Arrange in" and "Align" submenus

ngraham added a comment. Ping. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26882 To: ngraham, hein, #vdg Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf,

D26884: [Folder View] Fix text label color in pop-up

ngraham added a comment. Ping. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26884 To: ngraham, #vdg, #plasma, hein, davidedmundson Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham,

D26271: [Applet]Update layout based on T10470

ngraham added a comment. I applied the patches in this series and tested and went through the code again and everything looks good to me. Shall we start landing them for 5.19? We can always tweak things later; there's loads of time before the next release. REPOSITORY R115 Plasma Audio

D27000: [kstyle] Drop Helper::connection()

This revision was automatically updated to reflect the committed changes. Closed by commit R31:9b20726184e4: [kstyle] Drop Helper::connection() (authored by zzag). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27000?vs=74605=74607 REVISION DETAIL

D26978: [kstyle] Use QX11Info::isCompositingManagerRunning()

This revision was automatically updated to reflect the committed changes. Closed by commit R31:932e5dc45410: [kstyle] Use QX11Info::isCompositingManagerRunning() (authored by zzag). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26978?vs=74606=74608 REVISION

D27000: [kstyle] Drop Helper::connection()

hpereiradacosta accepted this revision. hpereiradacosta added a comment. This revision is now accepted and ready to land. thanks ! REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D27000 To: zzag, hpereiradacosta Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev,

D26978: [kstyle] Use QX11Info::isCompositingManagerRunning()

zzag updated this revision to Diff 74606. zzag added a comment. update REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26978?vs=74598=74606 BRANCH use-qx11info-is-compositing-manager-active REVISION DETAIL https://phabricator.kde.org/D26978 AFFECTED

D27000: [kstyle] Drop Helper::connection()

zzag created this revision. zzag added a reviewer: hpereiradacosta. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. zzag requested review of this revision. REVISION SUMMARY Since Qt 4 style plugin had been dropped, we can use QX11Info::connection() directly.

D26998: Fix new user creation

This revision was automatically updated to reflect the committed changes. Closed by commit R128:184a544cdef0: Fix new user creation (authored by meven). REPOSITORY R128 User Manager CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26998?vs=74602=74604 REVISION DETAIL

D26998: Fix new user creation

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Ignore my ramblings. Seems to work, and the logic makes sense REPOSITORY R128 User Manager BRANCH master REVISION DETAIL https://phabricator.kde.org/D26998 To:

D26998: Fix new user creation

davidedmundson added a comment. I had deleted if (m_newUserData.isEmpty()) { return true; } which is effectively the same thing. and I was catting /etc/shadow to see if it was blank or not as my test Let me completely everything and retry with this.

D26999: [Notifications] Fix action button size

broulik created this revision. broulik added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY This never was a `Layout`, so this never worked, but they were supposed to be sized to fit.

D26998: Fix new user creation

meven added a comment. In D26998#602676 , @davidedmundson wrote: > I reached that same conclusion late last night (so in a sense ), and abandoned the other patch thinking I had everything understood. > > But then I tried it and it

D26998: Fix new user creation

davidedmundson added a comment. I reached that same conclusion late last night (so in a sense ), and abandoned the other patch thinking I had everything understood. But then I tried it and it didn't work. REPOSITORY R128 User Manager REVISION DETAIL

D26998: Fix new user creation

meven created this revision. meven added reviewers: ngraham, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REVISION SUMMARY UserAdded was called only when other parameters were provided for a new user beside

D26978: [kstyle] Use QX11Info::isCompositingManagerRunning()

zzag added a comment. In D26978#602655 , @hpereiradacosta wrote: > In principle, the removal of Helper::connection, although is a change unrelated to the commit purpose. Maybe put it in a different commit ? Will do. (I removed it as a

D26978: [kstyle] Use QX11Info::isCompositingManagerRunning()

hpereiradacosta accepted this revision. hpereiradacosta added a comment. This revision is now accepted and ready to land. Makes sense, thanks ! In principle, the removal of Helper::connection, although is a change unrelated to the commit purpose. Maybe put it in a different commit ?

D26978: [kstyle] Use QX11Info::isCompositingManagerRunning()

zzag updated this revision to Diff 74598. zzag added a comment. Fix coding style. REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26978?vs=74539=74598 BRANCH use-qx11info-is-compositing-manager-active REVISION DETAIL https://phabricator.kde.org/D26978

D21226: search for a default wallpaper in lookandfeel

rikmills added a comment. Would this handle the case where an existing look-and-feel package that did NOT specify a wallpaper, then in a new version adds one? And that occurs on a users system the l-n-f package was already active and plasma is long past 1st plasma start. REPOSITORY R120

D26993: [libkworkspace] Introduce UpdateLaunchEnvJob

davidedmundson added a comment. +++ Lets port some usages, so we can confirm it works in practice, but this looks good INLINE COMMENTS > updatelaunchenvjob.cpp:79 > + > +// Startup (effectively KSMServer) > +org::kde::Startup startup(QStringLiteral("org.kde.Startup"), Not

D26993: [libkworkspace] Introduce UpdateLaunchEnvJob

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY This is supposed to replace manual DBus calls to `KLauncher` `setLaunchEnv` done in e.g. the

D26992: [SystemTray] Use unified data model everywhere

kmaterka added a comment. This change is very big. I can try to split in into two (maybe more) id that's required. If yes, should I connect revisions somehow? Create task, add parent/child revision? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26992

D26992: [SystemTray] Use unified data model everywhere

kmaterka created this revision. kmaterka added reviewers: Plasma: Workspaces, Plasma, davidedmundson, ngraham, broulik. kmaterka added a project: Plasma. kmaterka requested review of this revision. REVISION SUMMARY Use the unified data model everywhere, not just in configuration. This

D26985: [Panel Shadows] Un-constify QWindow parameters

This revision was automatically updated to reflect the committed changes. Closed by commit R120:bb60002b1340: [Panel Shadows] Un-constify QWindow parameters (authored by zzag). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26985?vs=74555=74585

D21226: search for a default wallpaper in lookandfeel

This revision was automatically updated to reflect the committed changes. Closed by commit R120:670f3ec50456: search for a default wallpaper in lookandfeel (authored by mart). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D21226?vs=58130=74583#toc REPOSITORY R120 Plasma Workspace

D26972: Work around an issue with changing the wallpaper's filetype

ngraham added a comment. I didn't have the cache patch installed, but I probably forgot to delete the wallpapers from one of the several on-disk locations where they live. :/ reverted in bfe2152c5ef73e9f5b7ad03313f3a4ccef440a22

D21225: set the wallpaper when applying look and feel

ngraham added a comment. I have a feeling we'll get user complaints and bug reports if we unconditionally reset the wallpaper when applying a global theme. Before we do this, I think we need to add a mechanism to allow the user to choose which parts get applied, per the discussion in

D26842: Fix fonts KCM button state

ngraham added a comment. We are getting duplicates of https://bugs.kde.org/show_bug.cgi?id=416358, so I guess it would be nice if this made it into 5.18. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26842 To: bport, #plasma, ervin, crossi, meven Cc:

D26986: WIP-NotWorking: Try to fix flicker of screen while locked and detaching screens

zzag added a comment. Sorry, I know little to nothing about internals of KScreenLocker. REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D26986 To: tcanabrava Cc: zzag, davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus,

D26842: Fix fonts KCM button state

bport updated this revision to Diff 74576. bport added a comment. fix coding style REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26842?vs=74127=74576 REVISION DETAIL https://phabricator.kde.org/D26842 AFFECTED FILES kcms/fonts/fonts.cpp

D26842: Fix fonts KCM button state

bport added inline comments. INLINE COMMENTS > meven wrote in fonts.cpp:473 > Just a nitpick, I guess you plan to change it soon. It will be changed when we migrate this part to kconfigxt REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26842 To: bport,

D25634: Add kconf update script for ksmserver

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R119:6dc8da6c9539: Add kconf update script for ksmserver (authored by davidedmundson). REPOSITORY R119 Plasma Desktop

D26842: Fix fonts KCM button state

meven added inline comments. INLINE COMMENTS > meven wrote in fonts.cpp:473 > You can make this static. Just a nitpick, I guess you plan to change it soon. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26842 To: bport, #plasma, ervin, crossi, meven Cc:

D25634: Add kconf update script for ksmserver

davidedmundson added a comment. [Monday, 27 January 2020] [16:02:16 GMT] Alright then it looks reasonable to me Treating that as an approval REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25634 To: davidedmundson, #plasma Cc: broulik, plasma-devel,

D26842: Fix fonts KCM button state

bport added inline comments. INLINE COMMENTS > ervin wrote in fontssettings.kcfg:77 > I guess this depends on how the font get serialized... and looking into > KConfig we use toString() so stylename will appear AFAICT. This is only the default value, and default value will be not bold or

D26986: WIP-NotWorking: Try to fix flicker of screen while locked and detaching screens

tcanabrava updated this revision to Diff 74565. tcanabrava added a comment. - Simplify Architecture REPOSITORY R133 KScreenLocker CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26986?vs=74556=74565 BRANCH wip_fix_screenlocker_detach_reattach REVISION DETAIL

D26784: KCM KDED: Add immutability and fix default, reset, apply buttons

This revision was automatically updated to reflect the committed changes. Closed by commit R119:69ac53df265e: KCM KDED: Add immutability and fix default, reset, apply buttons (authored by bport). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D21225: set the wallpaper when applying look and feel

davidedmundson added a comment. I'm not completely blocking this, but I have two concerns with this patch: -- 1. wallpaper is somewhat different to the other configs, I'm not super convinced we want to reset it without prompts -- 2. the resetting has

KDE CI: Plasma » drkonqi » kf5-qt5 WindowsMSVCQt5.14 - Build # 3 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.14/3/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Wed, 29 Jan 2020 13:04:30 + Build duration: 2 min 37 sec and counting CONSOLE OUTPUT

D26894: Enable publication of API dox on api.kde.org

kossebau added a comment. For KDEPIM, the definition is in the akonadi repo: https://phabricator.kde.org/source/akonadi/browse/master/metainfo.yaml REPOSITORY R129 Window Decoration Library REVISION DETAIL https://phabricator.kde.org/D26894 To: kossebau, #kwin, graesslin, zzag Cc:

D26894: Enable publication of API dox on api.kde.org

kossebau added a comment. In D26894#602388 , @davidedmundson wrote: > Go for it. > > > If so, this change should trigger addition of KDecoration on api.kde.org, similar like KAsync is currently at the toplevel. > > If we could make a

D26894: Enable publication of API dox on api.kde.org

davidedmundson added a comment. Go for it. > If so, this change should trigger addition of KDecoration on api.kde.org, similar like KAsync is currently at the toplevel. If we could make a plasma subcategory, that would be great. We have some other potential libs to add. There's a

D26894: Enable publication of API dox on api.kde.org

This revision was automatically updated to reflect the committed changes. Closed by commit R129:e08b848015f5: Enable publication of API dox on api.kde.org (authored by kossebau). REPOSITORY R129 Window Decoration Library CHANGES SINCE LAST UPDATE

D26986: WIP-NotWorking: Try to fix flicker of screen while locked and detaching screens

tcanabrava added a comment. In D26986#602373 , @davidedmundson wrote: > This is definitely an area for improvement. > > This code was initially written before QGuiApplication::screenRemoved existed, which is why it's like this. > I think

D26894: Enable publication of API dox on api.kde.org

kossebau added a comment. So, with only positive feedback so far I would be going to merge this on 31st Jan. Or earlier, if you tell me :) REPOSITORY R129 Window Decoration Library REVISION DETAIL https://phabricator.kde.org/D26894 To: kossebau, #kwin, graesslin Cc: zzag, plasma-devel,

D26894: Enable publication of API dox on api.kde.org

kossebau updated this revision to Diff 74558. kossebau added a comment. keep Martin noted as maintainer, given no official step-down rebase to latest master REPOSITORY R129 Window Decoration Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26894?vs=74305=74558 BRANCH

D26986: WIP-NotWorking: Try to fix flicker of screen while locked and detaching screens

davidedmundson added a comment. This is definitely an area for improvement. This code was initially written before QGuiApplication::screenRemoved existed, which is why it's like this. I think this solution is overly complex, you have the pointer to what changed in screenRemoved, we

D21226: search for a default wallpaper in lookandfeel

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. So default wallpaper is effectively via any of: - The active LNF - the plasma theme - LNF/layout.js - desktoppackage/layout.js - containment specific override

D26986: WIP-NotWorking: Try to fix flicker of screen while locked and detaching screens

tcanabrava created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. tcanabrava requested review of this revision. REVISION SUMMARY This patch tries - and fails - to fix the flicker of screens while the kscreenlocker_greeter is active. The reasoning of

D26985: [Panel Shadows] Un-constify QWindow parameters

zzag created this revision. zzag added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. zzag requested review of this revision. REVISION SUMMARY It doesn't make sense to pass const `QWindow`s to `PanelShadows` because a `KWindowShadow` needs a

D26972: Work around an issue with changing the wallpaper's filetype

broulik added a comment. This doesn't work. The image doesn't load. `QImage` shortcuts when it sees a ".png". Are you sure you didn't leave the old wallpaper in the folder when you tested this? Or even had your "wallpaper cache" attempt patch still applied? REPOSITORY R31 Breeze

D26972: Work around an issue with changing the wallpaper's filetype

bshah added a comment. This doesn't work on neon dev unstable and actually breaks the wallpaper. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D26972 To: ngraham, davidedmundson, #plasma, ognarb Cc: bshah, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh,

D26965: [Emojier] Copy Emoji also into selection clipboard

This revision was automatically updated to reflect the committed changes. Closed by commit R119:6175428b2e80: [Emojier] Copy Emoji also into selection clipboard (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26965?vs=74496=74548

D26981: [startkde] Export LC_TIME again

This revision was automatically updated to reflect the committed changes. Closed by commit R120:bc34f232b7cd: [startkde] Export LC_TIME again (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26981?vs=74545=74546 REVISION DETAIL

D26981: [startkde] Export LC_TIME again

davidedmundson added a comment. I win! https://phabricator.kde.org/D26980 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26981 To: broulik, #plasma Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas,

D26981: [startkde] Export LC_TIME again

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY BUG: 416670 FIXED-IN: 5.18.0 TEST PLAN None. REPOSITORY R120 Plasma Workspace REVISION

D26834: libnotificationmanager : deprecate Settings ctor that takes a config

ervin added inline comments. INLINE COMMENTS > settings.cpp:40 > +{ > +static const char s_configFile[] = "plasmanotifyrc"; > +} I don't think that's what Kai had in mind regarding his comment. @broulik could you confirm? REPOSITORY R120 Plasma Workspace REVISION DETAIL

D26980: Sync LC_TIME

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY It's written out by the formats KCM, but wasn't loaded here BUG: 416670