D27998: Add workspace kcm option for dndToMove

trmdi created this revision. trmdi added reviewers: VDG, Plasma, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. trmdi requested review of this revision. REVISION SUMMARY Add gui for the new `dndToMove` option. Depend: D27951

[kio-extras] [Bug 354004] smb kioslave timeouts looking for kerberos authentication

https://bugs.kde.org/show_bug.cgi?id=354004 Bug Janitor Service changed: What|Removed |Added Status|NEEDSINFO |RESOLVED

D27954: appstreamrunner: Port to KApplicationTrader

dfaure accepted this revision. dfaure added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > appstreamrunner.cpp:102 > +return true; > +} else { > +const auto renamedFrom = >

D27972: [NightColor] fix for plasmoid status and tooltip subtext

pdabrowski updated this revision to Diff 77473. REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27972?vs=77472=77473 REVISION DETAIL https://phabricator.kde.org/D27972 AFFECTED FILES applets/nightcolor/package/contents/ui/main.qml

D27972: [NightColor] fix for plasmoid status and tooltip subtext

pdabrowski marked an inline comment as done. pdabrowski added a comment. In D27972#625596 , @zzag wrote: > > Fix for NightColor plasmoid active/passive status > > Could you please describe what's wrong with it right now? I wanted the

D27972: [NightColor] fix for plasmoid status and tooltip subtext

pdabrowski marked an inline comment as done. pdabrowski added inline comments. INLINE COMMENTS > zzag wrote in main.qml:36-38 > We want to keep the applet visible even if Night Color is inhibited so user > can quickly uninhibit it. With this patch, the user would have to click the > system

D27972: [NightColor] fix for plasmoid status and tooltip subtext

pdabrowski updated this revision to Diff 77472. pdabrowski edited the summary of this revision. pdabrowski added a comment. new patch REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27972?vs=77379=77472 REVISION DETAIL

D27954: appstreamrunner: Port to KApplicationTrader

apol added inline comments. INLINE COMMENTS > dfaure wrote in appstreamrunner.cpp:96 > Note that the original trader query used =~ which meant "case insensitive > comparison". > I have no idea if it was necessary though. Might have just chosen the wrong operator, it's part of the problem of

D27954: appstreamrunner: Port to KApplicationTrader

apol updated this revision to Diff 77469. apol added a comment. Remove unnecessary check REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27954?vs=77306=77469 BRANCH master REVISION DETAIL https://phabricator.kde.org/D27954 AFFECTED FILES

D27954: appstreamrunner: Port to KApplicationTrader

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. Cool to see KApplicationTrader being used :-) INLINE COMMENTS > appstreamrunner.cpp:96 > + > +if (service->desktopEntryName() == componentId) > +

D27996: Fix undefined check in global drawer menu mode

nicolasfella marked an inline comment as done. nicolasfella added inline comments. INLINE COMMENTS > apol wrote in PageRowGlobalToolBarUI.qml:49 > Wouldn't it be easier to do: > > visible: !Kirigami.Settings.isMobile && applicationWindow().globalDrawer && >

D27996: Fix undefined check in global drawer menu mode

nicolasfella updated this revision to Diff 77465. nicolasfella added a comment. - use 'in' REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27996?vs=77458=77465 BRANCH fixkamoso REVISION DETAIL https://phabricator.kde.org/D27996 AFFECTED FILES

D27996: Fix undefined check in global drawer menu mode

apol added inline comments. INLINE COMMENTS > PageRowGlobalToolBarUI.qml:49 > id: menuButton > -visible: !Kirigami.Settings.isMobile && > applicationWindow().globalDrawer && applicationWindow().globalDrawer.isMenu > !== "undefined" &&

D27914: [Kilpper] Port QRegExp to QRegularExpression

ahmadsamir added a comment. Ping. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27914 To: ahmadsamir, #plasma Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf,

D27996: Fix undefined check in global drawer menu mode

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Hah I was just investigating this the other day but couldn't find it. This makes sense. REPOSITORY R169 Kirigami BRANCH fixkamoso REVISION DETAIL

D27996: Fix undefined check in global drawer menu mode

nicolasfella created this revision. nicolasfella added reviewers: Kirigami, mart. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. REVISION SUMMARY Kamoso uses Overlaydrawer instead of GlobalDrawer, which has no isMenu

D27917: [Baloo] Fix firstRun and config change logic

This revision was automatically updated to reflect the committed changes. Closed by commit R119:550cf9cafb19: [Baloo] Fix firstRun and config change logic (authored by bruns). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27917?vs=77183=77456

D27984: [WIP] Add a ShadowedRectangle item

mart added a comment. tested it locally, works beautifully REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D27984 To: ahiemstra, #kirigami Cc: mart, cblack, zzag, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, ahiemstra, davidedmundson

D27985: Include s_kcrashErrorMessage in our traces

apol updated this revision to Diff 77452. apol added a comment. Include a usage in the test app, adapt to changes in kcrash REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27985?vs=77424=77452 BRANCH master REVISION DETAIL

D27984: [WIP] Add a ShadowedRectangle item

ahiemstra updated this revision to Diff 77446. ahiemstra added a comment. - Remove QRectF parameter from ShadowedRectNode ctor - Properly initialize offset and aspect ratio variables of ShadowedRectNode REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE

D27984: [WIP] Add a ShadowedRectangle item

ahiemstra added a comment. For appearance: F8171055: Peek 2020-03-11 18-28.mp4 REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D27984 To: ahiemstra, #kirigami Cc: cblack, zzag, plasma-devel, fbampaloukas, GB_2, domson,

D27984: [WIP] Add a ShadowedRectangle item

ahiemstra added a comment. In D27984#625969 , @cblack wrote: > Attributes of a shadow (size/radius, offsets) Performance isn't going to be much different between any of these properties, except that a few will be slightly faster because

D27785: [Fonts KCM] Change how nearestExistingFonts() finds a matching font

ahmadsamir updated this revision to Diff 77442. ahmadsamir retitled this revision from "[Fonts KCM] Change setNearestExistingFonts() to set the fonts only when necessary" to "[Fonts KCM] Change how nearestExistingFonts() finds a matching font". ahmadsamir edited the summary of this revision.

D27984: [WIP] Add a ShadowedRectangle item

ahiemstra updated this revision to Diff 77436. ahiemstra added a comment. - Convert to SPDX identifiers REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27984?vs=77430=77436 BRANCH shadowrect_distancefield REVISION DETAIL

D27985: Include s_kcrashErrorMessage in our traces

sitter added a comment. Probably should also get added to one of the parser tests to make sure it doesn't fall on the face. Talking about parser, I feel like this might benefit from highlighting somehow, currently it's very squished in with the random stuff in the header. That'll make

D27984: [WIP] Add a ShadowedRectangle item

cblack added a comment. In D27984#625964 , @ahiemstra wrote: > In D27984#625933 , @cblack wrote: > > > How does the shadow look and perform when animating? > > > Animating what?

D27984: [WIP] Add a ShadowedRectangle item

ahiemstra added a comment. In D27984#625933 , @cblack wrote: > I feel like a border property would be desirable for the following usecases: > > - Cards that have no elevation when resting > - Fallback for when shadows are too heavy

D27984: [WIP] Add a ShadowedRectangle item

ahiemstra reopened this revision. ahiemstra added a comment. Argh I hate arc REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D27984 To: ahiemstra, #kirigami Cc: cblack, zzag, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, ahiemstra,

D27979: [WIP] Add top area to notifications

ngraham added a comment. In D27979#625943 , @niccolove wrote: > In D27979#625809 , @broulik wrote: > > > Please also test with icons and configure button, I use

D27987: Fix inverse scaling calculation with regards to offset

ahiemstra created this revision. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. ahiemstra requested review of this revision. REPOSITORY R169 Kirigami BRANCH shadowrect_distancefield REVISION DETAIL https://phabricator.kde.org/D27987 AFFECTED FILES

D27984: [WIP] Add a ShadowedRectangle item

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R169:4a2ced7919b5: Add ElevatedRectangle object (authored by ahiemstra). CHANGED PRIOR TO COMMIT

D27979: [WIP] Add top area to notifications

niccolove added a comment. In D27979#625809 , @broulik wrote: > Please also test with icons and configure button, I use https://tests.peter.sh/notification-generator/ which can generate a multitude of test notifications Yepp, I did test

Re: Proposal to centralize KCM bugs inside the systemsettings product

The bugs in those products that affect their KCMs were moved into the systemsettings products. fFr print-manager, bugs in the applet were moved into plasmashell. Other bugs were not moved. So it it normal that there are still bugs in print-manager, plasma-nm, etc; they are bugs that don't

D27984: [WIP] Add a ShadowedRectangle item

cblack added a comment. I feel like a border property would be desirable for the following usecases: - Cards that have no elevation when resting - Fallback for when shadows are too heavy How does the shadow look and perform when animating? REPOSITORY R169 Kirigami REVISION

D27984: [WIP] Add a ShadowedRectangle item

ahiemstra updated this revision to Diff 77427. ahiemstra added a comment. - Add a manual test REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27984?vs=77421=77427 BRANCH shadowrect_distancefield REVISION DETAIL https://phabricator.kde.org/D27984

D27984: [WIP] Add a ShadowedRectangle item

ahiemstra added a comment. Yeah I can't upload screenshots etc. through Arc so I always need to upload those afterwards. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D27984 To: ahiemstra, #kirigami Cc: zzag, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos,

D27984: [WIP] Add a ShadowedRectangle item

zzag added a comment. Are there any significant differences between shadows that were generated using distance fields and shadows that were generated with a blur filter(e.g. box blur or stack blur, etc)? (asking out of curiosity) REPOSITORY R169 Kirigami REVISION DETAIL

Re: Proposal to centralize KCM bugs inside the systemsettings product

I still see bugs in e.g. https://bugs.kde.org/buglist.cgi?component=general_id=1723750=print-manager=--- and https://bugs.kde.org/buglist.cgi?component=general_id=1723749=plasma-nm=--- so have they been moved? I use this script to update the Bugzilla products with new versions when I make a

Re: Moving bugzilla components

On 3/11/20 9:39 AM, David Edmundson wrote: It was not sent to this mailing list. After some searching Kai says it was sent to plasma-bugs, a ml which isn't subscribed to directly but used (by me at least) only for bugzilla user watching. Probably explains the lack of response too. In that

Fwd: Proposal to centralize KCM bugs inside the systemsettings product

Forwarding to plasma-devel at David Edmundson's request because I originally sent this to the wrong mailing lists. Will send future such emails to plasma-devel, sorry about that. FWIW the proposed changes were already made, so this is mostly for visibility and record-keeping at this point.

D27985: Include s_kcrashErrorMessage in our traces

apol created this revision. apol added reviewers: Frameworks, sitter. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY CCBUG: 375913 TEST PLAN Called `kill -SIGSEGV plasma-discover` and got to see the string I

D27982: use better strings for dri devices

sitter added inline comments. INLINE COMMENTS > ngraham wrote in opengl.cpp:284 > What does "Card" mean in this context? A graphics card? Relates to D27980 a card here is a "3D Accelerator" "Card". whatever that means... It's a graphics card essentially,

Re: Moving bugzilla components

On Wed, 11 Mar 2020, 15:05 Nate Graham, wrote: > On 3/10/20 11:11 PM, David Edmundson wrote: > > As a reminder, bugzilla components should not be moved without prior > > discussion with maintainers. > > > > @nate please inform everyone of the bulk changes made and we'll see > > which we keep. >

D27980: make opengl module support multiple dri devices

sitter added inline comments. INLINE COMMENTS > apol wrote in opengl.cpp:281 > Probably only want to list files? Dirs actually, e.g. /proc/dri/0/name I honestly do not know what they are so I figured best to just list everything. They could be symlinks for all I know. /proc/dri/ isn't a thing

D27979: [WIP] Add top area to notifications

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Please test to make sure that your patches work :) INLINE COMMENTS > NotificationItem.qml:114 > > -NotificationHeader { > -id: notificationHeading > -

D27984: [WIP] Add a ShadowedRectangle item

ahiemstra created this revision. ahiemstra added a reviewer: Kirigami. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. ahiemstra requested review of this revision. REVISION SUMMARY This adds a ShadowedRectangle item, which is a rectangle with a shadow. It uses a

D27980: make opengl module support multiple dri devices

zzag added a comment. I'm not sure whether this is useful, but libdrm has an API to enumerate devices. REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D27980 To: sitter Cc: zzag, apol, adridg, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh,

D27980: make opengl module support multiple dri devices

apol added subscribers: adridg, apol. apol added a comment. +1 overall INLINE COMMENTS > opengl.cpp:278 > + > +static QList get_dri_devices_proc() > { I'd make it QVector, less to worry in the future. > opengl.cpp:281 > +QList list; > +const auto entries =

D27982: use better strings for dri devices

ngraham added inline comments. INLINE COMMENTS > opengl.cpp:284 > auto info = get_dri_device_proc(QStringLiteral("/proc/dri/") + entry > + QStringLiteral("/name")); > -info.deviceId = entry; > +info.deviceId = i18nc("%1 is a DRI card index integer", "Card %1", >

D27979: Added top area to notifications

broulik added a comment. Please also test with icons and configure button, I use https://tests.peter.sh/notification-generator/ which can generate a multitude of test notifications INLINE COMMENTS > NotificationPopup.qml:168 > // let the item bleed into the dialog margins

Re: Moving bugzilla components

On 3/10/20 11:11 PM, David Edmundson wrote: As a reminder, bugzilla components should not be moved without prior discussion with maintainers. @nate please inform everyone of the bulk changes made and we'll see which we keep. The last time I performed this kind of Bugzilla maintenance

D27189: Created a top area based on widgets/toparea.svg

niccolove updated this revision to Diff 77416. niccolove added a comment. Trailing spaces REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27189?vs=77412=77416 BRANCH systray_toparea (branched from master) REVISION DETAIL

D27981: strip non prtinable characters from opengl dri info

sitter created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sitter requested review of this revision. REVISION SUMMARY previously this was incorrectly indented was | Vendor | \s\s\s\s\s\s\s\sFoobar | | is now | Vendor | Foobar |

D27982: use better strings for dri devices

sitter created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sitter requested review of this revision. REVISION SUMMARY the /proc based fallback was using the raw entry name (number) to avoid a new string in 5.18. the Accelerator grouping entry

D27189: Created a top area based on widgets/toparea.svg

niccolove updated this revision to Diff 77412. niccolove added a comment. Third one's a charm REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27189?vs=77411=77412 BRANCH systray_toparea (branched from master) REVISION DETAIL

D27980: make opengl module support multiple dri devices

sitter created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sitter requested review of this revision. REVISION SUMMARY previously the code would only ever look at dri0 when that may not actually be the device that is used. instead list all possible

D27189: Created a top area based on widgets/toparea.svg

niccolove updated this revision to Diff 77411. niccolove added a comment. Second try of getting rid of unrelated changes REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27189?vs=77410=77411 BRANCH topbar (branched from master) REVISION DETAIL

D27189: Created a top area based on widgets/toparea.svg

niccolove updated this revision to Diff 77410. niccolove added a comment. Trying to get rid of unrelated changes REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27189?vs=77409=77410 BRANCH topbar (branched from master) REVISION DETAIL

D27189: Created a top area based on widgets/toparea.svg

niccolove updated this revision to Diff 77409. niccolove added a comment. - Merge branch 'master' into topbar REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27189?vs=76823=77409 BRANCH topbar (branched from master) REVISION DETAIL

D27697: WIP: Added top area to notification header

niccolove added a comment. Opened another one due to i-messed-up-arc-again: https://phabricator.kde.org/D27979 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27697 To: niccolove, broulik, ngraham Cc: ngraham, broulik, plasma-devel, Orage, LeGast00n,

D27979: Added top area to notifications

niccolove created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. niccolove requested review of this revision. REVISION SUMMARY Added the new PlasmoidHeading component to notifications, see: (...) This also adds it to the notifications in the history,

D27978: [FormLayout] Propagate FormData.enabled also to label

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Allows to mark the section as disabled even when the control itself is not, e.g. when you have

D27421: [Cuttleffish] Use proper QSortFilterProxyModel

This revision was automatically updated to reflect the committed changes. Closed by commit R118:2bae103fa66e: [Cuttleffish] Use proper QSortFilterProxyModel (authored by davidre). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D27421?vs=77171=77399#toc REPOSITORY R118 Plasma SDK

Re: Proposal: Dynamic Wallpapers in Plasma

On 3/11/20 10:45 AM, Kai Uwe Broulik wrote: It appears there's a need for a collection/dict API in QImageReader either way. Uh, maybe. At least, applications such as Gwenview need to know the difference between image sequences and image collections in order to display them correctly.

Re: Moving bugzilla components

On Wed, Mar 11, 2020 at 6:12 PM David Edmundson wrote: > > As a reminder, bugzilla components should not be moved without prior > discussion with maintainers. > > @nate please inform everyone of the bulk changes made and we'll see which we > keep. Please also note that bulk changes which are

Re: Proposal: Dynamic Wallpapers in Plasma

Hi, According to Qt documentation, if QImageReader::imageCount() returns a positive number, it means that the file contains an animated image. And that isn't even true. An ICO (windows icon file) has all its contained pixmap sizes and depths as a flat list. E.g. in the windows icon

Re: Proposal: Dynamic Wallpapers in Plasma

On 3/11/20 8:08 AM, David Edmundson wrote: We need to tweak the name as we have many wallpapers that are dynamic. This is a specific subset within that. Yes, agreed! I'm open to suggestions. ;-) Code wise, we have both sun positions and clock skew management in the time dataengine already.

D27915: Use breeze icons for categories

This revision was automatically updated to reflect the committed changes. Closed by commit R119:7a6e8f3bc52a: Use breeze icons for categories (authored by Guo Yunhe i...@guoyunhe.me). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27915?vs=77174=77392

D27972: [NightColor] fix for plasmoid status and tooltip subtext

zzag added inline comments. INLINE COMMENTS > main.qml:36-38 > -if (inhibitor.state != Inhibitor.Uninhibited) { > -return PlasmaCore.Types.ActiveStatus; > } We want to keep the applet visible even if Night Color is inhibited so user can quickly uninhibit it. With

D27972: [NightColor] fix for plasmoid status and tooltip subtext

zzag added a comment. > Fix for NightColor plasmoid active/passive status Could you please describe what's wrong with it right now? REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D27972 To: pdabrowski, #plasma, zzag, ngraham Cc: plasma-devel, Orage,

Re: Moving bugzilla components

On 3/11/20 7:11 AM, David Edmundson wrote: As a reminder, bugzilla components should not be moved without prior discussion with maintainers. @nate please inform everyone of the bulk changes made and we'll see which we keep. David What components were moved?

Re: Proposal: Dynamic Wallpapers in Plasma

We need to tweak the name as we have many wallpapers that are dynamic. This is a specific subset within that. Code wise, we have both sun positions and clock skew management in the time dataengine already. I'm fine for things becoming public qml plugins instead of dataengines using that code,