D28306: [applets/taskmanager] Make the hover state clarifying, but not main

This revision was automatically updated to reflect the committed changes. Closed by commit R119:488c4b746d68: [applets/taskmanager] Make the hover state clarifying, but not main (authored by epopov, committed by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D28129: Read the new message string after rather than before

apol updated this revision to Diff 78605. apol added a comment. Don't leak REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28129?vs=78604=78605 BRANCH arcpatch-D28129 REVISION DETAIL https://phabricator.kde.org/D28129 AFFECTED FILES

D28129: Read the new message string after rather than before

apol updated this revision to Diff 78604. apol marked 3 inline comments as done. apol added a comment. Rebase on top of ksyntaxhighlighting, works great REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28129?vs=78117=78604 BRANCH arcpatch-D28129 REVISION

D28306: Make the hover state clarifying, but not main

epopov updated this revision to Diff 78599. epopov added a comment. Fix hover state for pinned launchers REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28306?vs=78580=78599 REVISION DETAIL https://phabricator.kde.org/D28306 AFFECTED FILES

D28321: [WIP] [applets/devicenotifier] Port to ExpandableListItem

ngraham created this revision. ngraham added reviewers: VDG, Plasma, broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY WIP because of the TODOs at the top of the file in `DeviceItem.qml`. Assistance

D28086: Improve CMake handling of GNOME libraries

cblack updated this revision to Diff 78590. cblack added a comment. Drop giomm REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28086?vs=77833=78590 BRANCH arcpatch-D28086 REVISION DETAIL https://phabricator.kde.org/D28086 AFFECTED

D28318: [controls/formlayout] Don't attempt to reset implicitWidth

This revision was automatically updated to reflect the committed changes. Closed by commit R169:9b6ec041936a: [controls/formlayout] Dont attempt to reset implicitWidth (authored by cblack). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28318?vs=78585=78589

D28306: Make the hover state clarifying, but not main

ngraham added a comment. This does introduce a visual change: the hover effect now adds a blue background, even for un-launched pinned launchers. Currently the hover effect for pinned launchers is just a lightening of the icon itself. I'm not against it, but this is a visual change that

D28318: [controls/formlayout] Don't attempt to reset implicitWidth

cblack created this revision. cblack added a reviewer: Kirigami. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. cblack requested review of this revision. REVISION SUMMARY When a FormLayout is in wide mode, it attempts to reset the implicitWidth of a GridLayout by

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ngraham created this revision. ngraham added reviewers: VDG, Breeze. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY This patch adjusts the default Breeze color scheme to produce the final Tools Area

D28316: Add useful input method hints to password field by default

This revision was automatically updated to reflect the committed changes. Closed by commit R169:c9bbe6dea5a1: Add useful input method hints to password field by default (authored by ouwerkerk). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE

D27669: [kstyle] Tools area

ngraham added a comment. Can can confirm. Toolbars are no longer considered to be a part of the Tools area in all apps with the latest version of the patch. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D27669 To: cblack, #plasma, #breeze, #vdg, hpereiradacosta,

D28316: Add useful input method hints to password field by default

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Excellent idea! REPOSITORY R169 Kirigami BRANCH fix-password-field-input-hints REVISION DETAIL https://phabricator.kde.org/D28316 To: ouwerkerk, #kirigami, ngraham Cc: ngraham,

D27669: [kstyle] Tools area

abstractdevelop added a comment. For me it only merges the menus with the window decoration, not the toolbar :/ F8200218: QtAssistantToolbars.png REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D27669 To: cblack, #plasma,

D28306: Make the hover state clarifying, but not main

epopov marked 2 inline comments as done. epopov added inline comments. INLINE COMMENTS > broulik wrote in Task.qml:331 > We can use ECMAScript 6 now, use spread syntax: > > return [ > ...TaskTools.taskPrefix(etc), > ...foo, > ...bar > ]; > > Note the `...`

D28306: Make the hover state clarifying, but not main

epopov updated this revision to Diff 78580. epopov added a comment. Use ES6 spread syntax instead of Array.concat() REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D28316: Add useful input method hints to password field by default

ouwerkerk created this revision. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. ouwerkerk requested review of this revision. REVISION SUMMARY Hint that input methods should treat the password as sensitive and avoid applying "auto-correct" features as well.

D27808: [Fonts KCM] Use KFontChooserDialog instead of QFontDialog

meven added a comment. Seems good to me @bport should be the best reviewer here. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27808 To: ahmadsamir, #plasma, davidedmundson, broulik, meven, cfeck, bport Cc: plasma-devel, Orage, LeGast00n,

KDE CI: Plasma » kwin » kf5-qt5 SUSEQt5.12 - Build # 647 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20SUSEQt5.12/647/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 26 Mar 2020 15:51:54 + Build duration: 1 hr 18 min and counting JUnit Tests Name: (root) Failed: 0

D27669: [kstyle] Tools area

cblack updated this revision to Diff 78577. cblack added a comment. Don't include toolbars in MDI/dock widgets for the tools area calculation REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27669?vs=78572=78577 BRANCH cblack/toolsarea REVISION DETAIL

D27669: [kstyle] Tools area

davidre added a comment. two videos showing the performance regression (on the left current breeze, on the right with this patch applied) F8200103: breeze.webm F8200105: toolarea.webm REPOSITORY R31 Breeze

D27669: [kstyle] Tools area

ngraham added a comment. With the latest version of the patch, I still see this hilarious visual bug: F8200104: vokoscreenNG-2020-03-26_10-37-25.webm REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D27669 To: cblack, #plasma,

D27669: [kstyle] Tools area

ngraham added a comment. Yes, the decoration theme determines its own border value. For Breeze it's "No borders", but we can't assume that. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D27669 To: cblack, #plasma, #breeze, #vdg, hpereiradacosta, davidre Cc:

D27669: [kstyle] Tools area

cblack added a comment. In D27669#635285 , @davidre wrote: > In D27669#635243 , @cblack wrote: > > > Assume there's no borders when there's not a BorderSize entry > > > That's totally not

D27669: [kstyle] Tools area

davidre added a comment. In D27669#635243 , @cblack wrote: > Assume there's no borders when there's not a BorderSize entry That's totally not correct. The default value when there's no BorderSize entry is "Normal" . This patch is now

D28314: Allow setting separate corner radii for ShadowedRectangle

ahiemstra created this revision. ahiemstra added a reviewer: Kirigami. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. ahiemstra requested review of this revision. REVISION SUMMARY This adds a "corners" grouped property that allows setting separate radii for the

D28314: Allow setting separate corner radii for ShadowedRectangle

ahiemstra updated this revision to Diff 78574. ahiemstra added a comment. - Update test REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28314?vs=78573=78574 BRANCH shadowedrect_separatecorners REVISION DETAIL https://phabricator.kde.org/D28314

D27669: [kstyle] Tools area

cblack updated this revision to Diff 78572. cblack marked an inline comment as done. cblack added a comment. Fix error REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27669?vs=78567=78572 BRANCH cblack/toolsarea REVISION DETAIL

D27669: [kstyle] Tools area

hpereiradacosta added inline comments. INLINE COMMENTS > breezehelper.cpp:1687 > +while (parent != nullptr) { > +if (qobject_cast(widget) || qobject_cast QDockWidget*>(widget)) { > +return false; mmm shouldn't you test on parent rather than widget here ?

D28306: Make the hover state clarifying, but not main

epopov updated this revision to Diff 78568. epopov added a comment. Create a new function in TasksTools to make the code more readable. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28306?vs=78540=78568 REVISION DETAIL

D28297: KCM/touchpad: Disables the middleEmulation when not supported

This revision was automatically updated to reflect the committed changes. Closed by commit R119:73f3855ed3c5: KCM/touchpad: Disables the middleEmulation when not supported (authored by meven). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D27669: [kstyle] Tools area

cblack updated this revision to Diff 78567. cblack added a comment. Assume there's no borders when there's not a BorderSize entry REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27669?vs=78565=78567 BRANCH cblack/toolsarea REVISION DETAIL

D28296: KCM/Mouse: fix the middleEmulation checkbox status

This revision was automatically updated to reflect the committed changes. Closed by commit R119:fb86174858b5: KCM/Mouse: fix the middleEmulation checkbox status (authored by meven). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28296?vs=78523=78566

D27669: [kstyle] Tools area

cblack updated this revision to Diff 78565. cblack added a comment. Account for the applications that think it's semantically correct to put a main window in a dock widget REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27669?vs=78505=78565 BRANCH

KDE CI: Plasma » kwin » kf5-qt5 FreeBSDQt5.14 - Build # 10 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20FreeBSDQt5.14/10/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Thu, 26 Mar 2020 15:51:54 + Build duration: 24 min and counting JUnit Tests Name: projectroot

D28289: Refactor of OverlaySheet

ngraham added a comment. Generally much nicer looking. I found one visual issue: when I switch from touchpad scrolling to touchscreen scrolling, the close button in the corner gets overlapped by the content area since the scroll track gets narrower. INLINE COMMENTS > OverlaySheet.qml:24 >

D28296: KCM/Mouse: fix the middleEmulation checkbox status

ngraham accepted this revision. ngraham added a comment. stable branch REPOSITORY R119 Plasma Desktop BRANCH mouse-middleEmulation REVISION DETAIL https://phabricator.kde.org/D28296 To: meven, #plasma, ervin, bport, crossi, hchain, davidedmundson, ngraham Cc: ngraham, plasma-devel,

D28311: [applets/systemtray] Clear item from shown/hidden list when disabling entry

This revision was automatically updated to reflect the committed changes. Closed by commit R120:fede85a3d0ea: [applets/systemtray] Clear item from shown/hidden list when disabling entry (authored by nicolasfella). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D28311?vs=78561=78563#toc

D27669: [kstyle] Tools area

ngraham added a comment. In D27669#634903 , @davidre wrote: > - Why are we drawing a separator if the window has no toolbar? Because this looks really good :) F821: vokoscreenNG-2020-03-26_09-46-28.webm

D27669: [kstyle] Tools area

ngraham added a comment. Can confirm, if I override the default border setting and change it to "no borders", the appearance looks right again. So I guess we need to handle cases where the window decoration theme's default border setting is "no borders". It might also be nice to mention

D28311: [applets/systemtray] Clear item from shown/hidden list when disabling entry

broulik accepted this revision. broulik added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > ConfigEntries.qml:226 > case "disabled": > if (extraIndex > -1) { >

D28311: [applets/systemtray] Clear item from shown/hidden list when disabling entry

nicolasfella created this revision. nicolasfella added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. REVISION SUMMARY Else the entry is still in cfg_shownItems/cfg_hiddenItems and the config UI will

D28306: Make the hover state clarifying, but not main

broulik added inline comments. INLINE COMMENTS > davidedmundson wrote in Task.qml:331 > this is a bit longwinded, can we make a function in TasksTools? We can use ECMAScript 6 now, use spread syntax: return [ ...TaskTools.taskPrefix(etc), ...foo, ...bar ]; Note the `...`

D28308: [FormLayout] Set compression timer interval to 0

This revision was automatically updated to reflect the committed changes. Closed by commit R169:f6e15f51cac7: [FormLayout] Set compression timer interval to 0 (authored by broulik). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28308?vs=78546=78559

Re: KDE CI: Plasma » kwin » kf5-qt5 FreeBSDQt5.14 - Build # 9 - Failure!

On it. Aleix On Thu, Mar 26, 2020 at 4:15 PM CI System wrote: > *BUILD FAILURE* > Build URL > https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20FreeBSDQt5.14/9/ > Project: kf5-qt5 FreeBSDQt5.14 > Date of build: Thu, 26 Mar 2020 15:10:31 + > Build duration: 4 min 17 sec and counting >

KDE CI: Plasma » kwin » kf5-qt5 SUSEQt5.12 - Build # 646 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20SUSEQt5.12/646/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 26 Mar 2020 15:10:31 + Build duration: 6 min 44 sec and counting CONSOLE OUTPUT [...truncated 3970

KDE CI: Plasma » kwin » kf5-qt5 FreeBSDQt5.14 - Build # 9 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20FreeBSDQt5.14/9/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Thu, 26 Mar 2020 15:10:31 + Build duration: 4 min 17 sec and counting CONSOLE OUTPUT [...truncated

KDE CI: Plasma » plasma-desktop » kf5-qt5 SUSEQt5.12 - Build # 808 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20SUSEQt5.12/808/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 26 Mar 2020 15:00:54 + Build duration: 4 min 58 sec and counting JUnit Tests Name: (root)

D28232: [SpellChecking KCM] Fix the build

This revision was automatically updated to reflect the committed changes. Closed by commit R119:646bd3eecc72: [SpellChecking KCM] Fix the build (authored by ahmadsamir). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28232?vs=78554=78555 REVISION

D28232: [SpellChecking KCM] Fix the build

ahmadsamir updated this revision to Diff 78554. ahmadsamir added a comment. Rebase REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28232?vs=78347=78554 BRANCH l-fix-build (branched from master) REVISION DETAIL https://phabricator.kde.org/D28232

D28232: [SpellChecking KCM] Fix the build

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. > I could rework the patch to make it conditional on 5.14 and keep the iterator-based ctors as-is. May as well merge this and just revert when we're able to use 5.14

D28306: Make the hover state clarifying, but not main

davidedmundson added a comment. @ngraham the default theme doesn't change with this patch. I believe there are no plans to do so. INLINE COMMENTS > Task.qml:331 > +if (isHovered) > +return TaskTools.taskPrefix(basePrefix + >

D28306: Make the hover state clarifying, but not main

ngraham added a comment. Thanks for the patch! For visual patches like this, it's helpful if you put before-and-after images or screen recordings in the Test Plan section. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28306 To: epopov, davidedmundson, #vdg

D28300: Opt into KIO changes for cgroup management

This revision was automatically updated to reflect the committed changes. Closed by commit R120:b6a8662dbd91: Opt into KIO changes for cgroup management (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28300?vs=78527=78547

D28305: WIP: Systemd Startup

hchain added inline comments. INLINE COMMENTS > startplasma.cpp:404 > +startPlasmaSession.start(QStringLiteral(CMAKE_INSTALL_FULL_BINDIR > "/plasma_session"), plasmaSessionOptions); > +rc = startPlasmaSession.waitForStarted(); > +#else unrelated change ? REPOSITORY R120 Plasma

D28308: [FormLayout] Set compression timer interval to 0

broulik created this revision. broulik added a reviewer: mart. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Apparently `Timer` default interval is `1000` :) TEST PLAN - Putting a `FormLayout` into a

D28305: WIP: Systemd Startup

hchain added inline comments. INLINE COMMENTS > hchain wrote in plasmawayland-dev.desktop.cmake:2 > does that still work in legacy (non-systemd) mode ? original patch https://phabricator.kde.org/D19004 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28305

D28305: WIP: Systemd Startup

hchain added inline comments. INLINE COMMENTS > apol wrote in plasmawayland-dev.desktop.cmake:2 > Is this change related? does that still work in legacy (non-systemd) mode ? > apol wrote in org.kde.plasmashell.desktop.cmake:55 > We probably want it always hidden? maybe add a comment that this

D28305: WIP: Systemd Startup

davidedmundson added inline comments. INLINE COMMENTS > ahiemstra wrote in CMakeLists.txt:44 > This pattern is repeated multiple times, maybe we should make a macro out of > it? Like `install_systemd_service_file(source_file)` that's a good idea > apol wrote in ksmserver.service.cmake:8 > Why

D28305: WIP: Systemd Startup

apol added a comment. Change looks good to me overall +1 INLINE COMMENTS > ksmserver.service.cmake:8 > +# This magic minus sign means don't fail if exit code is non-zero... > +ExecStartPost=-@QtBinariesDir@/qdbus org.kde.KSplash /KSplash > org.kde.KSplash.setStage ksmserver >

D28305: WIP: Systemd Startup

ahiemstra added inline comments. INLINE COMMENTS > CMakeLists.txt:44 > > +configure_file(krunner.service.cmake > ${CMAKE_CURRENT_BINARY_DIR}/krunner.service @ONLY) > +install( FILES ${CMAKE_CURRENT_BINARY_DIR}/krunner.service DESTINATION This pattern is repeated multiple times, maybe we

D28305: WIP: Systemd Startup

davidedmundson added a comment. In terms of testing, you will need: - this patch - to rerun ./login-sessions/install-sessions.sh - cherry-picked the relevant repos in kded, kwin, kactivitymanagerd This will give you a basic session, for everything , you'll also want

D28306: Make the hover state clarifying, but not main

epopov created this revision. epopov added reviewers: davidedmundson, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. epopov requested review of this revision. REVISION SUMMARY I'm trying to make a custom appearance of the Task Manager by creating a new theme, but

D28289: Refactor of OverlaySheet

anthonyfieroni added inline comments. INLINE COMMENTS > OverlaySheet.qml:2-19 > +* Copyright (C) 2016 by Marco Martin > +* > +* This program is free software; you can redistribute it and/or modify > +* it under the terms of the GNU Library General Public License as > +* published by the

D28289: Refactor of OverlaySheet

mart updated this revision to Diff 78542. mart added a comment. - better response to window resizes REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28289?vs=78532=78542 BRANCH mart/overlaysheetrefactor2 REVISION DETAIL

D28305: WIP: Systemd Startup

davidedmundson updated this revision to Diff 78541. davidedmundson added a comment. add comments explaining some code REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28305?vs=78539=78541 BRANCH master REVISION DETAIL

D28305: WIP: Systemd Startup

davidedmundson created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY This brings numerous advantages such as: - easier admin configuration with drop-ins, overrides a nd

D28272: Avoid copying buffer twice

zzag added inline comments. INLINE COMMENTS > ahiemstra wrote in screencaststream.cpp:549-563 > The entire framebuffer is superfluous, it is never used. glGetTexImage() > reads from the currently bound texture, which in this case is "texture" since > you bind it at line 546. The fbo is gone

D28277: [UrlButton] Disable when there is no URL

This revision was automatically updated to reflect the committed changes. Closed by commit R169:d6cfab5bec74: [UrlButton] Disable when there is no URL (authored by broulik). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28277?vs=78460=78538 REVISION DETAIL

D28277: [UrlButton] Disable when there is no URL

bugseforuns added a comment. This patch fixes bug 418580 . REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D28277 To: broulik, mart, #vdg, #kirigami, ngraham, apol Cc: bugseforuns, apol, ngraham, plasma-devel,

D28272: Avoid copying buffer twice

ahiemstra added inline comments. INLINE COMMENTS > zzag wrote in screencaststream.cpp:549-563 > Do we actually need an fbo? The entire framebuffer is superfluous, it is never used. glGetTexImage() reads from the currently bound texture, which in this case is "texture" since you bind it at

D28192: WIP: Refactor dictionary runner

sitter added inline comments. INLINE COMMENTS > config_keys.h:5 > + */ > + > +static const char CONFIG_TRIGGERWORD[] = "triggerWord"; Include guards please > dictionarymatchengine.cpp:85 > m_wordLock.lockForRead(); > -foreach (ThreadData *data, m_lockers.values(source)) { > +for

D28289: Refactor of OverlaySheet

mart updated this revision to Diff 78532. mart added a comment. - Merge branch 'master' into mart/overlaysheetrefactor2 REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28289?vs=78482=78532 BRANCH mart/overlaysheetrefactor2 REVISION DETAIL

licensing terms of plasma dictionary runner

Hey Jason! Hope you are doing well. I've just noticed that the dictionary runner you've made for Plasma doesn't really have licensing terms in its source files. https://cgit.kde.org/kdeplasma-addons.git/tree/runners/dictionary/dictionaryrunner.cpp It'd be really grand if you could specify which

D28300: Opt into KIO changes for cgroup management

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY It was safeguarded by an environment variable so we don't retroactively

D28297: KCM/touchpad: Disables the middleEmulation when not supported

meven created this revision. meven added reviewers: Plasma, ervin, bport, crossi. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REVISION SUMMARY Similar to D28296 REPOSITORY R119 Plasma

D27669: [kstyle] Tools area

davidre added a comment. Some observation: - Performance in KDevelop is horrible (First startup, opening files, switching between file tabs...) - It also colors the toolbars of mdi windows F8199474: Screenshot_20200326_101026.png - It also

D27669: [kstyle] Tools area

davidre requested changes to this revision. davidre added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > breezehelper.cpp:1782 > +auto borderSize = kdecorationGroup.readEntry("BorderSize", > "Invalid"); > +if (borderSize != "None" && borderSize

D28296: KCM/Mouse: fix the middleEmulation checkbox status

meven created this revision. meven added reviewers: Plasma, ervin, bport, crossi, hchain. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REVISION SUMMARY The load function of the field was not called previously. Preventing the

D28282: KCM/GlobalShortut: convert FOREACH and old signal syntax

meven updated this revision to Diff 78522. meven marked 4 inline comments as done. meven added a comment. Review comments, code formating more const REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28282?vs=78457=78522 BRANCH shortcuts REVISION

D28286: [Task Manager] Port backend to ApplicationLauncherJob

broulik updated this revision to Diff 78521. broulik retitled this revision from "WIP: [Task Manager] Port backend to ApplicationLauncherJob" to "[Task Manager] Port backend to ApplicationLauncherJob". broulik edited the summary of this revision. broulik edited the test plan for this revision.

D27808: [Fonts KCM] Use KFontChooserDialog instead of QFontDialog

ahmadsamir updated this revision to Diff 78519. ahmadsamir retitled this revision from "[Fonts KCM] Port KFontDialog/KFontChooser to QFontDialog" to "[Fonts KCM] Use KFontChooserDialog instead of QFontDialog". ahmadsamir edited the summary of this revision. ahmadsamir edited the test plan for

D28282: KCM/GlobalShortut: convert FOREACH and old signal syntax

ahmadsamir added inline comments. INLINE COMMENTS > export_scheme_dialog.cpp:46 > int item=0; > -Q_FOREACH(QString component, mComponents) > +for(QString component : qAsConst(mComponents)) > { const QString & > export_scheme_dialog.cpp:74 > +const auto buttons =

Re: KDE CI: Administration » Dependency Build Plasma kf5-qt5 SUSEQt5.12 - Build # 95 - Failure!

On Wed, Mar 25, 2020 at 6:39 PM Ömer Fadıl USTA wrote: > > > Ben Cooksley , 25 Mar 2020 Çar, 07:48 tarihinde şunu yazdı: >> >> The Dependency Build says plasma-desktop is broken. >> >> Ideas anyone? >> > Hello ben, It looks like this will solve that problem : > https://phabricator.kde.org/D28232

D28232: [SpellChecking KCM] Fix the build

bcooksley added a comment. @bport Sorry, but this cannot be left in a broken state like this. Reality is that the `plasma-desktop` repository declares that it depends on a minimum of Qt 5.12 at the moment in CMake, so that is what it needs to build with. Should this be insufficient,