guide to build plasma mobile for pinephone

Hi, I would like to support in plasma development. Can someone point to the build scripts that help in building the plasma mobile for pinephone from source ? Thanks in advance regards Suren

KDE CI: Plasma » xdg-desktop-portal-kde » kf5-qt5 FreeBSDQt5.14 - Build # 14 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/xdg-desktop-portal-kde/job/kf5-qt5%20FreeBSDQt5.14/14/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Thu, 09 Apr 2020 04:38:50 + Build duration: 24 min and counting CONSOLE OUTPUT

D28692: Don't leak DrKonqi dialog / fix crash on wayland

anthonyfieroni added inline comments. INLINE COMMENTS > main.cpp:67 > void openDrKonqiDialog () { > DrKonqiDialog *w = new DrKonqiDialog(); > +QObject::connect(qApp, ::aboutToQuit, w, > ::deleteLater); Adding a qApp as a parent here? REPOSITORY R871 DrKonqi REVISION

D28688: Document Kirigami::Icon

cblack added inline comments. INLINE COMMENTS > nicolasfella wrote in icon.h:69 > Maybe mention that it's read-only. Do we have some standard way of doing that? It's mentioned by Doxygen REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D28688 To: cblack, #kirigami Cc:

D26185: Also disable automatic scaling on Qt >= 5.14

powersnail added a comment. Setting QT_AUTO_SCREEN_SCALE_FACTOR to 0 seems to affect the scaling of pixmaps. For example, designer-qt5 has extra small icons in the toolbar area. If I run designer-qt5 in commandline while unsetting QT_AUTO_SCREEN_SCALE_FACTOR, the icons are of the

D28693: Replace old notification when new notification for connection appears

nicolasfella created this revision. nicolasfella added reviewers: Plasma, broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added a reviewer: jgrulich. nicolasfella requested review of this revision. REVISION SUMMARY When a second notification appears

D28691: [kded] Clean up notification handling

nicolasfella updated this revision to Diff 79676. nicolasfella edited the summary of this revision. nicolasfella added a comment. - Fix REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28691?vs=79673=79676 BRANCH cleanup REVISION

D28692: Don't leak DrKonqi dialog / fix crash on wayland

davidedmundson added a comment. Thread 1 "drkonqi" hit Breakpoint 1, 0x7f0664dd8570 in QtWaylandClient::QWaylandDisplay::handleWindowDeactivated(QtWaylandClient::QWaylandWindow*)@plt () from /opt/qt5/plugins/wayland-shell-integration/libxdg-shell.so (gdb) bt #0

D28692: Don't leak DrKonqi dialog / fix crash on wayland

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY When a QApplication is in it's destructor it calls window->destroy() on

D28691: [kded] Clean up notification handling

nicolasfella created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added a reviewer: jgrulich. nicolasfella requested review of this revision. REPOSITORY R116 Plasma Network Management Applet BRANCH cleanup REVISION DETAIL

D28690: Add unit tests for PagePool/PagePoolAction

masonm created this revision. masonm added reviewers: Kirigami, mart. masonm added a project: Kirigami. masonm requested review of this revision. REVISION SUMMARY In addition to the new unit tests a fix has been added for initialProperties being ignored when they are already specified in

D28688: Document Kirigami::Icon

nicolasfella added a comment. +1 documentation improvements are always very welcome INLINE COMMENTS > icon.h:37 > + * @include icon/FilesystemSource.qml > + * * The Internet: > + * @include icon/InternetSource.qml Maybe instead of internet something like "a remote url" since

D28688: Document Kirigami::Icon

cblack created this revision. cblack added a reviewer: Kirigami. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. cblack requested review of this revision. REVISION SUMMARY There are now documentation comments for Kirigami::Icon. REPOSITORY R169 Kirigami BRANCH

D28685: Use ListSectionHeader in ListView example

This revision was automatically updated to reflect the committed changes. Closed by commit R1014:ae736f9febcd: Use ListSectionHeader in ListView example (authored by nicolasfella). REPOSITORY R1014 Kirigami Gallery CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28685?vs=79661=79668

D28127: Add some new battery sensors : energy_now, energy_full and power_now.

jjorge updated this revision to Diff 79665. jjorge added a comment. - A better cast to float REPOSITORY R106 KSysguard CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28127?vs=79655=79665 BRANCH acpi-energy REVISION DETAIL https://phabricator.kde.org/D28127 AFFECTED FILES

D28686: [Battery Monitor] Choose better wording

shubham created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. shubham requested review of this revision. REPOSITORY R120 Plasma Workspace BRANCH fix-wording REVISION DETAIL https://phabricator.kde.org/D28686 AFFECTED FILES

D28685: Use ListSectionHeader in ListView example

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Nice! REPOSITORY R1014 Kirigami Gallery BRANCH sectionheader REVISION DETAIL https://phabricator.kde.org/D28685 To: nicolasfella, #kirigami, ngraham Cc: ngraham, plasma-devel,

D28685: Use ListSectionHeader in ListView example

nicolasfella created this revision. nicolasfella added a reviewer: Kirigami. Herald added projects: Plasma, Kirigami. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. REPOSITORY R1014 Kirigami Gallery BRANCH sectionheader REVISION DETAIL

D28684: Kate Runner: Implement drag and drop for sessions

alex created this revision. alex added reviewers: Plasma, Kate, cullmann, broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. alex requested review of this revision. REVISION SUMMARY You can now drag the sessions from the runner to the taskbar or the desktop. TEST

D28683: Get rid of workaround that prevents file dialog from being blocked

volkov added a comment. DialogIsQtWindow was introduced in https://codereview.qt-project.org/c/qt/qtbase/+/144710 REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D28683 To: volkov, #plasma Cc: plasma-devel, Orage, LeGast00n,

D28683: Get rid of workaround that prevents file dialog from being blocked

volkov created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. volkov requested review of this revision. REVISION SUMMARY Invisible proxy QDialog blocks input when the native dialog is shown, and the workaround is to show the native file dialog with a

D28127: Add some new battery sensors : energy_now, energy_full and power_now.

jjorge updated this revision to Diff 79655. jjorge added a comment. I should learn to better use arc... - typo REPOSITORY R106 KSysguard CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28127?vs=79653=79655 BRANCH acpi-energy REVISION DETAIL

D28127: Add some new battery sensors : energy_now, energy_full and power_now.

jjorge updated this revision to Diff 79653. jjorge added a comment. - Oops fix bad named functions REPOSITORY R106 KSysguard CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28127?vs=79629=79653 BRANCH acpi-energy REVISION DETAIL https://phabricator.kde.org/D28127 AFFECTED

KDE CI: Plasma » xdg-desktop-portal-kde » kf5-qt5 FreeBSDQt5.14 - Build # 13 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/xdg-desktop-portal-kde/job/kf5-qt5%20FreeBSDQt5.14/13/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Wed, 08 Apr 2020 16:31:11 + Build duration: 52 sec and counting CONSOLE OUTPUT

D28517: Send notification when screencasting fails

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R838:1452cf0efde1: Send notification when screencasting fails (authored by cblack). CHANGED PRIOR TO COMMIT

D28671: Improve appearance of gallery listing

cblack updated this revision to Diff 79650. cblack retitled this revision from "Improved gallery listing" to "Improve appearance of gallery listing". cblack edited the summary of this revision. cblack added a comment. Add search REPOSITORY R1014 Kirigami Gallery CHANGES SINCE LAST UPDATE

D26934: KCM/Autostart Add a model to separate logic from UI

ervin requested changes to this revision. ervin added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > autostart.cpp:167 > { > -KOpenWithDialog owdlg( this ); > -if (owdlg.exec() != QDialog::Accepted) > -return; > +KOpenWithDialog* owdlg =

D28671: Improve appearance of gallery listing

cblack updated this revision to Diff 79648. cblack added a comment. Adjust images to fit above a baseline REPOSITORY R1014 Kirigami Gallery CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28671?vs=79647=79648 BRANCH cblack/pictures (branched from master) REVISION DETAIL

D28671: Improve appearance of gallery listing

cblack updated this revision to Diff 79647. cblack added a comment. Fix opacity issues REPOSITORY R1014 Kirigami Gallery CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28671?vs=79622=79647 BRANCH cblack/pictures (branched from master) REVISION DETAIL

D28666: Refactor for loops

cblack added a comment. In D28666#644079 , @ngraham wrote: > I'm not a Javascript expert, but the old/current versions seem much more readable to me. Is there a performance advantage to your proposed new versions? No, the main point is

D28666: Refactor for loops

cblack updated this revision to Diff 79642. cblack marked 3 inline comments as done. cblack added a comment. Address feedback REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28666?vs=79623=79642 BRANCH cblack/for-refactor (branched from master)

D28666: Refactor for loops

cblack added inline comments. INLINE COMMENTS > broulik wrote in Action.qml:156 > Why are you going through the prototype? Or is `children` not a "proper" > Array? > Also, can we use spread operator `...` here? > And yes, please make those a bit more readable by using useful line breaks > and

D28665: Explicitly type ColorUtils lambda

This revision was automatically updated to reflect the committed changes. Closed by commit R169:3263c5a9b533: Explicitly type ColorUtils lambda (authored by cblack). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28665?vs=79613=79641 REVISION DETAIL

D26934: KCM/Autostart Add a model to separate logic from UI

meven updated this revision to Diff 79639. meven marked 20 inline comments as done. meven added a comment. Make most dialogs use open/finished, make all dialogs modal... REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26934?vs=78855=79639 BRANCH

D28678: adjust smb kcm size to be sufficient vis a vis headers

sitter added a comment. F8225234: Screenshot_20200408_142242.png F8225237: Screenshot_20200408_142227-1.png F8225239: Screenshot_20200408_142309.png REPOSITORY

D28678: adjust smb kcm size to be sufficient vis a vis headers

sitter created this revision. sitter added a reviewer: ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sitter requested review of this revision. REVISION SUMMARY we use Stretch to get a somewhat uniform appearance between the two views but Stretch is bit meh

D28134: Add ColorUtils

winterz added a comment. In D28134#643899 , @kossebau wrote: > Seems to no be compatible with Qt 5.12, see failing on CI: https://build.kde.org/view/Failing/job/Frameworks/job/kirigami/job/kf5-qt5%20SUSEQt5.12/lastFailedBuild/console

D28134: Add ColorUtils

dfaure added a comment. Breaks compilation with Qt 5.13 too. /data/kde/src/5/frameworks/kirigami/src/kirigamiplugin.cpp:248:122: error: invalid user-defined conversion from ‘KirigamiPlugin::registerTypes(const char*)::’ to ‘QObject* (*)(QQmlEngine*, QJSEngine*)’ [-fpermissive]

Re: KDE CI: Plasma » plasma-workspace » kf5-qt5 SUSEQt5.14 - Build # 23 - Failure!

Is a failure, caused by some baloo thing.

D28127: Add some new battery sensors : energy_now, energy_full and power_now.

anthonyfieroni added inline comments. INLINE COMMENTS > acpi.c:147 > if ( maximum > 0) { > -state = charge * 100 / maximum; > +state = charge/(float)(maximum/100);/* to get 0.1% changes */ > } `(float)(var_int/var_int)` does not what you want, it should be

KDE CI: Plasma » plasma-workspace » kf5-qt5 SUSEQt5.14 - Build # 23 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20SUSEQt5.14/23/ Project: kf5-qt5 SUSEQt5.14 Date of build: Wed, 08 Apr 2020 10:54:19 + Build duration: 1 min 57 sec and counting CONSOLE OUTPUT

D28676: Drop kdeinit from ksmserver

This revision was automatically updated to reflect the committed changes. Closed by commit R120:5ea6a05ebb8e: Drop kdeinit from ksmserver (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28676?vs=79631=79637 REVISION

D28626: [plasma-session] Don't prematurely cache systemEnvironemnt

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R120:4e681fdb580f: [plasma-session] Dont prematurely cache systemEnvironemnt (authored by davidedmundson). REPOSITORY

D28677: Make PipeWire, GBM and Epoxy libs as required dependencies

jgrulich added a comment. I asked on kde-distribution-packagers, so far I got only response from Slack and the response was they don't care about Wayland, if they would, they would have included PipeWire. I think it should be either don't support Wayland at all if distribution doesn't care

D28677: Make PipeWire, GBM and Epoxy libs as required dependencies

jgrulich added a comment. In D28677#644196 , @davidedmundson wrote: > > Also allow to completely disable Wayland support in case some distribution don't ship PipeWire yet. > > I don't follow, why don't we just disable the screencasting

D28677: Make PipeWire, GBM and Epoxy libs as required dependencies

davidedmundson added a comment. > Also allow to completely disable Wayland support in case some distribution don't ship PipeWire yet. I don't follow, why don't we just disable the screencasting thing if we don't have pipewire. I don't see why we would affect the rest. REPOSITORY R838

D28677: Make PipeWire, GBM and Epoxy libs as required dependencies

jgrulich created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. jgrulich requested review of this revision. REVISION SUMMARY Also allow to completely disable Wayland support in case some distribution don't ship PipeWire yet REPOSITORY R838 Flatpak

D28676: Drop kdeinit from ksmserver

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY As we don't launch with kinit, no point ksmserver linking against it TEST

D28517: Send notification when screencasting fails

jgrulich added a comment. Looks good to me. @broulik what do you think? REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop REVISION DETAIL https://phabricator.kde.org/D28517 To: cblack, #plasma, #vdg, ngraham, apol, jgrulich Cc: broulik, apol, ngraham, plasma-devel, Orage,

D28127: Add some new battery sensors : energy_now, energy_full and power_now.

jjorge added a comment. Hem, you are right, I missed it because I was testing old binary. REPOSITORY R106 KSysguard REVISION DETAIL https://phabricator.kde.org/D28127 To: jjorge, #plasma, davidedmundson, ahiemstra Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh,

D28127: Add some new battery sensors : energy_now, energy_full and power_now.

jjorge updated this revision to Diff 79629. jjorge added a comment. - fix pointer REPOSITORY R106 KSysguard CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28127?vs=79321=79629 BRANCH acpi-energy REVISION DETAIL https://phabricator.kde.org/D28127 AFFECTED FILES

D28666: Refactor for loops

broulik added a comment. +1 for the `.some()` use -1 on the convoluted `Array.prototype` things, especially when chained. INLINE COMMENTS > Action.qml:156 > readonly property var visibleChildren: { > -var visible = []; > -var child; > -for (var i in children) {

KDE CI: Plasma » xdg-desktop-portal-kde » kf5-qt5 SUSEQt5.14 - Build # 9 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/xdg-desktop-portal-kde/job/kf5-qt5%20SUSEQt5.14/9/ Project: kf5-qt5 SUSEQt5.14 Date of build: Wed, 08 Apr 2020 05:58:25 + Build duration: 1 min 17 sec and counting JUnit Tests Name: