D29294: Add support for layers to PagePoolAction.

masonm created this revision. masonm added reviewers: Kirigami, mart. masonm added a project: Kirigami. masonm requested review of this revision. REVISION SUMMARY Currently PagePoolAction only supports pushing to a pageStack, but often it makes sense to use layers to push modal/contextual

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ngraham added a subscriber: cblack. ngraham added a comment. In D28317#660094 , @ndavis wrote: > In D28317#639653 , @ndavis wrote: > > > Do we really still need Breeze Light to be separate from

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ndavis added a comment. In D28317#639653 , @ndavis wrote: > Do we really still need Breeze Light to be separate from Breeze? I think it would make more sense to have just Breeze Light and Breeze Dark colorschemes (delete Breeze Light, rename

D29293: Add rules about import naming and platform specialization

This revision was automatically updated to reflect the committed changes. Closed by commit R1047:a445f089cbec: Add rules about import naming and platform specialization (authored by nicolasfella). REPOSITORY R1047 Kirigami Addons CHANGES SINCE LAST UPDATE

D29293: Add rules about import naming and platform specialization

nicolasfella updated this revision to Diff 81559. nicolasfella added a comment. - Expand notes on specific platforms REPOSITORY R1047 Kirigami Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29293?vs=81558=81559 BRANCH rules REVISION DETAIL

D29293: Add rules about import naming and platform specialization

nicolasfella created this revision. nicolasfella added reviewers: Kirigami, davidedmundson, vkrause. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. REVISION SUMMARY As discussed in chat REPOSITORY R1047 Kirigami Addons

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ndavis added a comment. Forgot to change a few more of the selection colors. I might as well post the updated Breeze Dark version too. F8271896: Breeze10.colors F8271897: BreezeDark10.colors REPOSITORY

repo freeze tomorrow

Dave has rightly pointed out my typo in the schedule and Plasma 5.19 repo freeze is tomorrow, April 30th. Does anyone have any git repos they'd like added to this Plasma release? Jonathan

D29268: [WIP] Add Date/Time dialog

nicolasfella added a comment. In D29268#659586 , @vkrause wrote: > There might be ways around the native function registration issue from the QML thread, e.g. by using the alternative approach of exported (mangled) symbols instead:

Re: Plasma 5.18 LTS

Just a proposal, if you think more frequent ones would be useful then we can do that Jonathan On Wed, 29 Apr 2020 at 17:59, Rik Mills wrote: > On 29/04/2020 17:22, Jonathan Riddell wrote: > > Plasma 5.18 is due to have its .5 release shortly and then we'll move > > onto Plasma 5.19 releases.

D29288: Improve PageRouter API

cblack created this revision. cblack added a reviewer: Kirigami. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. cblack updated this revision to Diff 81555. cblack added a comment. cblack requested review of this revision. Add missing EOF linebreak REVISION SUMMARY

D29290: IGNORE THIS - TESTING A PHAB THING

cblack added a comment. submit the revision as a draft (`arc diff --draft`) so you don't cause useless emails next time REPOSITORY R123 SDDM Configuration Panel (KCM) REVISION DETAIL https://phabricator.kde.org/D29290 To: davidedmundson, qi437103 Cc: cblack, plasma-devel, Orage,

D29290: IGNORE THIS - TESTING A PHAB THING

qi437103 created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. qi437103 requested review of this revision. REPOSITORY R123 SDDM Configuration Panel (KCM) BRANCH master REVISION DETAIL https://phabricator.kde.org/D29290 AFFECTED FILES test To:

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ndavis added a comment. In D28317#659952 , @ngraham wrote: > Thanks, that's fixed now. Is the tooltip background supposed to be this grayish color though? > > F8271573: Screenshot_20200429_124914.png

D27576: Kill Runner: Move config keys to new file

alex added a comment. @meven and others, may I ship this? REPOSITORY R120 Plasma Workspace BRANCH arcpatch-D27576_1 REVISION DETAIL https://phabricator.kde.org/D27576 To: alex, davidedmundson, ngraham, broulik, meven, apol Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack,

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ngraham added a comment. Thanks, that's fixed now. Is the tooltip background supposed to be this grayish color though? F8271573: Screenshot_20200429_124914.png If we're go with a light tooltip, I think I'd prefer it to look like the current

D29279: Don't play volume feedback if max volume is reached

ngraham added a comment. In D29279#659923 , @cblack wrote: > In D29279#659922 , @nicolasfella wrote: > > > To be clear: the 95%->100% transition still emits a sound, but 100%->100% does not any

D29279: Don't play volume feedback if max volume is reached

cblack added a comment. In D29279#659922 , @nicolasfella wrote: > To be clear: the 95%->100% transition still emits a sound, but 100%->100% does not any more Yes, that's what I rely on to know that I'm at maximum volume-when the volume

D29279: Don't play volume feedback if max volume is reached

nicolasfella added a comment. To be clear: the 95%->100% transition still emits a sound, but 100%->100% does not any more REPOSITORY R115 Plasma Audio Volume Applet BRANCH vol REVISION DETAIL https://phabricator.kde.org/D29279 To: nicolasfella, #plasma, drosca, ngraham Cc: cblack,

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ndavis added a comment. Oops, that's a leftover bit from when I was testing my changes to the Breeze QStyle. This color scheme is something I've been slowly working on for a while. New version with fixed selection color and darker titlebar: F8271489: Breeze10.colors

D29279: Don't play volume feedback if max volume is reached

nicolasfella added a comment. The lack of sound is feedback that you are at maximum volume Before it was hard to hear the difference between 90% and 100% REPOSITORY R115 Plasma Audio Volume Applet BRANCH vol REVISION DETAIL https://phabricator.kde.org/D29279 To: nicolasfella,

D29285: KCM Icons : Use KIconloader::emitChange() instead of deprecated newIconLoader()

crossi created this revision. crossi added reviewers: Plasma, bport. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. crossi requested review of this revision. REVISION SUMMARY Changing the icon size should emits `iconLoaderSettingsChanged` as well REPOSITORY R119

D29279: Don't play volume feedback if max volume is reached

cblack added a comment. Not sure how I feel about this change. I often rely on auditory feedback rather than visual feedback to confirm that I'm at maximum volume. REPOSITORY R115 Plasma Audio Volume Applet BRANCH vol REVISION DETAIL https://phabricator.kde.org/D29279 To:

D29279: Don't play volume feedback if max volume is reached

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. +1, this is a nice improvement. REPOSITORY R115 Plasma Audio Volume Applet BRANCH vol REVISION DETAIL https://phabricator.kde.org/D29279 To: nicolasfella, #plasma, drosca,

Re: Plasma 5.18 LTS

On 29/04/2020 17:22, Jonathan Riddell wrote: > Plasma 5.18 is due to have its .5 release shortly and then we'll move > onto Plasma 5.19 releases.  Plasma 5.18 is an LTS so its translations > will get put into the LTS branch and it'll move to 6 monthly releases > until we decide on another LTS. >

D28878: Fix WidgetExplorer "get new widgets" always a new window opens instead of taking the focus to the already opened one

davidedmundson added a comment. I don't like this "assistant" object that is just an opaque pointer being passed around from QML space. It's not very declarative. Either we should register this item as a singleton with some nice invokable methods to show KNS dialogs, which could be a

Re: Plasma 5.18 LTS

On 4/29/20 10:22 AM, Jonathan Riddell wrote:> I've added releases for next year to https://community.kde.org/Schedules/Plasma_5#Future_releases 5.18.6 LTS Bugfix Tue 2020-09-29 5.18.7 LTS Bugfix Tue 2021-03-30 https://phabricator.kde.org/calendar/

D28879: Fix WidgetExplorer "get new widgets" always a new window opens instead of taking the focus to the already opened one

davidedmundson added inline comments. INLINE COMMENTS > WidgetExplorer.qml:66 > Component.onCompleted: { > if (!root.widgetExplorer) { > +if (!root.widgetExplorerAssistant) { This existing code is horrible. It's a very bad idea to reference objects outside our scope.

Plasma 5.18 LTS

Plasma 5.18 is due to have its .5 release shortly and then we'll move onto Plasma 5.19 releases. Plasma 5.18 is an LTS so its translations will get put into the LTS branch and it'll move to 6 monthly releases until we decide on another LTS. I've added releases for next year to

D28878: Fix WidgetExplorer "get new widgets" always a new window opens instead of taking the focus to the already opened one

davidedmundson added a comment. > Iincluding the removal of KNS functionality? It's there. It's in widgetexplorerassistant To help rephrase the commit message. - WidgetExplorer opens dialogs - WidgetExplorer has a limited lifespan and can be recreated each time it's shown.

D29279: Don't play volume feedback if max volume is reached

nicolasfella updated this revision to Diff 81525. nicolasfella added a comment. - Fix comment REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29279?vs=81524=81525 BRANCH vol REVISION DETAIL https://phabricator.kde.org/D29279

D29279: Don't play volume feedback if max volume is reached

nicolasfella updated this revision to Diff 81524. nicolasfella added a comment. - Whitespace REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29279?vs=81523=81524 BRANCH vol REVISION DETAIL https://phabricator.kde.org/D29279

D29279: Don't play volume feedback if max volume is reached

nicolasfella updated this revision to Diff 81523. nicolasfella added a comment. - Clarify comment REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29279?vs=81522=81523 BRANCH vol REVISION DETAIL https://phabricator.kde.org/D29279

D29279: Don't play volume feedback if max volume is reached

nicolasfella created this revision. nicolasfella added reviewers: Plasma, drosca. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. REVISION SUMMARY I often smash my volume up key until the volume is max. I usually smash it

D29156: [kcms/fonts] When adjusting all fonts, keep Small font size smaller

This revision was automatically updated to reflect the committed changes. Closed by commit R119:24e4e15b7b04: [kcms/fonts] When adjusting all fonts, keep Small font size smaller (authored by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D29156: [kcms/fonts] When adjusting all fonts, keep Small font size smaller

cblack accepted this revision as: cblack. cblack added a comment. +1 from a design standpoint here. REPOSITORY R119 Plasma Desktop BRANCH make-small-font-smaller-when-changing-all-font-sizes (branched from master) REVISION DETAIL https://phabricator.kde.org/D29156 To: ngraham,

D28744: Rewrite of the global shortcuts kcm

ngraham added a comment. In D28744#659600 , @davidre wrote: > In D28744#659447 , @ngraham wrote: > > > I find that I'm not able to set shortcuts involving the space key. The key sequence get

D28878: Fix WidgetExplorer "get new widgets" always a new window opens instead of taking the focus to the already opened one

ngraham added a comment. This change seems rather more expansive than the title would suggest. I see a lot of unrelated-looking changes including the removal of KNS functionality? These changes need to be explained or reverted. REPOSITORY R120 Plasma Workspace REVISION DETAIL

KDE CI: Plasma » kwin » kf5-qt5 FreeBSDQt5.14 - Build # 67 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20FreeBSDQt5.14/67/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Wed, 29 Apr 2020 13:54:50 + Build duration: 26 min and counting JUnit Tests Name: projectroot

D29156: [kcms/fonts] When adjusting all fonts, keep Small font size smaller

ngraham updated this revision to Diff 81515. ngraham marked an inline comment as done. ngraham added a comment. Align code and comment REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29156?vs=81438=81515 BRANCH

D29276: Bundle icons for inline messages

This revision was automatically updated to reflect the committed changes. Closed by commit R169:8a65fcefe42d: Bundle icons for inline messages (authored by nicolasfella). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29276?vs=81513=81516 REVISION DETAIL

D29080: [kcms/fonts] Guide users towards KScreen KCM for making things bigger on-screen

This revision was automatically updated to reflect the committed changes. Closed by commit R119:f96c10583a69: [kcms/fonts] Guide users towards KScreen KCM for making things bigger on-screen (authored by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D29156: [kcms/fonts] When adjusting all fonts, keep Small font size smaller

bport accepted this revision. bport added a comment. OK for me, as long as VDG is ok with this behavior INLINE COMMENTS > fonts.cpp:272 > +const int generalFontPointSize = font.pointSize(); > +if (generalFontPointSize > 8) { > +

D29276: Bundle icons for inline messages

nicolasfella created this revision. nicolasfella added a reviewer: Kirigami. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. REVISION SUMMARY Those are used in InlineMessage for the standard message types. We need to

KDE CI: Plasma » kwin » kf5-qt5 FreeBSDQt5.14 - Build # 66 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20FreeBSDQt5.14/66/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Wed, 29 Apr 2020 13:40:49 + Build duration: 2 min 50 sec and counting CONSOLE OUTPUT [...truncated

D29260: Set better default and minimum sizes for the desktop config window

ngraham abandoned this revision. ngraham added a comment. This isn't the right solution as it affects all applet config windows, not just the wallpaper one. Sorry about the noise. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D29260 To: ngraham, #vdg,

D25144: [RFC][Global Shortcuts KCM] Categorize into Applications and System Services

davidre abandoned this revision. davidre added a comment. Superseeded by total rewrite of the kcm REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25144 To: davidre, #plasma, mlaurent, ngraham Cc: mlaurent, ngraham, plasma-devel, Orage, LeGast00n,

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ngraham added a comment. In D28317#659659 , @ndavis wrote: > Try this colorscheme for a while and see what you think of it: F8270901: Breeze10.colors Not bad! I like that the buttons are lighter

D28473: BookmarksRunner: Early return and formatting

alex added a comment. Ping, regarding the question :-) REPOSITORY R120 Plasma Workspace BRANCH bookmarksrunner_firefox_fix_prep (branched from master) REVISION DETAIL https://phabricator.kde.org/D28473 To: alex, bruns, broulik, #plasma Cc: plasma-devel, Orage, LeGast00n,

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ndavis added a comment. Try this colorscheme for a while and see what you think of it: F8270896: BreezeDark10.colors REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D28317 To: ngraham, #vdg, #breeze Cc: ndavis, niccolove,

[sysadmin/repo-metadata] projects: projects: move new wayland repos to their final place

Git commit 53d913c3af459024d359c13def87db8913d8ed6b by Bhushan Shah. Committed on 29/04/2020 at 11:09. Pushed by bshah into branch 'master'. projects: move new wayland repos to their final place - plasma-wayland-protocols -> frameworks - kwayland-server -> kde/workspace Ref: T13052 CCMAIL:

D28878: Fix WidgetExplorer "get new widgets" always a new window opens instead of taking the focus to the already opened one

sunny added a comment. ping REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28878 To: sunny, #plasma Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed,

Information regarding upcoming Gitlab Migration: clarifications

Good afternoon, [Please keep sysad...@kde.org list or bs...@kde.org in the CC for replies] I want to clarify some bits for which we have gotten a questions about, - Non unique naming: There's some teams which prefer if we dropped the namespace- part from their name which we have added. While

D28744: Rewrite of the global shortcuts kcm

davidre added a comment. In D28744#659447 , @ngraham wrote: > I find that I'm not able to set shortcuts involving the space key. The key sequence get repeated twice in the button and the Apply button ever becomes enabled. Can you reproduce?

D29268: [WIP] Add Date/Time dialog

vkrause added a comment. There might be ways around the native function registration issue from the QML thread, e.g. by using the alternative approach of exported (mangled) symbols instead: https://docs.oracle.com/javase/1.5.0/docs/guide/jni/spec/design.html -> "Loading and Linking Native

D14949: Add option for whether to show the volume change OSD

anonym removed a reviewer: anonym. anonym added a comment. In D14949#659120 , @ngraham wrote: > In fact an option to hide the volume OSD was added in 5.19 already. Sadly I think we all forgot about this patch (sorry about that) but at least it's

KDE CI: Plasma » plasma-workspace » kf5-qt5 FreeBSDQt5.14 - Build # 74 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20FreeBSDQt5.14/74/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Wed, 29 Apr 2020 08:34:31 + Build duration: 6 min 51 sec and counting JUnit Tests Name:

KDE CI: Plasma » plasma-workspace » kf5-qt5 SUSEQt5.14 - Build # 61 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20SUSEQt5.14/61/ Project: kf5-qt5 SUSEQt5.14 Date of build: Wed, 29 Apr 2020 08:34:31 + Build duration: 6 min 19 sec and counting BUILD ARTIFACTS

D29226: [ksmserver] Use CommandLauncherJob for restoring applications

broulik added a comment. I did, oops, thanks :) https://cgit.kde.org/plasma-workspace.git/commit/?id=eebbf6d47a3e4e31697162eb082c3489aa1f506e REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29226 To: broulik, #plasma, dfaure Cc: jbbgameich, dfaure,

D29226: [ksmserver] Use CommandLauncherJob for restoring applications

jbbgameich added a comment. Did you possibly forget to commit the changes to the header file? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29226 To: broulik, #plasma, dfaure Cc: jbbgameich, dfaure, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev,

D28926: Signal player gone in "pagehide" not "beforeunload"

This revision was automatically updated to reflect the committed changes. Closed by commit R856:229a5e2c9565: Signal player gone in pagehide not beforeunload (authored by broulik). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE

KDE CI: Plasma » plasma-workspace » kf5-qt5 FreeBSDQt5.14 - Build # 73 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20FreeBSDQt5.14/73/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Wed, 29 Apr 2020 07:27:41 + Build duration: 4 min 40 sec and counting CONSOLE OUTPUT

KDE CI: Plasma » plasma-workspace » kf5-qt5 SUSEQt5.14 - Build # 60 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20SUSEQt5.14/60/ Project: kf5-qt5 SUSEQt5.14 Date of build: Wed, 29 Apr 2020 07:27:41 + Build duration: 2 min 12 sec and counting CONSOLE OUTPUT

D29226: [ksmserver] Use CommandLauncherJob for restoring applications

This revision was automatically updated to reflect the committed changes. Closed by commit R120:963f41e5593c: [ksmserver] Use CommandLauncherJob for restoring applications (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D29268: [WIP] Add Date/Time dialog

broulik added inline comments. INLINE COMMENTS > CMakeLists.txt:69 > +if(ANDROID) > +install(FILES > +"${CMAKE_CURRENT_BINARY_DIR}/KF5KirigamiAddonsConfig.cmake" Why this only on Android? or is that used for that dummy library? > FindGradle.cmake:2 > +#.rst: > +# FindGradle > +# --