Online sprint(?!)

So I am seeing this idea floating around in multiple occasion in Plasma IRC channel and as well on other places, but nothing concrete came up out of this discussion so I thought I should start formal discussion, Due to COVID-19 we had to skip our in-person sprint[1], however recently Plasma

D29727: Add mobile-friendly versions

This revision was automatically updated to reflect the committed changes. Closed by commit R31:9873c57ea383: Add mobile-friendly versions (authored by ngraham). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29727?vs=82774=82797 REVISION DETAIL

D29652: Automatically close Clipboard applet after clearing history or deleting the last element

ngraham added inline comments. INLINE COMMENTS > clipboard.qml:33 > Plasmoid.switchHeight: units.gridUnit * 5 > -Plasmoid.status: clipboardSource.data["clipboard"]["empty"] ? > PlasmaCore.Types.PassiveStatus : PlasmaCore.Types.ActiveStatus > Plasmoid.toolTipMainText:

D29694: Introduce Avatar component

ratijastk added a comment. Cool thing. Makes me think of Nintendo Mii, and their open source counterpart, bloke (which is not really used anywhere, but whatever). Also, can we have name resolution algorithm extracted elsewhere, in a more re-usable

D29726: BookmarksRunner: Change caching databases

alex updated this revision to Diff 82790. alex added a comment. Add space REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29726?vs=82789=82790 BRANCH avid_unnecessary_copying (branched from master) REVISION DETAIL

D29726: BookmarksRunner: Change caching databases

alex updated this revision to Diff 82789. alex retitled this revision from "WIP BookmarksRunner: Change caching databases" to "BookmarksRunner: Change caching databases". alex edited the summary of this revision. alex edited the test plan for this revision. alex added a comment. Copy chrome

D28627: Adaptive panel opacity

ngraham added a comment. I still don't notice what you're trying to point out, so I'll take your word for it. :p REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28627 To: cblack, #plasma, davidedmundson, niccolove, #vdg Cc: apol, ngraham, davidedmundson,

D28627: Adaptive panel opacity

niccolove added a comment. In D28627#652806 , @ngraham wrote: > In D28627#652538 , @niccolove wrote: > > > Actually -- this seems to no longer apply panel internal margins? > > > Works for me.

D29140: Fix POTD in lock screen (complete)

ngraham resigned from this revision. ngraham added reviewers: davidre, broulik. ngraham added a comment. It works! Great job. I'd like #plasma people to review this as well, and I think we should wait until after 5.19 branches before landing it,

D29694: Introduce Avatar component

cblack updated this revision to Diff 82783. cblack added a comment. Avoid trying to display initials of non-Latin characters REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29694?vs=82780=82783 BRANCH cblack/avatar (branched from master) REVISION

D29694: Introduce Avatar component

ngraham added a comment. +1 overall. I notice that this algorithm will return "KB" for Kai Uwe Broulik and HC for Hugo Pereira da Costa. Is that right? Names are hard. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D29694 To: cblack, #kirigami, #vdg Cc:

D29694: Introduce Avatar component

ngraham added a comment. In D29694#669873 , @filipf wrote: > Cool stuff. The commit message needs to be expanded to explain where and how this will be used, and also needs to list key implentation feats (initials, colors). > > I believe we

D29694: Introduce Avatar component

cblack created this revision. cblack added reviewers: Kirigami, VDG. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. filipf added a comment. cblack updated this revision to Diff 82775. cblack edited the test plan for this revision. cblack updated this revision to Diff

D29727: Add mobile-friendly versions

ngraham created this revision. ngraham added reviewers: VDG, bshah. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Unfortunately this wallpaper is very landscape-centric in design, so it is not very

D29688: Exclude all loop devices from partition and disk sensors

This revision was automatically updated to reflect the committed changes. Closed by commit R106:f4e2c2022cd7: Exclude all loop devices from partition and disk sensors (authored by ahiemstra). REPOSITORY R106 KSysguard CHANGES SINCE LAST UPDATE

D29726: WIP BookmarksRunner: Change caching databases

alex created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. alex requested review of this revision. REVISION SUMMARY The copying/updating of the cache has been removed from the FetchSqlite class. This allows the browsers to have handle the caching

D29721: Add context to translated strings and clarify some strings

This revision was automatically updated to reflect the committed changes. Closed by commit R106:857eff12328e: Add context to translated strings and clarify some strings (authored by ahiemstra). REPOSITORY R106 KSysguard CHANGES SINCE LAST UPDATE

Re: kwallet-pam >= 5.18.4 and ecryptfs homes

> > Opinions? It's a tough situation, with no good answer. >SOLUTION 2: > * Ignore it and hope people will read my blog https://tsdgeos.blogspot.com/2020/05/kwallet-pam-5184-and-ecryptfs-homes.html We can simplify the bit about needing another user. If you use sudo mount --bind /

D29721: Add context to translated strings and clarify some strings

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. more context never hurts. Good idea REPOSITORY R106 KSysguard BRANCH translation_context REVISION DETAIL https://phabricator.kde.org/D29721 To: ahiemstra, #plasma,

D29721: Add context to translated strings and clarify some strings

ahiemstra created this revision. ahiemstra added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ahiemstra requested review of this revision. REVISION SUMMARY Many of the shorter strings are not really informative, so add context so translators can

D29351: [sddm-theme] Prevent the logo from leaking in after a fadeout

This revision was automatically updated to reflect the committed changes. Closed by commit R120:68601675d13b: [sddm-theme] Prevent the logo from leaking in after a fadeout (authored by filipf). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D29710: [Fonts KCM] Remove last remnants of setNearestExistingFonts()

ahmadsamir added a comment. Continuing the discussion from IRC, plasma 5.18 branch still uses QFontDialog, so https://bugs.kde.org/show_bug.cgi?id=420287 isn't directly related. However if users remove the ',Regular' bit from kdeglobals, QFontDialog will probably select the wrong style

D29394: Add photographic user avatars

This revision was automatically updated to reflect the committed changes. Closed by commit R128:13e73011b1ac: Add photographic user avatars (authored by filipf). REPOSITORY R128 User Manager CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29394?vs=82748=82762 REVISION DETAIL

D29710: [Fonts KCM] Remove last remnants of setNearestExistingFonts()

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. For the stable branch, we will need a patch that conditionally disables all of this stuff if you happen to have Frameworks 5.69 or newer. We don't want the stable branch to be broken for

D29710: [Fonts KCM] Remove last remnants of setNearestExistingFonts()

ahmadsamir added a comment. In D29710#670151 , @ahmadsamir wrote: > Also, is it OK to backport https://commits.kde.org/plasma-desktop/0325d698181055cdaaa93b24ee80172132822d35 and this diff to Plasma/5.18? Scratch that, 5.18 min.

D29394: Add photographic user avatars

ngraham accepted this revision. ngraham added a comment. Shipit! REPOSITORY R128 User Manager BRANCH add-photo-avatars (branched from master) REVISION DETAIL https://phabricator.kde.org/D29394 To: filipf, #vdg, ngraham Cc: jriddell, cblack, ognarb, plasma-devel, Orage, LeGast00n,

D29717: Fix translation domain for ksysguard plugins

davidedmundson created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REPOSITORY R106 KSysguard BRANCH master REVISION DETAIL https://phabricator.kde.org/D29717 AFFECTED FILES

D29716: [applet] Show KCM in System Settings

ngraham created this revision. ngraham added reviewers: jgrulich, mart, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added 1 blocking reviewer(s): jgrulich. ngraham requested review of this revision. REVISION SUMMARY CCBUG: 417836 Depends on

D29714: [applets] Show KCMs in System Settings

ngraham created this revision. ngraham added reviewers: mart, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY BUG: 417836 FIXED-IN: 5.20 Depends on D29711

D29713: [applets] Show KCMs in System Settings

ngraham created this revision. ngraham added reviewers: mart, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY CCBUG: 417836 Depends on D29711 As this will

D29712: [applets] Show KCMs in System Settings or Info Center, as appropriate

ngraham created this revision. ngraham added reviewers: mart, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY CCBUG: 417836 Depends on D29711 As this will

D29394: Add photographic user avatars

filipf updated this revision to Diff 82748. filipf added a comment. don't delete user_manager.kdev4 REPOSITORY R128 User Manager CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29394?vs=82746=82748 BRANCH add-photo-avatars (branched from master) REVISION DETAIL

D29706: support translations in faces

This revision was automatically updated to reflect the committed changes. Closed by commit R111:ee2ff95bcbab: support translations in faces (authored by mart). REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29706?vs=82743=82747 REVISION DETAIL

D29710: [Fonts KCM] Remove last remnants of setNearestExistingFonts()

ahmadsamir added a comment. Also, is it OK to backport https://commits.kde.org/plasma-desktop/0325d698181055cdaaa93b24ee80172132822d35 and this diff to Plasma/5.18? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D29710 To: ahmadsamir, #plasma, bport,

D29394: Add photographic user avatars

filipf updated this revision to Diff 82746. filipf added a comment. Make as REUSE compliant as possible REPOSITORY R128 User Manager CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29394?vs=82732=82746 BRANCH add-photo-avatars (branched from master) REVISION DETAIL

D29710: [Fonts KCM] Remove last remnants of setNearestExistingFonts()

ahmadsamir created this revision. ahmadsamir added reviewers: Plasma, bport, broulik. Herald added a project: Plasma. ahmadsamir requested review of this revision. REVISION SUMMARY This cleans up after commit 0325d698181055cdaaa93

D29706: support translations in faces

mart updated this revision to Diff 82743. mart added a comment. - i18nd REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29706?vs=82741=82743 BRANCH phab/i18n REVISION DETAIL https://phabricator.kde.org/D29706 AFFECTED FILES

D29706: support translations in faces

mart updated this revision to Diff 82741. mart added a comment. - add own context for the internal qml files REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29706?vs=82726=82741 BRANCH phab/i18n REVISION DETAIL

D29394: Add photographic user avatars

filipf added a comment. In D29394#670076 , @ngraham wrote: > The .license files could live in another folder. Maybe `src/pics_sources`? Yeah I can do that as well REPOSITORY R128 User Manager BRANCH add-photo-avatars (branched from

D28154: Add users KCM

broulik added inline comments. INLINE COMMENTS > ngraham wrote in UserDetailsPage.qml:217 > FWIW KCMs opened through KRunner are now opened in System Settings so > KCMShell is something we're going to have to deal with much less. :) Yes, but it's still something to consider. Right now Esc does

D28154: Add users KCM

ngraham added inline comments. INLINE COMMENTS > broulik wrote in UserDetailsPage.qml:217 > Can you add some way to make Escape close the sheet but not the entire KCM, > when run standalone through kcmshell? Hopefully the following is sufficient, > otherwise you'd have to mess with

D29706: support translations in faces

mart added a comment. In D29706#669968 , @davidedmundson wrote: > Who extracts and loads the translations for: > > ./ConfigAppearance.qml > ./ConfigSensors.qml > ./FaceDetailsConfig.qml > ./UsedSensorsView.qml > > in the top

D28154: Add users KCM

broulik added a comment. Pretty cool INLINE COMMENTS > UserDetailsPage.qml:36 > + > +property variant user > +property bool overrideImage: false Use `property var`, or even `property QtObject` since `User` is a `QObject` > UserDetailsPage.qml:82 > +id: fileDialog > +

D29709: Give all OverlaySheets consistent headers

ngraham marked an inline comment as done. ngraham added inline comments. INLINE COMMENTS > GB_2 wrote in UpdatesPage.qml:39 > "Update Issue" Oops, thanks. Fixed in 11cf0dc694f92551f75617b664cd3e7e49e98df8 . REPOSITORY

D29709: Give all OverlaySheets consistent headers

GB_2 added inline comments. INLINE COMMENTS > UpdatesPage.qml:39 > id: sheet > +header: Kirigami.Heading { text: i18n("Update issue") } > + "Update Issue" REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D29709 To: ngraham, apol,

D29688: Ignore mount paths that start with '/snap/'

ahiemstra updated this revision to Diff 82738. ahiemstra added a comment. - Exclude all loop devices from partition and disk sensors REPOSITORY R106 KSysguard CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29688?vs=82682=82738 BRANCH ignore_snap_partitions REVISION DETAIL

D29394: Add photographic user avatars

ngraham added a comment. The .license files could live in another folder. Maybe `src/pics_sources`? REPOSITORY R128 User Manager BRANCH add-photo-avatars (branched from master) REVISION DETAIL https://phabricator.kde.org/D29394 To: filipf, #vdg, ngraham Cc: jriddell, cblack, ognarb,

D29394: Add photographic user avatars

filipf added a comment. In D29394#670030 , @jriddell wrote: > Looks good for licence freedom > > Could you make the licence info in format specified at https://reuse.software/tutorial/ ? It's what we want to use from now on in KDE. > >

D29709: Give all OverlaySheets consistent headers

leinir accepted this revision. leinir added a comment. Yay consistency! Good idea (and timely ;) ) REPOSITORY R134 Discover Software Store BRANCH master REVISION DETAIL https://phabricator.kde.org/D29709 To: ngraham, apol, #discover_software_store, #vdg, leinir Cc: leinir,

D29709: Give all OverlaySheets consistent headers

This revision was automatically updated to reflect the committed changes. Closed by commit R134:fb1880d436a8: Give all OverlaySheets consistent headers (authored by ngraham). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29709?vs=82735=82736

D29709: Give all OverlaySheets consistent headers

ngraham updated this revision to Diff 82735. ngraham marked an inline comment as done. ngraham added a comment. Remove testing thingy that snuck in REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29709?vs=82734=82735 BRANCH master

D29709: Give all OverlaySheets consistent headers

ngraham marked an inline comment as done. ngraham added a comment. String freeze is tomorrow. INLINE COMMENTS > apol wrote in ApplicationPage.qml:282 > I guess this was for testing? Yes, to work around ODRS flakiness. :( REPOSITORY R134 Discover Software Store REVISION DETAIL

D29709: Give all OverlaySheets consistent headers

apol added a comment. +1 for the change btw, thanks! REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D29709 To: ngraham, apol, #discover_software_store, #vdg Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus,

D29709: Give all OverlaySheets consistent headers

apol added a comment. We are in string freeze right now, aren't we? INLINE COMMENTS > ApplicationPage.qml:282 > enabled: appInfo.application.isInstalled > -visible: reviewsModel.backend && > reviewsModel.backend.isResourceSupported(appInfo.application) > +//

D29394: Add photographic user avatars

jriddell added a comment. Looks good for licence freedom Could you make the licence info in format specified at https://reuse.software/tutorial/ ? It's what we want to use from now on in KDE. So add cat.jpg.license files with SPDX header lines saying CC0 and add

D29709: Give all OverlaySheets consistent headers

ngraham created this revision. ngraham added reviewers: apol, Discover Software Store, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY OverlaySheet has a `header:` property typically used to give the sheet

D29394: Add photographic user avatars

filipf updated this revision to Diff 82732. filipf added a comment. rework licensing stucture due to a flaw in user_manager (it shows every single file in the avatar gallery and the .license files break it) REPOSITORY R128 User Manager CHANGES SINCE LAST UPDATE

D29506: rejigger lookup of services by exec

sitter updated this revision to Diff 82731. sitter added a comment. s/%5/%4 REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29506?vs=82197=82731 BRANCH master REVISION DETAIL https://phabricator.kde.org/D29506 AFFECTED FILES

D29688: Ignore mount paths that start with '/snap/'

ahiemstra added a comment. In D29688#669867 , @anthonyfieroni wrote: > Should it /var/lib/flatpak (or just /flatpak/) be included as well? Flatpak doesn't use mounts for this as far as I can tell, or at least they don't show up in mtab.

D29703: Disable horizontal scrollbar in systemtray settings

davidre updated this revision to Diff 82728. davidre added a comment. do it for all REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29703?vs=82721=82728 BRANCH scroll (branched from Plasma/5.18) REVISION DETAIL

D29024: feat(wayland): support multiple protocol extensions through plugin system

dvratil added a comment. If I may add my two cents here, I agree with David that introducing a plugin for a plugin is a bit over the top. Whats the issue with contributing your backend into libkscreen upstream instead? If there's any code that could be shared between KWayland backend and

D29706: support translations in faces

davidedmundson added a comment. Who extracts and loads the translations for: ./ConfigAppearance.qml ./ConfigSensors.qml ./FaceDetailsConfig.qml ./UsedSensorsView.qml in the top level of faces but not in an individual package. code for the other stuff looks

D29704: [kcms/baloo] Disable horizonal scrollbar

davidre updated this revision to Diff 82727. davidre added a comment. Do it for every scrollview REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29704?vs=82722=82727 BRANCH scroll (branched from Plasma/5.18) REVISION DETAIL

D29706: support translations in faces

mart created this revision. mart added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY give each face its own catalog REPOSITORY R111 KSysguard Library BRANCH phab/i18n REVISION DETAIL

D29688: Ignore mount paths that start with '/snap/'

IlyaBizyaev added a comment. Maybe also /var/lib/docker? REPOSITORY R106 KSysguard BRANCH ignore_snap_partitions REVISION DETAIL https://phabricator.kde.org/D29688 To: ahiemstra, #plasma, davidedmundson Cc: IlyaBizyaev, anthonyfieroni, jriddell, plasma-devel, Orage, LeGast00n,

D29701: Disable horizontal scrollbar in kcm

jgrulich accepted this revision. jgrulich added a comment. This revision is now accepted and ready to land. I would say push it also to master. REPOSITORY R116 Plasma Network Management Applet BRANCH master REVISION DETAIL https://phabricator.kde.org/D29701 To: davidre, broulik,

D29704: [kcms/baloo] Disable horizonal scrollbar

davidre created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidre requested review of this revision. REVISION SUMMARY We need to hardcode it now because of QTBUG-83890. CCBUG: 419514 REPOSITORY R119 Plasma Desktop BRANCH scroll (branched

D29703: Disable horizontal scrollbar in systemtray settings

davidre created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidre requested review of this revision. REVISION SUMMARY We need to hardcode it now because of QTBUG-83890. CCBUG: 419514 REPOSITORY R120 Plasma Workspace BRANCH scroll

D29701: Disable horizontal scrollbar in kcm

davidre added a comment. Should this go to master, too? Or should we hope that we need the workaround only for 5.18 and 5.19 and the qtbug will be fixed eventually? REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D29701 To: davidre, broulik,

D29701: Disable horizontal scrollbar in kcm

davidre updated this revision to Diff 82719. davidre added a comment. . REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29701?vs=82718=82719 BRANCH master REVISION DETAIL https://phabricator.kde.org/D29701 AFFECTED FILES

D29701: Disable horizontal scrollbar in kcm

davidre created this revision. davidre added a reviewer: broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added a reviewer: jgrulich. davidre requested review of this revision. REVISION SUMMARY We need to hardcode it now because of QTBUG-83890. CCBUG:

D29688: Ignore mount paths that start with '/snap/'

jriddell added a comment. bug at https://bugs.kde.org/show_bug.cgi?id=421419 REPOSITORY R106 KSysguard BRANCH ignore_snap_partitions REVISION DETAIL https://phabricator.kde.org/D29688 To: ahiemstra, #plasma, davidedmundson Cc: anthonyfieroni, jriddell, plasma-devel, Orage, LeGast00n,

D29688: Ignore mount paths that start with '/snap/'

anthonyfieroni added a comment. Should it /var/lib/flatpak (or just /flatpak/) be included as well? REPOSITORY R106 KSysguard BRANCH ignore_snap_partitions REVISION DETAIL https://phabricator.kde.org/D29688 To: ahiemstra, #plasma, davidedmundson Cc: anthonyfieroni, jriddell,

D29688: Ignore mount paths that start with '/snap/'

jriddell added a comment. This didn't seem to work for me when I compiled and installed it and rebooted to check, still takes lots of disk to make the computer unuseable REPOSITORY R106 KSysguard BRANCH ignore_snap_partitions REVISION DETAIL https://phabricator.kde.org/D29688 To:

D29687: [IconApplet] Port KRun to ApplicationLauncherJob

ahmadsamir added a comment. I forgot to submit my reply to your inline comment INLINE COMMENTS > broulik wrote in iconapplet.cpp:435 > `m_localPath` is a *path* so you want `serviceByDesktopPath` I tried that first, and it doesn't work; those .desktop files are in a

D29700: Add a show label option to the pie chart face

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY To control the large "20%" text in the middle of a pie which can be

D29687: [IconApplet] Port KRun to ApplicationLauncherJob

ahmadsamir updated this revision to Diff 82714. ahmadsamir added a comment. Use KNotificationJobUiDelegate REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29687?vs=82681=82714 BRANCH l-krun-port (branched from master) REVISION DETAIL

D27513: Kill Runner: Remove duplicate function calls and refactor

This revision was automatically updated to reflect the committed changes. Closed by commit R120:6f103ebd7b3a: Kill Runner: Remove duplicate function calls and refactor (authored by alex). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D29687: [IconApplet] Port KRun to ApplicationLauncherJob

broulik requested changes to this revision. broulik added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > iconapplet.cpp:435 > > -new KRun(QUrl::fromLocalFile(m_localPath), QApplication::desktop()); > +KIO::ApplicationLauncherJob *job = new >