Re: Homerun sources and Plasma runners

2012-11-20 Thread Aaron J. Seigo
of inverting the design. -- Aaron J. Seigo signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: SystemTray: alignment of popup dialog

2012-11-19 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107378/#review22205 --- Ship it! Ship It! - Aaron J. Seigo On Nov. 19, 2012, 8:08

Re: SystemTray: pop-up window position

2012-11-19 Thread Aaron J. Seigo
On Monday, November 19, 2012 11:09:57 Marco Martin wrote: everybody give a try to see how it looks i've made a similar change in tasks widget, along with a tweak to the group indicator drawing. -- Aaron J. Seigo signature.asc Description: This is a digitally signed message part

Re: Homerun sources and Plasma runners

2012-11-19 Thread Aaron J. Seigo
is there, Homerun and KRunner can use it differently. agreed; in my other email i suggest one possible way to accomplish this that is SC and BC even :) -- Aaron J. Seigo signature.asc Description: This is a digitally signed message part. ___ Plasma-devel

Re: Homerun sources and Plasma runners

2012-11-19 Thread Aaron J. Seigo
On Monday, November 19, 2012 15:31:46 Aurélien Gâteau wrote: Le samedi 17 novembre 2012 12:56:13 Aaron J. Seigo a écrit : On Friday, November 16, 2012 17:04:04 Aurélien Gâteau wrote: Sources features missing in Runners: - model-based = more QML friendly as with Marco, i don't see any

Re: SystemTray: pop-up window position

2012-11-18 Thread Aaron J. Seigo
On Saturday, November 17, 2012 19:36:27 Marco Martin wrote: On Saturday 17 November 2012, Aaron J. Seigo wrote: like if is more than ~20 characters wide, we would assume is not something serving as a simple menu, but is a complex thing, so center... or maybe just compare the popup size

Re: SystemTray: pop-up window position

2012-11-17 Thread Aaron J. Seigo
. what may be missing in the QML bindings is a way to access that function, and it is not great if one has to write C++ just to figure out where something should popup. my proposal is to add a plasmoid.popupPosition(popupFromItem, itemToPopup, alignment) function .. thoughts? -- Aaron J. Seigo

Re: Homerun sources and Plasma runners

2012-11-17 Thread Aaron J. Seigo
. this would be very, very handy for runners that can return large datasets, such as music player listings, nepomuk searches, etc. that is something that is probably easiest to add directly to libplasma2 and should not be targetted for libplasma1 in any way. -- Aaron J. Seigo signature.asc Description

Re: Review Request: DBus-interface for changing wallpapers

2012-11-17 Thread Aaron J. Seigo
://git.reviewboard.kde.org/r/105319/#comment17009 see Frame::setImageAsWallpaper in kdeplasma-addons/applets/frame/frame.cpp for how this ought to be done. - Aaron J. Seigo On July 1, 2012, 5:56 a.m., Varun Herale wrote: --- This is an automatically

Re: SystemTray: pop-up window position

2012-11-17 Thread Aaron J. Seigo
On Saturday, November 17, 2012 13:25:01 Marco Martin wrote: On Saturday 17 November 2012, Aaron J. Seigo wrote: On Friday, November 16, 2012 18:57:17 Dmitry A. Ashkadov wrote: 2. At center: this has been the standard alignment for several releases for popups. it looks nice, minimizes

Re: SystemTray: pop-up window position

2012-11-17 Thread Aaron J. Seigo
said that the tooltips are harder / slower to read.) -- Aaron J. Seigo signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Homerun sources and Plasma runners

2012-11-17 Thread Aaron J. Seigo
to accurately determine cost of using a given library, such as libplasma. i really dislike designing with such placebo effects as requirements. -- Aaron J. Seigo signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma

Re: SystemTray: pop-up window position

2012-11-17 Thread Aaron J. Seigo
On Saturday, November 17, 2012 14:03:59 Marco Martin wrote: On Saturday 17 November 2012, Aaron J. Seigo wrote: and really, if the item the popup originates from is really bigger than the popup, the popup probably should be centered on the press event position. if triggered via a non

Re: Review Request: fix battery presence detection problem

2012-11-16 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107333/#review22076 --- Ship it! Ship It! - Aaron J. Seigo On Nov. 15, 2012, 8:04

Re: Introducing Homerun

2012-11-15 Thread Aaron J. Seigo
On Thursday, November 15, 2012 14:47:18 Alex Fiestas wrote: On Wednesday 14 November 2012 09:35:48 Aaron J. Seigo wrote: if you search for webaccounts in krunner, what do you get? Well, we have a few issues with the runners involved on this, so the results are not perfect. heh.. yes

Re: Introducing Homerun

2012-11-14 Thread Aaron J. Seigo
while a trail of cues is presented to them. iow, i'd like to see short interactive tours of essential functionality to get people off to a running start so that they can be effective quickly and have a higher level of confidence as a result (which can lead to increased exploration) -- Aaron J

Re: Introducing Homerun

2012-11-14 Thread Aaron J. Seigo
On Tuesday, November 13, 2012 16:56:29 Alex Fiestas wrote: On Tuesday 13 November 2012 15:56:11 Aaron J. Seigo wrote: On Tuesday, November 13, 2012 13:13:36 Alex Fiestas wrote: On Tuesday 13 November 2012 11:21:34 Marco Martin wrote: agree on above points, i'm not sure how much

Re: Introducing Homerun

2012-11-14 Thread Aaron J. Seigo
On Wednesday, November 14, 2012 11:30:58 Aurélien Gâteau wrote: Le mardi 13 novembre 2012 11:23:00 Aaron J. Seigo a écrit : krunnermodel, a Qt model that comes with a QML component plugin (so you can just import and use it directly) is in kde-runtime/plasma/declarativeimports I know

Re: Kickoff-QML in 4.10 ?

2012-11-14 Thread Aaron J. Seigo
away. this could well be a bug in PlasmaExtras.ScrollArea rather than in the kickoff-qml. -- Aaron J. Seigo signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org

Re: Review Request: Plasmate: Fix typo on remoteinstaller.ui and give more sane names to labels.

2012-11-14 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107312/#review21977 --- Ship it! Ship It! - Aaron J. Seigo On Nov. 13, 2012, 6:20

Re: Review Request: Show a album cover in the track view if a cover is available. At the moment only a placeholder is displayed.

2012-11-14 Thread Aaron J. Seigo
/metadatamusiccomponents/MediaBrowser.qml http://git.reviewboard.kde.org/r/107325/#comment16898 hardcoded? browsingbackends/metadatabackends/metadatamusicbackend/metadatamusiccomponents/MediaBrowser.qml http://git.reviewboard.kde.org/r/107325/#comment16899 hardcoded? - Aaron J. Seigo

Re: Review Request: Show a album cover in the track view if a cover is available. At the moment only a placeholder is displayed.

2012-11-14 Thread Aaron J. Seigo
really doing the majority of work and maintenance on it, but it looks good to me. - Aaron J. Seigo On Nov. 14, 2012, 12:09 p.m., Fabian Riethmayer wrote: --- This is an automatically generated e-mail. To reply, visit: http

Re: Introducing Homerun

2012-11-14 Thread Aaron J. Seigo
On Wednesday, November 14, 2012 15:05:09 Aurélien Gâteau wrote: Le mercredi 14 novembre 2012 12:33:55 Aaron J. Seigo a écrit : On Wednesday, November 14, 2012 11:30:58 Aurélien Gâteau wrote: Le mardi 13 novembre 2012 11:23:00 Aaron J. Seigo a écrit : krunnermodel, a Qt model that comes

Re: Introducing Homerun

2012-11-13 Thread Aaron J. Seigo
On Monday, November 12, 2012 17:02:41 Aurélien Gâteau wrote: Le dimanche 11 novembre 2012 12:02:58 Aaron J. Seigo a écrit : On Friday, November 9, 2012 23:09:35 Aurélien Gâteau wrote: As you can see, it is a fullscreen launcher with content organized in tabs. i find it to be a very

Re: small regression with new qml pager

2012-11-13 Thread Aaron J. Seigo
to accepts) but nothing happens when the drop is completed. -- Aaron J. Seigo signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Plasmate: The publisher can now return the error of the cmake. Publisher no longer need the $KDEDIRS

2012-11-13 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107278/#review21923 --- Ship it! Ship It! - Aaron J. Seigo On Nov. 12, 2012, 9:39

Re: Review Request: Rework of metadatamusic qml components.

2012-11-13 Thread Aaron J. Seigo
screenshots? thanks. - Aaron J. Seigo On Nov. 12, 2012, 6:04 p.m., Fabian Riethmayer wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107299

Re: Introducing Homerun

2012-11-13 Thread Aaron J. Seigo
algorithm could address these kinds of issues. -- Aaron J. Seigo signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Introducing Homerun

2012-11-13 Thread Aaron J. Seigo
with this body of information and then start designing. full listings, hierarchies and free search all have their sweet spots for people and a good launcher will utilize them. -- Aaron J. Seigo signature.asc Description: This is a digitally signed message part

Re: Introducing Homerun

2012-11-13 Thread Aaron J. Seigo
On Tuesday, November 13, 2012 12:33:35 Nuno Pinheiro wrote: Yes this is interesting stuf... The key thing here is how do we pull it of without anying the user to bits... i plan to run some controlled user testing of this mechanism so we will know for sure and not have to guess. -- Aaron J

Re: Introducing Homerun

2012-11-13 Thread Aaron J. Seigo
as possible show a useful result in the first half dozen or so returns. other interfaces using runners to do the work may work differently as they have different use case targets. that's why we split data and presentation. -- Aaron J. Seigo signature.asc Description: This is a digitally signed message

Re: Review Request: Rework of metadatamusic qml components.

2012-11-13 Thread Aaron J. Seigo
, but in future, please have the person who peer reviews the patch mark the review with ShipIt! so that we know it has actually seen peer review. thanks :) - Aaron J. Seigo On Nov. 13, 2012, 11:11 a.m., Fabian Riethmayer wrote

Re: Review Request: Plasmate: Rename windowswitcher and remote-widgets-browser

2012-11-13 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107221/#review21936 --- Ship it! Ship It! - Aaron J. Seigo On Nov. 5, 2012, 5:06

Re: Review Request: Plasmate: Fix the hard coded names of plasmateremoteinstaller and plasmateprevierlog

2012-11-13 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107212/#review21937 --- Ship it! Ship It! - Aaron J. Seigo On Nov. 5, 2012, 2:51

small regression with new qml pager

2012-11-11 Thread Aaron J. Seigo
. anyone feel up to the task? :) -- Aaron J. Seigo signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Introducing Homerun

2012-11-11 Thread Aaron J. Seigo
running in single runner mode. -- Aaron J. Seigo signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Plasmate: Replace font strings with KMessageWidget

2012-11-11 Thread Aaron J. Seigo
://git.reviewboard.kde.org/r/107279/#comment16839 maybe tell them what the directory is? - Aaron J. Seigo On Nov. 10, 2012, 5:48 p.m., Antonis Tsiapaliokas wrote: --- This is an automatically generated e-mail. To reply, visit: http

Re: Review Request: Plasmate: The publisher can now return the error of the cmake. Publisher no longer need the $KDEDIRS

2012-11-11 Thread Aaron J. Seigo
/#comment16842 consider using a KMessageWidget here as well? plasmate/publisher/publisher.cpp http://git.reviewboard.kde.org/r/107278/#comment16843 KMessageWidget? - Aaron J. Seigo On Nov. 10, 2012, 5:06 p.m., Antonis Tsiapaliokas wrote

Re: Review Request: Make sure ksmserver ignores excluded apps when saving session

2012-11-11 Thread Aaron J. Seigo
catch 1 and 4, however, was in case there were binaries of the same name in different paths that should be treated differently (allowing differentiation by full path).. Lubos will certainly have more insight on this, however. - Aaron J. Seigo On Nov. 10, 2012, 12:45 p.m., Jekyll Wu

Re: Review Request: Class Plasmoid is merged to SystemTray::Applet

2012-11-09 Thread Aaron J. Seigo
shape ... - Aaron J. Seigo On Nov. 9, 2012, 9:59 a.m., Dmitry Ashkadov wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107262

Re: Review Request: Class Plasmoid is merged to SystemTray::Applet

2012-11-09 Thread Aaron J. Seigo
On Nov. 9, 2012, 10:52 a.m., Aaron J. Seigo wrote: nice work :) it's really coming into a very good shape ... Dmitry Ashkadov wrote: But there is one problem: property id of Plasma::Applet isn't a constant for now, so, there are warnings in stdout. .. already fixed in kdelibs

Re: Review Request: Port the Calculator applet to QML

2012-11-08 Thread Aaron J. Seigo
On Nov. 8, 2012, 9:33 a.m., Marco Martin wrote: style is quite ok to me now. functions could still be changed to function foo() { ... } actually, the style was finally updated to: function foo() { } so no need to adjust this :) - Aaron J.

Re: Review Request: SystemTray: Refactoring: UiTask and TasksPool have been removed

2012-11-08 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107160/#review21618 --- Ship it! Ship It! - Aaron J. Seigo On Nov. 7, 2012, 3:20

Re: KDEREVIEW: share like connect and plasmate

2012-11-08 Thread Aaron J. Seigo
is integrated with the (needs to be secure) gpg passphrase infrastructure. that is not the case here, so it can easily use KPasswordDialog. -- Aaron J. Seigo signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list

Re: QML style guide

2012-11-07 Thread Aaron J. Seigo
Practices for these thanks :) -- Aaron J. Seigo signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Plasmate: Port QDialog to KDialog

2012-11-07 Thread Aaron J. Seigo
On Nov. 7, 2012, 12:33 a.m., Aleix Pol Gonzalez wrote: I'm unsure what's the reasoning behind, but isn't that exactly the opposite direction we want to go with KF5? Luis Gabriel Lima wrote: +1 we don't have KF5 yet, however, and feedback from kdereview was to use KDialog. if we

Re: Review Request: SystemTray: Refactoring: UiTask and TasksPool have been removed

2012-11-07 Thread Aaron J. Seigo
On Nov. 6, 2012, 1:39 p.m., Aaron J. Seigo wrote: one small issue with where hiding status is kept. it may be useful to keep in mind the difference between the data and the visualization - anything that the use can see (e.g. whether an icon is hidden or not) is visualization

kwin scripted effects - easing curves?

2012-11-07 Thread Aaron J. Seigo
hi.. this one is mostly for Martin G, i suppose: in the kwin scripting API for effects, the animate function can take a QEasingCurve .. however i do not see how to create one from the javascript. is this simply functionality that is currently missing, or? -- Aaron J. Seigo signature.asc

Re: Review Request: SystemTray: Refactoring: UiTask and TasksPool have been removed

2012-11-07 Thread Aaron J. Seigo
On Nov. 6, 2012, 1:39 p.m., Aaron J. Seigo wrote: one small issue with where hiding status is kept. it may be useful to keep in mind the difference between the data and the visualization - anything that the use can see (e.g. whether an icon is hidden or not) is visualization

Re: KDEREVIEW: share like connect and plasmate

2012-11-06 Thread Aaron J. Seigo
regardless of whether setTags failed or not indeed; legacy from usage in Active where nepomuk is always on. will fix next. -- Aaron J. Seigo signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org

Re: QML style guide

2012-11-06 Thread Aaron J. Seigo
to have on first line opening brace for functions: function foo() { ... code in kdelibs style ... } as that was the consensus on this list. otherwise, everything seem to be agreeable.. so let's all start using it! -- Aaron J. Seigo signature.asc Description: This is a digitally signed

Re: Review Request: load the images for the themes correctly

2012-11-06 Thread Aaron J. Seigo
On Nov. 2, 2012, 10:20 a.m., Aaron J. Seigo wrote: plasmate/packagemodel.cpp, lines 546-551 http://git.reviewboard.kde.org/r/106680/diff/4/?file=93274#file93274line546 this looks wrong; in the Package definition there is an entry for colors. even if it is not created by default

Re: Review Request: SystemTray: Refactoring: UiTask and TasksPool have been removed

2012-11-06 Thread Aaron J. Seigo
, which can be used by the visualization (e.g. system tray) to determine whether to show it or not. plasma/generic/applets/systemtray/ui/widgetitem.h http://git.reviewboard.kde.org/r/107160/#comment16710 this is where the hiding status should be kept rather than in Task. - Aaron J. Seigo

Re: QML style guide

2012-11-06 Thread Aaron J. Seigo
patterns ... -- Aaron J. Seigo signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Plasmate: Add Localisation to timeline

2012-11-06 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107231/#review21510 --- Ship it! Ship It! - Aaron J. Seigo On Nov. 6, 2012, 9:59

Re: PLASMA_PLATFORM and kdeglobals runtimePlatform

2012-11-02 Thread Aaron J. Seigo
On Thursday, November 1, 2012 23:09:55 Marco Martin wrote: should platformcomponents be added internally? this was done in kdelibs ad5036bae4f8518394cf27986f9f90afd9703314 on Oct 31 -- Aaron J. Seigo signature.asc Description: This is a digitally signed message part

Re: Review Request: load the images for the themes correctly

2012-11-02 Thread Aaron J. Seigo
if it is not created by default it should still show up in the model. the whole point of this model, after all, is to have a generic way to represent a Plasma::Package. same with the checks for Plasma/Theme in the data() method. none of these should be necessary. - Aaron J. Seigo On Nov. 2

Re: Review Request: Port the Calculator applet to QML

2012-11-02 Thread Aaron J. Seigo
. in fact, pressing a number after = should be the same as first pressing AC :) great work otherwise! can't wait to see this in applets/calculator/package/contents/ui/calculator.qml http://git.reviewboard.kde.org/r/107001/#comment16613 id goes first above properties - Aaron J. Seigo On Nov

Re: Review Request: replace index.html with index.jade

2012-11-02 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107174/#review21346 --- Ship it! Ship It! - Aaron J. Seigo On Nov. 2, 2012, 10:57

Re: Review Request: SystemTray: Refactoring: UiTask and TasksPool have been removed

2012-11-01 Thread Aaron J. Seigo
. (look for s_manager) this keeps memory usage and dbus activity down. so this approach can not work. - Aaron J. Seigo On Oct. 31, 2012, 7 p.m., Dmitry Ashkadov wrote: --- This is an automatically generated e-mail. To reply, visit: http

Re: Review Request: Add Package bindings from MobileComponents to PlasmaCore

2012-11-01 Thread Aaron J. Seigo
/declarativeimports/core/packageproxy.cpp http://git.reviewboard.kde.org/r/107166/#comment16589 these catalog insertions should probably be done in PackageStructure subclasses; not all packages will have i18n support - Aaron J. Seigo On Nov. 1, 2012, 12:24 a.m., Sebastian Kügler wrote

Re: Review Request: AppletContainer has moved to scriptengine

2012-11-01 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107165/#review21282 --- Ship it! looks good from here... - Aaron J. Seigo On Oct

Re: Review Request: Add Package bindings from MobileComponents to PlasmaCore

2012-11-01 Thread Aaron J. Seigo
On Nov. 1, 2012, 9:58 a.m., Aaron J. Seigo wrote: the reason this is still in MobileComponent is because it isn't quite general purpose use ready. the biggest issue is that it always assumes a Plasma/Generic type and can not load from anywhere other than the normal system install

Re: Review Request: load the images for the themes correctly

2012-11-01 Thread Aaron J. Seigo
true, and no, that's how it should be. if they are the stored in the same key, they are the same entry as far as the Package is concerned. - Aaron J. Seigo On Nov. 1, 2012, 3:08 p.m., Giorgos Tsiapaliokas wrote

Re: Review Request: SystemTray: Refactoring: UiTask and TasksPool have been removed

2012-11-01 Thread Aaron J. Seigo
On Nov. 1, 2012, 9:47 a.m., Aaron J. Seigo wrote: plasma/generic/applets/systemtray/core/manager.h, line 54 http://git.reviewboard.kde.org/r/107160/diff/1/?file=93099#file93099line54 the manager is shared across all instances of the system tray plasmoid. (look for s_manager

KDEREVIEW: share like connect and plasmate

2012-11-01 Thread Aaron J. Seigo
it is you are looking at (assuming that what you are looking at it with uses ResourceInstance to let us know :). We've shipped it in three Plasma Active releases and have made it spiffy for the desktop so we may include it in the layout in future. -- Aaron J. Seigo signature.asc Description

Re: Moving applet to review group

2012-10-31 Thread Aaron J. Seigo
, regarding licencing, i doubt you can use GPLV3+ when you use GPLV2+ KDE code. the plus means or later, at your discretion. the problem will be in using that GPLv3+ code in any other code that is licensed e.g. GPLv2+. but yes, having a consistent GPLv2+ would be nicest. -- Aaron J. Seigo

Re: PLASMA_PLATFORM and kdeglobals runtimePlatform

2012-10-31 Thread Aaron J. Seigo
On Wednesday, October 31, 2012 10:25:22 Marco Martin wrote: On Tuesday 30 October 2012, Aaron J. Seigo wrote: On Tuesday, October 30, 2012 22:34:11 Marco Martin wrote: * plasma active default settings i already did that :) what did you change? in plasma-mobile-config repo? yes

Re: QML style guide

2012-10-30 Thread Aaron J. Seigo
. so your vote is to live with it being inconsistent for now, and in new code put geometry properties with the other inhereted properties, correct? -- Aaron J. Seigo signature.asc Description: This is a digitally signed message part. ___ Plasma-devel

Re: Review Request: refactor the package model

2012-10-30 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106742/#review21136 --- Ship it! Ship It! - Aaron J. Seigo On Oct. 30, 2012, 9:17

Re: Review Request: load the images for the themes correctly

2012-10-30 Thread Aaron J. Seigo
(mimetype.size() - themeType.length()); imageDialog(commonFilter, opts); } - Aaron J. Seigo On Oct. 4, 2012, 10:49 a.m., Giorgos Tsiapaliokas wrote: --- This is an automatically generated e-mail. To reply, visit: http

Re: QML style guide

2012-10-30 Thread Aaron J. Seigo
On Tuesday, October 30, 2012 14:14:05 Dmitry Ashkadov wrote: 30.10.2012 13:15, Aaron J. Seigo пишет: On Tuesday, October 30, 2012 12:25:14 Dmitry Ashkadov wrote: We see that main.qml and main.js, delegate.qml and delegate.js may be considered in pairs. main.qml cannot exist without main.js

Re: QML style guide

2012-10-30 Thread Aaron J. Seigo
On Tuesday, October 30, 2012 15:01:04 Dmitry Ashkadov wrote: 30.10.2012 14:35, Aaron J. Seigo пишет: 5. Vim: The {{{ and }}} are just for the sakes of vim's automatic folding. Do we all use vim? I think no. So, we must never force developers use vim. i mostly agree :) i don't think

Re: QML style guide

2012-10-30 Thread Aaron J. Seigo
On Tuesday, October 30, 2012 12:55:31 Marco Martin wrote: if we agree to use this when possible will add to the wiki ooh, yes, absolutely! -- Aaron J. Seigo signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing

Re: QML style guide

2012-10-30 Thread Aaron J. Seigo
highlighting definition? -- Aaron J. Seigo signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: QML style guide

2012-10-30 Thread Aaron J. Seigo
() { } function bar() { } //END: functions like a boss! this will go into the Best Practices page rather than the Style Guide itself so that it is not required, but appreciated and recommended ... voila, no more controversy. we can find a new bikeshed to paint now :) -- Aaron J. Seigo

Re: QML style guide

2012-10-30 Thread Aaron J. Seigo
don't have a hugely set opinion on which way to do this. on-new- line means one less exception to the kdelibs style to follow; on-same-line means QML elements and JS functions look more similar. personally, i'm not 100% happy with either choice :P -- Aaron J. Seigo signature.asc Description

PLASMA_PLATFORM and kdeglobals runtimePlatform

2012-10-30 Thread Aaron J. Seigo
the search path inside of packages. testing for regressions is desired, though it is working here nicely (for whatever that's worth :) at least now we have *one* place that all of this ties together, both in terms of configuration and use from the code. -- Aaron J. Seigo signature.asc Description

Re: PLASMA_PLATFORM and kdeglobals runtimePlatform

2012-10-30 Thread Aaron J. Seigo
On Tuesday, October 30, 2012 22:34:11 Marco Martin wrote: * plasma active default settings i already did that :) -- Aaron J. Seigo signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org

Re: dependency problem with logout from kde-runtime scriptengine

2012-10-29 Thread Aaron J. Seigo
be no such code in kde-runtime anyways. this should be a Plasma::Service plugin which can be accessed from QML to trigger the right behaviour. that Service can then be platform specific if needed, shipped in kde-workspace or even not be on a system at all. -- Aaron J. Seigo signature.asc Description

QML style guide

2012-10-29 Thread Aaron J. Seigo
to this list so everyone notices. but i'd rather we just cleaned up our QML act by paying attention to the details and creating beautiful, consistent code and cleaning up the messy bed we've made for ourselves as we go ... fair? -- Aaron J. Seigo signature.asc Description

Re: QML style guide

2012-10-29 Thread Aaron J. Seigo
are usually one-liners, then child objects which are blocks of code again. this back-and-forth of styles is visually messy. i do like states and transitions at the end as they define how the things above work together. -- Aaron J. Seigo signature.asc Description: This is a digitally signed message part

Re: QML style guide

2012-10-29 Thread Aaron J. Seigo
our JavaScript files and send us nasty mails if it's not compliant any more ;-) +1 -- Aaron J. Seigo signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman

Re: QML style guide

2012-10-29 Thread Aaron J. Seigo
like to vote against mixing onFooChanged with property declaration and setting :) -- Aaron J. Seigo signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman

Re: Review Request: Convert file content to local encoding before uploading text file in the share dataengine

2012-10-28 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107044/#review21044 --- Ship it! Ship It! - Aaron J. Seigo On Oct. 25, 2012, 8:35

Re: qml systemtray: small refactorings

2012-10-26 Thread Aaron J. Seigo
, then the preferred means is to do them in the latest stable branch (e.g. 4.10 or whatever) and then merge that into master; if merge fails due to conflicts (which often happens eventually over the course of a devel cycle) then we restor to cherry-picks from branch into master. -- Aaron J. Seigo

Re: qml systemtray: small refactorings

2012-10-26 Thread Aaron J. Seigo
and if your refactoring goes badly then you can just start again very easily :) this tends to be what i do in such situations and it has saved me lots of effort more than once! -- Aaron J. Seigo signature.asc Description: This is a digitally signed message part

Re: qml systemtray: small refactorings

2012-10-26 Thread Aaron J. Seigo
just done :) -- Aaron J. Seigo signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Testing several plasmoid instances at the same time

2012-10-25 Thread Aaron J. Seigo
in the same containment so that I could drag and drop between them. Any hints? Am I missing something? nope :) perhaps you could try the widget-strip app from plasma-mobile? -- Aaron J. Seigo signature.asc Description: This is a digitally signed message part

Re: Review Request: Fix KRunner's 'spell in foreign language' feature

2012-10-25 Thread Aaron J. Seigo
name, and doesn't really say much about what it does. just speller should be good enough. runners/spellchecker/spellcheck.cpp http://git.reviewboard.kde.org/r/106244/#comment16449 missing whitespace: if (1_speller-isValid()) { - Aaron J. Seigo On Sept. 21, 2012, 1:51 p.m., Simeon Bird

Re: Review Request: Fix screenChanged signal in javascript appletinterface

2012-10-25 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106936/#review20841 --- Ship it! Ship It! - Aaron J. Seigo On Oct. 18, 2012, 1 a.m

Re: Review Request: Fix ReferenceErrors in ListItem

2012-10-25 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106937/#review20842 --- Ship it! Ship It! - Aaron J. Seigo On Oct. 18, 2012, 2:39

Re: Review Request: make kickoff-qml partly c++, restores simpleapplet, applet type switch

2012-10-25 Thread Aaron J. Seigo
On Oct. 19, 2012, 3:09 p.m., Greg T wrote: looks good, just a couple of notes: why are you installing 2 desktop files for the kickoff launcher: - metadata.desktop and the old plasma-applet-launcher.desktop - we don't need CMakeLists.txt in core/ anymore? - also it conflicts with my

Re: Review Request: Fix Inconsistencies and Bugs in Activity Bar's Size Hinting

2012-10-25 Thread Aaron J. Seigo
/106978/#comment16460 and for non-horz/vert? remember that it can be moved between form factors :) plasma/generic/applets/activitybar/activitybar.cpp http://git.reviewboard.kde.org/r/106978/#comment16459 should be on same line: } else { - Aaron J. Seigo On Oct. 22, 2012, 2:27 a.m

Re: Review Request: Possibility to change an element ID of svg image in IconWidget

2012-10-25 Thread Aaron J. Seigo
a QGraphicsWidget thing and will need to be replaced eventually anyways. this should be using the Button QML element, which does support using SVG files. - Aaron J. Seigo On Oct. 24, 2012, 1:02 p.m., Dmitry Ashkadov wrote

Re: Review Request: Fix KRunner's 'spell in foreign language' feature

2012-10-25 Thread Aaron J. Seigo
::loadInstalledRunner. this is now fixed in kdelibs rev 28a310b which should make this code unnecessary. - Aaron J. Seigo On Oct. 25, 2012, 5:24 p.m., Simeon Bird wrote: --- This is an automatically generated e-mail. To reply, visit: http

qml systemtray: small refactorings

2012-10-25 Thread Aaron J. Seigo
and definitely decent code to be certain; it's just nice to make it as smooth as possible so maintenance later is easier :) p.s. i'd also like to get rid of all the private pimpl classes; this is not a library after all :) -- Aaron J. Seigo signature.asc Description: This is a digitally

Re: plans for Plasma Desktop default containment in QML

2012-10-24 Thread Aaron J. Seigo
On Monday, October 22, 2012 17:19:32 todd rme wrote: Can you submit it to kde-look.org in the meantime? Does plasma support installing containments through GHNS? There has been no such integration yet; all the client-side stuff is there (e.g. plasmapkg), but there is no scripted containments

Re: kickoff qml

2012-10-24 Thread Aaron J. Seigo
On Tuesday, October 23, 2012 21:16:41 David Edmundson wrote: Marco, where do you want bug reports / tracking what needs to be done. use the normal places: bugs.kde.org, community.kde.org, this mailing list, etc -- Aaron J. Seigo signature.asc Description: This is a digitally signed message

Re: slc repo as dependency

2012-10-24 Thread Aaron J. Seigo
.. we need to get it out of playground :) i'll make some sys admin bug reports -- Aaron J. Seigo signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman

<    2   3   4   5   6   7   8   9   10   11   >