D27412: Port away from deprecated API on Qt 5.15.0

apol created this revision. apol added a reviewer: Frameworks. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Upstream recommends using QLocale for turning dates into strings. TEST PLAN Builds on my system now

D27411: Port away from deprecated API

apol created this revision. apol added a reviewer: jgrulich. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY QComboBox::currentIndexChanged now gets an int and a string TEST PLAN Can build it now on my system

D27406: Fix build with Qt 5.15

apol updated this revision to Diff 75707. apol added a comment. I am potato REPOSITORY R122 Powerdevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27406?vs=75697=75707 BRANCH master REVISION DETAIL https://phabricator.kde.org/D27406 AFFECTED FILES

D27408: Fix build with Qt 5.15.0

apol created this revision. apol added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY currentIndexChanged(int) is reprecated and bound to be removed. TEST PLAN Builds REPOSITORY R121

D27406: Fix build with Qt 5.15

apol created this revision. apol added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY QComboBox::currentIndexChanged(int) got deprecated. TEST PLAN Builds REPOSITORY R122 Powerdevil

D27402: Make it possible to change the sorting when searching

apol added a comment. In D27402#611597 , @ngraham wrote: > When you switch from relevance to something else, that entry *disappears entirely* from the menu! That's rather odd. You should be able to return to sorting by relevance if you switch

D27402: Make it possible to change the sorting when searching

apol created this revision. apol added a reviewer: ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY We were hiding it because sorting wouldn't work when we have the relevancy on, so now we'll disable it

Re: How to contribute to Plasma Mobile

Hi Yari, Welcome! You can find here a workboard with a bunch of tasks to do. You could consider taking one to start. https://phabricator.kde.org/project/view/28/ Cheers, Aleix On Thu, Feb 13, 2020 at 1:18 PM Yari Polla wrote: > > Hi guys, > > I'm an IT student who would like to contribute to PM

D27346: emojier: Improve resizing performance

apol added a comment. uh right, didn't see that. Actually, do you know what's up with those? we should just be showing them as 1 glyph... REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27346 To: apol, #plasma Cc: Zren, plasma-devel, Orage, LeGast00n,

D27337: [Emojier] Optimize performance

apol added a comment. Here's an alternative https://phabricator.kde.org/D27346 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27337 To: Zren, apol, #plasma Cc: broulik, davidedmundson, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack,

D27346: emojier: Improve resizing performance

apol created this revision. apol added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Don't calculate the most fitting size, adopt a reasonable size and go with it. BUG: 417454 TEST PLAN

D27345: Don't emit palette changes if the palette didn't change

apol created this revision. apol added a reviewer: Kirigami. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Should keep us from repainting objects that depend on it. TEST PLAN Detected it with

D27337: [Emojier] Optimize performance

apol added inline comments. INLINE COMMENTS > broulik wrote in CategoryPage.qml:71 > > but there was a bit of an empty space on the right. > > If `Label` resizing is the problem. Would keeping the `Label` square and > using a padding `Item` around it fix the performance issue? Yes, or just

D27337: [Emojier] Optimize performance

apol added inline comments. INLINE COMMENTS > CategoryPage.qml:71 > > -cellWidth: width/columnsToHave > +cellWidth: desiredSize > cellHeight: desiredSize This was added so that the columns adapt to the width of the view, otherwise it was very fast (as fast as without

D27337: [Emojier] Optimize performance

apol added a comment. Right, maybe we can find a better way of doing this. Or just delaying resizing of the Label since it's indeed the slow part. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27337 To: Zren, apol, #plasma Cc: broulik, davidedmundson,

D27304: Replace plasma.kde.org with kde.org/plasma-desktop

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Feels wrong having "desktop" on the URL, but I guess this is not the right place to fix it. REPOSITORY R120 Plasma Workspace BRANCH Plasma/5.18 REVISION DETAIL

D27079: Don't escape search text in search page title

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. whatever REPOSITORY R134 Discover Software Store BRANCH show-search-text-un-escaped (branched from Plasma/5.18) REVISION DETAIL https://phabricator.kde.org/D27079 To: ngraham, #vdg,

D27079: Don't escape search text in search page title

apol added a comment. In D27079#607311 , @ngraham wrote: > Why is that not entirely correct? The bold tags are just styling; the user clearly intended to search for the word "potato". Because the user actually wrote "potato", it's only

D27079: Don't escape search text in search page title

apol added a comment. So with this change, if you search "potato", you'll get as a title "potato". I wouldn't say that's entirely correct. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D27079 To: ngraham, #vdg, #discover_software_store, apol Cc:

D27203: Don't try to open files we can't figure out where they are

apol created this revision. apol added a reviewer: Frameworks. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. TEST PLAN Been using it for a few days, no regressions. Opening sftp:///localhost/.../somefile.text twice, doesn't

D27193: Improve the behaviour of the power button on mobile

This revision was automatically updated to reflect the committed changes. Closed by commit R122:57ba878cdd61: Improve the behaviour of the power button on mobile (authored by apol). REPOSITORY R122 Powerdevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27193?vs=75106=75107

D27193: Improve the behaviour of the power button on mobile

apol updated this revision to Diff 75106. apol added a comment. address documentation, connect REPOSITORY R122 Powerdevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27193?vs=75102=75106 BRANCH master REVISION DETAIL https://phabricator.kde.org/D27193 AFFECTED FILES

D27193: Improve the behaviour of the power button on mobile

apol added a comment. > Regarding this behavior, it will not always be desirable to do that, especially if user interaction is still happening, e.g. listening to music, having an active USB connection (because it'll close) for copying files or doing something over ssh, etc. I mentioned

D27193: Improve the behaviour of the power button on mobile

apol created this revision. apol added reviewers: Plasma, bshah. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY On Mobile, if the power button is pressed for short time, suspend to Ram as requested by Bhushan.

D27079: Don't escape search text in search page title

apol added a comment. They shouldn't that doesn't mean we should style it when they do. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D27079 To: ngraham, #vdg, #discover_software_store, apol Cc: plasma-devel, apol, Orage, LeGast00n,

D27090: Replace config.h with target_compile_definitions

apol added a comment. I wouldn't say it's simpler. If anything it's easier to inspect the value that is being passed from your editor. REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D27090 To: gikari Cc: apol, plasma-devel, Orage, LeGast00n,

D27079: Don't escape search text in search page title

apol added a comment. Because if you enter `my potato` it gets styled, which shouldn't happen. I suggest just doing the following: diff --git a/discover/qml/ApplicationsListPage.qml b/discover/qml/ApplicationsListPage.qml index 4445a195..e094b667 100644 ---

D27047: Make the api docs reflect that Kirigami is not only a mobile toolkit

apol added a comment. We made an effort to not use "convergence", as it seems like it's hard to understand. How about "adaptable"? concept makes sense to me. INLINE COMMENTS > Mainpage.dox:26 > \section overview Introduction > -Kirigami is a set of QtQuick components at the moment

D27034: Fix message box when passing a remote url that includes a file

This revision was automatically updated to reflect the committed changes. Closed by commit R135:317a899dc774: Fix message box when passing a remote url that includes a file (authored by apol). REPOSITORY R135 Integration for Qt applications in Plasma CHANGES SINCE LAST UPDATE

D27027: Clip the flickable parent item

apol added a comment. The fact that isn't preexistent doesn't change that if the flicked item were to be placed properly, clipping wouldn't be necessary REPOSITORY R169 Kirigami BRANCH scrollview_clip REVISION DETAIL https://phabricator.kde.org/D27027 To: ahiemstra, #kirigami,

D27034: Fix message box when passing a remote url that includes a file

apol created this revision. apol added a reviewer: Frameworks. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY The if was negated, I assume it was a typo TEST PLAN I don't get the following screenshot anymore

D26875: Make it possible to stream only input

apol closed this revision. apol added a comment. https://commits.kde.org/xdg-desktop-portal-kde/46ebf487e8075635179cf18bc5f6ec5ea79388aa REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop REVISION DETAIL https://phabricator.kde.org/D26875 To: apol, #plasma, #kde_connect,

D27027: Clip the flickable parent item

apol added a comment. after looks cropped now, are you sure this is the right fix? (not that it isn't necessary...) REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D27027 To: ahiemstra, #kirigami Cc: apol, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos,

D26966: [kstyle] Use guarded pointers to store shadows

apol added a comment. +1 REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D26966 To: zzag, #plasma, broulik Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai,

D26966: [kstyle] Use guarded pointers to store shadows

apol added inline comments. INLINE COMMENTS > breezeshadowhelper.h:157 > //* managed shadows > -QMap _shadows; > if this is a thing, maybe it would make sense to actually try and remove the KWindowShadows upon destruction? Something like `connect(newshadow, ::destroyed,

D26965: [Emojier] Copy Emoji also into selection clipboard

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Right, didn't think of this since we don't have selection clipboard on wayland.  REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26965 To: broulik, #plasma,

D26956: Remove export header from static install

apol requested changes to this revision. apol added a comment. This revision now requires changes to proceed. Wait no, are you sure? kirigami headers will still include the file... REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D26956 To: masonm, #kirigami, mart,

Re: Long press global shortcuts

On Sun, Jan 12, 2020 at 6:11 PM Aleix Pol wrote: > > Hi, > In a discussion some weeks ago, we came to the conclusion that it > would make sense to support long press global shortcuts. > > The use-case we discussed back then was the power button on the Plasma > phone. We n

D26875: Make it possible to stream only input

apol created this revision. apol added reviewers: Plasma, KDE Connect. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY No need to share our screen contents to be able to move the mouse. TEST PLAN Ported KDE

D26790: Remove unused variable (probabilities) + make it compile without deprecated method: reverseDist is already a QMultiHash

apol added a comment. Clearly 2 separate changes and too long line on the commit message. Please split when landing. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D26790 To: mlaurent Cc: apol, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham,

D26777: [App Style KCM] Port away from QDBusInterface

apol added a comment. Why don't you just export the interface you are using through qdbusxml2cpp and viceversa? This way you don't need to have the glue code. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26777 To: gikari Cc: apol, plasma-devel, Orage,

D26772: [kcm] Handle empty shortcut in property fetch

apol added a comment. FWIW, for this you could have used QList::value(0), it would have saved quite a bit of boilerplate. https://doc.qt.io/qt-5/qlist.html#value REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D26772 To: davidedmundson, #plasma, ngraham Cc:

D26738: Fix typo, launch plugin with argument, change signals

apol added a comment. +1 to me, hopefully someone more familiar with this code can review, otherwise I'll approve it. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26738 To: alex, broulik Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev,

D26738: Fix typo, launch plugin with argument, change signals

apol added a comment. Looks good to me overall. Can you commit the HACKING change separately? it's completely unrelated. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26738 To: alex, broulik Cc: apol, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh,

D18006: Include only the largest size for the "Next" wallpaper

apol added a comment. In D18006#595773 , @apol wrote: > -1 I just saw what this revision depends on. So it could make sense. I'll leave it at -0 because caches are bad. REPOSITORY R31 Breeze REVISION DETAIL

D18006: Include only the largest size for the "Next" wallpaper

apol added a comment. -1 This will also reduce load time considerably (I did the profiling before, using the same resolution is a big win). Also you'll get to save quite some IO. If this is a problem, I'd suggest looking into doing these wallpapers in svg or even QML. REPOSITORY

D26111: Runner: make recentdocument use KActivityStats data

apol added a comment. I'm not the original author. I guess I appear because of the git repository split or something. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26111 To: meven, #plasma, ivan, ngraham, broulik, apol Cc: broulik, plasma-devel,

D26715: [Widget Explorer] Show placeholder message when there are no widgets or search results

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. I believe we are in string freeze, this will sadly have to go to master. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D26715 To: ngraham,

D26570: Improve Plasma user feedback introspection

This revision was automatically updated to reflect the committed changes. Closed by commit R120:35dcbd3dd89c: Improve Plasma user feedback introspection (authored by apol). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26570?vs=73641=73674 REVISION

D26570: Improve Plasma user feedback introspection

apol added inline comments. INLINE COMMENTS > davidedmundson wrote in feedback.cpp:41 > where do you use this? It's used by `std::sort(m_feedbackSources.begin(), m_feedbackSources.end()...` > davidedmundson wrote in feedback.cpp:109 > This doesn't look right. > > With 2 async processes, the

D26570: Improve Plasma user feedback introspection

apol updated this revision to Diff 73641. apol added a comment. rebase REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26570?vs=73315=73641 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26570 AFFECTED FILES

D26571: Provide information about how we are using KUserFeedback

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R134:b893a9bb940c: Provide information about how we are using KUserFeedback (authored by apol). REPOSITORY R134 Discover

D26392: Add option to easily configure and start a hotspot

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. LGTM REPOSITORY R116 Plasma Network Management Applet BRANCH hotspot REVISION DETAIL https://phabricator.kde.org/D26392 To: jgrulich, #plasma, ngraham, #vdg, apol Cc: meven, cblack,

D26392: Add option to easily configure and start a hotspot

apol added a comment. Patch looks good to me overall. +1 INLINE COMMENTS > handler.cpp:615 > + > +QVariantMap options; > +options.insert(QLatin1String("persist"), QLatin1String("volatile")); I'd prefer the initializer list syntax `const QVariantMap options = {

Re: Long press global shortcuts

On Tue, Jan 14, 2020 at 9:05 PM Nate Graham wrote: > > On 1/12/20 10:11 AM, Aleix Pol wrote: > > The second part of this is why I'm sending this e-mail. We're > > responding to global shortcuts on press rather than on release, which > > makes it impossible to handle the l

D26392: Add option to easily configure and start a hotspot

apol added a comment. > What about allowing to create a hotspot if the WiFi is in use, but it's not used as primary connection (e.g. Ethernet or Mobile connections are used primarily). In that case the user wouldn't be without connection if we disconnect him. Surely. And if the laptop

D26632: Fix warning on ScrollablePage

This revision was automatically updated to reflect the committed changes. Closed by commit R169:e2ebbe6f4ac9: Fix warning on ScrollablePage (authored by apol). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26632?vs=73431=73433 REVISION DETAIL

D26632: Fix warning on ScrollablePage

apol created this revision. apol added a reviewer: Kirigami. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY At the moment we'll be going through all of the children objects and reassigning the overlay as the

D26630: Fix warning

This revision was automatically updated to reflect the committed changes. Closed by commit R169:ec3b2d53d853: Fix warning (authored by apol). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26630?vs=73422=73427 REVISION DETAIL

D26628: Specify where the code is coming from as the URL

This revision was automatically updated to reflect the committed changes. Closed by commit R169:dee14718ceb4: Specify where the code is coming from as the URL (authored by apol). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26628?vs=73424=73426 REVISION

D26628: Specify where the code is coming from as the URL

apol updated this revision to Diff 73424. apol added a comment. consistency REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26628?vs=73420=73424 BRANCH arcpatch-D26628 REVISION DETAIL https://phabricator.kde.org/D26628 AFFECTED FILES

D26630: Fix warning

apol created this revision. apol added a reviewer: Kirigami. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY columnview.cpp:7: TypeError: Cannot read property 'contentX' of null TEST PLAN Used to get it all

D26628: Specify where the code is coming from as the URL

apol created this revision. apol added a reviewer: Kirigami. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Makes it much simpler to see where warnings are coming from if we get to see a file name. TEST PLAN

Long press global shortcuts

Hi, In a discussion some weeks ago, we came to the conclusion that it would make sense to support long press global shortcuts. The use-case we discussed back then was the power button on the Plasma phone. We need to have 2 actions upon press. Short press would lock and dim the screen, long press

D19947: systray: show a small animation on the icons when activated

This revision was automatically updated to reflect the committed changes. Closed by commit R120:27fa3f7e0c35: systray: show a small animation on the icons when activated (authored by apol). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D26570: Improve Plasma user feedback introspection

apol updated this revision to Diff 73315. apol added a comment. Async load REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26570?vs=73227=73315 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26570 AFFECTED FILES

D26392: Add option to easily configure and start a hotspot

apol added a comment. Otherwise lgtm INLINE COMMENTS > networkmodel.cpp:517 > NetworkModelItem *originalItem = nullptr; > - > for (NetworkModelItem *item : > m_list.returnItems(NetworkItemsList::Connection, connection)) { unrelated change. REPOSITORY R116 Plasma Network

D26392: Add option to easily configure and start a hotspot

apol added a comment. In D26392#588345 , @jgrulich wrote: > In D26392#587159 , @mthw wrote: > > > @apol You are right, it is not possible to create a hotspot if one is already connected to a WiFi

D26570: Improve Plasma user feedback introspection

apol added a comment. F7876596: photo_2020-01-10_20-09-45.jpg REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26570 To: apol, #plasma Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas,

D26571: Provide information about how we are using KUserFeedback

apol created this revision. apol added reviewers: Plasma, vkrause. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Implements --feedback See 26569 TEST PLAN Used the KCM happily REPOSITORY R134 Discover

D26570: Improve Plasma user feedback introspection

apol created this revision. apol added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Before loading the view, query all plasma processes and show why they're using KUserFeedback.

D26538: Don't anchor AbstractApplicationHeader blindly

This revision was automatically updated to reflect the committed changes. Closed by commit R169:e8fef85c138c: Dont anchor AbstractApplicationHeader blindly (authored by apol). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26538?vs=73111=73189 REVISION

D26547: pk: Load the AppStream database on a separate thread

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R134:2ce5eb9dab5b: pk: Load the AppStream database on a separate thread (authored by apol). CHANGED PRIOR TO COMMIT

D26547: pk: Load the AppStream database on a separate thread

apol marked 2 inline comments as done. apol added inline comments. INLINE COMMENTS > broulik wrote in PackageKitBackend.cpp:502 > Why is this delayed now? It's a quirk of how ResultsStream works. We need the results to be emitted when something is listening to it. If you look at it closely, it

D26547: pk: Load the AppStream database on a separate thread

apol updated this revision to Diff 73173. apol marked an inline comment as done. apol added a comment. kai comments REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26547?vs=73139=73173 BRANCH arcpatch-D26547 REVISION DETAIL

D26552: [KCMs/Feedback] Adjust UI to be more user-friendly

apol added inline comments. INLINE COMMENTS > main.qml:53 > wrapMode: Text.WordWrap > -text: xi18nc("@info", "You can read about our policy in the > following link:") > +text: xi18nc("@info", "You can help KDE improve this software by > contributing

D26547: pk: Load the AppStream database on a separate thread

apol added a comment. In D26547#590948 , @ngraham wrote: > Very nice. Launching definitely feels faster now. This also fixes https://bugs.kde.org/show_bug.cgi?id=409262 for me. Does that make any sense? Yes, it makes sense. > One

D26547: pk: Load the AppStream database on a separate thread

apol created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY No need to block the backends load on PackageKit appstream usage. BUG: 409599 TEST PLAN Tested manually REPOSITORY R134

D26538: Don't anchor AbstractApplicationHeader blindly

apol created this revision. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY If we do it, then QtQuick.Layouts complains when it's placed inside because Layouts.fillWidth should be used instead. TEST PLAN

Re: New Emojier translations

On Mon, Dec 30, 2019 at 8:26 PM Luigi Toscano wrote: > > Yuri Chornoivan ha scritto: > > Hi, > > > > There is a report in Russian mailing list that the translations for the new > > emoji KCM [1] do not work. It is reported that the catalog name > > (plasma_applet_org.kde.kimpanel.po [2]) does not

Re: RFC: Dropping Breeze + Oxygen Qt4 builds after

+1 On Tue, Jan 7, 2020 at 11:29 AM Harald Sitter wrote: > > +1 > > On Tue, Jan 7, 2020 at 10:51 AM David Edmundson > wrote: > > > > We're starting to see a lot of preparation for Qt6 porting API which > > we know will be deprecated. > > > > One place where this is problematic is Breeze + Oxygen

D25179: Don't move the drawer collapse button if there's no icon or image

apol abandoned this revision. apol added a comment. collapseButton isn't a thing anymore, at least as is. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D25179 To: apol, #kirigami, mart Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol,

D26421: Only show full name in review dialog

apol added a subscriber: jgrulich. apol added a comment. @jgrulich you included that, right? Do you remember why? I can see it's used for generating the user hash. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D26421 To: ngraham,

D25889: Polish the reviews UI and presentation

apol accepted this revision. apol added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > ReviewDelegate.qml:188 > +checkable: true > +checked: { > +switch(usefulChoice) { `checked:

D26416: Kicker/Documents optimization: Lazily build KFileItem

apol added inline comments. INLINE COMMENTS > recentusagemodel.cpp:251 > +auto getFileItem = [=] () { > +#if KIO_VERSION >= QT_VERSION_CHECK(5,57,0) > +// Avoid calling QT_LSTAT and accessing recent documents I'm pretty sure we can/should depend on newer KF5. I'd say

D26392: Add option to easily configure and start a hotspot

apol added a comment. Cool feature! INLINE COMMENTS > Toolbar.qml:133 > + > +onClicked: { > +if (checked) { is it always prossible to create the hotspot? I'd expect it not to be possible at all sometimes (visible should be false then) and if the wifi is in use

D26305: Fix Ctrl+F shortcut conflict

apol added a comment. Patch looks good. INLINE COMMENTS > ngraham wrote in SettingsBase.cpp:422 > Dunno why phab is showing this; I didn't actually remove the trailing newline. kate and vim do in some occasions. REPOSITORY R124 System Settings REVISION DETAIL

D26035: battery: Improve the brightness responsiveness

This revision was automatically updated to reflect the committed changes. Closed by commit R120:62be85f4360d: battery: Improve the brightness responsiveness (authored by apol). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26035?vs=71743=72439

D26316: flatpak: don't crash when showing sources

apol created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY QML seems to be getting confused (only in opensuse) and crash. This is a blind fix that hopefully fixes the issue. TEST PLAN Doesn't

D26275: SourcesPage: Override contentItem of ListSectionHeader instead of relying on data property

apol added a comment. F7851481: Screenshot_20191231_024108.png The bug mentioned got fixed by this (old Qt doesn't iterate over QList). I don't see how this would make it look any different. The kirigami visible patch is indeed necessary but

D26275: SourcesPage: Override contentItem of ListSectionHeader instead of relying on data property

apol added a comment. This feels workaround-y, maybe we can just fix ListSectionHeader? REPOSITORY R134 Discover Software Store BRANCH sources_actiontoolbar REVISION DETAIL https://phabricator.kde.org/D26275 To: ahiemstra, #plasma, #discover_software_store, apol, ngraham Cc:

D26279: ActionToolBar: Only show the overflow button if there are visible items in the menu

apol accepted this revision. apol added a comment. Thanks! REPOSITORY R169 Kirigami BRANCH actiontoolbar_contextbutton_visible REVISION DETAIL https://phabricator.kde.org/D26279 To: ahiemstra, #kirigami, ngraham, apol Cc: apol, ngraham, plasma-devel, fbampaloukas, GB_2, domson,

D26035: battery: Improve the brightness responsiveness

apol added a comment. https://phabricator.kde.org/D26035 has been landed. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26035 To: apol, #plasma, broulik Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen,

D26035: battery: Improve the brightness responsiveness

apol marked an inline comment as done. apol added inline comments. INLINE COMMENTS > broulik wrote in logic.js:53 > Wouldn't that cause subsequent calls to fail if the previous hasn't finished > yet? Wouldn't that be annoying if you drag the slider quickly? No, it will be called eventually,

D25889: Polish the "review this review" UI and presentation

apol added a comment. I'm not convinced about using emoji in place of icons. Are we sure about that? I like ndavis's suggestion, but as a delegate, having so many lines could look cluttered. Should we consider using cards? REPOSITORY R134 Discover Software Store REVISION DETAIL

D26244: Install all kcm plugins into kcms subdir

apol added a comment. Hi, This is a good change but I'm afraid it needs some more tweaking. Are you sure this doesn't need adapting the desktop files? In fact, can you take a look at how the colors kcm does it? Emphasis on the kcoreaddons_desktop_to_json bit. REPOSITORY R119

D26200: Add shortcut for closing pages

apol added a comment. Shouldn't the application control whether its pages get closed and under which condition it happens? REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D26200 To: nicolasfella, #kirigami, mart, ngraham Cc: apol, plasma-devel, fbampaloukas, GB_2,

D26199: Remove unneeded shortcut for page naviagtion

apol requested changes to this revision. apol added a comment. This revision now requires changes to proceed. This is not for changing pages, it's about scrolling vertically. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D26199 To: nicolasfella,

D26185: Fix font rendering when compiled against Qt >= 5.14

apol added subscribers: davidedmundson, dfaure. apol added a comment. I'm not all that sure. Not it's coming from D24255 by @dfaure, approved by @davidedmundson. Maybe they have some insight. REPOSITORY R120 Plasma Workspace REVISION DETAIL

D25670: Synchronize decorations buttons order in GTK headerbars

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Never mind my last message, that's okay. REPOSITORY R99 KDE Gtk Configuration Tool BRANCH gtk-decoration-order-sync (branched from master) REVISION DETAIL

<    1   2   3   4   5   6   7   8   9   10   >