D20549: Improve the look of the Plymouth Boot Splash Screen KCM UI

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY Port the KCM to the new GriedView KCM design. F6771665: Improved Plymouth Boot Splash Screen KCM

D18419: Adjust some KCMs to implement new Appearance section layout

GB_2 added a comment. Ping REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D18419 To: ngraham, #vdg, #plasma, davidedmundson Cc: GB_2, abetts, davidedmundson, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas,

D17410: Add alternatives button to applet configuration in panel edit mode

GB_2 added a comment. Or we could just leave it how it is now. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17410 To: GB_2, #plasma, #vdg, davidedmundson Cc: Codezela, broulik, davidedmundson, ngraham, ndavis, #vdg, plasma-devel, #plasma, cblack,

D19829: kicker: add option to make root level icons visible

GB_2 added a comment. Ping REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19829 To: i.Dark_Templar, hein, #plasma, #vdg Cc: GB_2, ngraham, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18546: [Desktop Toolbox] Use "tools" icon

GB_2 added a comment. I think this revision can be abandoned. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D18546 To: ngraham, #vdg, #plasma Cc: Codezela, GB_2, hein, ndavis, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D17410: Add alternatives button to applet configuration in panel edit mode

GB_2 added a comment. It seems like Elisa has a function to do this: https://lxr.kde.org/source/extragear/multimedia/elisa/src/elisaapplication.h#0083 Maybe something like this could be added to KDE/Plasma Franeworks? REPOSITORY R119 Plasma Desktop REVISION DETAIL

D17410: Add alternatives button to applet configuration in panel edit mode

GB_2 added a comment. In D17410#448842 , @davidedmundson wrote: > Toolbutton should be able to take a qicon as a source Nope, when I use `iconSource: plasmoid.action("alternatives").icon` this happens: `ConfigOverlay.qml:392:21:

D17410: Add alternatives button to applet configuration in panel edit mode

GB_2 added a comment. in the toolbutton icon source/name property. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17410 To: GB_2, #plasma, #vdg, davidedmundson Cc: Codezela, broulik, davidedmundson, ngraham, ndavis, #vdg, plasma-devel, #plasma, cblack,

D17410: Add alternatives button to applet configuration in panel edit mode

GB_2 added a comment. In D17410#448756 , @davidedmundson wrote: > > It currently returns a QIcon, but I want the name/source of it from QML. > > What for? So I can use the same icon that is in the context menu REPOSITORY R119

D17410: Add alternatives button to applet configuration in panel edit mode

GB_2 updated this revision to Diff 55960. GB_2 added a comment. Try to fix diff REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17410?vs=55959=55960 BRANCH master REVISION DETAIL https://phabricator.kde.org/D17410 AFFECTED FILES

D17410: Add alternatives button to applet configuration in panel edit mode

GB_2 updated this revision to Diff 55959. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17410?vs=55958=55959 REVISION DETAIL https://phabricator.kde.org/D17410 AFFECTED FILES containments/panel/contents/ui/ConfigOverlay.qml To: GB_2, #plasma,

D17410: Add alternatives button to applet configuration in panel edit mode

GB_2 updated this revision to Diff 55958. GB_2 edited the summary of this revision. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17410?vs=55856=55958 REVISION DETAIL https://phabricator.kde.org/D17410 AFFECTED FILES containments/panel/contents/ui/ConfigOverlay.qml To: GB_2,

D17410: Add alternatives button to applet configuration in panel edit mode

GB_2 added a comment. BTW, @davidedmundson or someone else: How do I get the icon name/source here: `iconSource: plasmoid.action("alternatives").icon`? It currently returns a QIcon, but I want the name/source of it from QML. REPOSITORY R119 Plasma Desktop REVISION DETAIL

D17410: Add alternatives button to applet configuration in panel edit mode

GB_2 commandeered this revision. GB_2 edited reviewers, added: davidedmundson; removed: GB_2. GB_2 added a comment. Sure! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17410 To: GB_2, #plasma, #vdg, davidedmundson Cc: Codezela, broulik, davidedmundson,

D17410: Add alternatives button to applet configuration in panel edit mode

GB_2 added a comment. Nice, thank you so much! INLINE COMMENTS > ConfigOverlay.qml:392 > +iconSource: "preferences-desktop-default-applications" > +text: i18n("Alternatives...") > +enabled: >

D17410: Add alternatives button to applet configuration in panel edit mode

GB_2 added a comment. In D17410#446874 , @Codezela wrote: > This icon have a lot of details for this small size we need more clear one I guess The icon was added here: D20367 I think it's still ok,

D18419: Adjust some KCMs to implement new Appearance section layout

GB_2 added a comment. In D18419#446564 , @davidedmundson wrote: > From my last comment > > >> Merge various KCMs together (e.g. Icons and Emoticons, Widget Style and GNOME Applications Style (GTK)) > > > > > This is by /far/ the

D20043: digitalclock: have it display a context menu onPressAndHold

GB_2 added a comment. Ping REPOSITORY R120 Plasma Workspace BRANCH digiclock REVISION DETAIL https://phabricator.kde.org/D20043 To: apol, #plasma, ngraham Cc: GB_2, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20093: Show a context menu on pressAndHold

GB_2 added a comment. Ping REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D20093 To: apol, #plasma, mart Cc: GB_2, davidedmundson, hein, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19209: [sddm-kcm] Adjust Background label and button

GB_2 closed this revision. REPOSITORY R123 SDDM Configuration Panel (KCM) REVISION DETAIL https://phabricator.kde.org/D19209 To: GB_2, #vdg, #plasma, filipf, ngraham Cc: GB_2, abetts, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol,

D18419: Adjust some KCMs to implement new Appearance section layout

GB_2 added a comment. In D18419#400163 , @davidedmundson wrote: > > Improve text on existing QWidgets KCMs to conform to the HIG > > After this. > > > Re-arrange weird layouts for existing QWidgets KCMs to conform to the HIG > >

D19209: [sddm-kcm] Adjust Background label and button

GB_2 added a comment. I think I can leave it how it is now. REPOSITORY R123 SDDM Configuration Panel (KCM) REVISION DETAIL https://phabricator.kde.org/D19209 To: GB_2, #vdg, #plasma, filipf, ngraham Cc: GB_2, abetts, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai,

D20266: Add new notification plasmoid

GB_2 added a comment. I made a better timeout indicator that you can use: F6755221: TimeoutIndicator.qml This is how it looks like: F6755222: Circular Timeout.mp4 REPOSITORY R120 Plasma Workspace REVISION

D20266: Add new notification plasmoid

GB_2 added a comment. Amazing! INLINE COMMENTS > FullRepresentation.qml:247 > +opacity: 0.6 > +text: list.count === 0 ? i18n("No unread notifications.") : > i18n("Notifications") > +} Please remove the dot to make it consistent with other Plasmoids.

D19209: [sddm-kcm] Adjust Background label and button

GB_2 commandeered this revision. GB_2 edited reviewers, added: rooty; removed: GB_2. GB_2 added a comment. Ok, thanks. REPOSITORY R123 SDDM Configuration Panel (KCM) REVISION DETAIL https://phabricator.kde.org/D19209 To: GB_2, #vdg, #plasma, filipf, ngraham, rooty Cc: GB_2, abetts,

D19209: [sddm-kcm] Adjust Background label and button

GB_2 added a comment. @rooty Can you please reopen this? REPOSITORY R123 SDDM Configuration Panel (KCM) REVISION DETAIL https://phabricator.kde.org/D19209 To: rooty, #vdg, #plasma, filipf, ngraham, GB_2 Cc: GB_2, abetts, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai,

D19209: [sddm-kcm] Adjust Background label and button

GB_2 added a comment. Is this okay with a form layout? F6753594: Adjusted SDDM KCM Background Label and Button.png If yes, I will take over this revision. REPOSITORY R123 SDDM Configuration Panel (KCM) REVISION DETAIL

D20144: Make location of "Lock Widgets" and "Remove Panel" buttons more obvious

This revision was automatically updated to reflect the committed changes. Closed by commit R119:da0adfedcab0: Make location of Lock Widgets and Remove Panel buttons more obvious (authored by GB_2). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D20144: Make location of "Lock Widgets" and "Remove Panel" buttons more obvious

GB_2 added subscribers: rooty, filipf, abetts, ndavis. GB_2 added a comment. In D20144#441802 , @ngraham wrote: > Hmm, the separator line feels like a bit much to me. How about just `units.largeSpacing` or `units.gridUnit` between them?

D19077: Redesign the theme preview window

GB_2 added a comment. I like B too. BTW, can "Background:" and the background selection button be centered like in a form layout? REPOSITORY R123 SDDM Configuration Panel (KCM) REVISION DETAIL https://phabricator.kde.org/D19077 To: filipf, #plasma, #vdg, ngraham Cc: mart, GB_2,

D17410: Add alternatives button to applet configuration in panel edit mode

GB_2 added a comment. Ping REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17410 To: GB_2, #plasma, #vdg Cc: broulik, davidedmundson, ngraham, ndavis, #vdg, plasma-devel, #plasma, cblack, arvidhansson, ian, hannahk, Pixel_Lime, jraleigh, squeakypancakes,

D19829: kicker: add option to make root level icons visible

GB_2 added a comment. In D19829#432852 , @i.Dark_Templar wrote: > Favorite icons are much larger, it's hard to confuse them with root level menu icons. If it's deemed as informational noise, it's disabled by default. But in case it's not, it

D19077: Redesign the theme preview window

GB_2 added a comment. Ping REPOSITORY R123 SDDM Configuration Panel (KCM) REVISION DETAIL https://phabricator.kde.org/D19077 To: filipf, #plasma, #vdg, ngraham Cc: mart, GB_2, mmustac, davidedmundson, abetts, rooty, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai,

D20144: Make location of "Lock Widgets" and "Remove Panel" buttons more obvious

GB_2 updated this revision to Diff 55225. GB_2 added a comment. Add separator and spacer between the two buttons REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20144?vs=55139=55225 BRANCH master REVISION DETAIL

D20144: Make location of "Lock Widgets" and "Remove Panel" buttons more obvious

GB_2 added a comment. In D20144#441087 , @ngraham wrote: > Maybe just switch the buttons' positions and add a spacer between them, then? I can try putting a spacer or seperator between the 2 buttons, but if I switch the positions of

D20144: Make location of "Lock Widgets" and "Remove Panel" buttons more obvious

GB_2 added a comment. In D20144#441083 , @ngraham wrote: > +1 for moving out out from under the More Settings... button; this isn't a setting so that was clearly wrong. However I'm not sure I like the new placement of the button. Now it's right

D20144: Make location of "Lock Widgets" and "Remove Panel" buttons more obvious

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY BUG: 406079 Move these two buttons to the left/top of the panel edit mode toolbar.

D19469: [sddm-theme] Update login screen preview image

GB_2 added a comment. In D19469#435220 , @rooty wrote: > F6703853: image.png > > This is the Konqi avatar I have available in SySe. It renders as fairly blurry / lower quality than the one I opted for

D19469: [sddm-theme] Update login screen preview image

GB_2 added a comment. In D19469#435216 , @rooty wrote: > In D19469#435215 , @GB_2 wrote: > > > BTW, it's still not 1920x1080. > > > Noted. (Why is that relevant though?) Much more

D19469: [sddm-theme] Update login screen preview image

GB_2 added a comment. BTW, it's still not 1920x1080. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D19469 To: rooty, #vdg, ngraham, filipf Cc: GB_2, davidedmundson, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg,

D19469: [sddm-theme] Update login screen preview image

GB_2 added a comment. In D19469#435183 , @rooty wrote: > In D19469#435175 , @GB_2 wrote: > > > The file size is quite big (you can change the compression in Spectacle) and I think the resolution

D19469: [sddm-theme] Update login screen preview image

GB_2 added a comment. The file size is quite big (you can change the compression in Spectacle) and I think the resolution should be 1920x1080. Please also change the user images to the colorful Konqi and Katie ones. REPOSITORY R120 Plasma Workspace REVISION DETAIL

D19788: [service runner] throw out kde3 "compat" code

GB_2 added a comment. GTK+ was recently renamed to GTK (https://mail.gnome.org/archives/gtk-devel-list/2019-February/msg0.html). REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D19788 To: sitter, broulik Cc: GB_2, plasma-devel, jraleigh, ragreen, Pitel,

D19790: Improve the look of the GTK Application Style KCM UI

This revision was automatically updated to reflect the committed changes. Closed by commit R99:36dd29f8b65a: Improve the look of the GTK Application Style KCM UI (authored by GB_2). REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE

D19790: Improve the look of the GTK Application Style KCM UI

GB_2 updated this revision to Diff 54033. GB_2 added a comment. Fix groupbox widths REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19790?vs=54032=54033 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19790 AFFECTED FILES

D19790: Improve the look of the GTK Application Style KCM UI

GB_2 updated this revision to Diff 54032. GB_2 added a comment. Improve and clean UI REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19790?vs=54026=54032 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19790 AFFECTED

D19790: Improve the look of the GTK Application Style KCM UI

GB_2 updated this revision to Diff 54026. GB_2 added a comment. Add back word GNOME and update GHNS button tooltip REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19790?vs=53994=54026 BRANCH master REVISION DETAIL

D19790: Improve the look of the GTK Application Style KCM UI

GB_2 added inline comments. INLINE COMMENTS > apol wrote in kde-gtk-config.desktop:59 > Then do it so I can accept the patch I already did it. > apol wrote in gtkconfigkcmodule.cpp:65 > That's fine, but you can do it in a separate patch. I'm already updating the strings here. I always did

D19790: Improve the look of the GTK Application Style KCM UI

GB_2 updated this revision to Diff 53994. GB_2 added a comment. Clean desktop file REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19790?vs=53967=53994 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19790 AFFECTED FILES

D19790: Improve the look of the GTK Application Style KCM UI

GB_2 added inline comments. INLINE COMMENTS > apol wrote in kde-gtk-config.desktop:1 > All this not saying they're right or wrong but unrelated to the change at > stake. I'll remove the things that weren't here before, but this is just sorting the desktop entry to make it consistent with

D19790: Improve the look of the GTK Application Style KCM UI

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY Apply the KDE HIG, move the KCM below the Application Style KCM, drop the word GNOME, update strings

D19788: [service runner] throw out kde3 "compat" code

GB_2 added a comment. This is bug 383287 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D19788 To: sitter, broulik Cc: GB_2, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19651: Improve the look of the Application Style KCM UI

This revision was automatically updated to reflect the committed changes. Closed by commit R119:a946944edb20: Improve the look of the Application Style KCM UI (authored by GB_2). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19651?vs=53803=53806

D19651: Improve the look of the Application Style KCM UI

GB_2 updated this revision to Diff 53803. GB_2 added a comment. Update Quick Help text REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19651?vs=53798=53803 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19651 AFFECTED FILES

D19651: Improve the look of the Application Style KCM UI

GB_2 updated this revision to Diff 53798. GB_2 added a comment. Update preview REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19651?vs=53792=53798 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19651 AFFECTED FILES

D19651: Improve the look of the Application Style KCM UI

GB_2 updated this revision to Diff 53792. GB_2 added a comment. Implement Rooty's suggestions and update preview REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19651?vs=53747=53792 BRANCH master REVISION DETAIL

D19651: Improve the look of the Application Style KCM UI

GB_2 added a comment. In D19651#430117 , @rooty wrote: > Please consider abbreviating the labels: > > - dropping text in the last two dropdown menu items (No Text, Text Only, Beside Icons, Below Icons) > - dropping the word location (it's

D19651: Improve the look of the Application Style KCM UI

GB_2 updated this revision to Diff 53747. GB_2 added a comment. Improve preview REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19651?vs=53635=53747 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19651 AFFECTED FILES

D19651: Improve the look of the Application Style KCM UI

GB_2 added a comment. In D19651#428459 , @GB_2 wrote: > In D19651#428458 , @ndavis wrote: > > > Can it have the same default width as the toolbar text location comboboxes? > > > Yeah, I can

D19651: Improve the look of the Application Style KCM UI

GB_2 updated this revision to Diff 53635. GB_2 added a comment. Check if configure button should be enabled after clicking "Defaults" and rename "cbStyle" to "comboStyle" REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19651?vs=53592=53635 BRANCH

D19651: Improve the look of the Application Style KCM UI

GB_2 added a comment. In D19651#428458 , @ndavis wrote: > Can it have the same default width as the toolbar text location comboboxes? Yeah, I can do that. REPOSITORY R119 Plasma Desktop REVISION DETAIL

D19651: Improve the look of the Application Style KCM UI

GB_2 added a comment. In D19651#428453 , @ndavis wrote: > Is that "Application style" combobox long enough to accommodate longer strings like "MS Windows 9x"? Yes, it adjusts itself to the width of the longest item automatically.

D19651: Improve the look of the Application Style KCM UI

GB_2 updated this revision to Diff 53592. GB_2 added a comment. Rename style preview checkbox from "Check box" to "Checkbox" REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19651?vs=53591=53592 BRANCH master REVISION DETAIL

D19651: Improve the look of the Application Style KCM UI

GB_2 updated this revision to Diff 53591. GB_2 added a comment. Clean up style preview UI file REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19651?vs=53589=53591 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19651 AFFECTED FILES

D19651: Improve the look of the Application Style KCM UI

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY Apply the KDE HIG, merge the two tabs into one page and make the KCM look better. F6680804:

D19472: [Task Manager] Make sure "Alternatives..." context menu item is always available

GB_2 added a comment. In D19472#427613 , @ngraham wrote: > In D19472#427046 , @broulik wrote: > > > This suffers from the same bug as the action in the D17410 .

D17410: Add alternatives button to applet configuration in panel edit mode

GB_2 added a comment. Ping REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17410 To: GB_2, #plasma, #vdg Cc: broulik, davidedmundson, ngraham, ndavis, #vdg, plasma-devel, #plasma, Pixel_Lime, jraleigh, squeakypancakes, alexde, IohannesPetros, GB_2, rooty,

D19280: [TaskManager] Modernize and reorganize configuration settings

GB_2 added a comment. Now just update the screenshots. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D19280 To: filipf, #plasma, #vdg, ngraham, rooty, GB_2, hein Cc: hein, GB_2, rooty, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot,

D19280: [TaskManager] Modernize and reorganize configuration settings

GB_2 added inline comments. INLINE COMMENTS > ngraham wrote in ConfigAppearance.qml:21 > Yes it is, there's a RowLayout in here. I meant the QQC1 import, but it was removed just before I posted this comment :P REPOSITORY R119 Plasma Desktop REVISION DETAIL

D19280: [TaskManager] Modernize and reorganize configuration settings

GB_2 added inline comments. INLINE COMMENTS > ConfigAppearance.qml:21 > +import QtQuick 2.0 > +import QtQuick.Controls 1.0 as QQC1 > +import QtQuick.Controls 2.5 Import is not needed anymore. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19280 To: filipf,

D19280: [TaskManager] Modernize and reorganize configuration settings

GB_2 added inline comments. INLINE COMMENTS > filipf wrote in ConfigBehavior.qml:69 > I tried `units.largeSpacing` first then realized it's not aligned with the > top text (not even with 1.0 scaling) so I did something like > `(units.largeSpacing - units.smallSpacing * 2)` which worked ok with

D19280: [TaskManager] Modernize and reorganize configuration settings

GB_2 added inline comments. INLINE COMMENTS > hein wrote in ConfigBehavior.qml:69 > Wait, 10x the checkbox width? Should be `units.largeSpacing` REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19280 To: filipf, #plasma, #vdg, ngraham, rooty, GB_2, hein Cc:

D19280: [TaskManager] Modernize and reorganize configuration settings

GB_2 added a comment. Almost perfect! INLINE COMMENTS > ConfigBehavior.qml:64 > +id: onlyGroupWhenFull > +text: i18n("Only when the Task Manager is full") > +enabled: groupingStrategy.currentIndex > 0 && groupPopups.checked "Task Manager" should be

D19077: Redesign the theme preview window

GB_2 added a comment. In D19077#417065 , @filipf wrote: > OK so down to only one hack now. If possible I'd really like to keep it because it works in 100% of the cases I tested it with and results in better visuals; don't know how to fix on the

D19093: Improve the look of the Emoticons KCM UI

This revision was automatically updated to reflect the committed changes. Closed by commit R119:8b413729da44: Improve the look of the Emoticons KCM UI (authored by GB_2). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19093?vs=51978=51979 REVISION

D19093: Improve the look of the Emoticons KCM UI

GB_2 updated this revision to Diff 51978. GB_2 added a comment. Address comments REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19093?vs=51905=51978 BRANCH improve-look-of-emoticons-kcm-ui (branched from master) REVISION DETAIL

D19093: Improve the look of the Emoticons KCM UI

GB_2 updated this revision to Diff 51905. GB_2 added a comment. Fix resizing REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19093?vs=51903=51905 BRANCH improve-look-of-emoticons-kcm-ui (branched from master) REVISION DETAIL

D19093: Improve the look of the Emoticons KCM UI

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY Apply the KDE HIG, make buttons consistent and make the KCM look better. F6619998: Improved

D19079: Make look of Font Management KCM UI more consistent

This revision was automatically updated to reflect the committed changes. Closed by commit R119:8596ae908533: Make look of Font Management KCM UI more consistent (authored by GB_2). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19079?vs=51877=51893

D19079: Make look of Font Management KCM UI more consistent

GB_2 updated this revision to Diff 51877. GB_2 added a comment. Use /Cancel style message box buttons REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19079?vs=51866=51877 BRANCH make-look-of-font-management-kcm-ui-more-consistent (branched from

D19079: Make look of Font Management KCM UI more consistent

GB_2 added a comment. In D19079#413663 , @ngraham wrote: > While we're at it, can we turn those Yes/No messageboxes into /Cancel style instead? Sure REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19079

D19079: Make look of Font Management KCM UI more consistent

GB_2 updated this revision to Diff 51866. GB_2 added a comment. Remove unneeded ellipses REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19079?vs=51855=51866 BRANCH arcpatch-D19079 REVISION DETAIL https://phabricator.kde.org/D19079 AFFECTED

D19079: Make look of Font Management KCM UI more consistent

GB_2 added inline comments. INLINE COMMENTS > ngraham wrote in KCmFontInst.cpp:236 > Heh I think that may be a typo and the word was supposed to be "excluding". I > specifically remember having a conversation about this and we concluded that > confirmation prompts didn't count because then you

D19079: Make look of Font Management KCM UI more consistent

GB_2 added inline comments. INLINE COMMENTS > ngraham wrote in KCmFontInst.cpp:236 > This one doesn't need an ellipsis. If the window/dialog that pops up when you > click on it is nothing more than a confirmation box, we don't use ellipsis. > > However the confirmation dialog that results from

D19079: Make look of Fonts KCM UI more consistent

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY Apply the KDE HIG and make tooltips, buttons and others more consistent and better looking.

D17410: Add alternatives button to applet configuration in panel edit mode

GB_2 added a subscriber: broulik. GB_2 added a comment. It seems like this is quite difficult, me and @broulik couldn't figure it out. If someone wants to take over this revision then please do it. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17410 To:

D19046: Make Breeze theme tooltip texts consistent and rename Breeze Snow cursors to Breeze Light

This revision was automatically updated to reflect the committed changes. Closed by commit R31:1befbfed8bbe: Make Breeze theme tooltip texts consistent and rename Breeze Snow cursors to… (authored by GB_2). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE

D19046: Make Breeze theme tooltip texts consistent and rename Breeze Snow cursors to Breeze Light

GB_2 updated this revision to Diff 51781. GB_2 added a comment. Fix comment REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19046?vs=51780=51781 BRANCH make-breeze-theme-tooltip-texts--consistent-and-rename-breeze-snow-cursors-to-breeze-light (branched

D19046: Make Breeze theme tooltip texts consistent and rename Breeze Snow cursors to Breeze Light

GB_2 added inline comments. INLINE COMMENTS > ngraham wrote in index.theme:46 > `Comment=Comment=Breeze`? :) Oops, haha REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D19046 To: GB_2, #plasma, #vdg, ngraham Cc: ngraham, #vdg, plasma-devel, #plasma, jraleigh, GB_2,

D19046: Make Breeze theme tooltip texts consistent and rename Breeze Snow cursors to Breeze Light

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY Improve wording and make texts consistent with others. TEST PLAN Open the Curors KCM and hover over

D19038: Make Appearance KCM tooltip texts consistent

This revision was automatically updated to reflect the committed changes. Closed by commit R119:6eb834d7: Make Appearance KCM tooltip texts consistent (authored by GB_2). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19038?vs=51761=51778 REVISION

D19038: Make Appearance KCM tooltip texts consistent

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY Improve wording and add an ellipsis where needed in tooltips in Appearance KCMs. TEST PLAN Open

D19009: Use better KDE GTK Config KCM desktop file comment

This revision was automatically updated to reflect the committed changes. Closed by commit R99:bceb50cb8ec3: Use better KDE GTK Config KCM desktop file comment (authored by GB_2). REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE

D19006: Use KCM name in KCM header

This revision was automatically updated to reflect the committed changes. Closed by commit R124:b6ad57fc5fa2: Use KCM name in KCM header (authored by GB_2). REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19006?vs=51688=51695 REVISION DETAIL

D19009: Use better KDE GTK Config KCM desktop file comment

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY Use a better KDE GTK Config KCM desktop file comment that is correct and consistent with others.

D19006: Use KCM name in KCM header

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY Use the KCM name in Qt Widgets KCM headers, to make them consistent with others. F6614892: KCM Name

D18892: Move Look and Feel KCM to top level

This revision was automatically updated to reflect the committed changes. Closed by commit R119:0af980f5cab8: Move Look and Feel KCM to top level (authored by GB_2). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18892?vs=51301=51642 REVISION DETAIL

D18892: Move Look and Feel KCM to top level

GB_2 added a comment. Ping? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D18892 To: GB_2, #plasma, #vdg, rooty, ngraham, davidedmundson, abetts Cc: ngraham, davidedmundson, abetts, rooty, #vdg, plasma-devel, #plasma, jraleigh, GB_2, ragreen, Pitel,

D18903: Make Appearance KCMs' labels consistent

GB_2 added a comment. Oops REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D18903 To: filipf, GB_2, #vdg, ngraham, #plasma Cc: broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18903: Make Appearance KCMs' labels consistent

GB_2 accepted this revision. GB_2 added a comment. In D18903#411538 , @ngraham wrote: > In D18903#411529 , @filipf wrote: > > > For this patch (and moving forward) we still have 2 dilemmas left then:

<    1   2   3   4   5   6   7   >