D27277: Properly search for PipeWire libs

cgiboudeaux accepted this revision. cgiboudeaux added a comment. This revision is now accepted and ready to land. Just one thing left to fix before pushing INLINE COMMENTS > FindPipeWire.cmake:112 > INTERFACE_COMPILE_OPTIONS "${PipeWire_DEFINITIONS}" > -

D27277: Properly search for PipeWire libs

cgiboudeaux added inline comments. INLINE COMMENTS > FindPipeWire.cmake:74 > +pipewire-0.3/pipewire/pipewire.h > +spa-0.2/spa/param/props.h > +# Old PipeWire locations same thing for this one > FindPipeWire.cmake:80 > ${PKG_PipeWire_INCLUDE_DIRS} > +

D27277: Properly search for PipeWire libs

cgiboudeaux added inline comments. INLINE COMMENTS > FindPipeWire.cmake:73 > NAMES > +pipewire-0.3/pipewire/pipewire.h > +spa-0.2/spa/param/props.h this would break includes > FindPipeWire.cmake:76 > +# Old PipeWire locations > pipewire/pipewire.h > +

D24751: installdbgsymbols_suse: Pass --plus-content debug to zypper

This revision was automatically updated to reflect the committed changes. Closed by commit R871:807d9dccab08: installdbgsymbols_suse: Pass --plus-content debug to zypper (authored by fvogt, committed by cgiboudeaux). REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE

D25275: Clean up config-X11.h

cgiboudeaux closed this revision. REPOSITORY R101 KHotKeys REVISION DETAIL https://phabricator.kde.org/D25275 To: cgiboudeaux, davidedmundson Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai,

D25275: Clean up config-X11.h

cgiboudeaux added a comment. Also tested with CMake 3.1 which is the version required by Qt 5.12. REPOSITORY R101 KHotKeys REVISION DETAIL https://phabricator.kde.org/D25275 To: cgiboudeaux Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot,

D25275: Clean up config-X11.h

cgiboudeaux created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. cgiboudeaux requested review of this revision. REVISION SUMMARY Khotkeys only requires libX11 and the optional Xtst component. Report whether the optional Xtst component was found.

D25275: Clean up config-X11.h

cgiboudeaux added a comment. Note: this is 2 different commits. REPOSITORY R101 KHotKeys REVISION DETAIL https://phabricator.kde.org/D25275 To: cgiboudeaux Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf,

D25223: Avoid side effects during menu initialization

cgiboudeaux added a comment. tested successfully locally. I don't see menus opening on the top left corner when running vlc or hp-systray. REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D25223 To: kmaterka, #plasma, #frameworks,

D24363: Fix several build system errors

cgiboudeaux added a comment. Note: the metainfo file says this framework is tier 3. The subgroup value looks wrong INLINE COMMENTS > CMakeLists.txt:40-41 > +# IconThemes and ConfigWidgets are optional > +find_package(KF5IconThemes) > +find_package(KF5ConfigWidgets) > KF5_DEP_VERSION

D18244: Check for python-cairo

cgiboudeaux added a comment. In D18244#394859 , @rikmills wrote: > This breaks NeonKubuntu builds, whereas previously the builds were working as I explicitly had added python3-cairo to the build depends. It is there still, but cmake thinks not.

D18244: Check for python-cairo

cgiboudeaux added a comment. +1 REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D18244 To: davidedmundson, #plasma, ngraham, cgiboudeaux Cc: ngraham, zzag, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D18244: Check for python-cairo

cgiboudeaux added inline comments. INLINE COMMENTS > zzag wrote in FindPythonCairo.cmake:6 > Shouldn't it be right after find_package(Python3)? Correct, or this will be empty with CMake < 3.12 REPOSITORY R98 Breeze for Gtk BRANCH master REVISION DETAIL

D18244: Check for python-cairo

cgiboudeaux added inline comments. INLINE COMMENTS > FindPythonCairo.cmake:8 > +# Check for python cairo > +execute_process(COMMAND ${PYTHON_EXECUTABLE} -c "import cairo" > +RESULT_VARIABLE PYTHON_CAIRO_RESULT) FindPython3.cmake doesn't define PYTHON_EXECUTABLE but

D17154: Go back to SCSS

cgiboudeaux added a comment. In D17154#392806 , @davidedmundson wrote: > > Are there any strong reasons? > > It's not installed, so a user can't use it. > > That means it's only a build tool. As it's a build tool it's very important to

D17154: Go back to SCSS

cgiboudeaux added inline comments. INLINE COMMENTS > CMakeLists.txt:14 > > -include(KDEInstallDirs) > +if(${CMAKE_VERSION} GREATER_EQUAL 3.12.0) > +find_package(Python3 COMPONENTS Interpreter REQUIRED) This doesn't exist in CMake 2.8.12. Use if(NOT CMAKE_VERSION VERSION_LESS 3.12.0)

Re: Fwd: KDE CI: Administration » Dependency Build Plasma kf5-qt5 SUSEQt5.11 - Build # 5 - Failure!

On jeudi 13 septembre 2018 21:47:36 CEST Ben Cooksley wrote: > Hi all, > > Please see below. If someone could please take a look and fix this failure > that would be appreciated. > > On another note, the Marble build recently broke with a similar error - has > something been changed in

D15442: Improve DDCUtil handling in CMakeLists

cgiboudeaux added a comment. With the change, you can't tell if powerdevil must use the old or the new api. Suggestion: https://paste.kde.org/powk2bhxm config_powerdevil.h then defines HAVE_DDCUTIL and DDCUTIL_VERSION REPOSITORY R122 Powerdevil REVISION DETAIL

D15327: Add appmenu-gtk-module as runtime dependency

cgiboudeaux accepted this revision. cgiboudeaux added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > FindAppMenuGtkModule.cmake:1-6 > +# - Try to find appmenu-gtk2-module and appmenu-gtk3-module > +# Once done this will define > +# > +#

D15310: Search for the Qt5Platform/ThemeSupport in the default includes first

cgiboudeaux added a comment. In D15310#321234 , @sdepiets wrote: > Checking that Qt5Core version is initialized Sorry, but the whole change makes no sense, a big -1. REPOSITORY R135 Integration for Qt applications in Plasma REVISION

D15310: Search for the Qt5Platform/ThemeSupport in the default includes first

cgiboudeaux added a comment. In D15310#321232 , @sdepiets wrote: > In D15310#321216 , @cgiboudeaux wrote: > > > In D15310#321210 , @davidedmundson wrote:

D15310: Search for the Qt5Platform/ThemeSupport in the default includes first

cgiboudeaux added a comment. In D15310#321210 , @davidedmundson wrote: > I have this in my dev setup > > PKG_CONFIG_PATH=/opt/qt5/lib/pkgconfig:/opt/kde5/lib64/pkgconfig > > If you had the equivalent, would you need this?

D15310: Search for the Qt5Platform/ThemeSupport in the default includes first

cgiboudeaux added inline comments. INLINE COMMENTS > FindQt5PlatformSupport.cmake:72 > +PATH_SUFFIXES > +QtPlatformSupport/${Qt5Core_VERSION}/ > ) This CMake module doesn't know Qt5Core_VERSION, this only works for you because there's a find_package(Qt5 ...) call before looking

D15228: Export install location for DBUS interfaces via CMake

cgiboudeaux added a comment. In D15228#320381 , @bruns wrote: > This did not break the build, but D15229 becoming effective before this one. Without commit 36a7e03

D15228: Export install location for DBUS interfaces via CMake

cgiboudeaux added a comment. In D15228#319955 , @broulik wrote: > This breaks plasma-workspace build on CI: https://build.kde.org/job/Plasma%20plasma-workspace%20kf5-qt5%20FreeBSDQt5.11/16/ FTR; fixed in master. REPOSITORY R133

Re: Changes to networkmanager-qt - breakage in plasma-workspace

Hi, On vendredi 30 mars 2018 00:21:41 CEST Ben Cooksley wrote: > Hi Jan, > > It seems that as part of your recent changes to networkmanager-qt to > increase the dependency to 1.0.0 you've made some other changes which > mean the appropriate include paths are no longer being provided to >

D8858: Fix testWaylandFullscreenShell.

This revision was automatically updated to reflect the committed changes. Closed by commit R127:7cd465a3bad3: Fix testWaylandFullscreenShell. (authored by cgiboudeaux). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D8858?vs=22546=23037#toc REPOSITORY R127 KWayland CHANGES SINCE LAST

D8858: Fix testWaylandFullscreenShell.

cgiboudeaux added a comment. ping ! REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D8858 To: cgiboudeaux, graesslin Cc: plasma-devel, #frameworks, leezu, ZrenBot, alexeymin, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart,

D8858: Fix testWaylandFullscreenShell.

cgiboudeaux updated this revision to Diff 22546. cgiboudeaux added a comment. Add message if the executable wasn't found REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8858?vs=22492=22546 BRANCH master REVISION DETAIL

D8858: Fix testWaylandFullscreenShell.

cgiboudeaux created this revision. cgiboudeaux added a reviewer: graesslin. Restricted Application added subscribers: Frameworks, plasma-devel. Restricted Application added projects: Plasma on Wayland, Frameworks. REVISION SUMMARY This test needs the weston executable. Skip the test if the

[Powerdevil] [Bug 379740] Build fails with CLang

https://bugs.kde.org/show_bug.cgi?id=379740 Christophe Giboudeaux <christo...@krop.fr> changed: What|Removed |Added CC||j...@jridde

[Powerdevil] [Bug 379740] New: Build fails with CLang

https://bugs.kde.org/show_bug.cgi?id=379740 Bug ID: 379740 Summary: Build fails with CLang Product: Powerdevil Version: unspecified Platform: Other OS: Linux Status: UNCONFIRMED Severity: normal

Re: Review Request 117783: Handle QxOrm release and debug mode properly

}) endif() cmake/FindQxOrm.cmake https://git.reviewboard.kde.org/r/117783/#comment39479 endif() - Christophe Giboudeaux On April 26, 2014, 11:57 a.m., Bhushan Shah wrote: --- This is an automatically generated e-mail

Re: Review Request 117783: Handle QxOrm release and debug mode properly

/117783/#comment39483 copy paste is bad :) libs/mediacenter/CMakeLists.txt https://git.reviewboard.kde.org/r/117783/#comment39484 That's now one or another - Christophe Giboudeaux On April 26, 2014, 1:11 p.m., Bhushan Shah wrote

Re: Review Request 117783: Handle QxOrm release and debug mode properly

://git.reviewboard.kde.org/r/117783/#comment39494 s/have/has - Christophe Giboudeaux On April 26, 2014, 1:41 p.m., Bhushan Shah wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117783