D19370: [sddm-theme] Add circles behind action buttons

filipf abandoned this revision. filipf added a comment. Parent dependency was abandoned. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D19370 To: filipf, #vdg, ngraham, rooty, #plasma Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, a

D19379: [sddm-theme] Add a bottom panel

filipf abandoned this revision. filipf added a comment. Parent dependency was abandoned. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D19379 To: filipf, #vdg, #plasma, ngraham, rooty Cc: abetts, broulik, ndavis, plasma-devel, jraleigh, GB_2, ragreen, Pitel

D19044: [InlineMessage] Do not draw shadows around the message

filipf updated this revision to Diff 52923. filipf added a comment. don't track the .directory file REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19044?vs=52922&id=52923 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19044 AFFECTED FILE

D19044: [InlineMessage] Do not draw shadows around the message

filipf updated this revision to Diff 52922. filipf added a comment. move most of InlineMessage into templates, use shadow in /controls, don't use a shadow in /styles/Material REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19044?vs=51774&id=52922 BRANC

D19044: [InlineMessage] Do not draw shadows around the message

filipf added a comment. In D19044#416559 , @mart wrote: > - whole InlineMessage should be moved into templates I've been trying to do this but there's several properties such as padding and contentItem (with a big ColumnLayout attached) t

D19275: [ConfigCategoryDelegate] Add horizontal padding to the label

This revision was automatically updated to reflect the committed changes. Closed by commit R119:ff0a0e30a28a: [ConfigCategoryDelegate] Add horizontal padding to the label (authored by filipf). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19275?vs=5244

D19275: [ConfigCategoryDelegate] Add horizontal padding to the label

filipf added a comment. Any more thoughts on this? REPOSITORY R119 Plasma Desktop BRANCH config-category-label-padding (branched from master) REVISION DETAIL https://phabricator.kde.org/D19275 To: filipf, #plasma, #vdg, ngraham Cc: rooty, plasma-devel, jraleigh, GB_2, ragreen, Pitel,

D19409: [sddm-theme/lock screen] Adjust login and lock screen blur effect

filipf added a comment. In D19409#422453 , @rooty wrote: > In D19409#422361 , @filipf wrote: > > > In D19409#422203 , @rooty wrote: > > > > > Should we

D19433: [sddm-theme/lock screen] Increase username and action button font size

filipf added a comment. In any case, I'd like to have it like this: - no shadows with blur - username is 12pt (or level 3) - action buttons are 11pt (or level 4) - the tool buttons at the bottom are 10 pt F6646413: image.png REPOSITORY R

D19433: [sddm-theme/lock screen] Increase username and action button font size

filipf added a comment. The difference is too jarring with level 3. F6646395: image.png REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D19433 To: rooty, #vdg, #plasma, ngraham Cc: filipf, ngraham, plasma-devel, jra

D19409: [sddm-theme/lock screen] Adjust login and lock screen blur effect

filipf added a comment. In D19409#422203 , @rooty wrote: > Should we keep the UserDelegate.qml shadow then? Because it doesn't seem necessary considering the blur's here to stay. I think they're unnecessary. There's also a bug they cause

D19433: [sddm-theme/lock screen] Increase username and action button font size

filipf added a comment. From a technical point of view I'm not sure this is the ideal solution. It's not hardcoding font sizes, but is changing only 2 labels (to be headings when they're actually not headings) while the other ones remain 10pt. The best solution would be if we had an opti

D19077: Redesign the theme preview window

filipf added a subscriber: mart. filipf added a comment. @mart could you help us out a bit please? I used code with "Kirigami.Theme.viewBackgroundColor.r", which throws out a warning that the value is deprecated. The one suggested for replacement (Theme.View) isn't the same as the deprecated

D19409: [sddm-theme/lock screen] WIP, Adjust login and lock screen blur effect

filipf added a comment. In D19409#421832 , @rooty wrote: > In D19409#421790 , @davidedmundson wrote: > > > The relevant preview we need to do is see how the blur looks over a near completely black a

D19372: [sddm-theme] Enlarge user avatar in focus

filipf added a comment. In D19372#421381 , @davidedmundson wrote: > Heh, I'm sure some old SDDM (maybe even LightDM) theme did that. There was a whole Carousel system. Our old SDDM theme

D19379: [sddm-theme] Add a bottom panel

filipf planned changes to this revision. filipf added a comment. In D19379#421197 , @abetts wrote: > I can help with defining how they can look in the center? That would be of great help, please do. I agree there could be better solutions

D19379: [sddm-theme] Add a bottom panel

filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY As a dependent revision of D19369 , this patch adds a panel to the bottom in order to make sure t

D19364: [sddm-theme/lock screen] Add shadows to action buttons

filipf accepted this revision as: filipf. filipf added a comment. This revision is now accepted and ready to land. Will let Nate verify that the outline patch has been done well here, but otherwise looks good. REPOSITORY R120 Plasma Workspace BRANCH arcpatch-D19364 REVISION DETAIL htt

D19373: [RFC] [Splash Screen] Use current "Next" wallpaper as the background

filipf added a comment. ^ let's discuss it in a separate task (here's one technical caveat: people with different sddm themes having to select the breeze theme to change their splash screen), I agree that implementing it here would be rushing things REPOSITORY R120 Plasma Workspace BRANCH

D19373: [RFC] [Splash Screen] Use current "Next" wallpaper as the background

filipf added a comment. Finally! Now let's just get it to work. INLINE COMMENTS > Splash.qml:28 > +// ${CMAKE_INSTALL_PREFIX}/${WALLPAPER_INSTALL_DIR > +source: "/usr/share/wallpapers/Next/contents/images/3200x2000.png" > +fillMode: Image.PreserveAspectCrop This will get removed

D19372: [sddm-theme] Enlarge user avatar in focus

filipf added a comment. In D19372#420739 , @rooty wrote: > In D19372#420737 , @filipf wrote: > > > As this is meant to be a replacement for `opacity: isCurrent ? 1.0 : 0.5` I would suggest to remove

D19372: [sddm-theme] Enlarge user avatar in focus

filipf added a comment. As this is meant to be a replacement for `opacity: isCurrent ? 1.0 : 0.5` I would suggest to remove it in this patch. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D19372 To: rooty, #vdg, ngraham Cc: filipf, plasma-devel, jraleigh,

D19370: [sddm-theme] Add circles behind action buttons

filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY As a dependent revision of D19369 , this patch adds a circle behind action button icons in order

D19184: [Kicker, Kickoff & Dash] Use the word "Sleep" instead of "Suspend"

filipf accepted this revision. filipf added a comment. This revision is now accepted and ready to land. +1 REPOSITORY R119 Plasma Desktop BRANCH use-the-word-sleep (branched from master) REVISION DETAIL https://phabricator.kde.org/D19184 To: ngraham, #vdg, #plasma, filipf Cc: filipf,

D19185: [KRunner, SDDM theme, Logout screen, Login widget] Use the word "Sleep" instead of "Suspend"

filipf accepted this revision. filipf added a comment. +1 from a usability and visuals POV REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D19185 To: ngraham, #vdg, #plasma, filipf Cc: filipf, davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, Zre

D19186: [KCM & UI] Use the word "Sleep" instead of "Suspend"

filipf accepted this revision. filipf added a comment. This revision is now accepted and ready to land. +1 for the reasons listed in the commit message REPOSITORY R122 Powerdevil BRANCH use-the-word-sleep (branched from master) REVISION DETAIL https://phabricator.kde.org/D19186 To: ng

D19280: [TaskManager] Modernize and reorganize configuration settings

This revision was automatically updated to reflect the committed changes. Closed by commit R119:5e905afb07e8: [TaskManager] Modernize and reorganize configuration settings (authored by filipf). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19280?vs=526

D19325: [sddm-theme/lock screen] WIP, Tighten clock shadows

filipf added a comment. In D19325#420487 , @ngraham wrote: > OK, if 0.35 spread is too much, how about increasing the radius a bit instead? The thing that I don't like so much about this new style is how hard-edged the shadows look in comparison

D19325: [sddm-theme/lock screen] WIP, Tighten clock shadows

filipf added a comment. I think we should also be a little big careful with trying to apply the same shadow settings everywhere. The DesktopContainment settings work great for 10pt and 11pt text (meaning they will be great for most of the labels in the sddm theme), but the clock is rather bi

D19280: [TaskManager] Modernize and reorganize configuration settings

filipf updated this revision to Diff 52647. filipf added a comment. Don't import QQC1 for ConfigAppearance.qml REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19280?vs=52646&id=52647 BRANCH master REVISION DETAIL https://phabricator.kde.org/D192

D19280: [TaskManager] Modernize and reorganize configuration settings

filipf added a comment. In D19280#420401 , @filipf wrote: > rename "vertical" property to "plasmoidVertical" because it was interfering with QQC2's slider > "vertical" variable; use QQC2 slider Shoutout to @GB_2 for figuring out why t

D19280: [TaskManager] Modernize and reorganize configuration settings

filipf updated this revision to Diff 52646. filipf added a comment. rename "vertical" property to "plasmoidVertical" because it was interfering with QQC2's slider "vertical" variable; use QQC2 slider REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/

D19325: [sddm-theme/lock screen] WIP, Tighten clock shadows

filipf added a comment. In D19325#420378 , @ngraham wrote: > However, the Request Changes is for two reasons: > > 1. Shouldn't we do this for the shadows under the usernames too? > 2. I'm not sold on the visual appearance. No other shadow in

D19280: [TaskManager] Modernize and reorganize configuration settings

filipf updated this revision to Diff 52644. filipf added a comment. use units.largeSpacing for indentation; remove redunant visible: vertical properties for children of RowLayout REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19280?vs=52565&id=52

D19325: [sddm-theme/lock screen] WIP, Tighten clock shadows

filipf added a comment. I've been advocating this before (D16031#372706 ) so obviously I'm in favor of the change. One thing that's been bothering me though is the blue offset that shows up to the left of the text: F6639680: image.png

D19280: [TaskManager] Modernize and reorganize configuration settings

filipf added inline comments. INLINE COMMENTS > GB_2 wrote in ConfigBehavior.qml:69 > Should be `units.largeSpacing` I tried `units.largeSpacing` first then realized it's not aligned with the top text (not even with 1.0 scaling) so I did something like `(units.largeSpacing - units.smallSpacing

D19044: [InlineMessage] Do not draw shadows around the message

filipf added a comment. In D19044#416559 , @mart wrote: > - whole InlineMessage should be moved into templates Im not home right now but I ran into an issuse with this step because that file I should move to templates already imports temp

D19280: [TaskManager] Modernize and reorganize configuration settings

filipf updated this revision to Diff 52565. filipf added a comment. I forgot to hide the grouping and sorting options when using Icons-only REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19280?vs=52518&id=52565 BRANCH master REVISION DETAIL htt

D19077: Redesign the theme preview window

filipf added inline comments. INLINE COMMENTS > ngraham wrote in main.qml:81 > This is a word puzzle and will lead to bad translations because translators > won't be able to figure out what `", by "` refers to. The string should be > like this instead: > > `i18n("%1, by %2 (%3)", description,

D18934: WIP: [Notifications] Remove close button border by porting to IconItem

filipf added a comment. Update: I managed to get RoundButton working. While it does only have a minimal frame, unfortunately (with non-Breeze themes I believe) the button seemed to be suffering from odd coloring issues such as randomly taking on highlight color (even when the notifications w

D19280: [TaskManager] Modernize and reorganize configuration settings

filipf updated this revision to Diff 52518. filipf added a comment. try a better solution for the indentation (now works consistently with scaling) REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19280?vs=52514&id=52518 BRANCH master REVISION DET

D19289: [DeviceNotifier] Port settings to QQC2 and Kirigami

This revision was automatically updated to reflect the committed changes. Closed by commit R120:6be6a8c003c6: [DeviceNotifier] Port settings to QQC2 and Kirigami (authored by filipf). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19289?vs=52497&id=52

D19280: [TaskManager] Modernize and reorganize configuration settings

filipf updated this revision to Diff 52514. filipf added a comment. fix typo in comments REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19280?vs=52513&id=52514 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19280 AFFECTED FILES a

D19280: [TaskManager] Modernize and reorganize configuration settings

filipf updated this revision to Diff 52513. filipf added a comment. revert grouping settings order and indent the onlyGroupWhenFull option REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19280?vs=52491&id=52513 BRANCH master REVISION DETAIL http

D19289: [DeviceNotifier] Port settings to QQC2 and Kirigami

filipf updated this revision to Diff 52497. filipf added a comment. remove PlasmaCore as an import REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19289?vs=52493&id=52497 BRANCH modernize-devicenotifier-settings (branched from master) REVISION D

D19289: [DeviceNotifier] Port settings to QQC2 and Kirigami

filipf added inline comments. INLINE COMMENTS > configGeneral.qml:23 > > import org.kde.plasma.core 2.0 as PlasmaCore > Is PlasmaCore also needed here? REPOSITORY R120 Plasma Workspace BRANCH modernize-devicenotifier-settings (branched from master) REVISION DETAIL https://phabricat

D19289: [DeviceNotifier] Port settings to QQC2 and Kirigami

filipf added a comment. In D19289#418964 , @davidedmundson wrote: > Out of curiosity, did you need the exclusive group. > In theory RadioButton should do it automatically when we share a parent, I'm curious if FormLayout breaks that.

D19289: [DeviceNotifier] Port settings to QQC2 and Kirigami

filipf updated this revision to Diff 52493. filipf added a comment. ButtonGroup is not needed REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19289?vs=52489&id=52493 BRANCH modernize-devicenotifier-settings (branched from master) REVISION DETAIL

D19280: [TaskManager] Modernize and reorganize configuration settings

filipf added a comment. Thank you :) Does anyone from #plasma maybe know why the QQC2 Slider fails to obey the "visible: vertical" setting? The variables have been changed in accordance with QQC2 and the slider does show up with no "visible:" st

D19280: [TaskManager] Modernize and reorganize configuration settings

filipf updated this revision to Diff 52491. filipf added a comment. "Filters:" -> "Filter:", "Only when the Task Manager is full" -> "Group only when the Task Manager is full" (I think it's better to be explicit), use "preferences-desktop-color" for Appearance icon, "Highlight windows"

D19289: [DeviceNotifier] Port settings to QQC2 and Kirigami

filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY Settings are ported to QtQuickControls 2 and now use a Kirigami Form Layout. REPOSITORY R120 Plasma Workspace BRANCH modernize-d

D19280: [TaskManager] Modernize and reorganize configuration settings

filipf added a comment. Much better, I agree! I've implemented all the changes. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19280 To: filipf, #plasma, #vdg, ngraham, rooty Cc: rooty, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-m

D19280: [TaskManager] Modernize and reorganize configuration settings

filipf updated this revision to Diff 52484. filipf added a comment. better categorization of settings REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19280?vs=52479&id=52484 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19280 AFFEC

D19280: [TaskManager] Modernize and reorganize configuration settings

filipf updated this revision to Diff 52479. filipf added a comment. use sentence-style capitalization for combobox entries REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19280?vs=52476&id=52479 BRANCH master REVISION DETAIL https://phabricator.

D19280: [TaskManager] Modernize and reorganize configuration settings

filipf updated this revision to Diff 52476. filipf edited the test plan for this revision. filipf added a comment. Use action verbs for "Sorting" and "Grouping"; extend "visible: vertical" property to all revelant elements REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https

D19276: [AppletConfiguration] Use title case for Keyboard Shortcuts label

This revision was automatically updated to reflect the committed changes. Closed by commit R119:61e9f7319a60: [AppletConfiguration] Use title case for Keyboard Shortcuts label (authored by filipf). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19276?vs

D19280: [TaskManager] Modernize and reorganize configuration settings

filipf updated this revision to Diff 52465. filipf added a comment. remove unneeded section breaks at the very beginning of the layout REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19280?vs=52461&id=52465 BRANCH master REVISION DETAIL https://

D19280: [TaskManager] Modernize and reorganize configuration settings

filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY This patch ports most of the QQC1 elements into QQC2 and makes use of Kirigami.FormLayout. Due to an overwhelming number of opt

D19276: [AppletConfiguration] Use title case for Keyboard Shortcuts label

filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY "Keyboard shortcuts" -> "Keyboard Shortcuts" REPOSITORY R119 Plasma Desktop BRANCH keyboard-shortcuts-TC (branched from master)

D19275: [ConfigCategoryDelegate] Add horizontal padding to the label

filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY This patch adds horizontal padding to the category configuration delegate so that the label does not look like it is glued to the p

D19036: [notifications] Lift up notification content if one line of body text droops

filipf accepted this revision. filipf added a comment. This revision is now accepted and ready to land. Tested it and it looks good to me. REPOSITORY R120 Plasma Workspace BRANCH lift-up-noto (branched from master) REVISION DETAIL https://phabricator.kde.org/D19036 To: rooty, #plasma,

D19077: Redesign the theme preview window

filipf updated this revision to Diff 52351. filipf added a comment. save some vertical space, don't use max line count and elision REPOSITORY R123 SDDM Configuration Panel (KCM) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19077?vs=52249&id=52351 BRANCH master REVISION DETAI

D19214: [sddm-theme] Replace login button label with icon

filipf added a comment. In D19214#417762 , @ngraham wrote: > It would probably be worth mentioning that in a comment--or fixing the PC2 button to always vertically center the icon. Alternatively, maybe the PlasmaComponents3 button works better?

D19214: [sddm-theme] WIP, Replace login button label with icon

filipf added a comment. Design-wise I've been advocating this as well so it's obviously a +1 from me. Usability-wise I'd like use to increase the height of the input field and consequently the login button size because you have to keep touchscreen users in mind. Bigger button = easier to

D19077: Redesign the theme preview window

filipf added a comment. In D19077#417105 , @ngraham wrote: > This introduces a new warning: > WARNING: viewBackgroundColor is deprecated, use backgroundColor with colorSet: Theme.View instead I would use the new value, but it doesn't p

D19077: Redesign the theme preview window

filipf added a comment. OK so down to only one hack now. If possible I'd really like to keep it because it works in 100% of the cases I tested it with and results in better visuals; don't know how to fix on the C++ side of things. Couple of things that might be worthy of being discussed:

D19077: Redesign the theme preview window

filipf updated this revision to Diff 52249. filipf added a comment. clean up whitespace, remove MouseArea hacks, remove the double Rectangle hack by defining height with Units.gridUnit, add spacing below the last label, better samples value for the DropShadow REPOSITORY R123 SDDM Config

D19209: [sddm-kcm] Adjust Background label and button

filipf added a comment. In D19209#416946 , @rooty wrote: > Also, should we ditch the heading "Customize theme"? It doesn't seem necessary seeing as there's nothing to customize... aside from the wallpaper I'm also in favor of this, it's a

D19077: Redesign the theme preview window

filipf added a comment. In D19077#416726 , @mmustac wrote: > To be honest this kcm looks out of place when I compare it to the newer refurbished ones. The new look is quite an improvement compared to the current state but when I look at the colo

D19077: Redesign the theme preview window

filipf added a comment. In D19077#416432 , @rooty wrote: > In D19077#416430 , @filipf wrote: > > > You have to install the Elarun theme because it's the only one that's considerably taller than the o

D19077: Redesign the theme preview window

filipf added a comment. You have to install the Elarun theme because it's the only one that's considerably taller than the other themes. Elarun will then break the height for your other themes. REPOSITORY R123 SDDM Configuration Panel (KCM) REVISION DETAIL https://phabricator.kde.org/D1

D19077: Redesign the theme preview window

filipf added a comment. @davidedmundson yes, so without the hack I get this happening: F6627430: image.png When using childrenRect, I believe the rectangle's height is properly adjusted for the **tallest** theme preview, but ends up being too sh

D19077: Fix long labels not being wrapped

filipf added a comment. In D19077#416397 , @ngraham wrote: > With the default System Settings window size (and default font & size), the URLs now get cut off at the bottom nearly all the time. I probably need to add bottom padding to the

D19179: Use PointingHand when hovering links in Label

filipf added a comment. In D19179#416235 , @leinir wrote: > In D19179#416222 , @filipf wrote: > > > I had to use I think identical code precisely for this use case recently, however it resulted in in

D19077: Fix long labels not being wrapped

filipf planned changes to this revision. filipf marked 12 inline comments as done. filipf added inline comments. INLINE COMMENTS > ngraham wrote in main.qml:26 > Is this actually going to work with all color schemes? Why are the colors not > identical in the first place? I tested it with multip

D19077: Fix long labels not being wrapped

filipf updated this revision to Diff 52181. filipf added a comment. address Nate's comments: fix import versions, use Layout.fillWidth: true REPOSITORY R123 SDDM Configuration Panel (KCM) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19077?vs=52179&id=52181 BRANCH master REVI

D19077: Fix long labels not being wrapped

filipf updated this revision to Diff 52179. filipf added a comment. rectangle will now fit seamlessly into the window (color matches the bg color), slightly reduce the margins REPOSITORY R123 SDDM Configuration Panel (KCM) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19077?vs=5

D19077: WIP: Fix long labels not being wrapped

filipf updated this revision to Diff 52177. filipf added a comment. email address will be opened in mail client, added version number to the heading REPOSITORY R123 SDDM Configuration Panel (KCM) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19077?vs=52175&id=52177 BRANCH mas

D19077: WIP: Fix long labels not being wrapped

filipf added a comment. Limiting the height to 400, font size is 16pt: F6626929: Screenshot_20190220_210617.png Using the height hack, font size is 16pt: F6626931: Screenshot_20190220_210535.png REPOSITORY

D19077: WIP: Fix long labels not being wrapped

filipf added a comment. In D19077#416325 , @ngraham wrote: > Hmm, you might have to keep the hardcoded height, given that the QWidgets container expects the QML view to have a certain size. That breaks apart as soon as the font isn't 11pt

D19077: WIP: Fix long labels not being wrapped

filipf updated this revision to Diff 52175. filipf added a comment. Use a hack for the aforementioned problem until something better is proposed REPOSITORY R123 SDDM Configuration Panel (KCM) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19077?vs=52174&id=52175 BRANCH master

D19077: WIP: Fix long labels not being wrapped

filipf added a comment. Here's the problem I'm running into with setting root's height. With Elarun it's good: F6626883: Screenshot_20190220_203244.png But with other previews the Rectangle just doesn't cover the underlying widget: F66268

D19077: WIP: Fix long labels not being wrapped

filipf updated this revision to Diff 52174. filipf added a comment. Use Kirigami.Theme for color, use childrenRect for root height, make website info clickable, drop shadow has a vertical offset of 2 REPOSITORY R123 SDDM Configuration Panel (KCM) CHANGES SINCE LAST UPDATE https://phabric

D19179: Use PointingHand when hovering links in Label

filipf added a comment. I had to use I think identical code precisely for this use case recently, however it resulted in increased spacing in ColumnLayout (right after MouseArea). Now I'm just a novice tinkerer so apologies if the question is stupid, but could it cause similar issues if impl

D18975: [PotD] Port mostly to QQC2

filipf added a comment. Looks the same here with 1.2 scaling (verified it was the right file edited). Before: F6624971: Screenshot_20190220_012827.png After: F6624973: Screenshot_20190220_012850.png

D19148: Make shadow sizes linear

filipf added a comment. All of the new versions look better to me. +1 REPOSITORY R31 Breeze BRANCH shadow-sizes (branched from master) REVISION DETAIL https://phabricator.kde.org/D19148 To: ndavis, #vdg, #breeze, ngraham Cc: filipf, ngraham, zzag, rooty, plasma-devel, jraleigh, GB_2,

D19077: WIP: Fix long labels not being wrapped

filipf planned changes to this revision. filipf added inline comments. INLINE COMMENTS > main.qml:27 > color: palette.base > -width: 360 > -height:320 > +height: previewImage.height + column.height + units.largeSpacing > childrenRect.height can be used here, but the problem is

D19173: [InlineMessage] Tint icon and text color

filipf added a comment. You're right, let's not pursue this further at this point. Bit of more than I could chew anyway! But if anyone would be interested in doing something like this in the future, feel free to commandeer the revision. REPOSITORY R169 Kirigami REVISION DETAIL https://p

D19044: [InlineMessage] Do not draw shadows around the message

filipf added a comment. Don't fully understand the next course of action yet so if anyone wants to commandeer the revision for a speedier resolution, go ahead! REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D19044 To: filipf, #vdg, #kirigami, ngraham, mart Cc: root

D19173: [InlineMessage] Tint icon and text color

filipf created this revision. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY This patch tints both the icon and text colors of inline messages in order to achieve more appealing visuals. REPOSITORY R169 K

D19077: WIP: Fix long labels not being wrapped

filipf updated this revision to Diff 52018. filipf added a comment. go back to Rectangle as root REPOSITORY R123 SDDM Configuration Panel (KCM) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19077?vs=51932&id=52018 BRANCH master REVISION DETAIL https://phabricator.kde.org/D1

D19129: [sddm-theme] Apply new username prompt and user list icons

filipf accepted this revision. filipf added a comment. This revision is now accepted and ready to land. +1 REPOSITORY R120 Plasma Workspace BRANCH apply-new-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D19129 To: rooty, #vdg, #plasma, ngraham, filipf Cc: fi

D19124: Change shadow color to 0,0,0

filipf accepted this revision. filipf added a comment. Another big +1 for all the reasons already mentioned. REPOSITORY R31 Breeze BRANCH black-shadow (branched from master) REVISION DETAIL https://phabricator.kde.org/D19124 To: ndavis, #vdg, ngraham, filipf Cc: filipf, ngraham, plasm

D19077: WIP: Fix long labels not being wrapped

filipf added a comment. In D19077#414283 , @abetts wrote: > Just added some visual adjustments (mockup) > > F6620598: Screen Shot 2019-02-17 at 4.56.46 PM.png Thanks! I like all the adjustments.

D19077: WIP: Fix long labels not being wrapped

filipf planned changes to this revision. filipf added a comment. Added inline comments for things I'm struggling with. INLINE COMMENTS > main.qml:25 > id: root > -SystemPalette { id: palette; colorGroup: SystemPalette.Active } > -color: palette.base > +frameVisible: true >

D19077: Fix long labels not being wrapped

filipf updated this revision to Diff 51932. filipf added a comment. running into a wall so posting s WIP in hopes of help REPOSITORY R123 SDDM Configuration Panel (KCM) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19077?vs=51852&id=51932 BRANCH master REVISION DETAIL https

D19077: Fix long labels not being wrapped

filipf added a comment. If I just change Text to Labels and remove hardcoded sizes, we won't be able to fit all the text in. We would then have to increase the root height to accommodate the text. This would only give us a good solution for the default font settings (10pt Noto Sans) with no

D19077: Fix long labels not being wrapped

filipf added a comment. Yeah this whole KCM is ... less than ideal. The problem is QML is explicitly only given an area of 360x320. To make sure all of the text fits in, the author had to resort to doing an awkward grid layout and to hardcoding font sizes (and even colors before heh). L

D19077: Fix long labels not being wrapped

filipf updated this revision to Diff 51852. filipf added a comment. Add topMargin so the label isn't glued to the preview image REPOSITORY R123 SDDM Configuration Panel (KCM) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19077?vs=51851&id=51852 BRANCH master REVISION DETAIL

D19077: Fix long labels not being wrapped

filipf updated this revision to Diff 51851. filipf added a comment. Don't need wrapMode when lineCount is 1 REPOSITORY R123 SDDM Configuration Panel (KCM) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19077?vs=51850&id=51851 BRANCH master REVISION DETAIL https://phabricator

<    5   6   7   8   9   10   11   12   >