D10750: wayland: Add support for zwp_linux_dmabuf

fredrik added inline comments. INLINE COMMENTS > zzag wrote in abstract_egl_backend.cpp:427 > What's holding us from doing that? We would need to create a separate EGL image and a separate texture for each plane. The scene would need to bind each of those textures to separate texture binding

D10747: Implement zwp_linux_dmabuf_v1

fredrik added a comment. In D10747#237235 , @romangg wrote: > Regarding the "drm_fourcc.h" file: do we want to copy it in KWayland's code base or could we use the system one? It's only available on Linux? In this case could we include it as a

D10750: wayland: Add support for zwp_linux_dmabuf

fredrik updated this revision to Diff 29953. fredrik added a comment. Fix issues pointed out by romangg. REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10750?vs=29331=29953 REVISION DETAIL https://phabricator.kde.org/D10750 AFFECTED FILES

D10750: wayland: Add support for zwp_linux_dmabuf

fredrik added a comment. In D10750#224860 , @romangg wrote: > In D10750#216337 , @fredrik wrote: > > > An issue that this patch does not fully address is switching compositing backends at runtime.

D10251: [RFC] Use mipmap filtering in window thumbnails

fredrik updated this revision to Diff 29832. fredrik added a comment. Rebase on master. REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10251?vs=26374=29832 REVISION DETAIL https://phabricator.kde.org/D10251 AFFECTED FILES

D10251: [RFC] Use mipmap filtering in window thumbnails

fredrik added a comment. In D10251#227092 , @broulik wrote: > What's the state of this? Bug 391915 just cropped up There are still some issues with the cubic filter, and I've been distracted by other things lately. I think we should

D11262: KDE logout screen background color fix

fredrik added inline comments. INLINE COMMENTS > mart wrote in Logout.qml:87 > the method lattes is using 0.2126*r + 0.7152*g + 0.0722*b is more correct > (a simple one would be convertin to gray scale with qGray, but unfortunately > is C++ only) qGray() uses an integer approximation that is

D10750: wayland: Add support for zwp_linux_dmabuf

fredrik updated this revision to Diff 29331. fredrik added a comment. Import the context. REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10750?vs=27803=29331 REVISION DETAIL https://phabricator.kde.org/D10750 AFFECTED FILES

D10747: Implement zwp_linux_dmabuf_v1

fredrik updated this revision to Diff 28986. fredrik added a comment. Import the context. REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10747?vs=27735=28986 REVISION DETAIL https://phabricator.kde.org/D10747 AFFECTED FILES

D10750: wayland: Add support for zwp_linux_dmabuf

fredrik added a comment. An issue that this patch does not fully address is switching compositing backends at runtime. Buffers are imported by the scene. The scene allocates and returns a subclassed LinuxDmabuf::Buffer that contains the file descriptors and backend specific objects,

D10750: wayland: Add support for zwp_linux_dmabuf

fredrik edited projects, added Plasma; removed KWin. fredrik added a comment. Restricted Application edited projects, added KWin; removed Plasma. In D10750#211784 , @graesslin wrote: > Concerning the tests: the ones requiring OpenGL work best if

D10750: wayland: Add support for zwp_linux_dmabuf

fredrik created this revision. fredrik added reviewers: KWin, Plasma, davidedmundson, mart, graesslin. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. fredrik requested review of this revision. Restricted Application edited projects,

D10747: Implement zwp_linux_dmabuf_v1

fredrik added inline comments. Restricted Application edited projects, added Plasma; removed Plasma on Wayland. INLINE COMMENTS > linuxdmabuf_v1_interface.h:39 > + > +namespace LinuxDmabuf > +{ Do we want these nested namespaces? We could have LinuxDmabufFlags, LinuxDmabufBuffer etc. instead.

D10747: Implement zwp_linux_dmabuf_v1

fredrik created this revision. fredrik added reviewers: KWin, Plasma, graesslin, davidedmundson, mart. Restricted Application added projects: Plasma on Wayland, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. fredrik requested review of this revision. Restricted

D10181: Removed the "fastblur" path

This revision was automatically updated to reflect the committed changes. Closed by commit R108:f8ff40271e4d: Removed the fastblur path (authored by anemeth, committed by fredrik). Restricted Application edited projects, added Plasma; removed KWin. CHANGED PRIOR TO COMMIT

D10181: Removed the "fastblur" path

fredrik accepted this revision. This revision is now accepted and ready to land. Restricted Application edited projects, added KWin; removed Plasma. REPOSITORY R108 KWin BRANCH master REVISION DETAIL https://phabricator.kde.org/D10181 To: anemeth, graesslin, #kwin, #plasma, #vdg, fredrik

D10251: [RFC] Use mipmap filtering in window thumbnails

fredrik added a comment. Before and after: F5688790: before-after.png REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10251 To: fredrik, #plasma, #vdg Cc: plasma-devel, #frameworks, michaelh, ZrenBot,

D10251: [RFC] Use mipmap filtering in window thumbnails

fredrik created this revision. fredrik added reviewers: Plasma, VDG. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. fredrik requested review of this revision. REVISION SUMMARY Blit the contents of the window texture

D10170: Added optional transparency/blur to menu frames

fredrik added a comment. > I think the "blur" option should go. Blur should be controlled centrally by the desktop effect. In other words: BlurBehind should always be set to true, and then left to kwin to handle. Having an extra option here seems like micro-management. Why would you need

D10181: Removed the "fastblur" path

fredrik added a comment. Restricted Application edited projects, added KWin; removed Plasma. Code wise this LGTM. Consider it accepted if the VDG has no objections. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D10181 To: anemeth, graesslin, #kwin, #plasma Cc:

D10181: Removed the "fastblur" path

fredrik added inline comments. Restricted Application edited projects, added Plasma; removed KWin. INLINE COMMENTS > blur.kcfg:9 > > -5 > - > - > -false > +10 > This looks like an unrelated change. REPOSITORY R108 KWin

D10173: windowthumbnail: Fix the GLXFBConfig selection code

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R242:46121d58484c: windowthumbnail: Fix the GLXFBConfig selection code (authored by fredrik). REPOSITORY R242 Plasma

D10173: windowthumbnail: Fix the GLXFBConfig selection code

fredrik created this revision. fredrik added a reviewer: Plasma. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. fredrik requested review of this revision. REVISION SUMMARY Check that the sizes of the color channels

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

fredrik accepted this revision. This revision is now accepted and ready to land. Restricted Application edited projects, added Plasma; removed KWin. REPOSITORY R108 KWin BRANCH master REVISION DETAIL https://phabricator.kde.org/D9848 To: anemeth, #plasma, #kwin, fredrik Cc: luebking,

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

fredrik added inline comments. Restricted Application edited projects, added KWin; removed Plasma. INLINE COMMENTS > kwinglutils.cpp:1104 > + > +s_renderTargets.reserve(s_renderTargets.size() + targets.size()); > + The reserve() call should be in the else {} clause. REPOSITORY R108 KWin

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

fredrik added a comment. Restricted Application edited projects, added KWin; removed Plasma. I haven't looked at everything in detail, but in general I think this looks ready to land. Just a couple of nitpicks, and a question below. INLINE COMMENTS > anemeth wrote in blur.cpp:145 > Ok

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

fredrik added inline comments. Restricted Application edited projects, added KWin; removed Plasma. INLINE COMMENTS > blur.cpp:30 > #include > +#include > Is this still needed when qPow() is not used? > anemeth wrote in blur.cpp:145 > This texture is only used by

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

fredrik added a comment. Restricted Application edited projects, added Plasma; removed KWin. Don't forget to add your name to the license headers. INLINE COMMENTS > blur.cpp:46 > m_simpleShader = > ShaderManager::instance()->generateShaderFromResources(ShaderTrait::MapTexture, >

D6565: Query supported OpenGL core profile version on X11, GLX

fredrik added a comment. You should use the GLX_MESA_query_renderer extension for this when it is available. REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D6565 To: madcatx, graesslin Cc: fredrik, graesslin, cfeck, plasma-devel, ZrenBot, progwolff, lesliezhai,

Re: KWin 5.10.3.1 update

On Saturday 08 July 2017, Martin Flöser wrote: > Am 2017-07-07 15:54, schrieb Maximiliano Curia: > > ¡Hola Jonathan! > > > > El 2017-07-03 a las 17:26 +0100, Jonathan Riddell escribió: > >> KWin has received an update to the 5.10.3 release. 5.10.3.1 contains a > >> fix for

D5245: Desaturate non-responsive windows

fredrik added a comment. In https://phabricator.kde.org/D5245#98926, @broulik wrote: > > Lower brightness? > > I actually increase the brightness to produce this washed-out effect but admittedly it doesn't look as good in less graphically intensive apps (I used Gwenview in the

D4963: Add scaling support into BlurEffect::doBlur

fredrik added a comment. The blur shader is not designed to blur and scale simultaneously. The sampled offsets are computed so that the shader samples between pixels, and the kernel weights are the sums of the gaussian function for the interpolated pixel values at each offset. This

[Differential] [Commented On] D4366: WIP: Add screen recorder interface

fredrik added a comment. I know this revision has been abandoned, but I wanted to comment on a few things for future reference. INLINE COMMENTS > screencast.cpp:105 > + > +QRect geometry = effects->virtualScreenGeometry(); > + I strongly suggest that you use the damage information from

[Differential] [Updated] D4400: Plasma 5.10 "Cascade" Wallpaper

fredrik added a comment. In https://phabricator.kde.org/D4400#82337, @kvermette wrote: > In https://phabricator.kde.org/D4400#82334, @broulik wrote: > > > Did you try my suggestion regarding optimizing the image for a lossy compression algorithm? > > > > Fredrik made a Khronos

[Differential] [Closed] D3973: wallpapers/image: Use QImageReader in ImageSizeFinder::run()

This revision was automatically updated to reflect the committed changes. Closed by commit R120:ee245780f236: wallpapers/image: Use QImageReader in ImageSizeFinder::run() (authored by fredrik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

[Differential] [Request, 4 lines] D3973: wallpapers/image: Use QImageReader in ImageSizeFinder::run()

fredrik created this revision. fredrik added a reviewer: Plasma. fredrik set the repository for this revision to R120 Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY There is no need to decode the whole

[Differential] [Commented On] D2484: [Image Wallpaper] Avoid cross-fading which reveals black background behind images

fredrik added a comment. The correct way to fix this is to use a custom shader that does approximately this: uniform sampler2D texture1; uniform sampler2D texture2; uniform float fadeProgress; varying vec2 texcoord1; varying vec2 texcoord2; void main(void) {

Re: Review Request 126131: Don't delete gl texture twice in thumbnail

texture ID's are silently ignored by glDeleteTextures(). That doesn't mean it's a good idea to do it, since a texture ID can be reused for a different texture after it's been passed to glDeleteTextures(). But regardless, it shouldn't crash as long as the textures pointer is valid. - Fredrik

Re: Review Request 123473: Port mouse theme kcm to QML

On April 23, 2015, 11:31 a.m., Eike Hein wrote: This is more an experiment on how much modules can be closely ported (and in how much time). What's the benefit to the user of merging this version now? Marco Martin wrote: none. not too much pain as well tough. all

Re: Review Request 121473: Port mouse dataengine

On Dec. 13, 2014, 4:33 p.m., Andrea Scarpino wrote: I know this has already been submitted thanks to Bhushan, but I really have to add a -2 here. This code has clearly not been ported at all! Did you even test this before you pushed it, or is this a case of It builds, ship it?

Re: Review Request 121473: Port mouse dataengine

that you didn't even try building it. - Fredrik Höglund On Dec. 13, 2014, 12:50 p.m., Andrea Scarpino wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121473

Re: Review Request 119913: Force creation of a OpenGL core context

request version 3.2 or higher. Furthermore, the renderable type must be set to OpenGL. - Fredrik Höglund On Aug. 23, 2014, 3:16 p.m., Alexander Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Minutes Monday Plasma hangout

On Wednesday 19 February 2014, David Edmundson wrote: On Mon, Feb 17, 2014 at 1:26 PM, Sebastian Kügler se...@kde.org wrote: Plasma Meeting February, 17th, 2014 Present: Alex Fiestas, David Edmundson, Giorgos Tsiapaliokas, Marco Martin, Martin Grässlin, Martin Klapetek, Jens Reuterberg,

Re: Review Request: Fix KSelectionWatcher / KWindowSystem::compositingChanged signal

that the event should be delivered to winId(). KSelectionOwner does not send XFixes events; they are generated by the X server. - Fredrik Höglund On Jan. 5, 2013, 2:38 p.m., Thomas Lübking wrote: --- This is an automatically generated e

Re: plasma2 and ToolTipManager

On Monday 01 October 2012, Martin Gräßlin wrote: On Monday 01 October 2012 15:34:54 Aaron J. Seigo wrote: On Monday, October 1, 2012 15:15:23 Martin Gräßlin wrote: Am 01.10.2012 14:46, schrieb Aaron J. Seigo: the GL texture would be generated and updated by the window manager but

Re: IRC meeting summary

On Wednesday 12 September 2012, Ivan Čukić wrote: even tough is materal way post 4.10, if there is something really needed for plasma that is still not present in the protocol, we should speak up asap Will not pretend I understand the interface at all, but somebody mentioned there will be

Re: Review Request: Add Tilt-Wheel, XButton1, and XButton2 support for Kickoff GUI

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104406/#review11881 --- Ship it! Ship It! - Fredrik Höglund On March 26, 2012, 5

Re: Review Request: Scroll automatically when touching the border with the rubberband

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104396/#review11809 --- Ship it! Ship It! - Fredrik Höglund On March 24, 2012, 12

Re: Review Request: do not crash when passing a url in the ctor e.g. when creating a folderview by dropping a folder onto the desktop

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104311/#review11504 --- Ship it! Ship It! - Fredrik Höglund On March 17, 2012, 9

Re: Review Request: Save scrollbar position on plasma exit

. To reply, visit: http://git.reviewboard.kde.org/r/104258/ --- (Updated March 13, 2012, 1:51 p.m.) Review request for Plasma, Aaron J. Seigo, Marco Martin, and Fredrik Höglund. Description --- This patch implements scrolbar

Re: Review Request: Take sorting order into account in ProxyModel::lessThan() in order to give folders precedence regardless of the sort order used

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103884/#review10404 --- Ship it! Ship It! - Fredrik Höglund On Feb. 7, 2012, 7:40

Re: Review Request: Less repainting on mousePressEvent(), moseReleaseEvent() and mouseDoubleClickEvent() in FolderView::IconView

'. - Fredrik Höglund On Jan. 29, 2012, 3:54 p.m., Ignat Semenov wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103822

Re: folderview broken

On Wednesday 21 December 2011, Aaron J. Seigo wrote: On Monday, December 19, 2011 09:25:41 sujith h wrote: Are you trying to access remote site or local host? I had not done anything for local host. If you are trying to access the remote host, can you please share the URL for that, so

Re: compositingActive not efficient on XRandR events

On Monday 18 July 2011, Aaron J. Seigo wrote: On Saturday, July 16, 2011 15:36:19 Martin Gräßlin wrote: The bug is much simpler - Plasma just simply fails to recognize that a compositing manager is active. I can see this each time I restart kwin (which is considerable often). In order to

Re: the next step on the desktop

On Monday 31 January 2011, Martin Gräßlin wrote: - Ursprüngliche Mitteilung - A Segunda, 31 de Janeiro de 2011 13:00:50 Marco Martin você escreveu: provocation: remove the maximize button by default? ;) (as the netbook doesn't have minimize) will talk to mgrslin this

Re: Review Request: Folderview : label when empty folder

On 2010-07-08 08:31:35, Beat Wolf wrote: Looks good to me, and trunk is open again. Iamluc wrote: Thanks you for the review. I don't have an SVN account yet (and I think it's too early to ask one). So could you please commit the patch for me ? Simon Stiphanos wrote:

Re: Review Request: Folderview : label when empty folder

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4519/#review6434 --- I wouldn't worry about the size just now, it can be done in a

Re: system tray work

On Friday 07 May 2010, Aurélien Gâteau wrote: On 02/05/2010 23:36, Fredrik Höglund wrote: Anyway, I've attached the current version of the Klipper patch. Aside from the keyboard shortcut there's also the issue that the dbus menu isn't always updated when the clipboard history changes

Re: system tray work

On Friday 07 May 2010, Aaron J. Seigo wrote: On May 7, 2010, Aurélien Gâteau wrote: But it's not enough because KStatusNotifierItem shows the menu itself instead of sending a menu request over DBus. Which is understandable because there is currently no way to send a menu request. This would

Re: system tray work

On Thursday 29 April 2010, Aaron J. Seigo wrote: On April 29, 2010, Marco Martin wrote: i think i like more the second option. the only problem is that the ui for it would be rather clunky (there would be two distinct shortcut configurations in 2 different places that do almost the same

Re: Review Request: Add simple Type-and-Select feature to Folderview applet

, visit: http://reviewboard.kde.org/r/2659/ --- (Updated 2010-01-21 05:09:57) Review request for Plasma and Fredrik Höglund. Summary --- This patch intends to provide a simple selection method to select icons. Its intended

Re: Review Request: Folderview popups should inherit file preview settings

) Review request for Plasma and Fredrik Höglund. Summary --- Currently the folderview on-hover popups always previews (only) images no matter what the preview settings of the parent folderview applet is. I saw a 'TODO' comment in the code that says popups should inherit file preview

Re: Review Request: Make folderview's hovering popups more usable

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2262/#review3246 --- Ship it! Part 1 is already implemented in SVN, but part 2 looks good

Re: Review Request: Allows selection of icons using the SHIFT key.

for Plasma and Fredrik Höglund. Summary --- If the view is arranged (i.e. m_layoutBroken is false), the icons between the previous and the current click are selected linearly. If the view is broken, the icons which are in the rectangular region of the previous and currently selected

Re: Review Request: Make folderview plasmoid to select first item if user press right key. Just like dolphin do.

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1564/#review2281 --- Ship it! Looks good to me. - Fredrik On 2009-09-10 07:44:38, Reza

Re: Calling KDirLister from plasma widget causes no files to be found.

On Saturday 29 August 2009, David Hubner wrote: Hi, Calling KIO::KDirLister from a plasma widget causes no files to be listed by KDirLister. An example is the Trash Widget, m_dirlister-openUrl(KUrl(Trash:/)); is called but when the signal slotCompleted is thrown,

Re: Review Request: Add keyboard navigation to plasma applet Folder View

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/368/#review886 --- Ship it! Aside from a couple of minor nitpicks below I think the patch

Re: Review Request: Add keyboard navigation to plasma applet Folder View

On 2009-04-02 13:56:47, Fredrik Höglund wrote: I think in general the code looks good, but there are still numerous coding style issues, especially with the way the code is indented. Shantanu Tushar Jha wrote: Oh, I apologise for that, but I'm unable to figure out where I've messed

Re: Tool tips ideas

On Saturday 04 April 2009, Marco Martin wrote: On 4/3/09, Aaron J. Seigo ase...@kde.org wrote: On Friday 03 April 2009, Emdek wrote: well, the subtitle can actually be html, so there can be a quite good level of customization (look at the pager tooltip for instance) Yes,

Re: Review Request: Add keyboard navigation to plasma applet Folder View

On 2009-03-20 14:07:32, Fredrik Höglund wrote: /trunk/KDE/kdebase/apps/plasma/applets/folderview/iconview.cpp, line 1208 http://reviewboard.kde.org/r/368/diff/2/?file=3392#file3392line1208 A problem with the way this function is implemented is that it assumes that the view

Re: Review Request: Add keyboard navigation to plasma applet Folder View

--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/368/#review796 --- I think in general the code looks good, but there are still numerous

Re: Review Request: Add keyboard navigation to plasma applet Folder View

On 2009-03-20 14:07:32, Fredrik Höglund wrote: /trunk/KDE/kdebase/apps/plasma/applets/folderview/iconview.cpp, line 1208 http://reviewboard.kde.org/r/368/diff/2/?file=3392#file3392line1208 A problem with the way this function is implemented is that it assumes that the view

Re: Review Request: Add keyboard navigation to plasma applet Folder View

On 2009-03-20 14:07:32, Fredrik Höglund wrote: /trunk/KDE/kdebase/apps/plasma/applets/folderview/iconview.cpp, line 1208 http://reviewboard.kde.org/r/368/diff/2/?file=3392#file3392line1208 A problem with the way this function is implemented is that it assumes that the view

Re: Plasma, ARGB and 4.5

On Wednesday 18 February 2009, Marco Martin wrote: On Tuesday 17 February 2009, Fredrik Höglund wrote: seems to work quite good, except for two things: the tooltips seems to insist that they don't want to be transparent the systemtray has garbage again with the raster graphicssystem

Re: Plasma, ARGB and 4.5

On Monday 16 February 2009, Marco Martin wrote: On Monday 16 February 2009, Aaron J. Seigo wrote: On Friday 13 February 2009, Marco Martin wrote: Hi all, right now plasma enables argb visuals with that magin X11 code pasted in many places... since 4.5 now can handle it by setting

Re: Review Request: Make folderview follow some guidelines

On Sunday 14 December 2008 16:34, Artur Souza (MoRpHeUz) wrote: Hey! On Sun, Dec 14, 2008 at 12:00 PM, Fredrik Höglund fred...@kde.org wrote: The warning that the desktop folder will be created when the user selects Show Desktop folder in the config dialog was carefully worked out

Re: Review Request: Make folderview follow some guidelines

On Sunday 14 December 2008 17:09, Celeste Lyn Paul wrote: On Sunday 14 December 2008 10:34:22 Artur Souza (MoRpHeUz) wrote: Hey! On Sun, Dec 14, 2008 at 12:00 PM, Fredrik Höglund fred...@kde.org wrote: The warning that the desktop folder will be created when the user selects Show

Re: Review Request: Bugfix for Folderview bug #175191

On Sunday 30 November 2008 18:20, Aaron Seigo wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/288/#review276 --- Ship

Re: Review Request: style on the taskbar group menu

On Monday 03 November 2008 17:58, Marco Martin wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/254/ --- Review request

Re: Review Request: style on the taskbar group menu

On Monday 03 November 2008 23:33, Marco Martin wrote: On Monday 03 November 2008, Fredrik Höglund wrote: I also don't think it's a good idea to abuse the tasks-hover background for the highlighted item, since this imposes a significant design limitation on the theme in that the taskbar

Re: Review Request: Spinner widget

On Monday 03 November 2008 15:25, Marco Martin wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/253/ --- Review request

Re: QuickAccess Plasmoid

On Wednesday 29 October 2008 03:50, Aaron J. Seigo wrote: On Tuesday 28 October 2008, Loïc Marteau wrote: http://www.kde-look.org/content/show.php?content=84128 I think than this one is really a killer one and should me moved ignoring the various ways it ignores plasma conventions in the

Re: QuickAccess Plasmoid

On Wednesday 29 October 2008 15:07, Sebastian Kügler wrote: On Wednesday 29 October 2008 08:11:00 Loïc Marteau wrote: What do you suggest ? Making folderview a popupapplet as first step and solving interaction problems from there. You can't turn a Containment into a PopupApplet, because

Re: playground applets

On Tuesday 30 September 2008 06:33, Aaron J. Seigo wrote: needs more work === train-clock - sizing oddnesses (see difference between clock size and the standard background) commandwatch - should use exec dataengine; should use a scrolling text area; wrong PluginInfo-Name style