t's enough.
- Marco
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109049/#review27876
---
On Feb. 21, 2013, 7:2
ot;bookmarks" to view all bookmarks: proper favicon is shown.
Removing the database query fix, but leaving the safety guard, and cleaning
favicon cache (to have again a "broken" feature case), the default icon is
shown.
Thanks,
Marco Gulino
new one?
>
> Àlex Fiestas wrote:
> Code-wise the patch looks fine.
>
> Marco Gulino wrote:
> You're right, there's a compatibility break, and we can't even know
> starting from which version, since it's an internal database not documented
>
new one?
>
> Àlex Fiestas wrote:
> Code-wise the patch looks fine.
>
> Marco Gulino wrote:
> You're right, there's a compatibility break, and we can't even know
> starting from which version, since it's an internal database not documented
>
d an order by clause to choose the wider one as default.
- Marco
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109049/#review27760
--------
me as default browser, install the plugin, restart krunner, type
"bookmarks" to view all bookmarks: proper favicon is shown.
Removing the database query fix, but leaving the safety guard, and cleaning
favicon cache (to have again a "broken" feature case), t
avicon and set it to 0 (or
better, NULL), as "delete NULL" is a noop.
Apart from this, I think it's ok :)
- Marco Gulino
On Sept. 19, 2012, 11:21 a.m., Giorgos Tsiapaliwkas wrote:
>
> ---
> This is an automatically
Thanks, it helped :)
I just pushed on master, you can see the commit here:
http://commits.kde.org/kde-workspace/56e9cf6e7a305caba2a38630109c0486dc1b9cde
Cheers
Marco
On Fri, Aug 31, 2012 at 9:01 AM, Martin Gräßlin wrote:
> On Friday 31 August 2012 08:48:20 Marco Gulino wrote:
> >
My fault, sorry... I just forgot about that additional dependency. I think
I'll be able to fix it today or tomorrow, by simply disabling chrome
support when QJSON is not found.
Small problem: there is no builtin CMake script for QJSON, there's one
around that works quite fine, however, I've been u
enerated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105673/#review16476
---
On July 26, 2012, 10:23 a.m., Marco Gulino wrote:
>
> ---
> This is an automati
> On July 22, 2012, 11:17 p.m., Aleix Pol Gonzalez wrote:
> > I don't see the patch...?
>
> Marco Gulino wrote:
> it's in a separate branch (the one specified above) , there are too many
> files, a patch wouldn't be handy :-)
>
> Marco Martin wrot
nners/bookmarks/tests/chrome-config-home/Chrome-Bookmarks-SecondProfile.json
PRE-CREATION
plasma/generic/runners/bookmarks/tests/testchromebookmarks.h PRE-CREATION
plasma/generic/runners/bookmarks/tests/testchromebookmarks.cpp PRE-CREATION
Diff: http://git.reviewboard.kde.org/r/105673/diff/
-
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105673/#review16244
---
On July 22, 2012, 10:27 p.m., Marco Gulino wrote:
>
>
krunner plugins.
What's still missing: maybe a little more testing (both unit and manual) and
cleanup.
branch: plasma/bookmarksrunner-chrome-gulino, path
/plasma/generic/runners/bookmarks
Diffs
-
Diff: http://git.reviewboard.kde.org/r/105673/diff/
Test
issing: maybe a little more testing (both unit and manual) and
cleanup.
branch: plasma/bookmarksrunner-chrome-gulino, path
/plasma/generic/runners/bookmarks
Diffs
-
Diff: http://git.reviewboard.kde.org/r/105673/diff/
Testing
---
Thanks,
Marco Gulino
_
s in a blob, but it looks
like a hack is needed, since i cant load blob icons directly into a pixmap.
I tried using temporary files, and it works, but it sounds like a dirty
approach, kinda study it a little more before pushing.
Thanks
Marco
On Fri, Jul 20, 2012 at 1:59 PM, Marco Gulino wrote:
&g
Thank you, but this proxy is kinda too much restrictive, i can use https,
but ssh on https port doesn't seem to work.
Anyway, not a big deal... in a few hours i'll be on holiday for a whole
month, no proxy or firewalls in the way :)
On Fri, Jul 20, 2012 at 1:11 PM, Ben Cooksley wrote:
>
> In case
On Fri, Jul 20, 2012 at 11:50 AM, Alex Fiestas wrote:
>
> > If it's ok I can start pushing refactored code to master starting
> tomorrow.
> That was fast! :p
>
I was in Tibet the last 4 years, i learned some secret refactoring
tecniques :P Also, these two days i don't have much stuff to do at wo
Well yes, but i don't mean to develop a separate runner, just add chrome
support to the existing one (which already supports Firefox and Opera too).
And yes, i saw a chrome runner too, but it's a standalone runner. I'll
probably still look at it, but the main point is to refactor the existing
one f
Hello!
As i've been suggested, forwarding my previous mail in here, since i'm
working on plasma files.
Thanks
Marco
-- Forwarded message ------
From: Marco Gulino
Date: Thu, Jul 19, 2012 at 9:43 AM
Subject: back developing [KRunner Bookmarks for chrome]
To: kde-devel
H
20 matches
Mail list logo
