D10236: [libinput] Ensure Event::device returns a proper Device

graesslin updated this revision to Diff 26362. graesslin added a comment. Restricted Application edited projects, added Plasma; removed KWin. Make m_device mutable and always lazy load it. REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10236?vs=26337=26362

Re: Plasma 4 bug reports: Open for bugs

Am 2018-02-01 22:19, schrieb David Edmundson: In bugzilla a product can be "Open for bug entry" or not. It can also be done at a per-version level. When unset a user will not see it in the "enter bug" list, or the version won't be listed. If they force it, they'll get a message like:

D10236: [libinput] Ensure Event::device returns a proper Device

graesslin added a comment. Restricted Application edited projects, added Plasma; removed KWin. In https://phabricator.kde.org/D10236#199252, @fvogt wrote: > Now you can remove the initial setting of `m_device` as well. I thought about it while doing the change. I decided against

D10057: Require libinput and udev

graesslin added a comment. Restricted Application edited projects, added Plasma; removed KWin. If nobody objects by Sunday I'm going to push this. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D10057 To: graesslin, #kwin, #plasma Cc: mart, plasma-devel, kwin, ZrenBot,

D10234: LibInput: Queue native libinput events instead of LibInput::Event

graesslin added a comment. Restricted Application edited projects, added KWin; removed Plasma. alternative approach in https://phabricator.kde.org/D10236 REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D10234 To: fvogt, #plasma, graesslin Cc: kwin, plasma-devel, #kwin,

D10236: [libinput] Ensure Event::device returns a proper Device

graesslin created this revision. graesslin added reviewers: KWin, Plasma, fvogt. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. graesslin requested review of this revision. Restricted Application edited projects, added Plasma; removed

D10235: [server] Add support for the frame semantics of Pointer version 5

graesslin created this revision. graesslin added reviewers: KWin, Plasma, Frameworks. Restricted Application added projects: Plasma on Wayland, Frameworks. Restricted Application added a subscriber: plasma-devel. graesslin requested review of this revision. Restricted Application edited projects,

D10234: LibInput: Queue native libinput events instead of LibInput::Event

graesslin added a comment. Restricted Application edited projects, added Plasma; removed KWin. In https://phabricator.kde.org/D10234#199165, @fvogt wrote: > In https://phabricator.kde.org/D10234#199148, @graesslin wrote: > > > I had another idea: when the Event gets processed and the

D10234: LibInput: Queue native libinput events instead of LibInput::Event

graesslin added a comment. Restricted Application edited projects, added Plasma; removed KWin. I had another idea: when the Event gets processed and the m_device is null, we just update it again from the event. Something like if (!event->device()) { event->updateDevice();

D10156: Block geometry updates on move resize finish and don't configure xdg shell surfaces while blocked

graesslin created this revision. graesslin added reviewers: KWin, Plasma, jgrulich. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. graesslin requested review of this revision. Restricted Application edited projects, added Plasma; removed

D9980: Do not reset the size of window once we move it to an edge

graesslin added a comment. Another attempt to fix it based on the ideas of this change in https://phabricator.kde.org/D10156 REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D9980 To: jgrulich, graesslin Cc: ngraham, plasma-devel, kwin, #kwin, iodelay, bwowk, ZrenBot,

D10060: Enable blending if a subsurface has an alpha channel

graesslin updated this revision to Diff 26097. graesslin added a comment. Restricted Application edited projects, added Plasma; removed KWin. Always call setBlendEnabled before rendering a subsurface. @romangg: I hope this addresses all your comments. REPOSITORY R108 KWin CHANGES

D9713: Add script to unlock a broken session via ConsoleKit.

graesslin accepted this revision. graesslin added a comment. This revision is now accepted and ready to land. I like it! Thanks a lot for adding the runtime checking. REPOSITORY R133 KScreenLocker BRANCH master REVISION DETAIL https://phabricator.kde.org/D9713 To: tcberner,

D10142: [server] Properly handle the situation when the DataSource for a drag gets destroyed

graesslin created this revision. graesslin added reviewers: Frameworks, KWin, Plasma. Restricted Application added projects: Plasma on Wayland, Frameworks. Restricted Application added a subscriber: plasma-devel. graesslin requested review of this revision. Restricted Application edited projects,

D10118: Disable keyboard geometry preview code

graesslin added a comment. I never had noticed any problems when compiling the code. Could it be that the CI system changed (e.g. newer compiler?) I would find it sad to lose this very useful feature (which might in fact not be exposed enough) REPOSITORY R119 Plasma Desktop REVISION

D9638: [effects] replace old slide effect with a new one

graesslin added a comment. Restricted Application edited projects, added Plasma; removed KWin. In https://phabricator.kde.org/D9638#196539, @zzag wrote: > If you know how to start wayland session, please let me know. Till then, I can't do too much (I'm familiar with effects part only).

D9638: [effects] replace old slide effect with a new one

graesslin added a comment. Restricted Application edited projects, added KWin; removed Plasma. In https://phabricator.kde.org/D9638#196184, @zzag wrote: > @graesslin: do elevated windows have order? (e.g. docks are above fullscreen windows, etc) They are above all other windows.

D9638: [effects] replace old slide effect with a new one

graesslin added a comment. Restricted Application edited projects, added Plasma; removed KWin. > Docks are drawn above all windows by the following code: > > for (EffectWindow* w : windows) { > if (! w->isDock()) { > continue; > } > WindowPaintData

D9638: [effects] replace old slide effect with a new one

graesslin added a comment. Restricted Application edited projects, added KWin; removed Plasma. In https://phabricator.kde.org/D9638#196026, @zzag wrote: > In https://phabricator.kde.org/D9638#195979, @graesslin wrote: > > > What you could try is using the PaintClipper to perform

D9638: [effects] replace old slide effect with a new one

graesslin added a comment. Restricted Application edited projects, added KWin; removed Plasma. What you could try is using the PaintClipper to perform clipping. But I don't know whether it's still fully functional on OpenGL. REPOSITORY R108 KWin REVISION DETAIL

D9638: [effects] replace old slide effect with a new one

graesslin added a comment. Restricted Application edited projects, added Plasma; removed KWin. In https://phabricator.kde.org/D9638#195793, @zzag wrote: > I think this effect is ready for testing. > > Yet, I would like to have some clipping but it seems like there is no way to do

D10040: Add serial number and EISA ID to OutputDevice interface

graesslin requested changes to this revision. graesslin added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > outputdevice.xml:104-107 > + + summary="textual representation of serial number"/> > + + summary="textual

D9944: Expose if the tablet mode switch is available

graesslin accepted this revision. This revision is now accepted and ready to land. Restricted Application edited projects, added KWin; removed Plasma. REPOSITORY R108 KWin BRANCH phab/tabletModeSupported REVISION DETAIL https://phabricator.kde.org/D9944 To: mart, #kwin, #plasma,

D10066: Add touchpad shortcuts to the whitelist

graesslin accepted this revision. graesslin added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > dos wrote in globalaccel.cpp:59 > I've just tested it (with 5.11.95) and it does work on Wayland. In that case: sorry for the noise. REPOSITORY R133

D10065: Fix brightness shortcuts in the whitelist

graesslin added a comment. And on Wayland it is KWin. REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D10065 To: dos, #plasma Cc: graesslin, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10066: Add touchpad shortcuts to the whitelist

graesslin requested changes to this revision. graesslin added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > globalaccel.cpp:59 > +)}, > +{QStringLiteral("/component/kcm_touchpad"), QRegularExpression( > +QStringLiteral("Toggle Touchpad|Enable

D10060: Enable blending if a subsurface has an alpha channel

graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. graesslin requested review of this revision. Restricted Application edited projects, added Plasma; removed KWin.

D10057: Require libinput and udev

graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. graesslin requested review of this revision. Restricted Application edited projects, added Plasma; removed KWin.

D9944: [WIP]expose if the tablet mode switch is available

graesslin added inline comments. Restricted Application edited projects, added Plasma; removed KWin. INLINE COMMENTS > mart wrote in tabletmodemanager.cpp:87-96 > yes, the point is to expose it to applications (on plasma i wouldn't want a > "show this only in tablet mode" option visible (or at

D9967: Acknowledge the server side deco mode in WaylandServer not ShellClient

This revision was automatically updated to reflect the committed changes. Closed by commit R108:339a08de3883: Acknowledge the server side deco mode in WaylandServer not ShellClient (authored by graesslin). Restricted Application edited projects, added KWin; removed Plasma. REPOSITORY R108 KWin

D9944: [WIP]expose if the tablet mode switch is available

graesslin added inline comments. Restricted Application edited projects, added Plasma; removed KWin. INLINE COMMENTS > tabletmodemanager.cpp:87-96 > +void TabletModeManager::setTabletModeAvailable(bool available) > +{ > +//TODO: we need to access to libinput::connection from here > +if

D9944: [WIP]expose if the tablet mode switch is available

graesslin added inline comments. Restricted Application edited projects, added KWin; removed Plasma. INLINE COMMENTS > input.cpp:1897 > +#endif > +return true; > +} false REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D9944 To: mart, #kwin, #plasma Cc: graesslin,

D9930: Require libinput version 1.9

graesslin added a comment. Restricted Application edited projects, added Plasma; removed KWin. In https://phabricator.kde.org/D9930#193993, @tcberner wrote: > Hi there > > This breaks the CI on FreeBSD, where we only have libinput 1.6 > > 10:17:48 -- Could NOT find Libinput:

D9930: Require libinput version 1.9

This revision was automatically updated to reflect the committed changes. Closed by commit R108:4cc1d7a24546: Require libinput version 1.9 (authored by graesslin). Restricted Application edited projects, added Plasma; removed KWin. REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE

D9980: Do not reset the size of window once we move it to an edge

graesslin added a comment. I took care of the auto test with https://commits.kde.org/kwin/0d2a34172357c016f74f5374e6db1785e7739f11 REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D9980 To: jgrulich, graesslin Cc: ngraham, plasma-devel, kwin, #kwin, iodelay, bwowk,

D9980: Do not reset the size of window once we move it to an edge

graesslin added inline comments. INLINE COMMENTS > jgrulich wrote in shell_client.cpp:300-301 > I don't have the log from WAYLAND_DEBUG enabled at this moment, but there was > definitely this state advertised together with the correct size, at least > from what I remember it called configure (

D9980: Do not reset the size of window once we move it to an edge

graesslin requested changes to this revision. graesslin added a comment. This revision now requires changes to proceed. Please also add a test case exposing the problem. INLINE COMMENTS > shell_client.cpp:300-301 > connect(this, ::activeChanged, this, configure); > -

Re: KDE and Google Summer of Code 2018

, Jan 18, 2018 at 7:54 PM, Martin Flöser <mgraess...@kde.org> wrote: Am 2018-01-18 15:23, schrieb Roman Gilg: I added two KWin project ideas: https://community.kde.org/GSoC/2018/Ideas#KWin [1] The first idea (parallel rendering) is IMHO too difficult for a GSoC. The other idea sounds reas

D9944: [WIP]expose if the tablet mode switch is available

graesslin added inline comments. Restricted Application edited projects, added Plasma; removed KWin. INLINE COMMENTS > mart wrote in tabletmodemanager.cpp:87 > which, would make sense api-wise even if something different than libinput > was used underneath makes sense. VirtualKeyboard also

D9967: Acknowledge the server side deco mode in WaylandServer not ShellClient

graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. graesslin requested review of this revision. Restricted Application edited projects, added Plasma; removed KWin.

D7246: Tooltips

This revision was automatically updated to reflect the committed changes. Closed by commit R129:24a859b356ef: Tooltips (authored by graesslin). REPOSITORY R129 Window Decoration Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7246?vs=25539=25604 REVISION DETAIL

Re: KDE and Google Summer of Code 2018

Am 2018-01-18 15:23, schrieb Roman Gilg: I added two KWin project ideas: https://community.kde.org/GSoC/2018/Ideas#KWin The first idea (parallel rendering) is IMHO too difficult for a GSoC. The other idea sounds reasonable from scope. Cheers Martin On Wed, Jan 17, 2018 at 6:18 PM, Roman

Re: KDE and Google Summer of Code 2018

Am 2018-01-17 18:18, schrieb Roman Gilg: Hi, Valorie, do we have until 23rd with project ideas? I didn't want to mentor this year because I only was a GSoC student last year, but since there are not yet many ideas from Plasma/KWin I might do it anyway. I'm not able to mentor this year (due to

D7246: Tooltips

graesslin accepted this revision. This revision is now accepted and ready to land. REVISION DETAIL https://phabricator.kde.org/D7246 To: McPain, #breeze, #plasma, graesslin Cc: cfeck, davidedmundson, jriddell, ngraham, broulik, plasma-devel, #breeze, ZrenBot, progwolff, lesliezhai,

Re: detecting tablet mode

Am 2018-01-17 13:26, schrieb Marco Martin: On Wed, Jan 17, 2018 at 10:33 AM, Marco Martin wrote: Another thing that i think would be needed, is to detect if the tabet mode switch is present at all on the hardware (my use case would be wether show options related to that on

D9944: [WIP]expose if the tablet mode switch is available

graesslin added inline comments. Restricted Application edited projects, added KWin; removed Plasma. INLINE COMMENTS > tabletmodemanager.cpp:87 > +{ > +//TODO: we need to access to libinput::connection from here > +if (m_tabletModeAvailable == available) { Impossible! That's violating

D9930: Require libinput version 1.9

graesslin added a comment. Restricted Application edited projects, added KWin; removed Plasma. In https://phabricator.kde.org/D9930#192197, @davidedmundson wrote: > Edit: please make sure the CI has this before pushing. CI has it. I checked before starting the work on the feature

D9930: Require libinput version 1.9

graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. graesslin requested review of this revision. Restricted Application edited projects, added Plasma; removed KWin.

D9414: Implement OSD to select action when unknown monitors is connected

graesslin added a comment. I just had a look at all the OSD's used and they all have outputOnly set to true. I have to say the idea here is clearly that OSDs should be non-interactive. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D9414 To: dvratil, sebas,

D9414: Implement OSD to select action when unknown monitors is connected

graesslin added a comment. In https://phabricator.kde.org/D9414#191973, @broulik wrote: > According to KWin code, windows of type `OnScreenDisplay` do not accept focus and don't take keyboard input but they can still be clicked (unless set to `outputOnly`, obviously). The idea

Re: LTS and Wayland

Am 2018-01-15 23:58, schrieb David Edmundson: That could simply mean avoiding writing Wayland and LTS in the same sentence. Totally fine with that. The only thing I want to have expressed is that Wayland is no longer exclude in KWin. Cheers Martin

D7246: Tooltips

graesslin requested changes to this revision. graesslin added a comment. This revision now requires changes to proceed. I get compile errors: /home/martin/src/kf5/kde/workspace/kdecoration/autotests/mockbridge.cpp: In member function ‘virtual std::unique_ptr

Re: LTS and Wayland

Am 2018-01-15 17:04, schrieb Jonathan Riddell: 5.12 is about ready to go but the announce says Wayland support is LTS which not everyone is happy with. Who knows what the story is here? The story is: for 5.8 we explicitly excluded Wayland (especially KWin) from the LTS promise. We don't do

D9859: Fix crash when destroying tabletmodemanager

graesslin abandoned this revision. graesslin added a comment. Restricted Application edited projects, added KWin; removed Plasma. Superseeded by https://phabricator.kde.org/R108:8510f31340ac78d76df69a3bccb001f610613913 REPOSITORY R108 KWin REVISION DETAIL

D9876: Add support for apply initial shortcut window rule

This revision was automatically updated to reflect the committed changes. Closed by commit R108:87f0a119e112: Add support for apply initial shortcut window rule (authored by graesslin). Restricted Application edited projects, added Plasma; removed KWin. REPOSITORY R108 KWin CHANGES SINCE LAST

D9870: Add support for apply initial keep above/below window rules

This revision was automatically updated to reflect the committed changes. Closed by commit R108:d7cc5eb3bd5b: Add support for apply initial keep above/below window rules (authored by graesslin). Restricted Application edited projects, added KWin; removed Plasma. REPOSITORY R108 KWin CHANGES

D9879: [effects/blur] Disable texture cache on Wayland

This revision was automatically updated to reflect the committed changes. Closed by commit R108:e200d7403110: [effects/blur] Disable texture cache on Wayland (authored by graesslin). Restricted Application edited projects, added KWin; removed Plasma. REPOSITORY R108 KWin CHANGES SINCE LAST

D9873: Manually take XKB_DEFAULT_{RULES,MODEL,LAYOUT,VARIANT,OPTIONS} into account

graesslin accepted this revision. This revision is now accepted and ready to land. Restricted Application edited projects, added Plasma; removed KWin. REPOSITORY R108 KWin BRANCH master REVISION DETAIL https://phabricator.kde.org/D9873 To: fvogt, #plasma, graesslin Cc: kwin,

D9879: [effects/blur] Disable texture cache on Wayland

graesslin updated this revision to Diff 25345. graesslin added a comment. Restricted Application edited projects, added Plasma; removed KWin. Hide option instead of disable it REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9879?vs=25343=25345 BRANCH

D9879: [effects/blur] Disable texture cache on Wayland

graesslin added a comment. Restricted Application edited projects, added KWin; removed Plasma. In https://phabricator.kde.org/D9879#190916, @graesslin wrote: > Also disable the cache blur checkbox on Wayland ah no, that's a stupid idea. The load call enables it again. I'll hide

D9879: [effects/blur] Disable texture cache on Wayland

graesslin updated this revision to Diff 25343. graesslin added a comment. Restricted Application edited projects, added Plasma; removed KWin. Also disable the cache blur checkbox on Wayland REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9879?vs=25342=25343

D9879: [effects/blur] Disable texture cache on Wayland

graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. graesslin requested review of this revision. Restricted Application edited projects, added Plasma; removed KWin.

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

graesslin added a comment. Restricted Application edited projects, added Plasma; removed KWin. In https://phabricator.kde.org/D9848#190882, @broulik wrote: > > There are some rendering artifacts, when intermediate rendering results shall be saved. > > That feature has shown to be

D9873: Manually take XKB_DEFAULT_{RULES,MODEL,LAYOUT,VARIANT,OPTIONS} into account

graesslin added a comment. Restricted Application edited projects, added KWin; removed Plasma. I wasn't aware of this secure_getenv functionality. Is that also in place after the process has completely dropped all privs? INLINE COMMENTS > xkb.h:121-127 > +static bool

D9876: Add support for apply initial shortcut window rule

graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. graesslin requested review of this revision. Restricted Application edited projects, added Plasma; removed KWin.

D9865: Do not call into NETWinInfo in AbstractClient::setSkipPager

This revision was automatically updated to reflect the committed changes. Closed by commit R108:85ef2831dbc1: Do not call into NETWinInfo in AbstractClient::setSkipPager (authored by graesslin). Restricted Application edited projects, added Plasma; removed KWin. REPOSITORY R108 KWin CHANGES

D9866: Add support for initial apply rules for skip (taskbar|pager|switcher)

This revision was automatically updated to reflect the committed changes. Closed by commit R108:42b099355c80: Add support for initial apply rules for skip (taskbar|pager|switcher) (authored by graesslin). Restricted Application edited projects, added KWin; removed Plasma. REPOSITORY R108 KWin

D9866: Add support for initial apply rules for skip (taskbar|pager|switcher)

graesslin added a dependent revision: D9870: Add support for apply initial keep above/below window rules. REPOSITORY R108 KWin BRANCH shell-client-skip-rules REVISION DETAIL https://phabricator.kde.org/D9866 To: graesslin, #kwin, #plasma, hein Cc: plasma-devel, kwin, ZrenBot, progwolff,

D9870: Add support for apply initial keep above/below window rules

graesslin added a dependency: D9866: Add support for initial apply rules for skip (taskbar|pager|switcher). Restricted Application edited projects, added KWin; removed Plasma. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D9870 To: graesslin, #kwin, #plasma Cc:

D9870: Add support for apply initial keep above/below window rules

graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. graesslin requested review of this revision. Restricted Application edited projects, added Plasma; removed KWin.

D9638: [effects] replace old slide effect with a new one

graesslin added inline comments. Restricted Application edited projects, added KWin; removed Plasma. INLINE COMMENTS > slide.cpp:62 > > -const auto d = animationTime( > -SlideConfig::duration() != 0 ? SlideConfig::duration() : 250); > -mTimeLine.setDuration(d); > +

D9866: Add support for initial apply rules for skip (taskbar|pager|switcher)

graesslin added a dependency: D9865: Do not call into NETWinInfo in AbstractClient::setSkipPager. Restricted Application edited projects, added KWin; removed Plasma. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D9866 To: graesslin, #kwin, #plasma Cc: plasma-devel, kwin,

D9865: Do not call into NETWinInfo in AbstractClient::setSkipPager

graesslin added a dependent revision: D9866: Add support for initial apply rules for skip (taskbar|pager|switcher). REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D9865 To: graesslin, #kwin, #plasma Cc: plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D9866: Add support for initial apply rules for skip (taskbar|pager|switcher)

graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. graesslin requested review of this revision. Restricted Application edited projects, added Plasma; removed KWin.

D9865: Do not call into NETWinInfo in AbstractClient::setSkipPager

graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. graesslin requested review of this revision. Restricted Application edited projects, added Plasma; removed KWin.

[kwin] /: Disable KActivities integration on Wayland

Git commit b8f43618478437e52b5e4f7f5cc50d1c689e6b1c by Martin Flöser. Committed on 13/01/2018 at 15:58. Pushed by graesslin into branch 'master'. Disable KActivities integration on Wayland Once again KActivities causes a delay in the startup of KWin. This is not the first time it happens

D9859: Fix crash when destroying tabletmodemanager

graesslin created this revision. graesslin added reviewers: KWin, Plasma, mart. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. graesslin requested review of this revision. Restricted Application edited projects, added Plasma; removed

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

graesslin resigned from this revision. graesslin added subscribers: fredrik, davidedmundson, mart. graesslin added a comment. Restricted Application edited projects, added Plasma; removed KWin. I would like to see this reviewed by @fredrik, @mart , @davidedmundson and in general the

Re: 5.12 announce

Am 2018-01-12 19:13, schrieb Jonathan Riddell: On Fri, Jan 12, 2018 at 06:41:31PM +0100, Martin Flöser wrote: Am 2018-01-11 20:16, schrieb Jonathan Riddell: >Could someone take a screenshot which does work of KScreen under >Wayland? I could do a screenshot, but what do you want to see? T

Re: keyboard indicator

Am 2018-01-12 17:06, schrieb Jonathan Riddell: Chatting with the Slimbook devs we noticed they wanted a programme called keyboard-indicator installed. Slimbook laptops don't have an LED on caps lock/num lock etc like some other laptops do so there's no visual indicator that you have caps lock

D9638: [effects] add 'Slide Desktops' effect

graesslin added a comment. Restricted Application edited projects, added KWin; removed Plasma. as we had quite positive feedback on the replacement idea: could you please rework the patch to replace the old effect? REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D9638

Re: 5.12 announce

Jonathan On 11 January 2018 at 19:05, Martin Flöser <mgraess...@kde.org> wrote: Am 2018-01-11 19:02, schrieb Jonathan Riddell: I've made https://www.kde.org/announcements/plasma-5.12.0.php I don't suppose anyone has done figures or nice bar graphs for the speedups? 'Output resolution can

Re: 5.12 announce

Am 2018-01-11 19:02, schrieb Jonathan Riddell: I've made https://www.kde.org/announcements/plasma-5.12.0.php I don't suppose anyone has done figures or nice bar graphs for the speedups? 'Output resolution can be set through KScreen' I used this for the screenshot for Wayland section but it

D7246: Tooltips

graesslin accepted this revision. graesslin added subscribers: jriddell, davidedmundson. graesslin added a comment. This revision is now accepted and ready to land. We are close to release and this might create hassles for distributions. Should we include it or wait for master being open

D9764: [WIP] a basic TabletModeManager

graesslin accepted this revision. This revision is now accepted and ready to land. Restricted Application edited projects, added Plasma; removed KWin. REPOSITORY R108 KWin BRANCH mart/tabletMode REVISION DETAIL https://phabricator.kde.org/D9764 To: mart, #plasma, #kwin, graesslin Cc:

D9699: Keep fullscreen windows in active layer based on transients not the group

This revision was automatically updated to reflect the committed changes. Closed by commit R108:b7ad4bcf881c: Keep fullscreen windows in active layer based on transients not the group (authored by graesslin). Restricted Application edited projects, added KWin; removed Plasma. REPOSITORY R108

D9555: Simulate user activity on fake input events

This revision was automatically updated to reflect the committed changes. Closed by commit R108:b002b2790321: Simulate user activity on fake input events (authored by graesslin). Restricted Application edited projects, added KWin; removed Plasma. CHANGED PRIOR TO COMMIT

D9764: [WIP] a basic TabletModeManager

graesslin added a comment. Restricted Application edited projects, added KWin; removed Plasma. In https://phabricator.kde.org/D9764#188862, @mart wrote: > In https://phabricator.kde.org/D9764#188354, @graesslin wrote: > > > In https://phabricator.kde.org/D9764#188268, @mart wrote: >

D9776: Fix Plastik bottom and right border

graesslin accepted this revision. This revision is now accepted and ready to land. Restricted Application edited projects, added KWin; removed Plasma. REPOSITORY R108 KWin BRANCH master REVISION DETAIL https://phabricator.kde.org/D9776 To: davidedmundson, #plasma, graesslin Cc:

Re: detecting tablet mode

Am 2018-01-08 11:13, schrieb Marco Martin: On Fri, Jan 5, 2018 at 6:24 PM, Martin Flöser <mgraess...@kde.org> wrote: Am 2018-01-05 16:11, schrieb Marco Martin: debugging a bit what happens currently on my machine, i don't seem to have any event device which libinput_device_switch_has_

D9713: Add script to unlock a broken session via ConsoleKit.

graesslin added inline comments. INLINE COMMENTS > tcberner wrote in abstractlocker.cpp:53 > So something ala > > - if logingd-runing then logindmessage > - if consolekit-running then consolekitmessage > - else falback message That would be the ultimate solution ;-) REPOSITORY R133

Re: detecting tablet mode

Am 2018-01-09 13:27, schrieb Marco Martin: On Fri, Jan 5, 2018 at 6:21 PM, Martin Flöser <mgraess...@kde.org> wrote: So I would do something like a small class class TabletModeManager : public QObject, public InputEventSpy { }; I'm starting on this direction now, another thing: li

D9764: [WIP] a basic TabletModeManager

graesslin added inline comments. Restricted Application edited projects, added KWin; removed Plasma. INLINE COMMENTS > tabletmodemanager.cpp:75 > +{ > +m_spy = new TabletModeInputEventSpy(this); > +input()->installInputEventSpy(m_spy); please put into initializer. Also the spy leaks.

D9764: [WIP] a basic TabletModeManager

graesslin added a comment. Restricted Application edited projects, added Plasma; removed KWin. In https://phabricator.kde.org/D9764#188268, @mart wrote: > one thing i'm wondering, is how to manage dependencies, as ideally we want most of our apps to make use of this, but can't ask for

D9521: Pass SwitchEvent from LibInput through KWin and add to DebugConsole

This revision was automatically updated to reflect the committed changes. Closed by commit R108:d2a9232ad34f: Pass SwitchEvent from LibInput through KWin and add to DebugConsole (authored by graesslin). Restricted Application edited projects, added Plasma; removed KWin. REPOSITORY R108 KWin

D9713: Add script to unlock a broken session via ConsoleKit.

graesslin requested changes to this revision. graesslin added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > abstractlocker.cpp:53 > +#if HAVE_CONSOLEKIT > +auto text = ki18n("The screen locker is broken and unlocking is not > possible anymore.\n" > +

D9699: Keep fullscreen windows in active layer based on transients not the group

graesslin updated this revision to Diff 24870. graesslin added a comment. Restricted Application edited projects, added Plasma; removed KWin. Check transients recursively by looking at the transients main windows REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE

D9699: Keep fullscreen windows in active layer based on transients not the group

graesslin added a comment. Restricted Application edited projects, added KWin; removed Plasma. In https://phabricator.kde.org/D9699#186972, @graesslin wrote: > git blame result: The group check was introduced with https://phabricator.kde.org/R108:476ca65295bfb3f0d90f535d9930250a13a8b323

D9699: Keep fullscreen windows in active layer based on transients not the group

graesslin added inline comments. Restricted Application edited projects, added Plasma; removed KWin. INLINE COMMENTS > romangg wrote in abstract_client.cpp:1155 > Just a question for understanding unrelated to this patch: why should > `isActiveFullScreen` return true, if `ac->screen() !=

D9699: Keep fullscreen windows in active layer based on transients not the group

graesslin added a comment. Restricted Application edited projects, added KWin; removed Plasma. git blame result: The group check was introduced with https://phabricator.kde.org/R108:476ca65295bfb3f0d90f535d9930250a13a8b323 - before it was a check for transient, but the group check was there

<    1   2   3   4   5   6   7   8   9   10   >