graesslin accepted this revision.
REPOSITORY
R31 Breeze
REVISION DETAIL
https://phabricator.kde.org/D9114
To: broulik, #plasma, hpereiradacosta, graesslin, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart
graesslin added inline comments.
INLINE COMMENTS
> breezedecoration.cpp:479
>
> +if ( !titleRect.contains(repaintRegion) ) return;
> +
are you sure contains is correct here? If repaint Region intersects the
titleRect it should get repainted?
REPOSITORY
R31 Breeze
REVISION DETAIL
graesslin added a comment.
There are a few unrelated changes, but otherwise looks good.
INLINE COMMENTS
> package.cpp:360
> //Nested loop, but in the medium case resolves to just one iteration
> -//qDebug() << "prefixes:" << prefixes.count() << prefixes;
> +// qDebug() <<
graesslin accepted this revision.
REPOSITORY
R268 KGlobalAccel
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9092
To: apol, #frameworks, #plasma, davidedmundson, graesslin
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol,
graesslin accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R278 KWindowSystem
REVISION DETAIL
https://phabricator.kde.org/D9086
To: broulik, #plasma, graesslin
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg,
This revision was automatically updated to reflect the committed changes.
Closed by commit R108:ff2e8834694a: Add support for new IdleInhibition protocol
(authored by graesslin).
Restricted Application edited projects, added KWin; removed Plasma.
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
graesslin added inline comments.
INLINE COMMENTS
> server.cpp:615
> +QSocketNotifier* n = new QSocketNotifier(sockets[1],
> QSocketNotifier::Read, this);
> +qApp->connect(n, SIGNAL(activated(int)), SLOT(quit()));
> +
why the old connect syntax?
REPOSITORY
R120 Plasma Workspace
graesslin added a comment.
In https://phabricator.kde.org/D9040#173465, @ngraham wrote:
> On most touch platforms, only the last character in password prompts is
revealed, one-at-a-time. It might make more sense to implement that than to
keep the reveal button.
On touch
graesslin added a comment.
I'm against reverting this. I think this is a very important feature for
touch input and nowadays we support a touch keyboard directly in the login
screen. Given that the reveal button is IMHO a must have feature.
REPOSITORY
R120 Plasma Workspace
BRANCH
graesslin added a comment.
I fail to see how option 3 would help. But I'm in favor of option 1.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D8924
To: davidedmundson, #plasma
Cc: graesslin, ngraham, apol, plasma-devel, ZrenBot, progwolff, lesliezhai,
graesslin accepted this revision.
This revision is now accepted and ready to land.
Restricted Application edited projects, added Plasma on Wayland; removed Plasma.
REPOSITORY
R127 KWayland
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8919
To: davidedmundson, #plasma,
graesslin accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R127 KWayland
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8858
To: cgiboudeaux, graesslin
Cc: plasma-devel, #frameworks, leezu, ZrenBot, alexeymin, progwolff,
lesliezhai,
graesslin added inline comments.
Restricted Application edited projects, added Plasma on Wayland; removed Plasma.
INLINE COMMENTS
> appmenu.xml:37-38
> +
> +
> +
> +
Could you please add "The string must be encoded in latin-1".
REPOSITORY
R127 KWayland
graesslin added a comment.
In https://phabricator.kde.org/D7246#171908, @graesslin wrote:
> I'm sorry, but Widgets is a dependency which cannot be used for it. This
creates problems in KWin. Tooltip support must be implemented directly in KWin,
exposed through the KDecoration API. Yes I
graesslin added a comment.
I'm sorry, but Widgets is a dependency which cannot be used for it. This
creates problems in KWin. Tooltip support must be implemented directly in KWin,
exposed through the KDecoration API. Yes I know that makes it rather complex,
but that's the reason why tooltip
graesslin added a comment.
In https://phabricator.kde.org/D8924#170463, @apol wrote:
> > This creates a "slight" problem for Wayland as ksmserver is forced to
XCB. What do you think about doing it like with kscreenlocker? On X11
ksmserver, on Wayland KWin? Otherwise +1000 to this
graesslin created this revision.
graesslin added reviewers: Plasma, KWin.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.
REVISION SUMMARY
Commit
https://phabricator.kde.org/R108:188491d3922180f1e1bba8fa2cd3fd2aa4a527c0
introduced a
This revision was automatically updated to reflect the committed changes.
Closed by commit R108:1c61e61119f3: [autotests] Support new way to run the
tests without need to install (authored by graesslin).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D7543?vs=18794=22704#toc
REPOSITORY
This revision was automatically updated to reflect the committed changes.
Closed by commit R108:f8be3f746ba9: [effects] Delay creation of EffectFrames in
WindowGeometryEffect (authored by graesslin).
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit R108:d4ba05a22f86: [autotests] Add tests for DRM platform
plugin (authored by graesslin).
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8776?vs=22236=22700
REVISION
graesslin added a comment.
This creates a "slight" problem for Wayland as ksmserver is forced to XCB.
What do you think about doing it like with kscreenlocker? On X11 ksmserver, on
Wayland KWin? Otherwise +1000 to this suggestion.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
graesslin added inline comments.
INLINE COMMENTS
> davidedmundson wrote in appmenu.cpp:178
> Wayland strings can be UTF-8 but DBus service names and object paths can only
> be ASCII.
>
> I figured it was best to avoid any potential locale issues.
Fair enough. I wasn't aware of the DBus
graesslin added a comment.
Looks good, just a few minor comments.
INLINE COMMENTS
> appmenu.cpp:178
> +Q_ASSERT(isValid());
> +org_kde_kwin_appmenu_set_address(d->appmenu, serviceName.toLatin1(),
> objectPath.toLatin1());
> +}
why toLatin1? I would expect a toUtf8?
>
graesslin accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R108 KWin
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8796
To: davidedmundson, #plasma, graesslin
Cc: ngraham, luebking, broulik, graesslin, plasma-devel, kwin, #kwin, bwowk,
graesslin accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R108 KWin
BRANCH
Plasma/5.11
REVISION DETAIL
https://phabricator.kde.org/D8887
To: fvogt, #plasma, graesslin
Cc: kwin, plasma-devel, #kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed,
graesslin added a comment.
In https://phabricator.kde.org/D#169518, @fvogt wrote:
> Should this go into Plasma/5.11 as well?
Yes, please.
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D
To: fvogt, #plasma, graesslin, davidedmundson
Cc:
graesslin added a comment.
In https://phabricator.kde.org/D8887#169520, @fvogt wrote:
> Should this go into Plasma/5.11 (probably even 5.8) as well?
5.11 yes! Wayland support is not covered by LTS, so I don't see a need to fix
in 5.8.
INLINE COMMENTS
> fvogt wrote in
graesslin accepted this revision.
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D
To: fvogt, #plasma, graesslin, davidedmundson
Cc: anthonyfieroni, ngraham, kwin, #kwin, plasma-devel, bwowk, ZrenBot,
progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg,
graesslin added inline comments.
INLINE COMMENTS
> logind.cpp:387
> +#else
> +// F_DUPFD_CLOEXEC not available, do it non-atomically
> +int fd =
> dup(reply.arguments().first().value().fileDescriptor());
Which systems wouldn't have it?
REPOSITORY
R108 KWin
REVISION
graesslin added inline comments.
INLINE COMMENTS
> drm_backend.cpp:553
> +qCWarning(KWIN_DRM) << "Could NOT find DrmOutput matching "
> << it.key()->uuid();
> +return;
> +}
why return? Shouldn't it be a continue?
REPOSITORY
R108 KWin
REVISION
graesslin requested changes to this revision.
graesslin added a comment.
This revision now requires changes to proceed.
Could you please add a message that it is missing?
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D8858
To: cgiboudeaux, graesslin
Cc:
graesslin created this revision.
graesslin added reviewers: KWin, Plasma.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.
REVISION SUMMARY
A small helper class is added which manages inhibiting idle for the
ShellClients. So far only
This revision was automatically updated to reflect the committed changes.
Closed by commit R108:1ae7990a959c: Allow a cross-process check for same
applications (authored by graesslin).
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8661?vs=21895=22483
REVISION
This revision was automatically updated to reflect the committed changes.
Closed by commit R127:9520c2f292d0: Add support for zwp_idle_inhibit_manager_v1
(authored by graesslin).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D8396?vs=21046=22482#toc
REPOSITORY
R127 KWayland
CHANGES
graesslin added a comment.
In https://phabricator.kde.org/D8845#168632, @broulik wrote:
> Look in the constructor, kept it consistent
ah I just made this as a proposal as you had to change unrelated lines.
REPOSITORY
R124 System Settings
REVISION DETAIL
graesslin added inline comments.
INLINE COMMENTS
> SidebarMode.cpp:236
>
> ToolTipManager *toolTipManager;
> QQuickWidget * quickWidget;
toolTipManager = nullptr;
REPOSITORY
R124 System Settings
REVISION DETAIL
https://phabricator.kde.org/D8845
To: broulik, mart
Cc:
graesslin added inline comments.
INLINE COMMENTS
> davidedmundson wrote in mock_drm.h:1
> I assume this is just phab being stupid?
yes or git being stupid. I did not copy any files around but created a new
empty file. Ok, I admit I copied the copyright header, but certainly one with
my
graesslin accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R110 KScreen Library
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8828
To: fvogt, #plasma, sebas, graesslin
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
graesslin added a comment.
As I just made my kwin crash just to get the backtrace I'm adding
nevertheless:
(gdb) bt
#0 0x7f8d550626b0 in KWayland::Client::Compositor::operator
wl_compositor*() () at /workspace/build/src/client/compositor.cpp:131
#1 0x7f8d428b377d in
graesslin added a comment.
In https://phabricator.kde.org/D8821#168053, @davidedmundson wrote:
> > New test case added which crashes without this fix.
>
> I wanted to see the backtrace of what we're working round, so applied just
the test and not the changes to the effect.
> It
graesslin created this revision.
graesslin added reviewers: KWin, Plasma.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.
REVISION SUMMARY
Without Xwayland KWin starts so fast that the creation of the EffectFrame
triggers a crash in
This revision was automatically updated to reflect the committed changes.
Closed by commit R108:5313b8564680: Support modifier+mouse button on window
decoration (authored by graesslin).
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8758?vs=22183=22366
REVISION
This revision was automatically updated to reflect the committed changes.
Closed by commit R108:9a965405e3ea: Support updating deco for changes of
borderless maximize windows config (authored by graesslin).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D8095?vs=20206=22364#toc
This revision was automatically updated to reflect the committed changes.
Closed by commit R108:188491d39221: Support user fullscreen for
XdgShellSurfaces (authored by graesslin).
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8169?vs=20422=22365
REVISION
graesslin added a comment.
ping
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D8661
To: graesslin, #kwin, #plasma
Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed,
hardening, jensreuterberg, abetts, sebas, apol, mart
This revision was automatically updated to reflect the committed changes.
Closed by commit R127:42b2daaec407: [server] Support inhibiting the
IdleInterface (authored by graesslin).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D8383?vs=21016=22363#toc
REPOSITORY
R127 KWayland
CHANGES
graesslin added a comment.
ping
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D8396
To: graesslin, #frameworks, #kwin, #plasma_on_wayland
Cc: plasma-devel, leezu, ZrenBot, alexeymin, progwolff, lesliezhai,
ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol,
graesslin accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D8794
To: davidedmundson, #plasma, graesslin
Cc: plasma-devel, kwin, #kwin, bwowk, ZrenBot, progwolff, lesliezhai,
ali-mohamed, hardening,
This revision was automatically updated to reflect the committed changes.
Closed by commit R108:c601e875cfa7: [platforms/drm] At safety checks for the
properties (authored by graesslin).
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8752?vs=22208=22293
graesslin added a comment.
Does KScreen allow to disable all screens? And if yes: how does KWin behave
in this case? I had been thinking about this for some time and are not sure how
KWin should handle this situation. I can see reasons to say "user asked for it,
so all screens should go
graesslin accepted this revision.
graesslin added a comment.
This revision is now accepted and ready to land.
misclicked, wanted to accept it.
REPOSITORY
R108 KWin
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8779
To: davidedmundson, #plasma, graesslin
Cc: bshah,
graesslin added inline comments.
INLINE COMMENTS
> davidedmundson wrote in input.cpp:960
> if we're always going to do:
>
> if (actionResult.first) {
> return actionResult.second;
>
> why return two bools and not just "and" them here?
if actionResult.first is true we should not
graesslin requested changes to this revision.
This revision now requires changes to proceed.
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D8779
To: davidedmundson, #plasma, graesslin
Cc: plasma-devel, kwin, #kwin, bwowk, ZrenBot, progwolff, lesliezhai,
ali-mohamed,
Am 2017-11-13 10:23, schrieb René J.V. Bertin:
Hi,
This is something I also noticed with KWin4 but which seems to be
worse with KWin5 (v5.11.1, FW 5.38.0, Qt 5.8.0 and the Breeze
windowtheme):
After a big compile job (like building QtWebKit) performed in the
background (output redirected to
graesslin added inline comments.
INLINE COMMENTS
> davidedmundson wrote in device.cpp:464
> Shouldn't we be multiplying the default matrix for the device by the matrix
> you're generating here then setting that?
>
> If a user has set a static calibration we want to keep that.
Hmm, you might
graesslin added a subscriber: sebas.
graesslin added a comment.
In https://phabricator.kde.org/D8752#166896, @fvogt wrote:
> I don't remember seeing any of those issues before AMS got added.
> Only issue 1 disappears with KWIN_DRM_NO_AMS=1.
The problem is not ams, but that
graesslin updated this revision to Diff 22237.
graesslin added a comment.
Restricted Application edited projects, added KWin; removed Plasma.
Handle deviceAdded
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8748?vs=22175=22237
BRANCH
graesslin added a dependent revision: D8776: [autotests] Add tests for DRM
platform plugin.
REPOSITORY
R108 KWin
BRANCH
drm-property-safety
REVISION DETAIL
https://phabricator.kde.org/D8752
To: graesslin, #kwin, #plasma, fvogt, subdiff
Cc: plasma-devel, kwin, ZrenBot, progwolff,
graesslin added a dependency: D8752: [platforms/drm] At safety checks for the
properties.
REVISION DETAIL
https://phabricator.kde.org/D8776
To: graesslin, #kwin, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart
graesslin created this revision.
graesslin added reviewers: KWin, Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
The addition of the test infrastructure is motivated by the regressions
caused by adding mode
graesslin updated this revision to Diff 22208.
graesslin added a comment.
Restricted Application edited projects, added Plasma; removed KWin.
Update the eglsurface in AbstractEglBackend if it changed
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
graesslin added a comment.
Ok, I figured out why the context is not current any more. We seem to get a
mode change request from KScreen, which results in the DRMBackend updating a
screen, the EGLBackend recreates the EGLSurface but didn't pass it to the
parent class which tried to make a
graesslin added a comment.
In combination that looks like kscreen sends a request to KWin which is
stupid. Resulting in KWin losing the OpenGL context and then epoxy crashing. So
we have two problems here: one being the incorrect request from KScreen, the
other the fact that KWin ends up
graesslin updated this revision to Diff 22200.
graesslin added a comment.
Restricted Application edited projects, added KWin; removed Plasma.
Fix stupid mistake, now starting should work again
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8752?vs=22186=22200
graesslin updated this revision to Diff 22186.
graesslin added a comment.
Restricted Application edited projects, added Plasma; removed KWin.
Prevent the new reported crash
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8752?vs=22158=22186
BRANCH
graesslin created this revision.
graesslin added reviewers: KWin, Plasma, broulik.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.
REVISION SUMMARY
On X11 modifier+mouse button on the window decoration triggers the
"special" handling
graesslin accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R133 KScreenLocker
BRANCH
seccomp
REVISION DETAIL
https://phabricator.kde.org/D8756
To: davidk, graesslin
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts,
graesslin updated this revision to Diff 22175.
graesslin added a comment.
Restricted Application edited projects, added Plasma; removed KWin.
Use screens()->geometry() instead of size
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8748?vs=22152=22175
BRANCH
graesslin marked an inline comment as done.
graesslin added inline comments.
INLINE COMMENTS
> graesslin wrote in connection.cpp:395
> It's failing to compile in tests/ directory. There I don't have the
> mockscreens, so I didn't think of it. Will try with the mockscreens. Thanks
> for the
graesslin added inline comments.
INLINE COMMENTS
> davidedmundson wrote in connection.cpp:395
> not that it's a problem, but why?
> You have screens mocked already.
It's failing to compile in tests/ directory. There I don't have the
mockscreens, so I didn't think of it. Will try with the
graesslin created this revision.
graesslin added reviewers: KWin, Plasma, fvogt, subdiff.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.
REVISION SUMMARY
The AMS code accesses elements in a vector which might not be valid. This
graesslin added a comment.
> Yet we're putting this sensor stuff in kwin instead, then having to come up
with extra interfaces to fix the problems we're creating.
The main reason is that I wanted to support the phone case (hwcomposer) where
we don't have the OutputConfigurationInterface
graesslin updated this revision to Diff 22153.
graesslin added a comment.
Restricted Application edited projects, added KWin; removed Plasma.
Fixup arc failure
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8731?vs=22151=22153
BRANCH
graesslin created this revision.
graesslin added reviewers: KWin, Plasma.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.
REVISION SUMMARY
This change finds the screen for a touch screen device based on:
- number available screens
graesslin updated this revision to Diff 22151.
graesslin added a comment.
Restricted Application edited projects, added Plasma; removed KWin.
- [libinput] Find screen for touch screen devices and calibrate accordingly
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
graesslin added inline comments.
INLINE COMMENTS
> anthonyfieroni wrote in orientation_sensor.cpp:106
> m_userEnabled = m_config &&
> m_config->group("OrientationSensor").readEntry("Enabled", true);
>
> ?
I might want to extend the loadConfig with further options (who knows) and then
it
graesslin created this revision.
graesslin added reviewers: KWin, Plasma, sebas, davidedmundson.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.
REVISION SUMMARY
The initial state for user enabled is now read from config. In addition
graesslin added a comment.
Please see https://phabricator.kde.org/D8738 - I hope this addresses your
concerns and can us allow to unblock this change.
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D8731
To: graesslin, #kwin, #plasma, sebas, davidedmundson
Cc:
graesslin added a comment.
In https://phabricator.kde.org/D8731#165948, @davidedmundson wrote:
> I said on the previous patch that there's a *fundamental* design flaw in
the previous patch, which will be even worse on X.
> The last patch was pushed regardless..and now there's a patch
Am 2017-11-07 20:11, schrieb Martin Flöser:
Am 2017-11-07 19:03, schrieb Sebastian Kügler:
On dinsdag 7 november 2017 18:28:40 CET Martin Flöser wrote:
> upside down works, 90 and 270 do nothing on my system.
>
> Debian Unstable
> Linux manta 4.13.0-1-amd64 #1 SMP Debian 4.13.4-1
graesslin created this revision.
graesslin added reviewers: KWin, Plasma, sebas.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.
REVISION SUMMARY
The XRandRScreens detects whether a screen is internal and supports
transformations and
This revision was automatically updated to reflect the committed changes.
Closed by commit R108:9df1744830a0: Support automatic screen rotation based on
orientation sensor (authored by graesslin).
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit R108:99b6f6150d04: [platforms/drm] Determine the supported
transformation on a plane (authored by graesslin).
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit R108:59f7ed9c780a: [platforms/drm] Forward the mode changes to
the OutputInterface (authored by graesslin).
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
graesslin added a comment.
In https://phabricator.kde.org/D8699#165474, @davidedmundson wrote:
> > if auto rotation is enabled you cannot manually rotate the screen and
vice versa.
>
> Yeah, that's great...but kscreen needs to have that information.
>
> It's going to be
graesslin added a comment.
5.11 yes, 5.8 no
REPOSITORY
R108 KWin
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8706
To: apol, #plasma, davidedmundson
Cc: graesslin, plasma-devel, kwin, #kwin, bwowk, ZrenBot, progwolff,
lesliezhai, ali-mohamed, hardening, jensreuterberg,
Am 2017-11-07 19:03, schrieb Sebastian Kügler:
On dinsdag 7 november 2017 18:28:40 CET Martin Flöser wrote:
> upside down works, 90 and 270 do nothing on my system.
>
> Debian Unstable
> Linux manta 4.13.0-1-amd64 #1 SMP Debian 4.13.4-1 (2017-10-01)
> x86_64 GNU/ Linux
graesslin added a comment.
That reminds me: https://phabricator.kde.org/tag/vdg/ how can I request two
new status notifier icons? I need: "automatic-screen-rotation-enabled" and
"automatic-screen-rotation-disabled"
BRANCH
automatic-rotation
REVISION DETAIL
graesslin added a comment.
In https://phabricator.kde.org/D8699#165399, @sebas wrote:
> Ah, btw ... we have icons: They're in
breeze-icons/applets/*/osd-rotate-{ccw,cw,flip,normal].svg
>
> These should probably be used for the statusnotifier then.
No, the idea for the status
graesslin added a comment.
In https://phabricator.kde.org/D8699#165407, @davidedmundson wrote:
> I don't see how the interaction with KScreen is going to work; you rotate
the screen in kscreen, kscreen will consider that a completely different config
change and save it.
My
graesslin added a comment.
In https://phabricator.kde.org/D8699#165395, @sebas wrote:
> Code-wise, looks good.
>
> Have you thought about a way to switch it on and off? Perhaps a simple dbus
interface that allows checking its state and turning it on and off is
sufficient.
graesslin accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R108 KWin
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8702
To: davidedmundson, #plasma, graesslin
Cc: plasma-devel, kwin, #kwin, bwowk, ZrenBot, progwolff, lesliezhai,
graesslin accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D8703
To: davidedmundson, #plasma, graesslin
Cc: plasma-devel, kwin, #kwin, bwowk, ZrenBot, progwolff, lesliezhai,
ali-mohamed, hardening,
Am 2017-11-07 18:27, schrieb Sebastian Kügler:
On maandag 6 november 2017 16:54:26 CET Martin Flöser wrote:
Hi all,
I am currently working on screen rotation on Wayland. Unfortunately my
systems do not support vertical rotation (rotate by 90 or 270
degrees). Thus I do not know whether my code
Am 2017-11-07 09:03, schrieb Sebastian Kügler:
Hi Drew,
Thanks for reaching out!
On zaterdag 4 november 2017 15:10:33 CET Drew DeVault wrote:
As part of our effort to reuse existing Wayland protocols for common
desktop features in Sway (and wlroots), we're taking a look at KDE's
Am 2017-11-07 17:46, schrieb David Edmundson:
Linux david-laptop 4.10.17-2-MANJARO #1 SMP PREEMPT Sun May 21
11:02:41 UTC 2017 x86_64 GNU/Linux
On Intel it's not yet enabled by default with 4.10. Please do the
following:
1. Edit /etc/default/grub
and add "i915.nuclear_pageflip=1" to
graesslin added a dependent revision: D8699: Support automatic screen rotation
based on orientation sensor.
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D8645
To: graesslin, #kwin, #plasma, subdiff
Cc: broulik, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai,
graesslin added a dependency: D8645: [platforms/drm] Determine the supported
transformation on a plane.
REVISION DETAIL
https://phabricator.kde.org/D8699
To: graesslin, #kwin, #plasma, sebas
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol,
graesslin created this revision.
graesslin added reviewers: KWin, Plasma, sebas.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
This change introduces an OrientationSensor class which wraps a
QOrientationSensor. The
Am 2017-11-06 19:07, schrieb David Edmundson:
I am not :(
drmSetClientCap fails
Is there much I can do?
Could you please tell me which kernel version and which gpu driver you
are using?
Cheers
Martin
401 - 500 of 1301 matches
Mail list logo
