D7955: Move X11-only specific part of EffectsHandlerImpl to x11 platform plugin

graesslin added a comment. ping REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D7955 To: graesslin, #kwin, #plasma Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart

D7856: Make xstacking order dirty handling work without X11

This revision was automatically updated to reflect the committed changes. Closed by commit R108:ec7fe4419011: Make xstacking order dirty handling work without X11 (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7856?vs=19599=20139

D7846: [tabbox] Drop the passing to Effects in X11 Filter

This revision was automatically updated to reflect the committed changes. Closed by commit R108:f7d6e4affd22: [tabbox] Drop the passing to Effects in X11 Filter (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7846?vs=19581=20138 REVISION

D7843: Move XFixes cursor change tracking into the x11 standalone platform

This revision was automatically updated to reflect the committed changes. Closed by commit R108:6f99b577360d: Move XFixes cursor change tracking into the x11 standalone platform (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE

D7808: Create a dedicated X11EventFilter for the events used by RootInfo

This revision was automatically updated to reflect the committed changes. Closed by commit R108:cea7a189c8ba: Create a dedicated X11EventFilter for the events used by RootInfo (authored by graesslin). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D7808?vs=19501=20136#toc REPOSITORY

D7942: Create a dedicated X11Filter for Client sync events and move it to X11 platform

graesslin added a comment. ping REVISION DETAIL https://phabricator.kde.org/D7942 To: graesslin, #kwin, #plasma Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8065: Ensure libinput connection thread uses real time scheduling

graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY The SCHED_RESET_ON_FORK results in threads (not only processes) to have the scheduling policy

D7757: Use real-time scheduling policy for kwin_wayland

This revision was automatically updated to reflect the committed changes. Closed by commit R108:7c8003f7f621: Use real-time scheduling policy for kwin_wayland (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7757?vs=19375=20113 REVISION

D8040: Load QtQuick settings

graesslin added a comment. In https://phabricator.kde.org/D8040#150577, @davidedmundson wrote > If you do want to set this based on the initial scene backend, skip using this method and call the static method on QQuickWindow instead. After reading through the docs I think the

D8050: Expose wl_display_set_global_filter as a virtual method

graesslin accepted this revision. graesslin added a comment. This revision is now accepted and ready to land. Due you know whether we are allowed to block? E.g. to show a polkit dialog? My assumption would be we are not allowed to block here. REPOSITORY R127 KWayland BRANCH filter2

D8050: Expose wl_display_set_global_filter as a virtual method

graesslin added inline comments. INLINE COMMENTS > davidedmundson wrote in filtered_display.cpp:41 > I tried. > > modding getConnection means modding modding ClientConnection constructor, > modding that means modding the Private ctor > > that gets into > > wl_client_add_destroy_listener(c,

D8050: Expose wl_display_set_global_filter as a virtual method

graesslin added a comment. Btw. today is a great day: I finally can clean up my whiteboard. I had drafted an idea how to do what this change does more than a year ago and it's still waiting for the future me to implement it. But with this change I can finally clean it without having a bad

D8040: Load QtQuick settings

graesslin accepted this revision. graesslin added a comment. This revision is now accepted and ready to land. Let's assume we use XRender or QPainter compositor: how can we switch to software in this case? In KWin that is before we load any QtQuick (at least on Wayland on X11 I'm not sure,

D8039: Support software QtQuickRendering in Aurorae

graesslin added inline comments. INLINE COMMENTS > aurorae.cpp:354 > [this] { > if (!m_context->makeCurrent(m_offscreenSurface.data())) { > return; stupid question: but why is this code working? I would assume that making the context current

D8050: Expose wl_display_set_global_filter as a virtual method

graesslin added inline comments. INLINE COMMENTS > davidedmundson wrote in filtered_display.cpp:62 > Somewhat. > This is new in 1.13, we depend on 1.7. > > Debian is currently on 1.12. > (my general rule is: "is Debian has it, everyone else must do") > > Should we #ifdefs and then no-op (with

D8050: Expose wl_display_set_global_filter as a virtual method

graesslin added inline comments. INLINE COMMENTS > filtered_display.cpp:41 > +auto t = static_cast(data); > +auto clientConnection = > t->q->getConnection(const_cast(client)); > +auto interface = wl_global_get_interface(global);

D8050: Expose wl_display_set_global_filter as a virtual method

graesslin added inline comments. INLINE COMMENTS > filtered_display.cpp:62 > +} > +wl_display_set_global_filter(*this, Private::globalFilterCallback, > d.data()); > +}); I didn't know such API exists! This is great ;-) But I think you need to increase the minimum Wayland

D8016: Ensure leave event is send to decoration when a window maximizes

graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY When clicking the maximize button without moving the mouse, the maximize button stayed in

D7965: Drop the ObscurringWindow functionality on desktop switching

This revision was automatically updated to reflect the committed changes. Closed by commit R108:38ce05eaff4f: Drop the ObscurringWindow functionality on desktop switching (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7965?vs=19852=19994

D8012: Only assert on broken GL when we're rendering using GL

graesslin added inline comments. INLINE COMMENTS > desktopview.cpp:60 > > -connect(this, ::sceneGraphInitialized, this, > -[this, corona]() { > -// check whether the GL Context supports OpenGL > -// Note: hasOpenGLShaderPrograms is broken, see QTBUG--39730 >

D7997: [tabbox] Create X11Filter on establishKeyboardGrab

This revision was automatically updated to reflect the committed changes. Closed by commit R108:bc88f8477725: [tabbox] Create X11Filter on establishKeyboardGrab (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7997?vs=19951=19953 REVISION

D7997: [tabbox] Create X11Filter on establishKeyboardGrab

graesslin added a comment. Thanks for testing! REPOSITORY R108 KWin BRANCH tabbox-x11-filter-grab-5.11 REVISION DETAIL https://phabricator.kde.org/D7997 To: graesslin, #kwin, #plasma, broulik Cc: broulik, plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D7997: [tabbox] Create X11Filter on establishKeyboardGrab

graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY Creating the X11Filter directly on startup caused a regression as the filter got too early in

D7857: Change default argument of grabXKeyboard to XCB_WINDOW_NONE

This revision was automatically updated to reflect the committed changes. Closed by commit R108:a264c2b5cf14: Change default argument of grabXKeyboard to XCB_WINDOW_NONE (authored by graesslin). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D7857?vs=19600=19916#toc REPOSITORY R108

D6591: XdgV6 - Kwin side

graesslin accepted this revision. graesslin added a comment. This revision is now accepted and ready to land. And sorry, sorry, sorry that the review took so long. REPOSITORY R108 KWin BRANCH xdgv6 REVISION DETAIL https://phabricator.kde.org/D6591 To: davidedmundson, #plasma,

D7970: Restore cursors across multiple screens

graesslin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R108 KWin BRANCH Plasma/5.11 REVISION DETAIL https://phabricator.kde.org/D7970 To: davidedmundson, #plasma, graesslin Cc: plasma-devel, kwin, #kwin, bwowk, ZrenBot, progwolff, lesliezhai,

D7965: Drop the ObscurringWindow functionality on desktop switching

graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY The ObscurringWindows are a hack to make it more unlikely that the desktop wallpaper becomes

D7958: Drop ENABLE_TRANSIENCY_CHECK related code as it doesn't compile

This revision was automatically updated to reflect the committed changes. Closed by commit R108:e6ca32131733: Drop ENABLE_TRANSIENCY_CHECK related code as it doesnt compile (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE

D7956: Drop unused functions from utils

This revision was automatically updated to reflect the committed changes. Closed by commit R108:9ce651fc309d: Drop unused functions from utils (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7956?vs=19837=19847 REVISION DETAIL

D6591: XdgV6 - Kwin side

graesslin added a comment. I really would like to see this go in now into master! But we need to have at least a few unit tests. If that's too difficult I can write them, but I would prefer if one of you extends it. It's really not difficult in this case as we just need to add the basics to

D7856: Make xstacking order dirty handling work without X11

graesslin added a comment. ping REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D7856 To: graesslin, #kwin, #plasma Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart

D7853: Add a dedicated X11EventFilter for forwarding property events to the effect system

graesslin added a comment. ping REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D7853 To: graesslin, #kwin, #plasma Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart

D7846: [tabbox] Drop the passing to Effects in X11 Filter

graesslin added a comment. ping REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D7846 To: graesslin, #kwin, #plasma Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart

D7808: Create a dedicated X11EventFilter for the events used by RootInfo

graesslin added a comment. ping REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D7808 To: graesslin, #kwin, #plasma Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart

D7958: Drop ENABLE_TRANSIENCY_CHECK related code as it doesn't compile

graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY The code ifdefed by ENABLE_TRANSIENCY_CHECK does no longer compile and has not compiled since

D7956: Drop unused functions from utils

graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY Not used anywhere in KWin -> can go. TEST PLAN Still compiles REPOSITORY R108 KWin BRANCH

D7955: Move X11-only specific part of EffectsHandlerImpl to x11 platform plugin

graesslin added a dependency: D7846: [tabbox] Drop the passing to Effects in X11 Filter. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D7955 To: graesslin, #kwin, #plasma Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening,

D7846: [tabbox] Drop the passing to Effects in X11 Filter

graesslin added a dependent revision: D7955: Move X11-only specific part of EffectsHandlerImpl to x11 platform plugin. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D7846 To: graesslin, #kwin, #plasma Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai,

D7955: Move X11-only specific part of EffectsHandlerImpl to x11 platform plugin

graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY The Platform API is extended by a call to create the EffectsHandler. In X11 standalone

D7894: Only try creating X11 shadow if we have an X11 connection

This revision was automatically updated to reflect the committed changes. Closed by commit R108:537b36d1cb48: Only try creating X11 shadow if we have an X11 connection (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7894?vs=19704=19822

D7871: Properly update the visible (icon) name when the caption changes

This revision was automatically updated to reflect the committed changes. Closed by commit R108:ab7b6757bf32: Properly update the visible (icon) name when the caption changes (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE

D7843: Move XFixes cursor change tracking into the x11 standalone platform

graesslin edited the test plan for this revision. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D7843 To: graesslin, #kwin, #plasma Cc: plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D7942: Create a dedicated X11Filter for Client sync events and move it to X11 platform

graesslin added a dependency: D7843: Move XFixes cursor change tracking into the x11 standalone platform. REVISION DETAIL https://phabricator.kde.org/D7942 To: graesslin, #kwin, #plasma Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D7843: Move XFixes cursor change tracking into the x11 standalone platform

graesslin added a dependent revision: D7942: Create a dedicated X11Filter for Client sync events and move it to X11 platform. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D7843 To: graesslin, #kwin, #plasma Cc: plasma-devel, kwin, ZrenBot, progwolff, lesliezhai,

D7942: Create a dedicated X11Filter for Client sync events and move it to X11 platform

graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY On Wayland we have the sync disabled as it doesn't work properly. This allows us to also move the

D7843: Move XFixes cursor change tracking into the x11 standalone platform

graesslin updated this revision to Diff 19802. graesslin added a comment. Restricted Application edited projects, added Plasma; removed KWin. Fix crash on startup - cursor is created before Workspace, so the filter creation needs to be delayed REPOSITORY R108 KWin CHANGES SINCE LAST

D7938: Drop useless XCB_DESTROY_NOTIFY from big event switch statement

This revision was automatically updated to reflect the committed changes. Closed by commit R108:8aa7bb28c876: Drop useless XCB_DESTROY_NOTIFY from big event switch statement (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE

D7938: Drop useless XCB_DESTROY_NOTIFY from big event switch statement

graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY It just returned false, but that's also the default handling. REPOSITORY R108 KWin BRANCH

D7937: Don't reload background contrast effect on screen resize

graesslin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R108 KWin BRANCH master REVISION DETAIL https://phabricator.kde.org/D7937 To: davidedmundson, #plasma, graesslin Cc: graesslin, plasma-devel, kwin, #kwin, ZrenBot, progwolff, lesliezhai,

D7937: Don't reload background contrast effect on screen resize

graesslin added inline comments. INLINE COMMENTS > contrast.cpp:79 > +} > +foreach (EffectWindow *window, effects->stackingOrder()) > +updateContrastRegion(window); please no foreach in new code, please use range-based for. (Reason: I don't trust Qt to keep it after there was a

D7934: Add KCM for adjusting QtQuick Rendering in Plasma

graesslin added a comment. Out from experience with the KWin Compositing kcm: hide it well, add more warnings and hide it even more. No matter how much you warn against the settings users will change them. Even if it tells them it's the wrong setting for their system and it's going to break

D7845: Fix position where removeEffectsOverrideCursor is called

This revision was automatically updated to reflect the committed changes. Closed by commit R108:27d06a1d4c1b: Fix position where removeEffectsOverrideCursor is called (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7845?vs=19580=19790

D7760: Move XRenderUtils init/cleanup into X11 standalone platform

This revision was automatically updated to reflect the committed changes. Closed by commit R108:551a6246a897: Move XRenderUtils init/cleanup into X11 standalone platform (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7760?vs=19361=19789

D7924: Support starting kwin_wayland without XWayland support

graesslin added dependencies: D7760: Move XRenderUtils init/cleanup into X11 standalone platform, D7894: Only try creating X11 shadow if we have an X11 connection, D7892: Only call xcb_flush in performCompositing if we have an X11 connection, D7856: Make xstacking order dirty handling work

D7924: Support starting kwin_wayland without XWayland support

graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY Just continues with the steps without starting XWayland. This does not yet fully support

D7892: Only call xcb_flush in performCompositing if we have an X11 connection

This revision was automatically updated to reflect the committed changes. Closed by commit R108:e8664f83b964: Only call xcb_flush in performCompositing if we have an X11 connection (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE

Re: KDE Slimbook and its Synaptics-less Touchpad

Am 2017-09-21 16:41, schrieb Aleix Pol: Hey Plasma, One of the things that could be improved in the KDE Slimbook is that since the touchpad is not synaptics-based the kcm is entirely disabled. Nevertheless, Alejandro recently pointed out to me that XInput is still providing some options that

D7897: Move X11 specific Workspace initialization code into dedicated method

graesslin added inline comments. INLINE COMMENTS > broulik wrote in workspace.cpp:381 > `kwinApp()->x11Connection()`? Yes, in a future change :-) Currently this only moves code around and tries to not change too much. Some time in the near to distant future connection() will have to die as

D7856: Make xstacking order dirty handling work without X11

graesslin added a dependent revision: D7897: Move X11 specific Workspace initialization code into dedicated method. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D7856 To: graesslin, #kwin, #plasma Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai,

D7897: Move X11 specific Workspace initialization code into dedicated method

graesslin added a dependency: D7856: Make xstacking order dirty handling work without X11. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D7897 To: graesslin, #kwin, #plasma Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening,

D7894: Only try creating X11 shadow if we have an X11 connection

graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY Otherwise it crashes for the first window being created in a KWin/Wayland without XWayland

D7892: Only call xcb_flush in performCompositing if we have an X11 connection

graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY Otherwise KWin crashes when operating without XWayland support. REPOSITORY R108 KWin BRANCH

D7888: Make sure OpenGL Context is valid before deleting shader

graesslin accepted this revision. graesslin added a comment. This revision is now accepted and ready to land. Feel free to push either of the two revisions. REPOSITORY R108 KWin BRANCH master REVISION DETAIL https://phabricator.kde.org/D7888 To: davidedmundson, #plasma, graesslin Cc:

D7888: Make sure OpenGL Context is valid before deleting shader

graesslin added inline comments. INLINE COMMENTS > davidedmundson wrote in scene_opengl.cpp:1191-1194 > changed is called from a timer, so we can be pretty confident that we're > called mid-doing anything else, but I'm happy to do something else? > > to be clear are you suggesting we: > > -

D7882: on wayland startup create XDG_RUNTIME_DIR

graesslin added a comment. In https://phabricator.kde.org/D7882#147153, @sebas wrote: > That's happening when I start startplasmacompositor by hand, and it's annoying as fuck. AFAIR you are a Debian user, so am I and I don't need to do that. I also start it from console.

D7888: Make sure OpenGL Context is valid before deleting shader

graesslin requested changes to this revision. graesslin added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > scene_opengl.cpp:1191-1194 > +makeOpenGLContextCurrent(); > +delete m_lanczosFilter; > +m_lanczosFilter

D7885: Don't crash if a client (legally) uses deleted global contrast manager

graesslin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland BRANCH master REVISION DETAIL https://phabricator.kde.org/D7885 To: davidedmundson, #plasma, graesslin Cc: plasma-devel, #frameworks, leezu, ZrenBot, alexeymin, progwolff,

D7882: on wayland startup create XDG_RUNTIME_DIR

graesslin added a comment. -1 from my side. This is a clear bug in whatever is used in the login process. If XDG_RUNTIME_DIR is not created we might have a thousand more things which don't work as expected. I rather have KWin bail out early on that one than have to hunt down all the things

D7757: Use real-time scheduling policy for kwin_wayland

graesslin added a comment. In https://phabricator.kde.org/D7757#146952, @tcberner wrote: > Looks good to me. Sorry for the timeout :) The ping was more meant to other (Linux) developers on whether there is agreement that we should try making KWin a real time process ;-)

D7356: Support mapping QKeyEvent to xkb_keysym_t

This revision was automatically updated to reflect the committed changes. Closed by commit R108:a17c85a9eab5: Support mapping QKeyEvent to xkb_keysym_t (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7356?vs=18254=19675 REVISION DETAIL

D7757: Use real-time scheduling policy for kwin_wayland

graesslin added a comment. ping REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D7757 To: graesslin, #kwin, #plasma Cc: tcberner, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D7740: Move SceneOpenGL into a dedicated plugin

graesslin added a comment. ping REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D7740 To: graesslin, #kwin, #plasma Cc: bshah, plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart

D7877: Don't recreate kwayland blurmanager on screen size changes

graesslin accepted this revision. graesslin added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > blur.cpp:94 > + > +void BlurEffect::updateTexture() { > +delete target; nitpick: position of { REPOSITORY R108 KWin REVISION DETAIL

D7870: Don't crash if a client (legally) uses a deleted global

graesslin added inline comments. INLINE COMMENTS > anthonyfieroni wrote in blur_interface.cpp:49 > I don't get that. So your patch is quite enough, treat this note as a noise :) The cast method here is only called from callbacks. Wayland works by having a global callback table where one just

D7870: Don't crash if a client (legally) uses a deleted global

graesslin accepted this revision. graesslin added a comment. This revision is now accepted and ready to land. What surprises me is that BlurManager recreates for Output changes. That sounds like a bug in KWin (or an area which could be improved). REPOSITORY R127 KWayland BRANCH

D7871: Properly update the visible (icon) name when the caption changes

graesslin created this revision. graesslin added reviewers: KWin, Plasma, hein. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY It was possible that we performed an early exit when the caption changes and this

D7868: Don't scale cursor hotspot differently to cursor

graesslin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D7868 To: davidedmundson, #plasma, graesslin Cc: plasma-devel, kwin, #kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening,

D7857: Change default argument of grabXKeyboard to XCB_WINDOW_NONE

graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY The implementation of grabXKeyboard checks whether the passed in arg is XCB_WINDOW_NONE and

D7856: Make xstacking order dirty handling work without X11

graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY The xStackingOrder unlike indicated by it's name is relevant for both X11 and Wayland and

D7853: Add a dedicated X11EventFilter for forwarding property events to the effect system

graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY So far both Workspace and Toplevel emitted signals for every property notify event on the root

D7846: [tabbox] Drop the passing to Effects in X11 Filter

graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY If an Effect has replaced the TabBox and wants to react on mouse events the EffectsHandlerImpl

D7760: Move XRenderUtils init/cleanup into X11 standalone platform

graesslin added a comment. ping REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D7760 To: graesslin, #kwin, #plasma Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart

Re: 5.11 Beta Bug Reporting

Am 2017-09-16 10:50, schrieb Richard Ullger: Hi, I am currently running 5.10.95 from the kde-unstable Arch repo. Where would you prefer bugs to be reported? bugs.kde.org, please don't use reddit or the mailing list Cheers Martin

D7845: Fix position where removeEffectsOverrideCursor is called

graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY Should be when there is no more an effect which overrides the cursor, not unconditionally.

D7842: Split out the X11 mouse event filtering for EffectsHandlerImpl

This revision was automatically updated to reflect the committed changes. Closed by commit R108:0c6fdeef2db4: Split out the X11 mouse event filtering for EffectsHandlerImpl (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE

D7842: Split out the X11 mouse event filtering for EffectsHandlerImpl

graesslin added a comment. In https://phabricator.kde.org/D7842#146206, @davidedmundson wrote: > ok. > > Also note that I made a comment about the (untouched) wayland code. thanks for the hint, I hadn't noticed it before. Yeah, looks wrong, I guess it evolved or something

D7843: Move XFixes cursor change tracking into the x11 standalone platform

graesslin created this revision. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY A dedicated X11EventFilter is added and created from the X11Cursor in case we have XFixes. This means some more X11 specific code is

D7842: Split out the X11 mouse event filtering for EffectsHandlerImpl

graesslin added a comment. In https://phabricator.kde.org/D7842#146171, @davidedmundson wrote: > Code does what it says but one comment > > 1. I would move the m_mouseInterceptionWindow code with it, that way we have RAII on that window, and less X specific things in the

D7842: Split out the X11 mouse event filtering for EffectsHandlerImpl

graesslin created this revision. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY This change introduces a dedicated X11EventFilter for the mouse interception on X11. The filter gets created together with the start

D7834: Sync XRDB DPI to the platform specific setting

graesslin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D7834 To: davidedmundson, #plasma, graesslin Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D7808: Create a dedicated X11EventFilter for the events used by RootInfo

graesslin created this revision. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY Splitting out the handling from events.cpp and moves it into a dedicated class created together with RootInfo. TEST PLAN Test case

Re: KGlobalAccel regression in latest frameworks release

Am 2017-09-13 20:28, schrieb Kai Uwe Broulik: Hi, either of the following reverts fix the problem for me: KGlobalAccel: 2c20ddff034e4958bf0536ca91ae9e444955305d or KWindowSystem: 53ab31c663e63c18e30c69af445e9dd022a89acc and 32526718eae99ccb594360627586eebdf793372b but perhaps both

D7806: seccomp filter: Handle openat as well

graesslin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R133 KScreenLocker BRANCH master REVISION DETAIL https://phabricator.kde.org/D7806 To: fvogt, #plasma, graesslin Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

Re: KGlobalAccel regression in latest frameworks release

be someone on an X11 system to test what helps (maybe Kai-Uwe?). Cheers Martin Jonathan On Wed, Sep 13, 2017 at 06:23:48PM +0200, Martin Flöser wrote: Hi all, unfortunately I have to inform you that KGlobalAccel has a severe regression [1] in the latest framework release resulting in many

Re: plasma 5.11 beta tars tonight

Am 2017-09-13 11:54, schrieb Jonathan Riddell: There's a pr thing being done tomorrow so I've been requested to get the plasma beta out the way in the morning. This means I'll be making the tars and branching tonight (not sure exact time, I've a Catalan independence rally to go to first). You

KGlobalAccel regression in latest frameworks release

on this release we must act quickly and do a bug fix release for frameworks even if this is uncommon and against the practice. Sorry for any inconveniences. Martin Flöser KGlobalAccel maintainer [1] https://bugs.kde.org/show_bug.cgi?id=384597

D7784: CMake 3.1 is the actually required version

graesslin accepted this revision. graesslin added a comment. This revision is now accepted and ready to land. I had no idea that this requires a newer CMake. Thanks for fixing! REPOSITORY R108 KWin BRANCH master REVISION DETAIL https://phabricator.kde.org/D7784 To: heikobecker,

Re: [RFC] kscreen and touchscreen rotation

Am 2017-09-11 12:56, schrieb David Edmundson: But AFAIK actual screen rotation itself needs to be added to kwin wayland, before we can be looking at fixing touch events. I gave that one a try this evening. It took me about half an hour thinking about where to add the code, then 10 min of

D7761: [effects] Support xcbConnectionChanged for support properties

This revision was automatically updated to reflect the committed changes. Closed by commit R108:90e77a939a4d: [effects] Support xcbConnectionChanged for support properties (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE

D7654: Move XRandR event filter into XRandRScreens

This revision was automatically updated to reflect the committed changes. Closed by commit R108:4fa41165d190: Move XRandR event filter into XRandRScreens (authored by graesslin). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D7654?vs=19085=19451#toc REPOSITORY R108 KWin CHANGES SINCE

<    3   4   5   6   7   8   9   10   11   12   >