D28369: [runners/recentdocuments] disable executables or .desktop files

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Stable branch? REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D28369 To: davidedmundson, #plasma, ngraham Cc: ngraham, plasma-devel,

D28360: cmake: make xsettingsd check an option

ngraham added a comment. +1 for just making it a required dependency REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D28360 To: eszlari, gikari Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas,

D28354: [applets/digital-clock] Fix calendar events not being shown at first

ngraham added a comment. If you're gonna have the function live inside the `onAgendaUpdated:` handler and only be used once, it might as well not be a function at all. :) If you want to keep it a function, it would be good to put it higher up in the file, so it can potentially be used by

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ngraham updated this revision to Diff 78686. ngraham added a comment. Don't forget to update `breeze.kcfg` too REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28317?vs=78676=78686 BRANCH tools-area-color-changes (branched from master) REVISION DETAIL

D28354: Bug 395956: calendar events are not shown at first

ngraham added reviewers: Plasma, vkrause. ngraham added a comment. No need to put the function in a separate file; you should put it in `CalendarView.qml`. Since it's only used once, it could even be inline without defining a new function at all. That's a judgment call though. REPOSITORY

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ngraham updated this revision to Diff 78676. ngraham added a comment. Also change Breeze light (large diff because it was super inconsistent with the old Breeze, which is fixed here as a part of making it consistent with the new Breeze except for the titlebar color not changing)

D28200: Enable wrapping of error messages which use KMessageWidget

ngraham added a comment. In D28200#636071 , @develoot wrote: > In D28200#633124 , @ngraham wrote: > > > Anyway, @develoot, could you provide your email address so we can land this patch with proper

D28200: Enable wrapping of error messages which use KMessageWidget

This revision was automatically updated to reflect the committed changes. Closed by commit R119:d9bf6f53a036: Enable wrapping of error messages which use KMessageWidget (authored by develoot, committed by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ngraham added a comment. This isn't really a new version of Breeze Light. I see Breeze Light as the light version of Breeze Dark; both are unibody (titlebar is same color as window background), but one is light and the other is dark. That said, yeah, I wonder how many people will still

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ngraham updated this revision to Diff 78666. ngraham added a comment. Also turn off the close button circle by default REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28317?vs=78665=78666 BRANCH tools-area-color-changes (branched from master) REVISION

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ngraham updated this revision to Diff 78665. ngraham added a comment. Complete colorscheme changes REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28317?vs=78584=78665 BRANCH tools-area-color-changes (branched from master) REVISION DETAIL

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ngraham added a comment. I don't think we're planning on changing Breeze Light or Breeze dark as a part of this Tools Area change. IMO they both become more coherent, implementing a unibody look that's entirely light or dark, while the new Breeze color scheme implements the color split

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ngraham added a comment. Some comparisons with and without the filled circle: F8201574: Kate - circle.png F8201576: Kate - no circle.png F8201578: Plasma config window - circle.png

D28330: Color icons in titlebar if possible

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Quite nice, quite nice. REPOSITORY R31 Breeze BRANCH icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D28330 To: davidre, #plasma, #vdg, ngraham Cc:

D28331: KCM/mouse KCM/touchpad: Add a Scroll speed setting for wayland

ngraham added a comment. These KCMs have X11 versions too. They are not Wayland-specific. I'm not a fan of adding this feature only on Wayland. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28331 To: meven, #kwin, #plasma, davidedmundson, ervin, bport,

D28331: KCM/mouse KCM/touchpad: Add a Scroll speed setting

ngraham added a comment. So is this Wayland-only? The dependent patch says it's for Wayland. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28331 To: meven, #kwin, #plasma, davidedmundson, ervin, bport, crossi, hchain Cc: ngraham, zzag, plasma-devel, Orage,

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ngraham added a subscriber: manueljlin. ngraham added a comment. In D28317#635580 , @broulik wrote: > You are not changing the close button to not be a filled circle, are you? Heh, I forgot to undo that change in my screenshots; I turn it

D28289: Refactor of OverlaySheet

ngraham added a comment. In D28289#635601 , @mart wrote: > I'm thinking to maybe *always* show the header with separator line and all even if empty when there is a close button... Makes sense to me, yeah. REPOSITORY R169 Kirigami

D28306: [applets/taskmanager] Make the hover state clarifying, but not main

This revision was automatically updated to reflect the committed changes. Closed by commit R119:488c4b746d68: [applets/taskmanager] Make the hover state clarifying, but not main (authored by epopov, committed by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D28321: [WIP] [applets/devicenotifier] Port to ExpandableListItem

ngraham created this revision. ngraham added reviewers: VDG, Plasma, broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY WIP because of the TODOs at the top of the file in `DeviceItem.qml`. Assistance

D28306: Make the hover state clarifying, but not main

ngraham added a comment. This does introduce a visual change: the hover effect now adds a blue background, even for un-launched pinned launchers. Currently the hover effect for pinned launchers is just a lightening of the icon itself. I'm not against it, but this is a visual change that

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ngraham created this revision. ngraham added reviewers: VDG, Breeze. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY This patch adjusts the default Breeze color scheme to produce the final Tools Area

D27669: [kstyle] Tools area

ngraham added a comment. Can can confirm. Toolbars are no longer considered to be a part of the Tools area in all apps with the latest version of the patch. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D27669 To: cblack, #plasma, #breeze, #vdg, hpereiradacosta,

D28316: Add useful input method hints to password field by default

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Excellent idea! REPOSITORY R169 Kirigami BRANCH fix-password-field-input-hints REVISION DETAIL https://phabricator.kde.org/D28316 To: ouwerkerk, #kirigami, ngraham Cc: ngraham,

D27669: [kstyle] Tools area

ngraham added a comment. With the latest version of the patch, I still see this hilarious visual bug: F8200104: vokoscreenNG-2020-03-26_10-37-25.webm REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D27669 To: cblack, #plasma,

D27669: [kstyle] Tools area

ngraham added a comment. Yes, the decoration theme determines its own border value. For Breeze it's "No borders", but we can't assume that. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D27669 To: cblack, #plasma, #breeze, #vdg, hpereiradacosta, davidre Cc:

D28289: Refactor of OverlaySheet

ngraham added a comment. Generally much nicer looking. I found one visual issue: when I switch from touchpad scrolling to touchscreen scrolling, the close button in the corner gets overlapped by the content area since the scroll track gets narrower. INLINE COMMENTS > OverlaySheet.qml:24 >

D28296: KCM/Mouse: fix the middleEmulation checkbox status

ngraham accepted this revision. ngraham added a comment. stable branch REPOSITORY R119 Plasma Desktop BRANCH mouse-middleEmulation REVISION DETAIL https://phabricator.kde.org/D28296 To: meven, #plasma, ervin, bport, crossi, hchain, davidedmundson, ngraham Cc: ngraham, plasma-devel,

D27669: [kstyle] Tools area

ngraham added a comment. In D27669#634903 , @davidre wrote: > - Why are we drawing a separator if the window has no toolbar? Because this looks really good :) F821: vokoscreenNG-2020-03-26_09-46-28.webm

D27669: [kstyle] Tools area

ngraham added a comment. Can confirm, if I override the default border setting and change it to "no borders", the appearance looks right again. So I guess we need to handle cases where the window decoration theme's default border setting is "no borders". It might also be nice to mention

D28306: Make the hover state clarifying, but not main

ngraham added a comment. Thanks for the patch! For visual patches like this, it's helpful if you put before-and-after images or screen recordings in the Test Plan section. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28306 To: epopov, davidedmundson, #vdg

D27669: [kstyle] Tools area

ngraham added a comment. So I'm still having an issue with the feature um, not working. :( I have it turned on in the Breeze settings but it behaves as if off; that is to say, I see no different appearance compared to the status quo. Is anyone else experiencing this, or just me?

D28281: Add options for OSD feedback

ngraham accepted this revision. ngraham added a reviewer: drosca. ngraham added a subscriber: drosca. ngraham added a comment. This revision is now accepted and ready to land. This looks great to me! I have to admit I was skeptical when I first saw the patch, but I think making the

D28281: Add options for OSD feedback

ngraham added a comment. This works great! In terms of the UI, it feels like we need a bit more logical separation between the groups now. I would adjust things (in this same patch) to be like this: Play audio feedback for changes to: [x] Audio volume Show visual

D28057: Fix/Allow folderview popup mode icon and list icon size

ngraham added a comment. Abandoning the existing `iconSize` config value and adding a new one called `gridViewIconSize` means that everyone'e existing icon view size will be reset, since nothing will be reading from the `iconSize` values in the config files anymore. You have two options

D28218: FileChooser: add option to open file with or without write access

ngraham added a comment. Honestly that's what makes sense to me. I don't think the use case of "I trust this app enough to open it and show it my files, but not enough to let it modify my files" really exists. I think most normal users would just not use an app they don't trust, or not let

D28289: Refactor of OverlaySheet

ngraham added a comment. FWIW this needs a rebase as there were apparently some changes to OverlaySheet on master since this was branched. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D28289 To: mart, #kirigami Cc: ngraham, plasma-devel, fbampaloukas, GB_2,

D28281: Add options for OSD feedback

ngraham added inline comments. INLINE COMMENTS > main.qml:198 > +function showOsdMicMute(text) { > +if (!Plasmoid.configuration.mutecOsd) > +return `mutecOsd`? :-) REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D28281 To:

D28275: skip over supposed network shares that aren't

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Whoops! REPOSITORY R102 KInfoCenter BRANCH smb-type-check REVISION DETAIL https://phabricator.kde.org/D28275 To: sitter, ngraham Cc: plasma-devel, Orage, LeGast00n,

D28280: [kcms/baloo] Refine UI and prepare for more indexing options in the future

ngraham added a comment. Right, so my intention was to make it easy to add a new entry to the combobox titled "Metadata-only indexing". REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28280 To: ngraham, #vdg, #baloo, #plasma Cc: bruns, plasma-devel, Orage,

D28277: [UrlButton] Disable when there is no URL

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Nice. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D28277 To: broulik, mart, #vdg, #kirigami, ngraham Cc: apol, ngraham, plasma-devel, fbampaloukas, GB_2,

D28280: [kcms/baloo] Refine UI and prepare for more indexing options in the future

ngraham added a comment. Such a complicated setup is probably not going to be typical, I expect. But for that we could have an Advanced Settings sheet that allows people to customize things with great detail. However we probably don't have to worry too much about that for the purpose of

D28280: [kcms/baloo] Refine UI and prepare for more indexing options in the future

ngraham added a comment. In D28280#634388 , @bruns wrote: > Try do imagine how the combobox will look like when you add 'Index hidden' to the config options. That would be fine. Comboboxes handle many options pretty well. In

D28025: [Baloo KCM] Complete overhaul of the include/exclude folder list

ngraham added a comment. UI refinement is here: D28280 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28025 To: bruns, #baloo, #vdg, ngraham, mart Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh,

D28280: [kcms/baloo] Refine UI and prepare for more indexing options in the future

ngraham updated this revision to Diff 78455. ngraham added a comment. use `onActivated:` rather than `onCurrentIndexChanged:` for the combobox REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28280?vs=78454=78455 BRANCH refine-baloo-kcm-ui

D28280: [kcms/baloo] Refine UI and prepare for more indexing options in the future

ngraham created this revision. ngraham added reviewers: VDG, Baloo, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY This patch refines the UI added in D28025 . The

D28277: [UrlButton] Don't show tooltip if it would be empty

ngraham added reviewers: VDG, Kirigami. ngraham added a comment. If `button.url` is undefined, then the whole thing won't work in the first place. Maybe instead the control could disable itself automatically, or change its color to red to indicate a broken link? REPOSITORY R169 Kirigami

D28154: Add users KCM

ngraham added a comment. FWIW deleting a user doesn't work for me. When I click the Delete User button, in the console I see: file:///home/nate/kde/usr/share/kpackage/kcms/user_manager/contents/ui/UserDetailsPage.qml:177: TypeError: Cannot read property 'uid' of undefined Also I

D28262: [applets/analog-clock] Optional minute hand

ngraham edited reviewers, added: VDG, Plasma; removed: Plasma: Workspaces. ngraham added a comment. Thanks for the patch, Anthony! Technical comment: you need to update the kcfg file too, to add a definition of the new option. Conceptual/UI comment: do you think you could explain

D27070: Refactor foreach, use Qt5 signal syntax, remove unnecessary method call

ngraham added a comment. This broke the CI: [2020-03-24T15:59:18.523Z] [ 66%] Linking CXX shared module ../../bin/krunner_datetime.so [2020-03-24T15:59:18.523Z] /usr/home/jenkins/workspace/Plasma/kdeplasma-addons/kf5-qt5 FreeBSDQt5.14/runners/spellchecker/spellcheck.cpp:198:30:

D28172: [applets/digital-clock] Fix date sizing in vertical panel

This revision was automatically updated to reflect the committed changes. Closed by commit R120:01691632b523: [applets/digital-clock] Fix date sizing in vertical panel (authored by ngraham). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D28172: [applets/digital-clock] Fix date sizing in vertical panel

ngraham updated this revision to Diff 78366. ngraham added a comment. Restore elision property REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28172?vs=78126=78366 BRANCH fix-vertical-panel-date-text-sizing (branched from Plasma/5.18) REVISION

D28238: Stop multiplying duration values

ngraham added a comment. In D28238#633505 , @cblack wrote: > I'm not sure where you can see the changes to `ActionButton.qml` and `UserDelegate.qml`. the lock, logout, and login screens REPOSITORY R120 Plasma Workspace BRANCH

D28238: Stop multiplying duration values

ngraham created this revision. ngraham added reviewers: VDG, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY After D28144 , some animations are now too long because

D28239: Stop multiplying duration values

ngraham created this revision. ngraham added reviewers: VDG, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY After D28144 , some animations are now too long because

D28236: [applet/taskmanager] Remove unnecessary icon size values set on PC3 toolbuttons

ngraham created this revision. ngraham added reviewers: VDG, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY `units.iconSizes.smallMedium` is the default size, so setting the icon size to this has no

D27972: [NightColor] fix for plasmoid status and tooltip subtext

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. In D27972#633289 , @zzag wrote: > > in "Always on" manual mode: when active (not inhibited) > > I still don't understand why

D27972: [NightColor] fix for plasmoid status and tooltip subtext

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. @zzag, is this okay for you? REVISION DETAIL https://phabricator.kde.org/D27972 To: pdabrowski, #plasma, zzag, ngraham, #vdg Cc: broulik, plasma-devel, Orage, LeGast00n,

D28154: Add users KCM

ngraham added a comment. Regarding groups, obviously if it isn't a part of this patch, then it isn't a part of this patch. I don't think it makes sense to WONTFIX the idea of it though. I not-infrequenrly wish for a GUI method of changing my user's group membership. Yes, I know how to do it

D28166: Add support for power sensors from lm-sensors

ngraham added a comment. Nice patch! Keep 'em coming! :) REPOSITORY R106 KSysguard REVISION DETAIL https://phabricator.kde.org/D28166 To: raghuraman, mlaurent, davidedmundson Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2,

D28166: Add support for power sensors from lm-sensors

This revision was automatically updated to reflect the committed changes. Closed by commit R106:00f522a7ceec: Add support for power sensors from lm-sensors (authored by raghuraman, committed by ngraham). REPOSITORY R106 KSysguard CHANGES SINCE LAST UPDATE

D28211: Make Pin buttons consistently sized in System Tray and Clock pop-ups

This revision was automatically updated to reflect the committed changes. Closed by commit R120:3a44e360e01e: Make Pin buttons consistently sized in System Tray and Clock pop-ups (authored by ngraham). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D28025: [Baloo KCM] Complete overhaul of the include/exclude folder list

ngraham added a comment. Ok, will do. I just have a few comments about the backend bits, just minor stuff. Overall this is really good! I plan to polish the UI after this lands, but left comments on the front-end component anyway so you can sharpen your QML skills (which are quite good

D28208: Move sni icon handling logic from data engine to applet

ngraham added inline comments. INLINE COMMENTS > kmaterka wrote in StatusNotifierItem.qml:90 > Yes, you are correct, my mistake. So `StatusNotifierItemSource` has no margin > and `KIconLoader` has 5% of icon size - another inconsistency. > What about 'always round when multiplying by a

D28200: Enable wrapping of error messages which use KMessageWidget

ngraham added a comment. Anyway, @develoot, could you provide your email address so we can land this patch with proper authorship information? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28200 To: develoot, #vdg, #plasma, #frameworks, davidedmundson Cc:

D28167: packagekit: Fix checking of APT::Periodic::Update-Package-Lists

ngraham added a comment. Very nice patch! May it be the first of many. :) REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D28167 To: eliac, #discover_software_store, apol, ngraham Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, semareit,

D28133: [applets/digital-clock] Switch timezones by clicking on them in the popup

This revision was automatically updated to reflect the committed changes. Closed by commit R120:e5caa59acb13: [applets/digital-clock] Switch timezones by clicking on them in the popup (authored by ngraham). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D28209: [applets/notes] Actually hide button row when it's not visible

This revision was automatically updated to reflect the committed changes. Closed by commit R114:7eaad09e1fd1: [applets/notes] Actually hide button row when its not visible (authored by ngraham). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE

D27503: [KCM Spellchecking] port to KPropertySkeletonItem

ngraham added a comment. Looks like this failed in the CI. [2020-03-23T17:18:47.106Z] /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/kcms/spellchecking/spellcheckingskeleton.cpp:24:10: fatal error: Sonnet/ConfigView: No such file or directory

D28211: [applets/systemtray] Make Pin button a bit larger

ngraham updated this revision to Diff 78300. ngraham added a comment. Remove all size overrides; the problem is in the Plasma theme icon having no padding and will be fixed there in a different patch REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D28211: [applets/systemtray] Make Pin button a bit larger

ngraham added a subscriber: mart. ngraham added a comment. The PC3 ToolButton has been "fixed" half a dozen times already and I imagine poor @mart is thoroughly sick of it by now... REPOSITORY R120 Plasma Workspace BRANCH normal-sized-pin-button (branched from master) REVISION DETAIL

D28218: FileChooser: add option to open file with or without write access

ngraham added a reviewer: VDG. ngraham added a comment. In D28218#632918 , @jgrulich wrote: > In D28218#632909 , @ngraham wrote: > > > In D28218#632907 ,

D27783: Add new Account portal

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Ah, thanks. LGTM. Would you be okay with me submitting a patch to alter/polish the UI after it lands? REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop BRANCH

D28218: FileChooser: add option to open file with or without write access

ngraham added a comment. In D28218#632907 , @jgrulich wrote: > but you can restrict the write access if you don't the sandboxed application to modify the file. Under what circumstance would you want that? REPOSITORY R838 Flatpak

D28218: FileChooser: add option to open file with or without write access

ngraham added a comment. Hmm, this seems like the kind of nerdy exposing-implementation-details thing that would be problematic from a UX standpoint. I can see the use cases for wanting to open a read-only file read-write so you can actually save to it, but I think a better UX for this

D27783: Add new Account portal

ngraham added a comment. Ok. When trying to compile I get the following: In file included from ../libportal/portal-qt5.h:20, from libportal-qt/a370903@@LibPortalQt@sha/../../../libportal-qt/portal_p.h:24, from

D28216: [VirtualDesktopInfo] Connect to rowsChanged singal

ngraham added a comment. +1, makes logical sense. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28216 To: broulik, #plasma, hein Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen,

D28209: [applets/notes] Actually hide button row when it's not visible

ngraham added a comment. No, there's space reserved for the row even when it's invisible, so the size of the text field doesn't jump around. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D28209 To: ngraham, #plasma, #vdg Cc: broulik, plasma-devel, Orage,

D28211: [applets/systemtray] Make Pin button a bit larger

ngraham added a comment. The size is actually perfect for being a ToolButton: F8194949: Screenshot_20200323_085422.png However yeah, the actual icon size in a ToolButton is `smallMedium`, so I guess the fact that you need to use `small` to get the

D28211: [applets/systemtray] Make Pin button a bit larger

ngraham created this revision. ngraham added reviewers: VDG, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY The Pin button in the System Tray expanded view is very small. This has always felt

D28200: Enable wrapping of error messages which use KMessageWidget

ngraham added a comment. In D28200#632622 , @davidedmundson wrote: > > I wonder if it makes sense to set this on the widget itself, as a sensible default. > > No. > > Not because it's a better or worse default, but because making a

D28200: Enable wrapping of error messages which use KMessageWidget

ngraham added reviewers: Plasma, Frameworks. ngraham added a comment. Thanks for the patch! I wonder if it makes sense to set this on the widget itself, as a sensible default. You're probably going to want to word-wrap more often than you aren't. REPOSITORY R119 Plasma Desktop REVISION

D27783: Add new Account portal

ngraham added a comment. How can I test this? REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop REVISION DETAIL https://phabricator.kde.org/D27783 To: jgrulich, #plasma, ngraham Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas,

D28209: [applets/notes] Actually hide button row when it's not visible

ngraham created this revision. ngraham added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Currently the row's opacity is changed from 0% to 100% depending on focus state, but it

D28208: Move sni icon handling logic from data engine to applet

ngraham added inline comments. INLINE COMMENTS > StatusNotifierItem.qml:84 > +} > +return 64; > +} Most of these numbers correspond to standard icon sizes (e.g. `units.iconSize.smallMedium` == 22); maybe use those where possible > StatusNotifierItem.qml:90 > +

D27669: [kstyle] Tools area

ngraham added a comment. Regarding the Tools Area separator color being different: I agree with Hugo, and have voiced this concern before. It's also not consistent with the mockups and IMO the presented justification demonstrates why the different color isn't needed: the Tools Area's

D28180: [applets/systemtray] Hide/show expander arrow - regression fix

ngraham added a comment. This works, but I wonder if there's a conceptually cleaner way to do it. Not that I know of one, so I'll wait for a #plasma person to comment. Oh and thanks for the code comments. Always very helpful! REPOSITORY R120

D21905: [Digital Clock] Open KOrganizer with event details on click

ngraham added a comment. +1 in general. Probably needs a rebase as I twiddled with a lot of this code recently. INLINE COMMENTS > CalendarView.qml:196 > + > +onClicked: { > +monthView.daysModel.showEventDetails(modelData.uid) If there's an

D28172: [applets/digital-clock] Fix date sizing in vertical panel

ngraham added a comment. Yeah, I've noticed that too. I haven't been able to figure out how to improve it. Where it decides to wrap is also not very deterministic. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28172 To: ngraham, #vdg, #plasma Cc: muesli,

D28172: [applets/digital-clock] Fix date sizing in vertical panel

ngraham created this revision. ngraham added reviewers: VDG, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY This patch fixes several errors in the code: - The property is named

D28025: [Baloo KCM] Complete overhaul of the include/exclude folder list

ngraham added a comment. Yes, it's true that our UIs are frequently inconsistent; that's why the #consistency goal exists. A big part of this goal is to improve the usability of common components like the Kirigami SwipeListItem so that

D28154: Add users KCM

ngraham added subscribers: nicolasfella, ngraham. ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Nice, this KCM was in desperate need of a rewrite. I've got some concerns though: Since the new KCM's name (`kcm_user`)

D28143: Add "veryLongDuration" animation duration

This revision was automatically updated to reflect the committed changes. Closed by commit R169:8427e8eaa037: Add veryLongDuration animation duration (authored by ngraham). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28143?vs=78037=78101 REVISION DETAIL

D28158: [Cursor Theme KCM] Use standardized pointer and help cursor for preview

ngraham accepted this revision. ngraham added a comment. stable branch REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28158 To: broulik, #plasma, davidedmundson, ngraham Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh,

D27669: [kstyle] Tools area

ngraham added a comment. Nice, the colors are better now. I still see a difference in animation speed when the titlebar and toolbar change color though. It's especially visible with the current Breeze color scheme. F8185590: vokoscreenNG-2020-03-19_20-53-04.webm

D28025: [Baloo KCM] Complete overhaul of the include/exclude folder list

ngraham added a comment. In D28025#630849 , @bruns wrote: > Having only inclusion/exclusion is a temporary state. I plan to add more settings for each path, so having an "add" button for each possible state will no longer be feasible. > >

D26200: Add shortcut for closing pages

ngraham added a comment. In D26200#589355 , @mart wrote: > hmm, not sure about it. > it would probably be ok for most of the cases, but i'm pretty sure it may break some existing app. > an app may want at least two pages always loaded for

D27555: Add a category for kde-only and gnome-only apps

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Requesting changes to remove from the review queue given that I have open icon and string change requests REPOSITORY R134 Discover Software Store REVISION DETAIL

D27783: Add new Account portal

ngraham added a comment. UserInfoDialog.qml an Item with a Rectangle in it, could you use a Window? https://doc.qt.io/qt-5/qml-qtquick-window-window.html REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop REVISION DETAIL https://phabricator.kde.org/D27783 To: jgrulich,

D28025: [Baloo KCM] Complete overhaul of the include/exclude folder list

ngraham requested changes to this revision. ngraham added a reviewer: mart. ngraham added a comment. This revision now requires changes to proceed. I have some UI suggestions: - Have a button to add an exclusion path as well as a button to add an inclusion path, rather than a single Add

<    3   4   5   6   7   8   9   10   11   12   >