Re: Information regarding upcoming Gitlab Migration

2020-04-27 Thread Rolf Eike Beer
Bhushan Shah wrote: I've worked on draft "move" of the current set of the repositories in their respective subgroups at the repo-metadata project's branch [1]. You can browse the directory structure to get idea of how final structure on Gitlab would look like. No objection, just a request for

[Powerdevil] [Bug 350365] Battery monitor in tray randomly shows there is no battery

2020-01-13 Thread Rolf Eike Beer
https://bugs.kde.org/show_bug.cgi?id=350365 --- Comment #49 from Rolf Eike Beer --- My battery is "gone" from the panel, so I started plasmoidviewer. It just shows a blank square, but when I click on it it shows the battery with 51%, which sounds plausible. When I click on

D22908: avoid qml warnings when controlRoot is not set

2019-08-14 Thread Rolf Eike Beer
dakon abandoned this revision. dakon added a comment. Dupe of D21514 REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D22908 To: dakon, ngraham, mart, #plasma, apol Cc: ngraham, mart, plasma-devel,

D22908: avoid qml warnings when controlRoot is not set

2019-08-03 Thread Rolf Eike Beer
dakon created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. dakon requested review of this revision. REVISION SUMMARY When debugging a custom Qml application in KDevelop I'm spammed with these messages otherwise:

D13100: do not use buffered file IO

2018-10-31 Thread Rolf Eike Beer
This revision was automatically updated to reflect the committed changes. Closed by commit R107:fcbcf0f1bdfa: do not use buffered file IO (authored by dakon). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D13100?vs=43538=44535#toc REPOSITORY R107 KWallet PAM Integration CHANGES SINCE

D13100: do not use buffered file IO

2018-10-27 Thread Rolf Eike Beer
dakon added inline comments. INLINE COMMENTS > aacid wrote in pam_kwallet.c:696 > const While this is "just an int", my personal taste is very much against using const on a file descriptor as this is not how this really works. I don't know. > aacid wrote in pam_kwallet.c:704 > const ACK

D13100: do not use buffered file IO

2018-10-13 Thread Rolf Eike Beer
dakon updated this revision to Diff 43538. dakon added a comment. O_CREAT was missing, as well as the file mode. O_CLOEXEC is available for a long time, there should be no need for the compat define. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13100?vs=34833=43538 REVISION

[Powerdevil] [Bug 350365] Battery monitor in tray randomly shows there is no battery

2018-09-25 Thread Rolf Eike Beer
https://bugs.kde.org/show_bug.cgi?id=350365 Rolf Eike Beer changed: What|Removed |Added Version|5.3.2 |5.12.5 -- You are receiving this mail

[Powerdevil] [Bug 350365] Battery monitor in tray randomly shows there is no battery

2018-09-25 Thread Rolf Eike Beer
https://bugs.kde.org/show_bug.cgi?id=350365 --- Comment #28 from Rolf Eike Beer --- So why does it work on the lockscreen, does that read it's information from somewhere else? -- You are receiving this mail because: You are the assignee for the bug.

[Powerdevil] [Bug 350365] Battery monitor in tray randomly shows there is no battery

2018-06-10 Thread Rolf Eike Beer
https://bugs.kde.org/show_bug.cgi?id=350365 --- Comment #22 from Rolf Eike Beer --- Similar to comment #8, I have this messages: file:///usr/share/plasma/plasmoids/org.kde.plasma.battery/contents/ui/CompactRepresentation.qml:43:39: Unable to assign [undefined] to bool file:///usr/share/plasma

[Powerdevil] [Bug 350365] Battery monitor in tray randomly shows there is no battery

2018-06-02 Thread Rolf Eike Beer
https://bugs.kde.org/show_bug.cgi?id=350365 --- Comment #21 from Rolf Eike Beer --- Still there in 5.12.5, and it seems to get worse as I see it more often. -- You are receiving this mail because: You are the assignee for the bug.

[Powerdevil] [Bug 350365] Battery monitor in tray randomly shows there is no battery

2018-06-02 Thread Rolf Eike Beer
https://bugs.kde.org/show_bug.cgi?id=350365 --- Comment #20 from Rolf Eike Beer --- *** Bug 394943 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.

D12937: Drop privileges when reading the salt file

2018-05-29 Thread Rolf Eike Beer
dakon added a comment. Nice. Now only the fread() return code needs to be handled and it is perfect. REPOSITORY R107 KWallet PAM Integration REVISION DETAIL https://phabricator.kde.org/D12937 To: aacid, dakon Cc: dakon, mgerstner, fvogt, plasma-devel, ragreen, Pitel, ZrenBot,

D12937: Drop privileges when reading the salt file

2018-05-27 Thread Rolf Eike Beer
dakon added inline comments. INLINE COMMENTS > aacid wrote in pam_kwallet.c:750 > It's a different process, that's why we're using pipes, i don't really want > to go into shared process memory for something as simple as this. I'm talking about the salt variable, which is returned from this

D12937: Drop privileges when reading the salt file

2018-05-27 Thread Rolf Eike Beer
dakon added inline comments. INLINE COMMENTS > aacid wrote in pam_kwallet.c:750 > it's not a bug > > the code works and will work 100% of times, pretending malloc fails is nice > from a teoretical point of view, but it's not going to happen, if you're > going to block me on this i will make

D12937: Drop privileges when reading the salt file

2018-05-27 Thread Rolf Eike Beer
dakon added inline comments. INLINE COMMENTS > aacid wrote in pam_kwallet.c:730 > I can check the return code but does it matter? we'll write into the pipe > anyway, be it 0 or whatever we read, if it's not the correct stuff the other > process will fail anyway so i don't really see the need

D12937: Drop privileges when reading the salt file

2018-05-25 Thread Rolf Eike Beer
dakon requested changes to this revision. dakon added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > pam_kwallet.c:705 > +{ > +int readSaltPipe[2] = { -1, -1}; > +if (pipe(readSaltPipe) < 0) { no init necessary, either pipe overwrites it or it returns

D13100: do not use buffered file IO

2018-05-24 Thread Rolf Eike Beer
dakon created this revision. dakon added a reviewer: aacid. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. dakon requested review of this revision. REVISION SUMMARY This is not necessary here. Additionally we can use O_CLOEXEC to make

D13015: use explicit_bzero() if it is present

2018-05-23 Thread Rolf Eike Beer
This revision was automatically updated to reflect the committed changes. Closed by commit R107:1f8707c4e114: use explicit_bzero() if it is present (authored by dakon). REPOSITORY R107 KWallet PAM Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13015?vs=34752=34753

D13079: use a consistent style to handle fork()

2018-05-23 Thread Rolf Eike Beer
dakon created this revision. dakon added a reviewer: aacid. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. dakon requested review of this revision. REPOSITORY R107 KWallet PAM Integration REVISION DETAIL

D13015: use explicit_bzero() if it is present

2018-05-23 Thread Rolf Eike Beer
dakon updated this revision to Diff 34752. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13015?vs=34573=34752 REVISION DETAIL https://phabricator.kde.org/D13015 AFFECTED FILES CMakeLists.txt pam_kwallet.c To: dakon, aacid Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai,

D13015: use explicit_bzero() if it is present

2018-05-21 Thread Rolf Eike Beer
dakon created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. dakon requested review of this revision. REPOSITORY R107 KWallet PAM Integration REVISION DETAIL https://phabricator.kde.org/D13015 AFFECTED FILES

[Powerdevil] [Bug 350365] Battery monitor in tray randomly shows there is no battery

2017-04-07 Thread Rolf Eike Beer
https://bugs.kde.org/show_bug.cgi?id=350365 Rolf Eike Beer <k...@opensource.sf-tec.de> changed: What|Removed |Added Status|UNCONFIRMED |CON

Re: Review Request 110633: Don't report crashes if version is disabled in Bugzilla

2013-05-25 Thread Rolf Eike Beer
Am Samstag 25 Mai 2013, 10:19:37 schrieb Jekyll Wu: Well, DrKonqi uses Product.get API to fetch product information from bugs.kde.org, including all available versions (either active or disabled). But that is not the point of those escaped reports which shouldn't be accepted. Even if DrKonqi

Re: Review Request: Fix misplaced panel (especially when more than one monitor is involved)

2012-07-29 Thread Rolf Eike Beer
Am Donnerstag 26 Juli 2012, 10:14:42 schrieb Marco Martin: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105596/#review16464 ---

Review Request: Fix misplaced panel (especially when more than one monitor is involved)

2012-07-17 Thread Rolf Eike Beer
--- Rebuild with that change, panel was placed properly after login. Using plain package immediately showed the problem again. Thanks, Rolf Eike Beer ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma