dakon added inline comments. INLINE COMMENTS
> aacid wrote in pam_kwallet.c:750 > it's not a bug > > the code works and will work 100% of times, pretending malloc fails is nice > from a teoretical point of view, but it's not going to happen, if you're > going to block me on this i will make you happy, but you should know you're > wasting my and your time for no reason. There can't happen anything too bad here I guess, the read() will just fail or crash. I wonder if we should not get rid of this alltogether and just pass in a stack buffer from the caller, this would avoid any failures and leaks on it. REPOSITORY R107 KWallet PAM Integration REVISION DETAIL https://phabricator.kde.org/D12937 To: aacid, dakon Cc: dakon, mgerstner, fvogt, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
