Re: Review Request 110420: Bugfix for bug #311364

2013-05-17 Thread Romário Rios
/110420/#review32683 --- On May 16, 2013, 4:56 p.m., Romário Rios wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110420

Re: Review Request 110420: Bugfix for bug #311364

2013-05-17 Thread Romário Rios
, but doesn't hide otherwise. Thanks, Romário Rios ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 110420: Bugfix for bug #311364

2013-05-17 Thread Romário Rios
retracts or the user closes it purposefully. (at which point it could go back to being a passive popup) Romário Rios wrote: I'll confirm that when I get home, but the patch changes the behavior of the notifications history (i.e., the thing that appears when we click

Re: Review Request 110420: Bugfix for bug #311364

2013-05-17 Thread Romário Rios
/110420/#review32694 --- On May 17, 2013, 8:26 a.m., Romário Rios wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110420

Re: Review Request 110420: Bugfix for bug #311364

2013-05-16 Thread Romário Rios
) - plasma/generic/applets/notifications/contents/ui/main.qml e867517 Diff: http://git.reviewboard.kde.org/r/110420/diff/ Testing (updated) --- Popup hides when it goes out of focus when no jobs are running, but doesn't hide otherwise. Thanks, Romário Rios

Re: Review Request 110420: Bugfix for bug #311364

2013-05-13 Thread Romário Rios
?id=311364 Diffs - plasma/generic/applets/notifications/contents/ui/main.qml e867517 Diff: http://git.reviewboard.kde.org/r/110420/diff/ Testing --- Popup goes away when it loses focus. Thanks, Romário Rios ___ Plasma-devel mailing

Re: Review Request 110420: Bugfix for bug #311364

2013-05-13 Thread Romário Rios
/show_bug.cgi?id=311364 Diffs - plasma/generic/applets/notifications/contents/ui/main.qml e867517 Diff: http://git.reviewboard.kde.org/r/110420/diff/ Testing --- Popup goes away when it loses focus. Thanks, Romário Rios ___ Plasma-devel

Re: Review Request: Port the Calculator applet to QML

2012-11-08 Thread Romário Rios
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107001/#review21614 --- On Nov. 6, 2012, 11:36 p.m., Romário Rios wrote

Re: Review Request: Port the Calculator applet to QML

2012-11-06 Thread Romário Rios
:54 a.m., Romário Rios wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107001/ --- (Updated Nov. 6, 2012, 2:54 a.m

Re: Review Request: Port the Calculator applet to QML

2012-11-06 Thread Romário Rios
: CustomButton { text: - onClicked: setOperator(/) } The same for the other buttons. Seems cleaner to me.. Romário Rios wrote: A repeater seems simpler to me in this case. Mark Gaiser wrote: Well, he tried (in the mailing list) and a repeater gets

Re: Review Request: Port the Calculator applet to QML

2012-11-06 Thread Romário Rios
, Romário Rios ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Port the Calculator applet to QML

2012-11-05 Thread Romário Rios
-calculator.desktop 0760729 Diff: http://git.reviewboard.kde.org/r/107001/diff/ Testing --- Tested as both applet and popupapplet, with the Air theme and the Oxygen theme. It seems to work fine. Thanks, Romário Rios ___ Plasma-devel mailing list

Re: Review Request: Port the Calculator applet to QML

2012-11-05 Thread Romário Rios
/107001/diff/ Testing --- Tested as both applet and popupapplet, with the Air theme and the Oxygen theme. It seems to work fine. Thanks, Romário Rios ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma

Re: Review Request: Port the Calculator applet to QML

2012-11-01 Thread Romário Rios
/ Testing (updated) --- Tested as both applet and popupapplet, with the Air theme and the Oxygen theme. It seems to work fine. Thanks, Romário Rios ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma

Review Request: Port the Calculator applet to QML

2012-10-22 Thread Romário Rios
keyboard-focused as a popupapplet (the user has to click it). Other than that, it seems to work fine. Thanks, Romário Rios ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Fix TextArea Plasma component documentation

2012-10-03 Thread Romário Rios
--- On Oct. 3, 2012, 1:31 a.m., Romário Rios wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106703

Review Request: Correct horizontalAlignment and verticalAlignment properties of TextArea

2012-10-02 Thread Romário Rios
#307506. This addresses bug 307506. http://bugs.kde.org/show_bug.cgi?id=307506 Diffs - plasma/declarativeimports/plasmacomponents/qml/TextArea.qml bc9095d Diff: http://git.reviewboard.kde.org/r/106702/diff/ Testing --- Works. Thanks, Romário Rios

Review Request: Fix TextArea Plasma component documentation

2012-10-02 Thread Romário Rios
with qmlapigenerator.py seems to fine. Thanks, Romário Rios ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Activities Dataengine: avoid calling KActivities::Controller::listActivities() unnecessarily

2011-12-15 Thread Romário Rios
, and it seems to work just fine as long as I tested. Thanks, Romário Rios ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request: Activity Dataengine: Delete the KActivities::Info when an activity is removed

2011-12-07 Thread Romário Rios
/diff Testing --- Removing some activities with plasmaengineexplorer running org.kde.activities seemed to work fine. Thanks, Romário Rios ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request: Activities Dataengine: avoid calling KActivities::Controller::listActivities() unnecessarily

2011-12-07 Thread Romário Rios
be something in KActivities. Could someone confirm this, please? Thanks, Romário Rios ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request: Apply button on systray plasmoid.

2011-02-13 Thread Romário Rios
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100651/ --- Review request for Plasma. Summary --- Enables Apply button on

Re: Review Request: Apply button on systray plasmoid.

2011-02-13 Thread Romário Rios
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100651/ --- (Updated Feb. 13, 2011, 9:19 p.m.) Review request for Plasma. Changes

Review Request: Enable Apply button on Lockout configuration dialog

2011-02-13 Thread Romário Rios
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100652/ --- Review request for Plasma. Summary --- This patch enables the Apply

Re: Review Request: Enable Apply button on Lockout configuration dialog

2011-02-13 Thread Romário Rios
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100652/ --- (Updated Feb. 14, 2011, 2:05 a.m.) Review request for Plasma. Changes

Review Request: Apply button on Rebember the milk configs.

2011-02-12 Thread Romário Rios
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100643/ --- Review request for Plasma. Summary --- This enables Apply button in

Re: Review Request: KHoliday::HolidayRegionSelector: emit signal when modified

2011-02-11 Thread Romário Rios
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100619/ --- (Updated Feb. 12, 2011, 4:40 a.m.) Review request for KDEPIM-Libraries

Re: Review Request: KHoliday::HolidayRegionSelector: emit signal when modified

2011-02-11 Thread Romário Rios
-mail. To reply, visit: http://git.reviewboard.kde.org/r/100619/#review1342 --- On Feb. 12, 2011, 4:40 a.m., Romário Rios wrote: --- This is an automatically generated e-mail. To reply

Re: Review Request: Enable Apply button for plasma clock

2011-02-11 Thread Romário Rios
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100620/ --- (Updated Feb. 12, 2011, 4:42 a.m.) Review request for Plasma. Changes

Re: Review Request: Apply button enabling for some plasmoids.

2011-02-09 Thread Romário Rios
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100614/#review1317 --- On Feb. 9, 2011, 5:53 a.m., Romário Rios wrote

Review Request: Apply button enabling for some plasmoids.

2011-02-08 Thread Romário Rios
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100614/ --- Review request for Plasma. Summary --- Just porting some plasmoids

Re: Review Request: Timer: one click to pause/resume, blinks when paused.

2011-02-02 Thread Romário Rios
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100521/ --- (Updated Feb. 2, 2011, 9:34 a.m.) Review request for Plasma. Changes

Re: Review Request: Timer: one click to pause/resume, blinks when paused.

2011-02-02 Thread Romário Rios
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100521/ --- (Updated Feb. 2, 2011, 9:39 a.m.) Review request for Plasma. Changes

Re: Review Request: Timer: one click to pause/resume, blinks when paused.

2011-02-02 Thread Romário Rios
--- On Feb. 2, 2011, 9:39 a.m., Romário Rios wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100521

Review Request: Timer: one click to pause/resume, blinks when paused.

2011-02-01 Thread Romário Rios
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100521/ --- Review request for Plasma. Summary --- This patch does some little