D29326: Bookmarks Runner: Fix extraction of firefox profile

bruns requested changes to this revision. bruns added a comment. This revision now requires changes to proceed. The summary needs some text which works without any images The code needs some comment which tells how the selection logic works and why it is as it is. INLINE COMMENTS >

D28619: BookmarksRunner: Remove caching of profile database path

bruns requested changes to this revision. bruns added a comment. This revision now requires changes to proceed. Please just remove the `writeEntry`. You can then propose "But what about renaming the dbfile entry, maybe to alternate_dbfile?" as another review. REPOSITORY R120 Plasma

D28619: BookmarksRunner: Remove caching of profile database path

bruns added a comment. There are two possible ways of changing the caching, and each one will break behavior for one of two different groups of users: 1. People who rely on the krunner following the default profile. 2. People who rely on krunner using the dbfile config entry. I

D28473: BookmarksRunner: Early return and formatting

bruns added a comment. LGTM - @broulik ? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28473 To: alex, bruns, broulik, #plasma Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham,

D28473: BookmarksRunner: Early return and formatting

bruns added inline comments. INLINE COMMENTS > firefox.cpp:166 > +if (!QSqlDatabase::isDriverAvailable(QStringLiteral("QSQLITE"))) { > +qWarning() << "SQLITE driver isn't available"; > +return; Thanks, though I was wrong about "no categories yet". #include

D28473: BookmarksRunner: Early return and formatting

bruns added inline comments. INLINE COMMENTS > firefox.cpp:198 > -if (profilePath.isEmpty()) { > -//qDebug() << "No default firefox profile found"; > -return; Can you leave this in, and even promote it to an active qWarning* - if we have a db and

D28439: BoorkmarksRunner: Set QIcon instead of Favicon pointer in BookmarkMatch

bruns added a comment. @davidedmundson - is `QIcon(QImage(...)) `save? the AppstreamRunner suffers from the same problem, it uses `match->setIcon(/*wrapped*/QIcon::fromTheme())`. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28439 To: alex, apol,

D28439: BoorkmarksRunner: Set QIcon instead of Favicon pointer in BookmarkMatch

bruns added a comment. In D28439#638188 , @davidedmundson wrote: > QIcon isn't thread safe. I think this is related to https://phabricator.kde.org/D5889?id=14601 ? I think we are save here, as the QIcon is created from an image

D28439: BoorkmarksRunner: Set QIcon instead of Favicon pointer in BookmarkMatch

bruns added a comment. In D28439#638216 , @alex wrote: > In D28439#638188 , @davidedmundson wrote: > > > QIcon isn't thread safe. > > > Sorry, I wasn't aware about that and haven't found

D28196: BUGFIX BookmarksRunner: Fix wrong default profile extraction, remove caching

bruns requested changes to this revision. bruns added a comment. This revision now requires changes to proceed. This should be 3 submission: 1. early return/indentation changes (preparation) 2. always read default profile from FF config, do not write "dbfile" to runner config 3. fix

D28196: BUGFIX BookmarksRunner: Fix wrong default profile extraction, remove caching

bruns added a comment. Also keep code lines at < 80 characters REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28196 To: alex, bruns, z3ntu, apol, broulik, davidedmundson, #plasma Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh,

D28196: BUGFIX BookmarksRunner: Fix wrong default profile extraction, remove caching

bruns added a comment. Regarding the summary: 1. Wrap the lines at <80 characters 2. Describe the screenshot textually REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28196 To: alex, bruns, z3ntu, apol, broulik, davidedmundson, #plasma Cc:

D28196: BUGFIX BookmarksRunner: Fix wrong default profile extraction, remove caching

bruns added a comment. Can you split out the early-return part for the QSQLite driver and submit it as a preparation patch? It adds quite some noise to the diff due to the whitespace changes (though I fully agree it is the better coding pattern). REPOSITORY R120 Plasma Workspace

D28280: [kcms/baloo] Refine UI and prepare for more indexing options in the future

bruns added a comment. In D28280#634471 , @ngraham wrote: > Such a complicated setup is probably not going to be typical, I expect. But for that we could have an Advanced Settings sheet that allows people to customize things with great detail.

D28280: [kcms/baloo] Refine UI and prepare for more indexing options in the future

bruns added a comment. In D28280#634405 , @ngraham wrote: > In D28280#634388 , @bruns wrote: > > > Try do imagine how the combobox will look like when you add 'Index hidden' to the config options.

D28280: [kcms/baloo] Refine UI and prepare for more indexing options in the future

bruns added a comment. For the "Add folder setting...": How about a config dialog **after** the File Dialog? This may seem over the top for now, but the next step is to make the excludeFilters and mimetype filters configurabe from the KCM, and then also per folder. REPOSITORY R119

D28280: [kcms/baloo] Refine UI and prepare for more indexing options in the future

bruns added a comment. Try do imagine how the combobox will look like when you add 'Index hidden' to the config options. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28280 To: ngraham, #vdg, #baloo, #plasma Cc: bruns, plasma-devel, Orage, LeGast00n,

D28025: [Baloo KCM] Complete overhaul of the include/exclude folder list

This revision was automatically updated to reflect the committed changes. Closed by commit R119:7498b41a1979: [Baloo KCM] Complete overhaul of the include/exclude folder list (authored by bruns). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D28025: [Baloo KCM] Complete overhaul of the include/exclude folder list

bruns updated this revision to Diff 78333. bruns marked 2 inline comments as done. bruns added a comment. update2 REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28025?vs=78332=78333 BRANCH baloo_config_rework REVISION DETAIL

D28025: [Baloo KCM] Complete overhaul of the include/exclude folder list

bruns updated this revision to Diff 78332. bruns marked 2 inline comments as done. bruns added a comment. update REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28025?vs=78064=78332 BRANCH baloo_config_rework REVISION DETAIL

D28025: [Baloo KCM] Complete overhaul of the include/exclude folder list

bruns marked 2 inline comments as done. bruns added inline comments. INLINE COMMENTS > ngraham wrote in filteredfoldermodel.cpp:36 > this handy little function feels like it wants to be in KCoreAddons or > something Now its likely inlined by the compiler ... > ngraham wrote in main.qml:112 >

D28208: Move sni icon handling logic from data engine to applet

bruns added inline comments. INLINE COMMENTS > kmaterka wrote in StatusNotifierItem.qml:90 > Yes, you are correct, my mistake. So `StatusNotifierItemSource` has no margin > and `KIconLoader` has 5% of icon size - another inconsistency. > What about 'always round when multiplying by a

D28025: [Baloo KCM] Complete overhaul of the include/exclude folder list

bruns added a comment. In D28025#631358 , @ngraham wrote: > If you're okay with me modifying the UI in a follow-up patch, I'll accept the UI in its current form. Is that acceptable? Thats the intention of all this - get it in a usable

D28025: [Baloo KCM] Complete overhaul of the include/exclude folder list

bruns added a comment. TODO: T12840 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28025 To: bruns, #baloo, #vdg, ngraham, mart Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus,

D28025: [Baloo KCM] Complete overhaul of the include/exclude folder list

bruns added a comment. F8185503: Screenshot_20200320_022339.png REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28025 To: bruns, #baloo, #vdg, ngraham, mart Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack,

D28025: [Baloo KCM] Complete overhaul of the include/exclude folder list

bruns updated this revision to Diff 78064. bruns added a comment. Use Kirigami.Action for Trash REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28025?vs=77574=78064 BRANCH baloo_config_rework REVISION DETAIL https://phabricator.kde.org/D28025

D28025: [Baloo KCM] Complete overhaul of the include/exclude folder list

bruns added a comment. In D28025#630882 , @ngraham wrote: > In D28025#630849 , @bruns wrote: > > > Having only inclusion/exclusion is a temporary state. I plan to add more settings for each path, so

D28025: [Baloo KCM] Complete overhaul of the include/exclude folder list

bruns added a comment. In D28025#630729 , @ngraham wrote: > I have some UI suggestions: > > - Have a button to add an exclusion path as well as a button to add an inclusion path, rather than a single Add Setting button, which is a rather

D28024: [Baloo KCM] Expose "Index hidden" config setting

This revision was automatically updated to reflect the committed changes. Closed by commit R119:491ce0f1d78f: [Baloo KCM] Expose Index hidden config setting (authored by bruns). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28024?vs=77558=77662

D28024: [Baloo KCM] Expose "Index hidden" config setting

bruns added inline comments. INLINE COMMENTS > ngraham wrote in main.qml:59 > Instead adding these new layouts, you could just set the following on each > checkbox that needs to be indented: > > Layout.leftMargin: !LayoutMirroring.enabled ? Kirigami.Units.largeSpacing : > 0 >

D28025: [Baloo KCM] Complete overhaul of the include/exclude folder list

bruns updated this revision to Diff 77574. bruns added a comment. tabs REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28025?vs=77560=77574 BRANCH baloo_config_rework REVISION DETAIL https://phabricator.kde.org/D28025 AFFECTED FILES

D28025: [Baloo KCM] Complete overhaul of the include/exclude folder list

bruns added inline comments. INLINE COMMENTS > main.qml:169 > +id: removeFolder > + visible: model.deletable > +icon.name: "user-trash" Spurious tab REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28025

D28025: [Baloo KCM] Complete overhaul of the include/exclude folder list

bruns added a comment. F8174362: Screenshot_20200313_145738.png F8174361: Screenshot_20200313_145811.png REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28025 To: bruns,

D28025: [Baloo KCM] Complete overhaul of the include/exclude folder list

bruns created this revision. bruns added reviewers: Baloo, VDG, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. bruns requested review of this revision. REVISION SUMMARY The current "Excluded folders" list in the KCM is quite awkward: 1. It tries to mimic

D28024: [Baloo KCM] Expose "Index hidden" config setting

bruns created this revision. bruns added reviewers: Baloo, VDG, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. bruns requested review of this revision. REVISION SUMMARY Also inset both "Index file content" and "Index hidden" so it is more obvious both are

D27917: [Baloo] Fix firstRun and config change logic

This revision was automatically updated to reflect the committed changes. Closed by commit R119:550cf9cafb19: [Baloo] Fix firstRun and config change logic (authored by bruns). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27917?vs=77183=77456

D27917: [Baloo] Fix firstRun and config change logic

bruns created this revision. bruns added reviewers: Baloo, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. bruns requested review of this revision. REVISION SUMMARY FirstRun should only be set if baloo was *never ever* run before, and this case is already

D27636: Remove redundant match for mountpoints

This revision was automatically updated to reflect the committed changes. Closed by commit R119:0acbfba3b0e4: Remove redundant match for mountpoints (authored by bruns). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27636?vs=76333=76432 REVISION

D27636: Remove redundant match for mountpoints

bruns created this revision. bruns added reviewers: Baloo, ngraham, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. bruns requested review of this revision. REVISION SUMMARY m_excludeList is populated from m_settings->excludeFolders(), so one of the

D27613: Remove bogus mount points check when starting baloo on save

This revision was automatically updated to reflect the committed changes. Closed by commit R119:9dc634bdb1ec: Remove bogus mount points check when starting baloo on save (authored by bruns). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D27612: Remove unused functions

This revision was automatically updated to reflect the committed changes. Closed by commit R119:cd52299862ea: Remove unused functions (authored by bruns). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27612?vs=76252=76331 REVISION DETAIL

D27611: Invert logic of shouldShowMountPoint -> ignoredMountPoint

This revision was automatically updated to reflect the committed changes. Closed by commit R119:31e823b6a67a: Invert logic of shouldShowMountPoint - ignoredMountPoint (authored by bruns). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D27611: Invert logic of shouldShowMountPoint -> ignoredMountPoint

bruns updated this revision to Diff 76329. bruns retitled this revision from "Invert logic of shouldShowMountPoint -> ignoreMountPoint" to "Invert logic of shouldShowMountPoint -> ignoredMountPoint". bruns edited the summary of this revision. bruns added a comment. Update commit message (I

D27613: Remove bogus mount points check when starting baloo on save

bruns created this revision. bruns added reviewers: Baloo, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. bruns requested review of this revision. REVISION SUMMARY The check stops baloo if non of the included pathes is *currently* mounted, i.e. if a device

D27611: Invert logic of shouldShowMountPoint -> ignoreMountPoint

bruns updated this revision to Diff 76253. bruns added a comment. ignoreMountPoint -> ignoredMountPoint whitespace REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27611?vs=76251=76253 REVISION DETAIL https://phabricator.kde.org/D27611 AFFECTED

D27611: Invert logic of shouldShowMountPoint -> ignoreMountPoint

bruns added a comment. In D27611#616556 , @usta wrote: > 2 Question : > 1- isnt that method should be const'ified ? Its not a member function ... REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27611

D27612: Remove unused functions

bruns updated this revision to Diff 76252. bruns added a comment. rebase REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27612?vs=76250=76252 REVISION DETAIL https://phabricator.kde.org/D27612 AFFECTED FILES kcms/baloo/filteredfoldermodel.cpp

D27611: Invert logic of shouldShowMountPoint -> ignoreMountPoint

bruns updated this revision to Diff 76251. bruns added a comment. move out of class REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27611?vs=76249=76251 REVISION DETAIL https://phabricator.kde.org/D27611 AFFECTED FILES

D27612: Remove unused functions

bruns created this revision. bruns added reviewers: Baloo, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. bruns requested review of this revision. REVISION SUMMARY showMessage() is only declared, but never defined. includeFolders() and

D27611: Invert logic of shouldShowMountPoint -> ignoreMountPoint

bruns created this revision. bruns added reviewers: Baloo, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. bruns requested review of this revision. REVISION SUMMARY Instead of negating the logic values in several places, just invert the logic. REPOSITORY

D27579: Remove attempt to start long gone baloo_file_cleaner

This revision was automatically updated to reflect the committed changes. Closed by commit R119:616a99165eda: Remove attempt to start long gone baloo_file_cleaner (authored by bruns). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27579?vs=76181=76199

D27579: Remove attempt to start long gone baloo_file_cleaner

bruns created this revision. bruns added reviewers: Baloo, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. bruns requested review of this revision. REVISION SUMMARY The standalone index cleaner has been replaced almost 5 years by functionality implemented in

D25991: [KFilePlacesModel] Fix supported scheme check for devices

bruns added inline comments. INLINE COMMENTS > kfileplacesmodel.cpp:758 > +KFilePlacesItem *item = nullptr; > +if (deviceAvailable) { > +item = new KFilePlacesItem(bookmarkManager, > bookmark.address(), udi); you have dropped the

D25280: [Baloo KCM] Purge index when disabling indexing

bruns added a comment. Agree with David/Thomas, first we need a "Suspend" button or similar. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25280 To: ngraham, tcanabrava, #plasma, #vdg, #baloo Cc: bruns, cfeck, davidedmundson, plasma-devel, LeGast00n,

D23112: Add a event Spy for GtkFileChooser recent files

bruns added inline comments. INLINE COMMENTS > ivan wrote in GtkEventSpy.cpp:126 > No need to compare chars with strings: > > if (!exec.isEmpty() && exec[0] == '\'' && exec.back() == '\'') missing `QChar('\'')`, otherwise it breaks with QT_NO_CAST_FROM_ASCII -> `if

D22333: Move Solid::Device::listFromQuery calls to a separate thread

bruns added a comment. In D22333#496544 , @davidedmundson wrote: > Kinda, you're summary missing a key part. > (the commit description is a bit poor) > > This patch does the following: > > - It does the search in the other thread.

D22333: Move Solid::Device::listFromQuery calls to a separate thread

bruns added a comment. In D22333#494852 , @anthonyfieroni wrote: > https://phabricator.kde.org/source/solid/browse/master/src/solid/devices/frontend/devicemanager.cpp$301 > @bruns, It's backend per thread Yes, you are correct, so

D22333: Move Solid::Device::listFromQuery calls to a separate thread

bruns added a comment. In D22333#494810 , @apol wrote: > In D22333#494774 , @bruns wrote: > > > Also, the code is calling non-threadsafe code from multiple threads now (e.g. once from each the two

D22333: Move Solid::Device::listFromQuery calls to a separate thread

bruns added a comment. In D22333#494415 , @apol wrote: > In D22333#494389 , @bruns wrote: > > > Again, where is it blocking? Which backend? > > > udisks2 mainly, but every backend can block by

D22333: Move Solid::Device::listFromQuery calls to a separate thread

bruns added a comment. In D22333#494384 , @apol wrote: > In D22333#494253 , @bruns wrote: > > > In D22333#494152 , @apol wrote: > > > > > In

D22333: Move Solid::Device::listFromQuery calls to a separate thread

bruns added a comment. In D22333#494152 , @apol wrote: > In D22333#494146 , @bruns wrote: > > > Why not just a singleshot timer from the constructor? Avoids any initial blocking ... > > >

D22333: Move Solid::Device::listFromQuery calls to a separate thread

bruns requested changes to this revision. bruns added a comment. This revision now requires changes to proceed. Why not just a singleshot timer from the constructor? Avoids any initial blocking ... REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22333 To:

D22296: [ksmserver] Remove obsolete KDELibs4Support dependency

This revision was automatically updated to reflect the committed changes. Closed by commit R120:7fa46fa74987: [ksmserver] Remove obsolete KDELibs4Support dependency (authored by bruns). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D22296: [ksmserver] Remove obsolete KDELibs4Support dependency

bruns updated this revision to Diff 61475. bruns marked an inline comment as done. bruns retitled this revision from "Port KSMServer to Solid::Power, drop KDELibs4Support requirement" to "[ksmserver] Remove obsolete KDELibs4Support dependency". bruns edited the summary of this revision. bruns

D22296: Port KSMServer to Solid::Power, drop KDELibs4Support requirement

bruns marked an inline comment as done. bruns added inline comments. INLINE COMMENTS > anthonyfieroni wrote in logout.cpp:399-400 > Make job autodelete if not. This is no KJob REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22296 To: bruns, #plasma, broulik,

D22296: Port KSMServer to Solid::Power, drop KDELibs4Support requirement

bruns added a comment. In D22296#492147 , @sitter wrote: > > So, in order to port to the API, it'd first need finishing up really. The question is - do we really want this call here, or not. As is, it is just an expensive

D22312: [DeviceNotifications] Keep last message for each device

This revision was automatically updated to reflect the committed changes. Closed by commit R120:bf811e448c76: [DeviceNotifications] Keep last message for each device (authored by bruns). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D22312: [DeviceNotifications] Keep last message for each device

bruns created this revision. bruns added reviewers: Plasma, broulik, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. bruns requested review of this revision. REVISION SUMMARY Ejecting e.g. a USB stick removes it from the bus (bus power is removed), but the

D22296: Port KSMServer to Solid::Power, drop KDELibs4Support requirement

bruns added a comment. After having looked into the callchain again, I am not sure what the best action here is: The old code did a DBus call of org.freedesktop.PowerManagement.Inhibit, which is implemented by powerdevil. Powerdevil only "schedules" the inhibition, but delays it for 5

D22296: Port KSMServer to Solid::Power, drop KDELibs4Support requirement

bruns created this revision. bruns added reviewers: Plasma, broulik, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. bruns requested review of this revision. REVISION SUMMARY As KDELibs4Support pulled in a number of Frameworks, we have to explicitly

D21414: Allow 'Exclude folders' section in Baloo KCM to fill window

bruns added a comment. The code change looks sane for me, although I haven't tested it. The summary should mention: - what is currently wrong (space consumed by spacer) - what was done to fix it (spacer removed, so the folder list can stretch) Can you add a before/after

D19796: [Device Notifier] Restore Solid notification messages

bruns requested changes to this revision. bruns added a comment. This revision now requires changes to proceed. This is just much to complicated, adding layer over layer does not help. Also, the second problem is unrelated to the change you mention - the "hasMessage" property could only

D20383: [KRunner] Avoid writing history if addToHistory is idempotent

This revision was automatically updated to reflect the committed changes. Closed by commit R120:9686c05c7226: [KRunner] Avoid writing history if addToHistory is idempotent (authored by bruns). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D20382: [KRunner] Move trivial check in addToHistory to the front

This revision was automatically updated to reflect the committed changes. Closed by commit R120:4a5f62fee952: [KRunner] Move trivial check in addToHistory to the front (authored by bruns). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D20383: [KRunner] Avoid writing history if addToHistory is idempotent

bruns updated this revision to Diff 55793. bruns added a comment. use const REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20383?vs=55748=55793 BRANCH arcpatch-D20383 REVISION DETAIL https://phabricator.kde.org/D20383 AFFECTED FILES

D20383: [KRunner] Avoid writing history if addToHistory is idempotent

bruns created this revision. bruns added reviewers: Plasma, broulik, apol. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. bruns requested review of this revision. REVISION SUMMARY It is not uncommon to run the same command repeatedly. In this case, the history is

D20382: [KRunner] Move trivial check in addToHistory to the front

bruns created this revision. bruns added reviewers: Plasma, broulik, apol. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. bruns requested review of this revision. REVISION SUMMARY No functional change. TEST PLAN compiles, runs REPOSITORY R120 Plasma Workspace

D19823: Port to the new install directory for knsrc files

bruns added a comment. Now plasma-workspace depends on KNewStuff 5.57 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D19823 To: apol, ngraham Cc: bruns, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D19963: Avoid serializing base64 encoded favicon data twice

This revision was automatically updated to reflect the committed changes. Closed by commit R856:c3611dc98170: Avoid serializing base64 encoded favicon data twice (authored by bruns). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE

D19963: Avoid serializing base64 encoded favicon data twice

bruns added a comment. Ping! REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D19963 To: bruns, #plasma, broulik Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19963: Avoid serializing base64 encoded favicon data twice

bruns added a comment. Ping! REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D19963 To: bruns, #plasma, broulik Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19963: Avoid serializing base64 encoded favicon data twice

bruns created this revision. bruns added reviewers: Plasma, broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. bruns requested review of this revision. REVISION SUMMARY The URL is ignored in case the image data is available. Avoid pushing it twice via DBus.

D18890: Add button to reset index database and repair Baloo crashing

bruns added a comment. In D18890#410137 , @davidedmundson wrote: > If we know the DB is corrupted, and it's just a cache, why do we need a user facing button? There are many possible ways of corruption: - non-decodable values -

D18890: Add button to reset index database and repair Baloo crashing

bruns added inline comments. INLINE COMMENTS > kcm.cpp:197 > +const QString rm = QStandardPaths::findExecutable(QStringLiteral("rm")); > +const QString balooctl = > QStandardPaths::findExecutable(QStringLiteral("balooctl")); > +const QString baloofile = >

D18890: Add button to reset index database and repair Baloo crashing

bruns added a comment. In D18890#409359 , @ngraham wrote: > Thanks! This is pretty good as-is, and I can confirm that it works just fine. However once the user presses the button, there's no further feedback, which could encourage them to

[kio-extras] [Bug 329687] previewing an HTML file from a local file system causes network retrievals while generating the thumbnail

https://bugs.kde.org/show_bug.cgi?id=329687 Stefan Brüns changed: What|Removed |Added CC||stefan.bruens@rwth-aachen.d

D16410: [Bookmarks Runner] Avoid leaking FetchSqlite instances

This revision was automatically updated to reflect the committed changes. Closed by commit R120:9e90fdd2a593: [Bookmarks Runner] Avoid leaking FetchSqlite instances (authored by bruns). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D16409: [Bookmarks Runner] Open database connection in the query thread

This revision was automatically updated to reflect the committed changes. Closed by commit R120:145caeac1050: [Bookmarks Runner] Open database connection in the query thread (authored by bruns). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D16405: Add debug category for bookmarks runner

This revision was automatically updated to reflect the committed changes. Closed by commit R120:62804f6becb9: Add debug category for bookmarks runner (authored by bruns). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16405?vs=44164=45352 REVISION

D16404: [Bookmarks Runner] Cleanup tests CMakeList

This revision was automatically updated to reflect the committed changes. Closed by commit R120:5ba0a08b8312: [Bookmarks Runner] Cleanup tests CMakeList (authored by bruns). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16404?vs=44161=45351

D16530: Drop X11 core fonts code from startkde/startplasma

This revision was automatically updated to reflect the committed changes. Closed by commit R120:5374513266ee: Drop X11 core fonts code from startkde/startplasma (authored by bruns). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16530?vs=44499=45152

D16404: [Bookmarks Runner] Cleanup tests CMakeList

bruns added a comment. Anyone? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D16404 To: bruns, #frameworks Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16530: Drop X11 core fonts code from startkde/startplasma

bruns added a comment. In D16530#355078 , @fvogt wrote: > Looks good to me, but I don't know enough about old X11 stuff like this to accept it. @fvogt - maybe you can poke a coworker? Someone else? REPOSITORY R120 Plasma

D16530: Drop X11 core fonts code from startkde/startplasma

bruns added a comment. Friendly reminder ... REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D16530 To: bruns, #plasma, fvogt, davidedmundson Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16404: [Bookmarks Runner] Cleanup tests CMakeList

bruns added a comment. Ping! REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D16404 To: bruns, #frameworks Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16530: Drop X11 core fonts code from startkde/startplasma

bruns created this revision. bruns added reviewers: Plasma, fvogt. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. bruns requested review of this revision. REVISION SUMMARY Qt and GTK based applications have switched to using fontconfig for fonts exclusively, so this

D12498: Fully remove `Application Name` from Details panel

This revision was automatically updated to reflect the committed changes. Closed by commit R121:eb9c4c080427: Fully remove `Application Name` from Details panel (authored by sharvey, committed by bruns). REPOSITORY R121 Policykit (Polkit) KDE Agent CHANGES SINCE LAST UPDATE

D16417: Improve replacement text when action description is not provided

This revision was automatically updated to reflect the committed changes. Closed by commit R121:9cf71f424950: Improve replacement text when action description is not provided (authored by bruns). REPOSITORY R121 Policykit (Polkit) KDE Agent CHANGES SINCE LAST UPDATE

D16417: Improve replacement text when action description is not provided

bruns added inline comments. INLINE COMMENTS > ngraham wrote in AuthDialog.cpp:359 > I would prefer "not available" over "not provided", but I won't choose this > as my hill to die on. :) > > Do we actually need to repeat the word 'Description' here? Btw, "not provided" is your own proposal

D15885: Clean UI file for `details` portion of UI

bruns abandoned this revision. bruns added a comment. Folded back into D12498 REPOSITORY R121 Policykit (Polkit) KDE Agent REVISION DETAIL https://phabricator.kde.org/D15885 To: bruns, ngraham, davidedmundson, sharvey Cc: bruns, plasma-devel,

  1   2   3   >