D24893: [Lock Screen] Add option to hide clock when idle

2019-11-12 Thread Thomas Pfeiffer
colomar added a comment. In D24893#558506 , @ngraham wrote: > In D24893#558451 , @mart wrote: > > > clock "always show" is fine too tough > > > Given that the setting will be off by default,

D18817: Updated documentation (mention of QQuickControls, link to HIG, IRC channel, supported platforms)

2019-02-07 Thread Thomas Pfeiffer
This revision was automatically updated to reflect the committed changes. Closed by commit R169:1dc931ec70c5: Updated documentation (mention of QQuickControls, link to HIG, IRC channel… (authored by colomar). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE

D18817: Updated documentation (mention of QQuickControls, link to HIG, IRC channel, supported platforms)

2019-02-07 Thread Thomas Pfeiffer
colomar created this revision. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. colomar requested review of this revision. REPOSITORY R169 Kirigami BRANCH update-docs (branched from master) REVISION DETAIL https://phabricator.kde.org/D18817 AFFECTED FILES

D17177: Drop tab-based UI for the about page

2018-11-27 Thread Thomas Pfeiffer
colomar added a comment. Integrating it in one page is definitely an improvement! Some detailed comments (I am aware that those things introduced with this layout change, they just become apparent now): 1. "About" at the top of the page and "About Discover..." are redundant. I'd

D13593: [Fonts KCM] Improve user-friendliness of some anti-aliasing strings

2018-07-15 Thread Thomas Pfeiffer
colomar added a comment. So, first (and perhaps for me only one this time) guerilla test: Participant: - Plasma user for several years (because I recommended it to her) - Frequent but generally mostly "non-technical" computer user - Uses Plasma in English but isn't a native English

D14025: Move scale and unify button to the top, next to primary combo

2018-07-13 Thread Thomas Pfeiffer
colomar added a comment. In D14025#291499 , @davidedmundson wrote: > It (currently) depends. There are two scale UI options with the appropriate one visible. > > The global scale factor for X is the only one that's moved. Ah, cool,

D14025: Move scale and unify button to the top, next to primary combo

2018-07-13 Thread Thomas Pfeiffer
colomar added a comment. The Unify Outputs button definitely makes sense to be there, but I'm not sure about the "Scale display" button. The "Primary display" selection and the Unify Outputs button both affect the whole setup, whereas Scale Display only affects the selected display,

D13593: [Fonts KCM] Improve user-friendliness of some anti-aliasing strings

2018-07-13 Thread Thomas Pfeiffer
colomar added a comment. I know that doing user research is not something favored here, but given how easy it is to use some user testing to settle discussions like this in a fact-based manner, I would really suggest the following: Each of us here who knows people that use English as their

D13334: When using a different background color, use highlightedText as text color

2018-06-04 Thread Thomas Pfeiffer
colomar added a comment. Perfect! REPOSITORY R169 Kirigami BRANCH master REVISION DETAIL https://phabricator.kde.org/D13334 To: apol, #kirigami, mart, ngraham Cc: colomar, ngraham, plasma-devel, apol, davidedmundson, mart, hein

D12091: HIG entry for On-demand pattern and swipe list item

2018-05-16 Thread Thomas Pfeiffer
colomar accepted this revision. colomar added a comment. Perfect! REPOSITORY R985 KDE Human Interface Guidelines BRANCH swipe REVISION DETAIL https://phabricator.kde.org/D12091 To: fabianr, colomar, mart, #kirigami Cc: plasma-devel, ngraham, mvourlakos, romangg, hpereiradacosta,

D12091: HIG entry for On-demand pattern and swipe list item

2018-05-16 Thread Thomas Pfeiffer
colomar added a comment. More concrete suggestion: Move the Dolphin screenshot to the top, next to the mobile screenshot. REPOSITORY R985 KDE Human Interface Guidelines BRANCH swipe REVISION DETAIL https://phabricator.kde.org/D12091 To: fabianr, colomar, mart, #kirigami Cc:

D12091: HIG entry for On-demand pattern and swipe list item

2018-05-16 Thread Thomas Pfeiffer
colomar added a comment. Currently we have a screenshot of the nouseover in Dolphin in here, but screenshots for swipeListItem only in the corresponding page. That gives preference to the Dolphin pattern because lazy people will implement what they see first. Therefore there should either

D12091: HIG entry for On-demand pattern and swipe list item

2018-05-04 Thread Thomas Pfeiffer
colomar added inline comments. INLINE COMMENTS > fabianr wrote in ondemand.rst:27 > My intention was to suggest switching to a navigation pattern like > "Master-Detail" or "Column-based navigation", so each item has its own > content page where more actions could easily be displayed. > >

D12091: HIG entry for On-demand pattern and swipe list item

2018-05-04 Thread Thomas Pfeiffer
colomar added a comment. See inline comments. Otherwise it looks good! INLINE COMMENTS > ondemand.rst:27 > + on-demand controls. If you need more actions, choose a different > + :doc:`navigation pattern `. > +- Only use on-demand controls, if the actions are the same for each item.

Re: KDE and Google Summer of Code 2018

2018-01-22 Thread Thomas Pfeiffer
> On 22. Jan 2018, at 00:35, David Edmundson wrote: > > > > On Sun, Jan 21, 2018 at 7:25 PM, Albert Astals Cid > wrote: > El divendres, 19 de gener de 2018, a les 10:42:44 CET, Marco Martin va > escriure: > > On Mon, Jan 15,

D9974: Improve header and metadata display

2018-01-19 Thread Thomas Pfeiffer
colomar accepted this revision. colomar added a comment. This is a clear improvement from my perspective, and I don't see it introducing any usability issues. REPOSITORY R134 Discover Software Store BRANCH combobox-to-choose-source REVISION DETAIL https://phabricator.kde.org/D9974

D9976: Display version alongside source, and use a combobox to switch between them

2018-01-19 Thread Thomas Pfeiffer
colomar added a comment. I think that when at the bottom, having the combobox is okay because it's not too prominent. The only problem I see is that it means that changing a combobox changes the content above it, which is not usually expected behavior for a combobox. REPOSITORY R134

D9976: Display version alongside source, and use a combobox to switch between them

2018-01-19 Thread Thomas Pfeiffer
colomar added a comment. I think this is a significant improvement. I'm not sure if it's ideal to have the re-layout of the whole page together with the change to the combo box in the same patch, but that's for @apol to decide. REPOSITORY R134 Discover Software Store REVISION DETAIL

D9792: even slimmer scrollbars

2018-01-14 Thread Thomas Pfeiffer
colomar added a comment. Dunno why I only noticed it now, but of course then this is not the right place to fix it. Sorry for the noise. REPOSITORY R31 Breeze BRANCH arcpatch-D9792 REVISION DETAIL https://phabricator.kde.org/D9792 To: mart, #plasma, #kirigami, #vdg, hpereiradacosta,

D9792: even slimmer scrollbars

2018-01-13 Thread Thomas Pfeiffer
colomar added a comment. Looks great! My only concern would be that in the mouseover state the contrast between the grip and groove is quite low. This could make the two difficult to distinguish, especially for color blind users. Could perhaps the contrast in terms of brightness be

D9542: Improve display of technical app info

2017-12-30 Thread Thomas Pfeiffer
colomar added a comment. This layout makes more sense to me as well overall. The only thing that I find a bit strange is that the summary now looks a bit like a headline, especially given that the application name is in the toolbar instead of the content area. I'm wondering if we should

D8939: Offset the scrollbar by the header size

2017-11-22 Thread Thomas Pfeiffer
colomar added a comment. Looking great! REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D8939 To: apol, #kirigami, mart, ngraham, abetts Cc: colomar, plasma-devel, apol, davidedmundson, mart, hein

D7905: Remove launch feature from hamburger button and restore to the toolbar

2017-09-21 Thread Thomas Pfeiffer
colomar added a comment. Yes, I totally agree. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D7905 To: ngraham, apol, #discover_software_store Cc: colomar, jensreuterberg, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, abetts, sebas,

D7905: Remove launch feature from hamburger button and restore to the toolbar

2017-09-21 Thread Thomas Pfeiffer
colomar added a comment. Application Dashboard in Plasma initially shows recent applications by default (which makes a ton of sense!). Maybe it could make sense to insert newly-installed applications in there? REPOSITORY R134 Discover Software Store REVISION DETAIL

D7905: Remove launch feature from hamburger button and restore to the toolbar

2017-09-21 Thread Thomas Pfeiffer
colomar added a comment. Don't worry: After many years working as a usability consultant and UX designer, I know that I have to distinguish between my own needs and user needs. If our users have trouble launching applications, then placing a launch button in Discover is _not_ the

D7905: Remove launch feature from hamburger button and restore to the toolbar

2017-09-21 Thread Thomas Pfeiffer
colomar added a comment. In https://phabricator.kde.org/D7905#147514, @jensreuterberg wrote: > The hamburger menu was my suggestion so I should probably say something about it - for me the "launch" option is completely meaningless fluff. Another button to nothing. That being said, if

Re: Videoconference between KDE community and Purism regarding Librem5

2017-09-05 Thread Thomas Pfeiffer
> On 5. Sep 2017, at 12:52, Sebastian Kügler wrote: > > Hi all, > > On maandag 4 september 2017 20:29:26 CEST Zlatan Todoric wrote: >> as Mak and me approached KDE community to discuss about potential >> collaboration between two sides we found very welcoming community that >>

Re: Plasma Mobile on the Librem 5 (please ignore previous two mails)

2017-09-02 Thread Thomas Pfeiffer
Hi Zlatan, please ignore my previous two mails mail to you which were both sent from the wrong address (sorry for that, new computer with no proper email client yet and GMail is terrible when it comes to multiple email addresses). On Sat, Sep 2, 2017 at 5:23 PM, Zlatan Todoric

Fwd: kubuntu 16-17, systemsettings, display with two monitors

2017-07-16 Thread Thomas Pfeiffer
Dear Plasma team, as requested, I forwarded the email below which was sent to the board mailing list to what I hope is the correct community. Cheers, Thomas -- Forwarded Message -- Subject: kubuntu 16-17, systemsettings, display with two monitors Date: Samstag, 15. Juli 2017,

D5429: Add option to focus some widgets only on keyboard input

2017-04-13 Thread Thomas Pfeiffer
colomar added a comment. It definitely should not be an option. Either it's better, then it goes in, or it isn't, then it doesn't. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D5429 To: mart, #plasma, hpereiradacosta Cc: hein, colomar, plasma-devel, progwolff,

D5429: Add option to focus some widgets only on keyboard input

2017-04-13 Thread Thomas Pfeiffer
colomar added a comment. Who has complained about this? Can we see the reports? REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D5429 To: mart, #plasma, hpereiradacosta Cc: colomar, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D5428: Add option to disable hover effects.

2017-04-13 Thread Thomas Pfeiffer
colomar added a comment. If it's most likely to be decided only on the distribution level, we don't necessarily need a GUI for switching it, do we? We could also just have it as an unexposed parameter in the config file. I think Breeze (like Oxygen) already has too many user-visible

D5339: Include a bottom toolbar for the application page

2017-04-08 Thread Thomas Pfeiffer
colomar added a comment. Version 2 (top toolbar, no colors) looks the best to me, with the downside that the install button does not stick out. If we go without colors, we'd probably at least need an icon for the install button to not make it totally blend with the rest. REPOSITORY R134

[Differential] [Commented On] D4838: [Notifications] Add context menu for thumbnail

2017-03-01 Thread Thomas Pfeiffer
colomar added a comment. Final comment: Do whatever makes sense, keep only the context menu if you like. I'm out. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4838 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

[Differential] [Commented On] D4838: [Notifications] Add context menu for thumbnail

2017-03-01 Thread Thomas Pfeiffer
colomar added a comment. In https://phabricator.kde.org/D4838#91404, @Fuchs wrote: > > As far as I was informed on IRC, as far as I can see in the very discussion here: context menus were discouraged. Ah right, that was a miscommunication on our side. I'd never

[Differential] [Commented On] D4838: [Notifications] Add context menu for thumbnail

2017-03-01 Thread Thomas Pfeiffer
colomar added a comment. In https://phabricator.kde.org/D4838#91286, @mart wrote: > i don't see the split button a very feasible option on a technical standpoint (and pretty bad purely on aestetics, would also be a thing we use only here and visually clashes with a combobox) If

[Differential] [Commented On] D4838: [Notifications] Add context menu for thumbnail

2017-03-01 Thread Thomas Pfeiffer
colomar added a comment. > Okay, personal opinion on why split buttons are among the most horrible things related to UX: > (And whilst some of these points might not apply to this very specific use case here: they will elsewhere, and once one component users this button, others

[Differential] [Commented On] D4838: [Notifications] Add context menu for thumbnail

2017-02-28 Thread Thomas Pfeiffer
colomar added a comment. In https://phabricator.kde.org/D4838#91004, @broulik wrote: > > Just as well or as badly as a regular "Open" button. If in this scenario you hide the Open button because it has no valid target, then of course there would be no split Open button, either. > >

[Differential] [Commented On] D4838: [Notifications] Add context menu for thumbnail

2017-02-28 Thread Thomas Pfeiffer
colomar added a comment. In https://phabricator.kde.org/D4838#91009, @subdiff wrote: > I thought of something like this: F2668672: Screenshot_20170228_114914.png > Is this in line with the HIG? That's the idea we've discussed above and

[Differential] [Commented On] D4838: [Notifications] Add context menu for thumbnail

2017-02-28 Thread Thomas Pfeiffer
colomar added a comment. In https://phabricator.kde.org/D4838#90994, @broulik wrote: > > A file manager has a menu bar, however, so the context menu is never the only means to execute an action. > > Dolphin does not by default. I don't see an "Open" or "Open With" action anywhere in

[Differential] [Commented On] D4838: [Notifications] Add context menu for thumbnail

2017-02-28 Thread Thomas Pfeiffer
colomar added a comment. > You don't have that in a file manager, either, and this thing represents a file. A file manager has a menu bar, however, so the context menu is never the only means to execute an action. I don't see how turning the Open button into a split button would

I've left the VDG group on Phabricator

2017-02-20 Thread Thomas Pfeiffer
Hi everyone, just a heads-up: I have just left the VDG group on Phabricator. This does not mean that I have a problem with the VDG or that I don’t identify as part of it anymore, but I have realized that I simply do not have the time and energy to keep up with the influx Phabricator requests

[Differential] [Updated] D4563: Replace warps-slider checkbox with radio buttons

2017-02-11 Thread Thomas Pfeiffer
colomar added a comment. I'm all for the change, obviously ;) Two small change suggestions: 1. left clicking -> left-clicking 2. Up/storm one page -> one page up/down REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D4563 EMAIL

[Differential] [Commented On] D4215: Make notifications execute the "default" action on click.

2017-01-24 Thread Thomas Pfeiffer
colomar added a comment. +1 from me, with clicking on a notification that does not define a default action doing nothing REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4215 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/

[Differential] [Commented On] D4215: Make notifications execute the "default" action on click.

2017-01-21 Thread Thomas Pfeiffer
colomar added a comment. Since there does not seem a clear "best solution", isn't this something that should be decided on a cross-desktop level? After all, it's not just about what users expect, but also what app developers can expect to happen with their notifications. REPOSITORY R120

[Differential] [Updated] D4215: Make notifications execute the "default" action on click.

2017-01-20 Thread Thomas Pfeiffer
colomar added a comment. In https://phabricator.kde.org/D4215#78928, @mck182 wrote: > > If you just want to close then you have the big X, no? > > That doesn't change the fact that the behavior of clicking the popup itself would change in an unpredictable way. One time it's close and

[Differential] [Commented On] D3815: [Task Manager] Add "Places" for entries belonging to a file manager

2016-12-27 Thread colomar (Thomas Pfeiffer)
colomar added a comment. Yes, that is certainly a downside. One idea could be to move it into a submenu if there are more than X entries (though I'm not sure yet which number to choose). The downside of that would be that people who often add and remove places might get confused by the

[Differential] [Commented On] D3815: [Task Manager] Add "Places" for entries belonging to a file manager

2016-12-26 Thread colomar (Thomas Pfeiffer)
colomar added a comment. To solve the problem of the context menu getting very long: How about putting the places in a submenu? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3815 EMAIL PREFERENCES

[Differential] [Commented On] D3790: RFC: [Lock Screen] Indicate keyboard layout when unlocking failed

2016-12-22 Thread colomar (Thomas Pfeiffer)
colomar added a comment. We always have to keep in mind that usind multiple layouts is an advanced feature used by a minority of users. Therefore, as long as a feature only becomes active when there are multiple layouts (and in this case only when multiple layouts are used _and_ the login

[Differential] [Commented On] D3756: [Folder View] Add "Restore" from trash option

2016-12-20 Thread colomar (Thomas Pfeiffer)
colomar added a comment. Yup, makes sense! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3756 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, #plasma:_design, hein Cc: colomar, plasma-devel,

[Differential] [Commented On] D3738: [Task Manager] Tooltips redesign

2016-12-19 Thread colomar (Thomas Pfeiffer)
colomar added a comment. Great improvements! Is the desktop / Activity only shown if - there are multiple ones and - the task manager shows tasks from different ones? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3738 EMAIL PREFERENCES

[Differential] [Commented On] D3616: [Lock Screen / Login] Add "reveal password button"

2016-12-10 Thread colomar (Thomas Pfeiffer)
colomar added a comment. +1 for the patch (I don't think the icon is close enough to the login button to be problematic) Also +1 for disabling "show password" buttons in general via Kiosk REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3616 EMAIL

[Differential] [Commented On] D3538: Drop resize animation when adding pages

2016-11-29 Thread colomar (Thomas Pfeiffer)
colomar added a comment. +1, definitely looks better to me (and Jens will love any killed animation, anyway ;) ) REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D3538 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol,

[Differential] [Commented On] D3539: [Notifications] Show interactive thumbnails on notifications

2016-11-29 Thread colomar (Thomas Pfeiffer)
colomar added a comment. Really nice! The single thumbnail might be a bit too large, as having large notification windows pop up could be irritating. Maybe half the size would be big enough? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3539 EMAIL

[Differential] [Commented On] D3210: make scrollbar size configurable

2016-11-15 Thread colomar (Thomas Pfeiffer)
colomar added a comment. I haven't had the chance to play with it and I think we should still have a plan B if we get negative feedback on it during beta tests, but the concept as it is described in the latest comments makes sense to me. REPOSITORY rBREEZE Breeze REVISION DETAIL

[Differential] [Commented On] D3210: make scrollbar size configurable

2016-11-10 Thread colomar (Thomas Pfeiffer)
colomar added a comment. In https://phabricator.kde.org/D3210#62062, @mart wrote: > > sorry for the late reply > ok, so if i understood correctly: > I'll remove those 2 options, and have instead both showing the scrollbar on hover *and* the scrollbar size depend

[Differential] [Commented On] D3210: make scrollbar size configurable

2016-11-07 Thread colomar (Thomas Pfeiffer)
colomar added a comment. Whoa okay, that is complex... Given that I failed to understand what the proposed checkboxes were supposed to mean, I fear it will be the same for users. Therefore maybe not gibing the option at all is indeed the better solution, and your suggestion to turn the

[Differential] [Commented On] D3268: Applet: Show device icons and active port name

2016-11-07 Thread colomar (Thomas Pfeiffer)
colomar added a comment. Great feature! I just fear that the naming scheme might make it look like the device name is the name for the port, like "A microphone called Audio Adapter". Maybe naming Port (device name) would make it more clear? REPOSITORY rPLASMAPA Plasma Audio Volume

[Differential] [Commented On] D3302: RFC: [Task Manager] Indicate applications playing audio

2016-11-07 Thread colomar (Thomas Pfeiffer)
colomar added a comment. Very useful patch! The only thing I'm unsure of is the three-second delay. It might be a bit too long if some annoying applicaiton suddenly starts blaring sound and the option to mute it easily only becomes available after three seconds of torture. I think two

[Differential] [Commented On] D3210: make scrollbar size configurable

2016-11-07 Thread colomar (Thomas Pfeiffer)
colomar added a comment. In https://phabricator.kde.org/D3210#60963, @hpereiradacosta wrote: > >> Why do we need both? What happens if one checks the first but not the second? > > You get a large scrollbar, visible only on mouse-over So that means it would be

[Differential] [Commented On] D3210: make scrollbar size configurable

2016-11-06 Thread colomar (Thomas Pfeiffer)
colomar added a comment. In https://phabricator.kde.org/D3210#60602, @mart wrote: > in this latest version there are 2 checkboxes: "show scrollbar only on mouse over" and "small scrollbar" which both defautls to true Why do we need both? What happens if one checks the first

[Differential] [Commented On] D3210: make scrollbar size configurable

2016-11-03 Thread colomar (Thomas Pfeiffer)
colomar added a comment. If I understood it correctly (that there is only a checkbox "Only show full scrollbar on mouse over" added to the config) then that is exactly what I had in mind. REPOSITORY rBREEZE Breeze REVISION DETAIL https://phabricator.kde.org/D3210 EMAIL PREFERENCES

[Differential] [Commented On] D3210: make scrollbar size configurable

2016-11-02 Thread colomar (Thomas Pfeiffer)
colomar added a comment. It does make sense to me to give the option to turn the slim scroll bar as such on and off. I can imagine some people being uncomfortable with the animation on mouseover. Being able to configure individual parameters is probably overkill, however. REPOSITORY

[Differential] [Commented On] D3156: WIP: Application Menu applet

2016-10-29 Thread colomar (Thomas Pfeiffer)
colomar added a comment. Our users will be very happy about this being back! I agree that there needs to be some way to access it via keyboard. Pressing alt to shift keyboard focus to the menu bar sounds like a good idea, if pressing alt again shifts it back to the window content again.

[Differential] [Commented On] D2314: Context Menu to Mute, Set Default Sink/Source, Active Port

2016-10-29 Thread colomar (Thomas Pfeiffer)
colomar added a comment. Sorry for not replying earlier. There is nothing that speaks against offering this context menu. However, all the actions in the context menu must be available in the main UI as well. Due to discoverability reasons, context menus must never be the only way to

Re: System Settings - Network -> Connectivity

2016-10-11 Thread Thomas Pfeiffer
Hi, just a heads up, I started working (again) on a new KCM for network configuration, this time I decided to make it simple, just implement it similar to the editor, with just a bit nicer UI. We can always add features and changes in future, but right now I think that the most important part

[Differential] [Commented On] D3011: [SDDM Theme] Show caps lock warning

2016-10-10 Thread colomar (Thomas Pfeiffer)
colomar added a comment. +1 for the change! I think the string for failed unlock while capslock is on should be "Login failed (Caps lock is on)" though, as the "login failed" part is the more important one. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL

[Differential] [Changed Subscribers] D2957: [SDDM Theme] Offer switching to the user's session if there is one

2016-10-06 Thread colomar (Thomas Pfeiffer)
colomar added a subscriber: graesslin. colomar added a comment. > Also it really needs to be a config option somewhere. People do multiple login. We made LightDM reuse sessions and got tonnes of comments. @graesslin said he'd prefer to block multiple login with the same user due to all

[Differential] [Commented On] D2957: [SDDM Theme] Offer switching to the user's session if there is one

2016-10-06 Thread colomar (Thomas Pfeiffer)
colomar added a comment. Definitely a good change! Suggestion as for when to release: One way we could go about it is see whether we get bug reports about the current behavior. If users perceive it as a bug, we release this as a bugfix, otherwise it goes into 5.9. REPOSITORY

[Plasma Workspace Wallpapers] [Bug 365761] Get Hot New Stuff for Wallpaper not working

2016-10-05 Thread Thomas Pfeiffer via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=365761 Thomas Pfeiffer <thomas.pfeif...@kde.org> changed: What|Removed |Added Version Fixed In||KF

[Differential] [Commented On] D2944: [TabBox] Switch between windows with mouse wheel

2016-10-05 Thread colomar (Thomas Pfeiffer)
colomar added a comment. Behavior sounds sensible, wrapping around would make sense, though. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2944 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik,

Re: Review Request 129048: Look and Feel -> Global Theme

2016-09-27 Thread Thomas Pfeiffer
sound nice, but explains what it does. - Thomas Pfeiffer On Sept. 27, 2016, 10:19 a.m., Andreas Kainz wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.review

Re: A Plasma Vision draft

2016-09-26 Thread Thomas Pfeiffer
On 26.09.2016 13:27, Olivier Churlaud wrote: Hi, Sorry if I come late, I wasn't aware of this thread... Le lundi 26 septembre 2016, 12:56:25 CEST Jens Reuterberg a écrit : "Plasma is for people using a computing device in a professional context, where productivity, performance and privacy are

[Powerdevil] [Bug 369181] User session security vulnerability from screen lock being suppressed with power management

2016-09-23 Thread Thomas Pfeiffer via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=369181 Thomas Pfeiffer <thomas.pfeif...@kde.org> changed: What|Removed |Added CC||thomas

[Differential] [Commented On] D2741: [Window Switcher] Cleanup

2016-09-13 Thread colomar (Thomas Pfeiffer)
colomar added a comment. I've just asked the other VDG members for their take on the font size. Since this is not a big issue either way, the patch is fine to go in anyway. If the VDG decides we'd like the font to be smaller, it would be nice if it could be changed in another patch.

Re: Plasma 5.8 and look and feel layouts

2016-09-13 Thread Thomas Pfeiffer
On 13.09.2016 13:12, Marco Martin wrote: On Tuesday 13 September 2016 11:30:49 Thomas Pfeiffer wrote: On 13.09.2016 11:06, David Edmundson wrote: If we can fix the issues before the release, why hold it back? The first release is in two days. Yes, the beta release, which is there to identify

Re: Plasma BOF Notes

2016-09-13 Thread Thomas Pfeiffer
On 13.09.2016 12:24, David Edmundson wrote: - new LTS every 18 months when the previous one ends While this of course makes sense from Plasma's side, it could be a problem for those who rely on LTS. There is a reason why distros usually have quite some overlap between the support cycles of

Re: Plasma 5.8 Errata

2016-09-13 Thread Thomas Pfeiffer
On 13.09.2016 12:22, Martin Graesslin wrote: Sorry, but I have seen enough bug reports set to critical and priority very high by the user. As long as users can modify that we will have stupidly set up bug reports. Wait, ordinary users can change the priority field??? That makes literally _no_

Re: Plasma 5.8 Errata

2016-09-13 Thread Thomas Pfeiffer
On 13.09.2016 07:52, Martin Graesslin wrote: On Monday, September 12, 2016 12:55:22 PM CEST Jonathan Riddell wrote: I've copied over the 5.7 Errata page for 5.8 Do we still have issues with Intel GPUs? Are there still freezes with Qt 5.6? Are the bugs marked critical still critical? I

Re: Plasma 5.8 and look and feel layouts

2016-09-13 Thread Thomas Pfeiffer
On 13.09.2016 11:06, David Edmundson wrote: > If we can fix the issues before the release, why hold it back? The first release is in two days. Yes, the beta release, which is there to identify and fix bugs, right? Of course the question is: Does the team consider the feature to be stable

[Differential] [Commented On] D2584: Introduce a config option whether applications are allowed to block compositing

2016-09-12 Thread colomar (Thomas Pfeiffer)
colomar added inline comments. INLINE COMMENTS > compositing.ui:291 > + This brings performance improvement for e.g. games. > + The setting can be overruled by window specific rules. > + window-specific REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D2584 EMAIL

[Differential] [Commented On] D2753: [Screen Locker KCM] Put Wallpaper in a separate tab

2016-09-12 Thread colomar (Thomas Pfeiffer)
colomar added a comment. In https://phabricator.kde.org/D2753#51248, @broulik wrote: > Because that's an idea Martin and I had a while ago iirc. And also I don't see how we could make this one scrolling page, since it's a QML thing with a ScrollView embedded in a widget environment.

[Differential] [Commented On] D2753: [Screen Locker KCM] Put Wallpaper in a separate tab

2016-09-12 Thread colomar (Thomas Pfeiffer)
colomar added a comment. In https://phabricator.kde.org/D2753#51234, @mart wrote: > as far i know the guidelines for new kcms are no tabs? Indeed the idea was to use a longer, scrolling page instead of tabs, combined with expanding sections for advanced settings. What made

Re: Plasma 5.8 and look and feel layouts

2016-09-12 Thread Thomas Pfeiffer
On 11.09.2016 22:49, Łukasz Sawicki wrote: Hi, In the last week I tested a new Plasma 5.8 feature "Look and feel layouts" to have something for our Plasma 5.8 promo materials. Let me share some experiences here. 1. Random crashes (especially when I switch "Look and feel layouts" for the first

[Differential] [Commented On] D2580: possible to use OverlaySheet with ListView

2016-09-12 Thread colomar (Thomas Pfeiffer)
colomar added a comment. There is always still the possibility to use one of the Action Buttons as a close button (as shown in the Gallery) if it gets too long to easily swipe away. REPOSITORY rKIRIGAMI Kirigami BRANCH phab/listviewsheet REVISION DETAIL

[Differential] [Commented On] D2580: possible to use OverlaySheet with ListView

2016-09-12 Thread colomar (Thomas Pfeiffer)
colomar added a comment. There is always still the possibility to use one of the Action Buttons as a close button (as shown in the Gallery) if it gets too long to easily swipe away. REPOSITORY rKIRIGAMI Kirigami BRANCH phab/listviewsheet REVISION DETAIL

[Differential] [Commented On] D2383: [Notifications] Add "Clear Notifications" context menu entry

2016-09-11 Thread colomar (Thomas Pfeiffer)
colomar added a comment. In https://phabricator.kde.org/D2383#50991, @andreaska wrote: > ordinary I had more often the problem that the notification stuff is empty but I'd like to know what happend in the past. > > most of the time I see no new notification but I'd like to see the

[Differential] [Commented On] D1771: [Workspace Options] Add option to disable OSD

2016-09-11 Thread colomar (Thomas Pfeiffer)
colomar added a comment. In https://phabricator.kde.org/D1771#50973, @broulik wrote: > Can we have something more concise than "Visual feedback (On-Screen Display) for status changes not triggered via a graphical user interface". Perhaps just "Visual feedback for status changes"?

[Differential] [Commented On] D2383: [Notifications] Add "Clear Notifications" context menu entry

2016-09-11 Thread colomar (Thomas Pfeiffer)
colomar added a comment. Okay, let's stick with the context menu for now and see if we can find a good place in the popup at some point. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2383 EMAIL PREFERENCES

[Differential] [Commented On] D2741: [Window Switcher] Cleanup

2016-09-11 Thread colomar (Thomas Pfeiffer)
colomar added a comment. Why is the font for the window titles so large? I don't really see much benefit from that... REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2741 EMAIL PREFERENCES

[Differential] [Commented On] D2610: Make icon follow styleHints

2016-08-30 Thread colomar (Thomas Pfeiffer)
colomar added a comment. > What you say does make sense, but I'd like to note that in KDE4 they did respect the single-/double-click settings (when on the desktop, not in the panel), so this can be seen as "regression" in Plasma5. I'd call it an improvement, actually, because now it

[Differential] [Commented On] D2610: Make icon follow styleHints

2016-08-30 Thread colomar (Thomas Pfeiffer)
colomar added a comment. The only raison d'être for "double-click to open" is to be able to select on single click. If selecting is not possible (as is the case both in the panel and in a desktop containment), there is no reason for opening only on double-click (other than consistency with

Re: Review Request 128793: [kio_mtp] Improve warning message

2016-08-30 Thread Thomas Pfeiffer
tings"? We probably can't go more specific than that because different OEMs may have worded the option differently. - Thomas Pfeiffer On Aug. 29, 2016, 5:44 p.m., Elvis Angelaccio wrote: > > --- > This is an automatically generat

[Differential] [Commented On] D2584: Introduce a config option whether applications are allowed to block compositing

2016-08-26 Thread colomar (Thomas Pfeiffer)
colomar added a comment. In https://phabricator.kde.org/D2584#48381, @broulik wrote: > Plasma is the only major desktop environment that still supports a non-composited uscase. Unity and Gnome cannot disable it in the first place. Oh, so they just ignore that request from

[Differential] [Commented On] D2584: Introduce a config option whether applications are allowed to block compositing

2016-08-26 Thread colomar (Thomas Pfeiffer)
colomar added a comment. Actually, I'm not really convinced of this. Blocking compositing is done via an official, cross-desktop API, isn't it? It's not a KWin-specific feature, right? If so, then KWin should not go alone in offering this config option. If I'm an application developer and

[Differential] [Updated] D2524: New User Switcher

2016-08-23 Thread colomar (Thomas Pfeiffer)
colomar added a project: VDG. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2524 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma, mart Cc: mart, plasma-devel, lesliezhai, ali-mohamed,

[Differential] [Commented On] D2523: New lockscreen

2016-08-23 Thread colomar (Thomas Pfeiffer)
colomar added a comment. Please tag all diffs with UI changes with VDG to make sure we learn about them. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2523 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

[Differential] [Updated] D2523: New lockscreen

2016-08-23 Thread colomar (Thomas Pfeiffer)
colomar added a project: VDG. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2523 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma, mart Cc: mart, plasma-devel, lesliezhai, ali-mohamed,

Re: Selecting a Plasma logo

2016-08-22 Thread Thomas Pfeiffer
On 22.08.2016 23:59, Ivan Čukić wrote: I'll chime in as well. First of all the main problem I have with this 'searching for the new logo' is that we are not really searching for the new Plasma logo, but an icon that could replace the k-gear one Yes, this is indeed a problem. Originally we were

[Differential] [Commented On] D2525: RFC: Make Switch User option invoke the switch user UI in the lockscreen

2016-08-22 Thread colomar (Thomas Pfeiffer)
colomar added a comment. Big +1, yay for consistency! REPOSITORY rKSCREENLOCKER KScreenLocker REVISION DETAIL https://phabricator.kde.org/D2525 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma Cc: colomar, mart, graesslin,

  1   2   3   4   5   6   >