Re: The usage statistics [kactivities, baloo, ktp, plasma]

2014-10-21 Thread Vishesh Handa
? -- Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: The usage statistics [kactivities, baloo, ktp, plasma]

2014-10-21 Thread Vishesh Handa
On Tue, Oct 21, 2014 at 9:58 PM, Eike Hein h...@kde.org wrote: On 10/21/2014 07:27 PM, Vishesh Handa wrote: Who else? Kicker. Ivan also has his Lancelot launcher in develop- ment as I understand it. Could you perhaps talk about possible workflows and how this would be displayed

Re: The usage statistics [kactivities, baloo, ktp, plasma]

2014-10-21 Thread Vishesh Handa
On Tue, Oct 21, 2014 at 10:48 PM, Vishesh Handa m...@vhanda.in wrote: So basically a filter on top of the global list of recently used documents? Yes - it was suggested a few times to subdivide Recent Documents into content type groups like text documents and videos to get to the goal

Re: The usage statistics [kactivities, baloo, ktp, plasma]

2014-10-21 Thread Vishesh Handa
with this is that the snapshots should be *very* frequent then. The cool thing about btfs snapshots is that even if they are frequent the don't consume any space, and are automatically deleted if the user starts using more space. Anyway, we probably should not discussing btrfs stuff. -- Vishesh

Re: Review Request 120623: LocationRunner: Convert case insensitive path to a proper one

2014-10-20 Thread Vishesh Handa
--- Bug fixed. Thanks, Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: The usage statistics [kactivities, baloo, ktp, plasma]

2014-10-20 Thread Vishesh Handa
understand all of the math, but this sounds quite ideal. Currently in KRunner we have a global run count which affects the score of all the result, and that score doesn't degrade over time. This seems like something nice to replace it with, if we can make it super fast that is. -- Vishesh Handa

Re: Review Request 120623: LocationRunner: Convert case insensitive path to a proper one

2014-10-17 Thread Vishesh Handa
--- On Oct. 17, 2014, 3:32 p.m., Vishesh Handa wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120623

Re: Baloo - Not Indexing everything by default

2014-10-17 Thread Vishesh Handa
a TODO about this to todo.kde.org. Hopefully, we can get a more advanced new comer to try and hack on this. -- Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Baloo - Not Indexing everything by default

2014-10-16 Thread Vishesh Handa
and Music. All of these are xdg user directories. Gnome Tracker actually does something quite similar. Comments? -- Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120550: Use the same strategy as FrameSvgItem and IconItem in QIconItem

2014-10-14 Thread Vishesh Handa
On Oct. 13, 2014, 1:35 p.m., Marco Martin wrote: src/quickaddons/managedtexturenode.h, line 52 https://git.reviewboard.kde.org/r/120550/diff/2/?file=318205#file318205line52 even if will always remain just this member, just to me sure, it should be in a dpointer Aleix Pol

Re: Review Request 120550: Use the same strategy as FrameSvgItem and IconItem in QIconItem

2014-10-14 Thread Vishesh Handa
://git.reviewboard.kde.org/r/120550/#comment47668 Strange indentation. - Vishesh Handa On Oct. 13, 2014, 5:54 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120550

Re: Review Request 120524: Let Search Folder Updater's name match by X-KDE-DBus-ModuleName and desktop file name

2014-10-08 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120524/#review68075 --- Ship it! Ship It! - Vishesh Handa On Oct. 7, 2014, 6:39

Re: Collecting new/improved stuff in 5.1 for promo

2014-10-01 Thread Vishesh Handa
and will listen to changes on xattr for files. This means any application can set the tags/ratings by just setting the xattr of the file. Applications no longer need to talk to Baloo. * Overall speed improvements * Many more tests in the File Indexers -- Vishesh Handa

Re: Review Request 120419: [ksmserver] Get rid of KDELibs4Support...

2014-09-29 Thread Vishesh Handa
, and the loading of KDELibs4Support was making a difference. - Vishesh Handa On Sept. 29, 2014, 10:50 a.m., Hrvoje Senjan wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120419

Re: Moving kde:muon repository to kde/workspaces

2014-09-26 Thread Vishesh Handa
+1 -- Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120235: restore ResizeOrigin

2014-09-18 Thread Vishesh Handa
this patch. Feel free to commit it. I'll try it out later. - Vishesh Handa On Sept. 17, 2014, 4:53 p.m., Marco Martin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120235

Re: Review Request 120235: restore ResizeOrigin

2014-09-17 Thread Vishesh Handa
which we can easily follow. - Vishesh Handa On Sept. 16, 2014, 3:52 p.m., Marco Martin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120235

Re: Review Request 120235: restore ResizeOrigin

2014-09-17 Thread Vishesh Handa
when the mainItem could be 0. Could you please add an assert in syncToMainItemSize for checking the mainItem. - Vishesh Handa On Sept. 17, 2014, 2:32 p.m., Marco Martin wrote: --- This is an automatically generated e-mail

Re: Initial standalone Plasma::Package repository

2014-09-17 Thread Vishesh Handa
and deprecated would clash) Just to confirm - With this, the package class in plasma-framework will now be deprecated? -- Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 120235: restore ResizeOrigin

2014-09-17 Thread Vishesh Handa
On Sept. 17, 2014, 2:54 p.m., Vishesh Handa wrote: src/plasmaquick/dialog.cpp, line 301 https://git.reviewboard.kde.org/r/120235/diff/2/?file=312805#file312805line301 Would this actually do anything? resizeOrigin = MainItem; // do stuff which changes the size

Re: Review Request 120235: restore ResizeOrigin

2014-09-17 Thread Vishesh Handa
it. src/plasmaquick/dialog.cpp https://git.reviewboard.kde.org/r/120235/#comment46562 ditto - Vishesh Handa On Sept. 17, 2014, 4:03 p.m., Marco Martin wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 120235: restore ResizeOrigin

2014-09-16 Thread Vishesh Handa
} } What do you think should be happening in this case? It's not obvious. I propose we make the mainItem responsible for the dialog size. The 'width' and 'height' properties of the Dialog can be made read only. - Vishesh Handa On Sept. 16, 2014, 3:52 p.m., Marco Martin wrote

Re: Review Request 120235: restore ResizeOrigin

2014-09-16 Thread Vishesh Handa
On Sept. 16, 2014, 4:08 p.m., Vishesh Handa wrote: We currently have the following ways of changing the dialog size 1. By changing the mainItem size 2. By actually changing the size of the dialog via QML 3. Window Managers (3) is not something that is exposed to the user since

Re: Review Request 119945: Dialog: Simplify handling of min/max width/height changed

2014-08-28 Thread Vishesh Handa
f207f88 src/plasmaquick/dialog.cpp 02271e4 Diff: https://git.reviewboard.kde.org/r/119945/diff/ Testing --- Thanks, Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 119945: Dialog: Simplify handling of min/max width/height changed

2014-08-26 Thread Vishesh Handa
/119945/diff/ Testing --- Thanks, Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Minutes Monday Plasma Hangout

2014-08-11 Thread Vishesh Handa
On Mon, Aug 11, 2014 at 12:40 PM, Sebastian Kügler se...@kde.org wrote: Antonis: - finished port of PA's widget explorer and containment - New resource indexer based on Baloo merged Could someone please elaborate on this? I'm not sure what a resource indexer means. -- Vishesh Handa

Re: Review Request 119602: support config dialog with current krunner config dialog

2014-08-05 Thread Vishesh Handa
On Aug. 5, 2014, 9:44 a.m., Vishesh Handa wrote: kcms/runners/kcm.cpp, line 60 https://git.reviewboard.kde.org/r/119602/diff/3/?file=295947#file295947line60 I'm fairly certain this is going to look bad on my hidpi screen. KIconLoader::SizeMedium is hardcoded to 32. I'm

Re: Review Request 119617: Plasma Mobile: Introduce org.kde.plasma.baloodatamodel

2014-08-05 Thread Vishesh Handa
On Aug. 5, 2014, 12:29 p.m., Marco Martin wrote: components/baloodatamodel/baloodatamodel.cpp, line 116 https://git.reviewboard.kde.org/r/119617/diff/1/?file=296386#file296386line116 maybe this should be done in a thread? I named the method exec so that it was clear it might block

Re: Review Request 119617: Plasma Mobile: Introduce org.kde.plasma.baloodatamodel

2014-08-05 Thread Vishesh Handa
On Aug. 5, 2014, 12:29 p.m., Marco Martin wrote: two things: * perhaps the query should still be executed in a thread * maybe the syntax from qml would be nicer if the query is in a sub object to have something like: BalooModel { query { type: File/Image

Re: Review Request 119602: support config dialog with current krunner config dialog

2014-08-05 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119602/#review63860 --- Ship it! - Vishesh Handa On Aug. 5, 2014, 10:50 a.m

Re: Review Request 119617: Plasma Mobile: Introduce org.kde.plasma.baloodatamodel

2014-08-05 Thread Vishesh Handa
not really Plasma specific. - Vishesh Handa On Aug. 5, 2014, 12:22 p.m., Antonis Tsiapaliokas wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119617

Re: Review Request 119617: Plasma Mobile: Introduce org.kde.plasma.baloodatamodel

2014-08-05 Thread Vishesh Handa
On Aug. 5, 2014, 2:17 p.m., Vishesh Handa wrote: I think the Baloo repo might a better place for code. It's not really Plasma specific. Marco Martin wrote: import org.kde.baloo in the baloo repo with this class and eventually others? would you do it just as an import

Re: Review Request 119617: Plasma Mobile: Introduce org.kde.plasma.baloodatamodel

2014-08-05 Thread Vishesh Handa
On Aug. 5, 2014, 12:29 p.m., Marco Martin wrote: components/baloodatamodel/baloodatamodel.cpp, line 116 https://git.reviewboard.kde.org/r/119617/diff/1/?file=296386#file296386line116 maybe this should be done in a thread? Vishesh Handa wrote: I named the method exec so

Re: Review Request 119602: support config dialog with current krunner config dialog

2014-08-04 Thread Vishesh Handa
a proper enum. - Vishesh Handa On Aug. 4, 2014, 12:26 p.m., Marco Martin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119602

Re: Review Request 119557: use kpluginselector for enabling runners

2014-08-04 Thread Vishesh Handa
On Aug. 1, 2014, 4:28 p.m., Vishesh Handa wrote: Nope. You're now listing plugins instead of listing categories. Marco Martin wrote: ook, but this gives a couple of problems Only giving possibility of enabling and disabling categories, altough it kinda makes sense, makes

Re: Review Request 119602: support config dialog with current krunner config dialog

2014-08-04 Thread Vishesh Handa
On Aug. 4, 2014, 2:37 p.m., Vishesh Handa wrote: It would be nice if you could upload a screenshot. Marco Martin wrote: done. and yep, i know it looks completely screwed at the moment :) (not exactly sure why the button is so much off center vertically) it all needs way more

Re: Review Request 119602: support config dialog with current krunner config dialog

2014-08-04 Thread Vishesh Handa
://git.reviewboard.kde.org/r/119602/#comment44469 Please use !isEmpty() instead - Vishesh Handa On Aug. 4, 2014, 5:02 p.m., Marco Martin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r

Re: Review Request 119557: use kpluginselector for enabling runners

2014-08-01 Thread Vishesh Handa
categories. - Vishesh Handa On Aug. 1, 2014, 1 p.m., Marco Martin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119557

Re: Review Request 107869: Add a real konquerorsessions plugin for krunner

2014-07-29 Thread Vishesh Handa
Attachment: the patch - 0002-Add-a-real-konquerorsessions-plugin_1.patch https://git.reviewboard.kde.org//r/107869/#fcomment230 I don't really understand the whole kate comment. - Vishesh Handa On Dec. 23, 2012, 12:27 p.m., Jekyll Wu wrote

Re: Review Request 107868: Rename krunner plugin konquerorsessions to konquerorprofiles to match what it really does

2014-07-29 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/107868/#review63408 --- Jekyll, ping? - Vishesh Handa On Dec. 31, 2012, 7:12 p.m

Re: Review Request 107881: Rename krunner plugin konsolesessions to konsoleprofiles

2014-07-29 Thread Vishesh Handa
suggested? - Vishesh Handa On Dec. 31, 2012, 6:58 p.m., Jekyll Wu wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/107881

Re: Reviews

2014-07-29 Thread Vishesh Handa
. If someone from PMC pings me I can help go through and discard outdated things. David Hey guys How about we get a separate group for PMC? It's is a separate mature project after all. The review request emails can still continue coming on the plasma-devel mailing list. -- Vishesh Handa

Re: Minutes Monday Plasma Hangout

2014-07-14 Thread Vishesh Handa
On Jul 14, 2014 1:02 PM, Sebastian Kügler se...@kde.org wrote: Sebastian: - last bits of work on release promo, join #kde-promo to help out - long video: https://www.youtube.com/watch?v=4n2dthDSGkc - short video: https://www.youtube.com/watch?v=c8JYt_xkJuY - release notes at:

Re: Review Request 119176: Update kickoff when user's name or face image changed

2014-07-08 Thread Vishesh Handa
/#comment43095 You'll be returning invalid image. Why not just an empty string? - Vishesh Handa On July 8, 2014, 12:49 p.m., Sebastian Kügler wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Copying over kxmlrpcclient into plasma-workspace

2014-07-08 Thread Vishesh Handa
a ship it. Cheers Rohan Garg ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel -- Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org

Re: Moving parts of kde-baseapps to plasma-workspace

2014-07-07 Thread Vishesh Handa
On Thu, Jul 3, 2014 at 3:10 PM, Vishesh Handa m...@vhanda.in wrote: On Tue, Jul 1, 2014 at 6:36 PM, Vishesh Handa m...@vhanda.in wrote: 1. kdepasswd - Contains the KCM for changing the real name and picture. This name is used by kickoff and is prominently displayed. It also contains an app

Re: Review Request 119155: Make the desktop containment respect minimum sizes

2014-07-07 Thread Vishesh Handa
/desktop/package/contents/ui/main.qml https://git.reviewboard.kde.org/r/119155/#comment43026 ? - Vishesh Handa On July 7, 2014, 12:51 p.m., Marco Martin wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: [kde-packager] Re: [kde-packager] Plasma 5 RC

2014-07-04 Thread Vishesh Handa
On Fri, Jul 4, 2014 at 10:59 AM, Jonathan Riddell j...@jriddell.org wrote: On Fri, Jul 04, 2014 at 12:54:22AM +0200, Vishesh Handa wrote: On Thu, Jul 3, 2014 at 11:05 PM, Jonathan Riddell j...@jriddell.org wrote: d58af08286e9d85ea6afa77831692c02efba9ba8ddebf57fd342854062425d39

Re: Review Request 118977: KSMServer: Do not autostart files

2014-07-04 Thread Vishesh Handa
: https://git.reviewboard.kde.org/r/118977/diff/ Testing --- Applications are now only started once. Thanks, Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 119105: PlasmaShell: Disable Session Management

2014-07-04 Thread Vishesh Handa
clears up the booting process to a certain extent, as plasmashell will now not be started twice (once via session restore, and once via autostart) Diffs - shell/main.cpp 0b96674 Diff: https://git.reviewboard.kde.org/r/119105/diff/ Testing --- Thanks, Vishesh Handa

Re: Review Request 119103: Startkde: Remove KLOCALE_LANGUAGES

2014-07-04 Thread Vishesh Handa
/ Testing --- Thanks, Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 119104: Add a Search category under Workspace

2014-07-04 Thread Vishesh Handa
--- On July 3, 2014, 1:35 p.m., Vishesh Handa wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119104

Re: [kde-packager] Re: [kde-packager] Plasma 5 RC

2014-07-04 Thread Vishesh Handa
On Fri, Jul 4, 2014 at 11:13 AM, Vishesh Handa m...@vhanda.in wrote: I would really like the tarballs to have the same name. Also, baloo4 and 5 are not really co-installable. They both ship executables with the same name. Just to clarify. All the libraries and plugins are co-instalable. It's

Review Request 119116: KRunner: Show a Configure button on the side

2014-07-04 Thread Vishesh Handa
https://git.reviewboard.kde.org/media/uploaded/files/2014/07/04/32a97211-153a-4f42-b5bf-9ed4560acb34__krunner_withconfig.png Thanks, Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 119116: KRunner: Show a Configure button on the side

2014-07-04 Thread Vishesh Handa
/119116/diff/ Testing --- File Attachments krunner_withconfig.png https://git.reviewboard.kde.org/media/uploaded/files/2014/07/04/32a97211-153a-4f42-b5bf-9ed4560acb34__krunner_withconfig.png Thanks, Vishesh Handa ___ Plasma

Review Request 119103: Startkde: Remove KLOCALE_LANGUAGES

2014-07-03 Thread Vishesh Handa
- startkde/kstartupconfig/CMakeLists.txt 6920fe5 startkde/kstartupconfig/kdostartupconfig.cpp d545f4f startkde/startkde.cmake 40e3377 Diff: https://git.reviewboard.kde.org/r/119103/diff/ Testing --- Thanks, Vishesh Handa ___ Plasma

Re: Review Request 119103: Startkde: Remove KLOCALE_LANGUAGES

2014-07-03 Thread Vishesh Handa
://git.reviewboard.kde.org/r/119103/#review61543 --- On July 3, 2014, 11:25 a.m., Vishesh Handa wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r

Re: Moving parts of kde-baseapps to plasma-workspace

2014-07-03 Thread Vishesh Handa
On Tue, Jul 1, 2014 at 6:36 PM, Vishesh Handa m...@vhanda.in wrote: 1. kdepasswd - Contains the KCM for changing the real name and picture. This name is used by kickoff and is prominently displayed. It also contains an app called 'kpasswd' which doesn't really work. Let's move

Review Request 119104: Add a Search category under Workspace

2014-07-03 Thread Vishesh Handa
/ Testing --- Thanks, Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 119103: Startkde: Remove KLOCALE_LANGUAGES

2014-07-03 Thread Vishesh Handa
On July 3, 2014, 11:41 a.m., Aleix Pol Gonzalez wrote: Don't we still need to pass the language somehow? or now it will be enough with $LANG? Vishesh Handa wrote: KLocale languages had a list of languages. The first one being the main one, and others being fallbacks. We no longer

Review Request 119105: PlasmaShell: Disable Session Management

2014-07-03 Thread Vishesh Handa
twice (once via session restore, and once via autostart) Diffs - shell/main.cpp 0b96674 Diff: https://git.reviewboard.kde.org/r/119105/diff/ Testing --- Thanks, Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https

Re: Plasma 5 RC

2014-07-03 Thread Vishesh Handa
. -- Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

The Social Desktop KCM

2014-07-02 Thread Vishesh Handa
is that? It may be best if we do not ship the KCM from now on. Specially since the openDesktop.org is proprietary. Opinions? -- Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: The Social Desktop KCM

2014-07-02 Thread Vishesh Handa
Removed - commit e6e1948c49b455ef1865dd76d4ffccaa43970880 Author: Vishesh Handa m...@vhanda.in Date: Wed Jul 2 14:56:32 2014 +0200 Remove the attica-kde aka The Social Desktop KCM This KCM was only used for providing credentials for loging into opendesktop.org (or other mythical

Re: Review Request 118977: KSMServer: Do not autostart files

2014-07-02 Thread Vishesh Handa
: https://git.reviewboard.kde.org/r/118977/diff/ Testing --- Applications are now only started once. Thanks, Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118974: UserAccount KCM: Change the name using the AccountManager

2014-07-01 Thread Vishesh Handa
--- On June 30, 2014, 1:16 p.m., Vishesh Handa wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118974

Re: Review Request 118974: UserAccount KCM: Change the name using the AccountManager

2014-07-01 Thread Vishesh Handa
: https://git.reviewboard.kde.org/r/118974/diff/ Testing --- Thanks, Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118974: UserAccount KCM: Change the name using the AccountManager

2014-07-01 Thread Vishesh Handa
On July 1, 2014, 10:08 a.m., Commit Hook wrote: This review has been submitted with commit 77275f50241eb2f4e38051152074c379fa96fe84 by Vishesh Handa to branch frameworks. Alex gave me a ship it via IM. - Vishesh

Re: new systemsettings categorization landed

2014-07-01 Thread Vishesh Handa
-- Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118977: KSMServer: Do not autostart files

2014-07-01 Thread Vishesh Handa
: is the rest up to date? now krunner should be started with autostart as the rest Vishesh Handa wrote: It seems that KRunner was started twice cause it being restored by the session manager and being started. I'll change krunner to ignore session management. Something similar

Re: Review Request 118977: KSMServer: Do not autostart files

2014-07-01 Thread Vishesh Handa
--- Applications are now only started once. Thanks, Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: new systemsettings categorization landed

2014-07-01 Thread Vishesh Handa
understand that these kind of design decisions are made in the forums. I commented over there as well [1] [1] http://forum.kde.org/viewtopic.php?f=285t=121053p=314382#p314382 -- Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https

Moving parts of kde-baseapps to plasma-workspace

2014-07-01 Thread Vishesh Handa
additionally seem to have a copy of libkonq in plasma-desktop. -- Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: new systemsettings categorization landed

2014-07-01 Thread Vishesh Handa
, and launch feedback. If the reasoning can be applied to multiple places perhaps it's a valid concern and should not be dismissed? -- Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Moving parts of kde-baseapps to plasma-workspace

2014-07-01 Thread Vishesh Handa
On Tue, Jul 1, 2014 at 6:49 PM, Eike Hein h...@kde.org wrote: Yeah, this can die. Folder now lives in plasma-desktop. kde-baseapps/plasma has been removed http://commits.kde.org/kde-baseapps/df78336e6974996dffbc13c77a0d28061ba283d2 -- Vishesh Handa

Re: Review Request 118974: UserAccount KCM: Change the name using the AccountManager

2014-06-30 Thread Vishesh Handa
--- Thanks, Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Runners KCM

2014-06-30 Thread Vishesh Handa
that exactly what the screenshot provides? -- Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Runners KCM

2014-06-27 Thread Vishesh Handa
with the VDG group. The idea is to call the KCM - Plasma Search, and rename the Baloo one to Search Backend. It's not perfect, but it works. This will result in a minor break in string freeze. -- Vishesh Handa [1] http://vhanda.in/krunner_kcm.png

Review Request 118975: Shell: Show an OSD for the keyboard brightness

2014-06-27 Thread Vishesh Handa
-workspace Description --- I have corresponding patches in powerdevil to hook it up and show it. Diffs - shell/osd.h 134d9f5 shell/osd.cpp a3fbedc Diff: https://git.reviewboard.kde.org/r/118975/diff/ Testing --- Yup. Works! Thanks, Vishesh Handa

Review Request 118977: KSMServer: Do not autostart files

2014-06-27 Thread Vishesh Handa
. Thanks, Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118933: PlasmaShell: Do not start krunner

2014-06-26 Thread Vishesh Handa
time plasma is restarted since krunner is already running and executing it then gives it focus. BUG: 336002 This patch depends on another patch in plasma-workspace/krunner which adds the krunner.desktop file - commit 1b570623b1e8df93f20940654e160b35570172ac Author: Vishesh Handa m

Re: Review Request 118937: DesktopView: Launch krunner on typing

2014-06-26 Thread Vishesh Handa
shell/desktopview.cpp a0e08ad Diff: https://git.reviewboard.kde.org/r/118937/diff/ Testing --- Thanks, Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118933: PlasmaShell: Do not start krunner

2014-06-25 Thread Vishesh Handa
., Vishesh Handa wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118933/ --- (Updated June 25, 2014, 10:58 a.m.) Review

Re: Review Request 118933: PlasmaShell: Do not start krunner

2014-06-25 Thread Vishesh Handa
that may not be used at all. Vishesh Handa wrote: I do not understand your comment about having a process which may not be used at all. Without this patch, krunner will always be started. Could you propose an alternate solution for the bug? I can think

Re: Review Request 118933: PlasmaShell: Do not start krunner

2014-06-25 Thread Vishesh Handa
that may not be used at all. Vishesh Handa wrote: I do not understand your comment about having a process which may not be used at all. Without this patch, krunner will always be started. Could you propose an alternate solution for the bug? I can think

Re: Review Request 118933: PlasmaShell: Do not start krunner

2014-06-25 Thread Vishesh Handa
that may not be used at all. Vishesh Handa wrote: I do not understand your comment about having a process which may not be used at all. Without this patch, krunner will always be started. Could you propose an alternate solution for the bug? I can think

Re: Review Request 118731: AbstractRunner: Add an iconForCategory virtual function

2014-06-20 Thread Vishesh Handa
KCM. Diffs - src/abstractrunner.h 0958a28 src/abstractrunner.cpp a48fd0c Diff: https://git.reviewboard.kde.org/r/118731/diff/ Testing --- Thanks, Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org

Review Request 118849: AppletQuickItem: Do not remember the popup dialog size

2014-06-20 Thread Vishesh Handa
- src/plasmaquick/appletquickitem.cpp a6e91f7 src/plasmaquick/private/appletquickitem_p.h 8b8010a Diff: https://git.reviewboard.kde.org/r/118849/diff/ Testing --- Thanks, Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https

Re: Review Request 118849: AppletQuickItem: Do not remember the popup dialog size

2014-06-20 Thread Vishesh Handa
--- On June 20, 2014, 2:35 p.m., Vishesh Handa wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118849

Re: Review Request 118849: AppletQuickItem: Do not remember the popup dialog size

2014-06-20 Thread Vishesh Handa
. Though even that could be buggy since the plasmoid could later be much smaller. Diffs - src/plasmaquick/appletquickitem.cpp a6e91f7 src/plasmaquick/private/appletquickitem_p.h 8b8010a Diff: https://git.reviewboard.kde.org/r/118849/diff/ Testing --- Thanks, Vishesh Handa

Re: Review Request 118791: (Need opinions) KRunner: Avoid having a scroll area

2014-06-19 Thread Vishesh Handa
the screen. I think you can leave the scroll area, but try to expand it as needed, even until it goes to touch the bottom margin of the screen (or near to it) and the scrollarea would almost never show a scrollbar, except corner cases. Vishesh Handa wrote: Well, we're only showing 20

Re: Review Request 118791: (Need opinions) KRunner: Avoid having a scroll area

2014-06-19 Thread Vishesh Handa
/media/uploaded/files/2014/06/17/a5743542-405a-4346-aa26-ac915821__krunner.png Thanks, Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 118791: (Need opinions) KRunner: Avoid having a scroll area

2014-06-17 Thread Vishesh Handa
/runcommand/RunCommand.qml 7a0503d Diff: https://git.reviewboard.kde.org/r/118791/diff/ Testing --- File Attachments Krunner in its full view https://git.reviewboard.kde.org/media/uploaded/files/2014/06/17/a5743542-405a-4346-aa26-ac915821__krunner.png Thanks, Vishesh

Review Request 118792: PowerDevil: Show the brightness OSD on pressing the brightness key

2014-06-17 Thread Vishesh Handa
: powerdevil Description --- See title Diffs - daemon/actions/bundled/brightnesscontrol.cpp 59bbbcc Diff: https://git.reviewboard.kde.org/r/118792/diff/ Testing --- Thanks, Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org

Re: Review Request 118791: (Need opinions) KRunner: Avoid having a scroll area

2014-06-17 Thread Vishesh Handa
the screen. I think you can leave the scroll area, but try to expand it as needed, even until it goes to touch the bottom margin of the screen (or near to it) and the scrollarea would almost never show a scrollbar, except corner cases. Vishesh Handa wrote: Well, we're only showing 20

Re: Review Request 118792: PowerDevil: Show the brightness OSD on pressing the brightness key

2014-06-17 Thread Vishesh Handa
marked as submitted. Review request for Plasma, Solid and Àlex Fiestas. Repository: powerdevil Description --- See title Diffs - daemon/actions/bundled/brightnesscontrol.cpp 59bbbcc Diff: https://git.reviewboard.kde.org/r/118792/diff/ Testing --- Thanks, Vishesh Handa

Re: Review Request 118797: Port webshortcuts runner

2014-06-17 Thread Vishesh Handa
. runners/webshortcuts/CMakeLists.txt https://git.reviewboard.kde.org/r/118797/#comment42034 Is DBus being used? runners/webshortcuts/CMakeLists.txt https://git.reviewboard.kde.org/r/118797/#comment42035 Ditto - Vishesh Handa On June 17, 2014, 2:53 p.m., Rohan Garg wrote

Re: Review Request 118791: (Need opinions) KRunner: Avoid having a scroll area

2014-06-17 Thread Vishesh Handa
://git.reviewboard.kde.org/media/uploaded/files/2014/06/17/a5743542-405a-4346-aa26-ac915821__krunner.png Thanks, Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118779: [krunner] Add Qt::Key_Search as a global shortcut

2014-06-16 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118779/#review60188 --- Ship it! Ship It! - Vishesh Handa On June 16, 2014, 11:45

Re: Review Request 118512: Turn KFileMetaData into a Framework.

2014-06-16 Thread Vishesh Handa
is not you - https://git.reviewboard.kde.org/r/118670/ Would you mind dropping this? His patch is ready to be shipped. - Vishesh Handa On June 14, 2014, 10:40 p.m., Matthew Dawson wrote: --- This is an automatically generated e-mail

<    1   2   3   >