This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMAWORKSPACE18858d16d6b1: Modified distance function to
keep aspect ratio as close as possible (authored by antlarr).
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
CHANGES SINCE LAST UPDATE
antlarr updated this revision to Diff 7823.
antlarr added a comment.
- Moved testfindpreferredimage to an autotests directory
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D3188?vs=7764=7823
BRANCH
arcpatch-D3188
REVISION DETAIL
antlarr added a comment.
@hpereiradacosta thanks for reviewing this. Can you cherry-pick the commit
for Plasma/5.8?
REPOSITORY
rBREEZE Breeze
REVISION DETAIL
https://phabricator.kde.org/D3192
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: antlarr,
antlarr closed this revision.
REPOSITORY
rBREEZE Breeze
REVISION DETAIL
https://phabricator.kde.org/D3192
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: antlarr, #plasma, #plasma:_design, hpereiradacosta
Cc: hpereiradacosta, davidedmundson,
antlarr updated this revision to Diff 7788.
antlarr added a comment.
- Increase width by MenuButton_IndicatorWidth+2 instead of adding a new enum
entry
REPOSITORY
rBREEZE Breeze
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D3192?vs=7735=7788
BRANCH
master
REVISION DETAIL
antlarr added inline comments.
INLINE COMMENTS
> davidedmundson wrote in breezestyle.cpp:2507
> you're still basing the height off the MenuButton_IndicatorWidth which you're
> otherwise not using
>
> Is that intentional?
Good point, I didn't notice that it was using MenuButton_IndicatorWidth
antlarr updated this revision to Diff 7764.
antlarr added a comment.
- Adjust the distance method to work with QUAD HD resolutions
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D3188?vs=7737=7764
BRANCH
Plasma/5.8
REVISION DETAIL
antlarr marked 3 inline comments as done.
antlarr added a comment.
Converted the test to use QTest
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D3188
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To:
antlarr updated this revision to Diff 7737.
antlarr added a comment.
- Converted the test to use QTest
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D3188?vs=7719=7737
BRANCH
Plasma/5.8
REVISION DETAIL
antlarr added a reviewer: Plasma: Design.
antlarr added a project: Plasma: Design.
REPOSITORY
rBREEZE Breeze
REVISION DETAIL
https://phabricator.kde.org/D3192
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: antlarr, #plasma, #plasma:_design
Cc:
antlarr created this revision.
antlarr added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
When the size of the combo box adjusts to its contents, the dropdown
listbox isn't large enough to fit the
antlarr added inline comments.
INLINE COMMENTS
> mart wrote in image.cpp:196
> dead code
The commented out qDebug a couple of lines below shows that variable (when
uncommented). Should I remove it from the qDebug line below? or just keep both?
(the same for the case above)
> mart wrote in
antlarr added inline comments.
INLINE COMMENTS
> testfindpreferredimage.cpp:91
> + if (preferred != expected) failed++;
> + std::cout << "For a screen size of " <<
> qPrintable(formatResolution(resolution))
> + << " the " << qPrintable(formatResolution(preferred)) << "
antlarr created this revision.
antlarr added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
This new version of the distance function simplifies the
findPreferredImageInPackage method by using the
antlarr closed this revision.
REPOSITORY
rKWIN KWin
REVISION DETAIL
https://phabricator.kde.org/D3132
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: antlarr, davidedmundson, #plasma, #kwin, graesslin
Cc: luebking, graesslin, kwin, plasma-devel,
antlarr added a comment.
I don't know why, but it seems arc diff doesn't work anymore and I have to
use arc diff HEAD~7 to include all 7 commits
REPOSITORY
rKWIN KWin
REVISION DETAIL
https://phabricator.kde.org/D3132
EMAIL PREFERENCES
antlarr updated this revision to Diff 7644.
antlarr added a comment.
Restricted Application edited projects, added Plasma; removed KWin.
Include all 7 commits
REPOSITORY
rKWIN KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D3132?vs=7638=7644
BRANCH
arcpatch-D3127_1
antlarr marked 5 inline comments as done.
antlarr added a comment.
All issues done
REVISION DETAIL
https://phabricator.kde.org/D3132
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: antlarr, #kwin, #plasma, davidedmundson
Cc: luebking, graesslin, kwin,
antlarr updated this revision to Diff 7638.
antlarr added a comment.
Restricted Application edited projects, added KWin; removed Plasma.
- Only call PostLastGuardedFrame when OpenGLCompositing is set
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D3132?vs=7637=7638
BRANCH
antlarr added inline comments.
INLINE COMMENTS
> luebking wrote in x11_platform.cpp:206
> PreFrame is (now) effectively "PreFirstGuardedFrame", is it?
> And if invoked at some later point would create the timer and hit the config
> rewrite every single frame (for the counter is stuck at 0)?
>
antlarr updated this revision to Diff 7637.
antlarr added a comment.
Restricted Application edited projects, added Plasma; removed KWin.
Include all 6 commits
REPOSITORY
rKWIN KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D3132?vs=7636=7637
BRANCH
arcpatch-D3127_1
antlarr updated this revision to Diff 7636.
antlarr marked 21 inline comments as done.
antlarr added a comment.
Restricted Application edited projects, added KWin; removed Plasma.
- Use only one timer to detect freezes and other optimizations
- Test 3 frames for freezes by default
CHANGES
antlarr closed this revision.
REPOSITORY
rUSERMANAGER User Manager
REVISION DETAIL
https://phabricator.kde.org/D3102
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: antlarr, #plasma, davidedmundson
Cc: mart, plasma-devel, lesliezhai, ali-mohamed,
antlarr added inline comments.
INLINE COMMENTS
> graesslin wrote in composite.h:242
> I would just count down the m_maxFramesTestedForSafety till it reaches 0
ok
> graesslin wrote in x11_platform.cpp:215
> You can use QMetaObject::invokeMethod with Qt::QueuedConnection.
Oh, I thought
antlarr added inline comments.
INLINE COMMENTS
> luebking wrote in x11_platform.cpp:215
> You should be able to call it as slot (whether QMetaObject::invokeMethod()
> works, I've never tried)
yeah, but then it wouldn't be a synchronous call and it would lose all its
meaning, isn't it? :)
>
antlarr added inline comments.
INLINE COMMENTS
> luebking wrote in composite.h:242
> m_testedFrames or similar, "Frame Count" is too generic.
> Alternatively, just use some "int m_freezeDectionFrames = 30;" and count
> them down (so when < 1, you're done)
ok. @graesslin do you prefer a count
antlarr added a comment.
Btw, I tested the last commit on a virtual machine simulating the freeze with
a sleep. I'll check tomorrow what's the minimum value for
m_maxFramesTestedForSafety that works to detect the real freeze and update its
default value.
REVISION DETAIL
antlarr updated this revision to Diff 7613.
antlarr added a comment.
Restricted Application edited projects, added Plasma; removed KWin.
- Remove most overhead caused by the freeze-detection thread
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D3132?vs=7599=7613
BRANCH
antlarr added a comment.
> How many frames do we need to detect the freeze? I think 30 frames is too
much by default. It's adding quite some stress on startup (lots of write to
config, lots of additional threads started). Assuming we freeze with tripple
buffer when trying to get the next
antlarr added a comment.
I tested this patch but it didn't work at detecting the freeze. Fortunately,
after debugging kwin for a bit I worked on this and made a version that detects
the freezes correctly.
I think I cannot add commits here, so I created a new phab at
antlarr created this revision.
antlarr added reviewers: KWin, Plasma, davidedmundson.
antlarr added subscribers: davidedmundson, plasma-devel, kwin.
antlarr added a project: Plasma.
Restricted Application edited projects, added KWin; removed Plasma.
REVISION SUMMARY
With nouveau driver it can
antlarr closed this revision.
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D3128
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: antlarr, #plasma, davidedmundson
Cc: plasma-devel, lesliezhai, ali-mohamed,
antlarr created this revision.
antlarr added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
If the user list is empty (for example, because regular users are hidden
or sddm's configuration includes
antlarr closed this revision.
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D2981
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: antlarr, #plasma, mart
Cc: mart, plasma-devel, lesliezhai, ali-mohamed,
antlarr added a comment.
Oops, sorry, I wrote a reply yesterday but forgot to submit it :/
INLINE COMMENTS
> mart wrote in accountmodel.cpp:165
> is there absolutely nothing left needing this?
I can't find anything at least. I tested the systemsettings window is updated
correctly
antlarr created this revision.
antlarr added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Only save values that were really changed
This allows to change settings without being asked for the
antlarr added inline comments.
INLINE COMMENTS
> mart wrote in image.cpp:245
> shouldn't then "preferred" just not be defined anymore in the wallpaper
> package structure then?
Sorry, I don't get your comment. That's why I remove it, so that "preferred" is
not defined anymore and the next
antlarr created this revision.
antlarr added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Removes preferred definition so a new wallpaper is selected.
Also, just in case, check for division by 0.
This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMAWORKSPACE189546c2696a: Renamed userPrompt to
userPromptComponent and add userListComponent id (authored by antlarr).
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
CHANGES SINCE LAST UPDATE
antlarr updated this revision to Diff 6968.
antlarr added a comment.
- Move logic to show/hide avatars from components/SessionManagementScreen.qml
to Main.qml
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D2874?vs=6954=6968
BRANCH
antlarr added a comment.
Thanks for your comments. I should warn you that this is the second time I
touch qml code, so apologies in advance :).
INLINE COMMENTS
> davidedmundson wrote in SessionManagementScreen.qml:60
> this component is shared with the lockscreen and user switcher, you're
antlarr created this revision.
antlarr added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Renamed userPrompt to userPromptComponent and add an id
(userListComponent) to the initialItem Login
antlarr closed this revision.
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D2834
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: antlarr, #plasma, davidedmundson
Cc: plasma-devel, lesliezhai, ali-mohamed,
antlarr created this revision.
antlarr added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
The default wallpaper method is to scale the wallpaper, and the previous
algorithm in plasma choosed the
44 matches
Mail list logo
