D10342: From 1.03% to 0.08% cpu usage moving 50.000 files

2018-03-23 Thread Marco Martin
mart added a comment. any update on this? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10342 To: jtamate, #plasma_workspaces, hein Cc: mart, mwolff, broulik, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D10342: From 1.03% to 0.08% cpu usage moving 50.000 files

2018-02-15 Thread Jaime Torres Amate
jtamate edited the summary of this revision. jtamate edited the test plan for this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10342 To: jtamate, #plasma_workspaces, hein Cc: mwolff, broulik, plasma-devel, ZrenBot, progwolff, lesliezhai,

D10342: From 1.03% to 0.08% cpu usage moving 50.000 files

2018-02-14 Thread Christoph Feck
cfeck added a reviewer: hein. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10342 To: jtamate, #plasma_workspaces, hein Cc: mwolff, broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10342: From 1.03% to 0.08% cpu usage moving 50.000 files

2018-02-14 Thread Jaime Torres Amate
jtamate marked 2 inline comments as done. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10342 To: jtamate, #plasma_workspaces Cc: mwolff, broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10342: From 1.03% to 0.08% cpu usage moving 50.000 files

2018-02-14 Thread Jaime Torres Amate
jtamate updated this revision to Diff 27177. jtamate added a comment. - From 1.03% to 0.08% cpu usage moving 50.000 files fixed mwolf comment REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10342?vs=26937=27177 BRANCH vivaldi (branched from

D10342: From 1.03% to 0.08% cpu usage moving 50.000 files

2018-02-14 Thread Milian Wolff
mwolff added inline comments. INLINE COMMENTS > xwindowtasksmodel.cpp:516 > + > +QUrl url= windowUrlFromMetadata(info->windowClassClass(), > NETWinInfo(QX11Info::connection(), window, > QX11Info::appRootWindow(), NET::WMPid, 0).pid(), `const auto url = ...`; note the space after

D10342: From 1.03% to 0.08% cpu usage moving 50.000 files

2018-02-12 Thread Jaime Torres Amate
jtamate added a comment. In D10342#204465 , @jtamate wrote: > In https://phabricator.kde.org/D9840 I noticed a high i/o and cpu usage > when using the vivaldi browser, opening 10 tabs just caused a 40% cpu > usage. Now, opening 10 tabs or

D10342: From 1.03% to 0.08% cpu usage moving 50.000 files

2018-02-11 Thread Jaime Torres Amate
jtamate updated this revision to Diff 26937. jtamate edited the test plan for this revision. jtamate added a comment. In https://phabricator.kde.org/D9840 I noticed a high i/o and cpu usage when using the vivaldi browser, opening 10 tabs just caused a 40% cpu usage. Now, opening 10 tabs or

D10342: From 1.03% to 0.08% cpu usage moving 50.000 files

2018-02-07 Thread Kai Uwe Broulik
broulik added a comment. > every time I changed konsole tabs, saved a file in kate, the appDataFromUrl (missed the cache) was called. Whenever `NET::WMVisibleName ` changes, both caches are evicted. It might be worth checking what's more expensive to create, the `KWindowInfo` or

D10342: From 1.03% to 0.08% cpu usage moving 50.000 files

2018-02-07 Thread Jaime Torres Amate
jtamate updated this revision to Diff 26692. jtamate edited the test plan for this revision. jtamate added a comment. What I've noticed is that with the first version of the patch, every time I changed konsole tabs, saved a file in kate, the appDataFromUrl (missed the cache) was called.

D10342: From 1.03% to 0.08% cpu usage moving 50.000 files

2018-02-07 Thread Kai Uwe Broulik
broulik added a comment. The progress display is completely independent of libtaskmanager. Can you disable it (Uncheck "Show application badges and progress" in task manager settings) and see if that changes anything? REPOSITORY R120 Plasma Workspace REVISION DETAIL

D10342: From 1.03% to 0.08% cpu usage moving 50.000 files

2018-02-06 Thread Jaime Torres Amate
jtamate added a comment. In https://phabricator.kde.org/D10342#201979, @broulik wrote: > Interesting. I'm curious as to why it calls those functions that often in the first place while copying files. My guess is that it is used to fill the task completion in the task bar, but is

D10342: From 1.03% to 0.08% cpu usage moving 50.000 files

2018-02-06 Thread Kai Uwe Broulik
broulik added a comment. Interesting. I'm curious as to why it calls those functions that often in the first place while copying files. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10342 To: jtamate, #plasma_workspaces Cc: broulik, plasma-devel,

D10342: From 1.03% to 0.08% cpu usage moving 50.000 files

2018-02-06 Thread Jaime Torres Amate
jtamate edited the summary of this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10342 To: jtamate, #plasma_workspaces Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10342: From 1.03% to 0.08% cpu usage moving 50.000 files

2018-02-06 Thread Jaime Torres Amate
jtamate created this revision. jtamate added a reviewer: Plasma: Workspaces. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. jtamate requested review of this revision. REVISION SUMMARY store the const iterator returned, not the address.