D10750: [wayland] Add support for zwp_linux_dmabuf

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R108:6613327a9c3e: [wayland] Add support for zwp_linux_dmabuf (authored by romangg). REPOSITORY R108 KWin CHANGES SINCE

D10750: [wayland] Add support for zwp_linux_dmabuf

romangg updated this revision to Diff 63225. romangg added a comment. Rebase on master. REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10750?vs=61915=63225 BRANCH dmaBuf REVISION DETAIL https://phabricator.kde.org/D10750 AFFECTED FILES

D10750: [wayland] Add support for zwp_linux_dmabuf

romangg updated this revision to Diff 61915. romangg marked 2 inline comments as done. romangg added a comment. Rebase on master. REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10750?vs=60898=61915 BRANCH dmaBuf REVISION DETAIL

D10750: [wayland] Add support for zwp_linux_dmabuf

romangg marked an inline comment as done. romangg added inline comments. INLINE COMMENTS > romangg wrote in abstract_egl_backend.cpp:405 > rm Nope, better not. Overlooked the `m_`. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D10750 To: romangg, #kwin, #plasma,

D10750: [wayland] Add support for zwp_linux_dmabuf

romangg added inline comments. INLINE COMMENTS > abstract_egl_backend.cpp:405 > if (image != EGL_NO_IMAGE_KHR) { > -eglDestroyImageKHR(m_backend->eglDisplay(), m_image); > +if (m_image != EGL_NO_IMAGE_KHR) { > +

D10750: wayland: Add support for zwp_linux_dmabuf

romangg updated this revision to Diff 60898. romangg added a comment. - Import dma-bufs with multi-plane via modifier REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10750?vs=60655=60898 BRANCH dmaBuf REVISION DETAIL https://phabricator.kde.org/D10750

D10750: wayland: Add support for zwp_linux_dmabuf

romangg added a comment. In D10750#486570 , @romangg wrote: > Multi-plane support is needed. See @fredrik's inline comment on how to do that: > > > We would need to create a separate EGL image and a separate texture for each plane. > >

D10750: wayland: Add support for zwp_linux_dmabuf

romangg planned changes to this revision. romangg added a comment. Multi-plane support is needed. See @fredrik's inline comment on how to do that: > We would need to create a separate EGL image and a separate texture for each plane. > The scene would need to bind each of those

D10750: wayland: Add support for zwp_linux_dmabuf

romangg updated this revision to Diff 60655. romangg added a comment. Refactor Bind the interface on abstract-egl level. Then we can remove the interface stubs throughout the stack. The interface is not created when EGL format extensions are not available or we don't use EGL.

D10750: wayland: Add support for zwp_linux_dmabuf

romangg added inline comments. INLINE COMMENTS > fredrik wrote in abstract_egl_backend.cpp:427 > We would need to create a separate EGL image and a separate texture for each > plane. > The scene would need to bind each of those textures to separate texture > binding points, and we would need

D10750: wayland: Add support for zwp_linux_dmabuf

fredrik added inline comments. INLINE COMMENTS > zzag wrote in abstract_egl_backend.cpp:427 > What's holding us from doing that? We would need to create a separate EGL image and a separate texture for each plane. The scene would need to bind each of those textures to separate texture binding

D10750: wayland: Add support for zwp_linux_dmabuf

zzag added inline comments. INLINE COMMENTS > abstract_egl_backend.cpp:438-439 > +EGL_DMA_BUF_PLANE0_PITCH_EXT, EGLint(planes[0].stride), > +EGL_DMA_BUF_PLANE0_MODIFIER_LO_EXT, EGLint(planes[0].modifier & > 0x), > +EGL_DMA_BUF_PLANE0_MODIFIER_HI_EXT,

D10750: wayland: Add support for zwp_linux_dmabuf

zzag added inline comments. INLINE COMMENTS > abstract_egl_backend.cpp:427 > + > +// FIXME: Add support for multi-planar images > +if (planes.count() != 1) What's holding us from doing that? REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D10750 To: romangg,

D10750: wayland: Add support for zwp_linux_dmabuf

romangg updated this revision to Diff 60482. romangg added a comment. Rebase Fredrik's dma-buf code on master REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10750?vs=29953=60482 BRANCH dmaBuf REVISION DETAIL https://phabricator.kde.org/D10750 AFFECTED

D10750: wayland: Add support for zwp_linux_dmabuf

meven added a comment. In D10750#327333 , @zzag wrote: > Any update on this? I am wondering as well. This seems like good progress was already done and what is left is some test fixes and polish. I can only encourage @fredrik and

D10750: wayland: Add support for zwp_linux_dmabuf

zzag added a comment. Any update on this? REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D10750 To: fredrik, #kwin, #plasma, davidedmundson, mart, graesslin Cc: zzag, romangg, anthonyfieroni, plasma-devel, kwin, mkulinski, ragreen, jackyalcine, Pitel, iodelay, bwowk,

D10750: wayland: Add support for zwp_linux_dmabuf

fredrik updated this revision to Diff 29953. fredrik added a comment. Fix issues pointed out by romangg. REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10750?vs=29331=29953 REVISION DETAIL https://phabricator.kde.org/D10750 AFFECTED FILES

D10750: wayland: Add support for zwp_linux_dmabuf

fredrik added a comment. In D10750#224860 , @romangg wrote: > In D10750#216337 , @fredrik wrote: > > > An issue that this patch does not fully address is switching compositing backends at runtime.

D10750: wayland: Add support for zwp_linux_dmabuf

romangg added a comment. In D10750#216337 , @fredrik wrote: > An issue that this patch does not fully address is switching compositing backends at runtime. Do we support that at all? The backend is set at startup. Don't think you can

D10750: wayland: Add support for zwp_linux_dmabuf

romangg added a comment. Do typedefs for `KWayland::Server::LinuxDmabuf` in files where you use it more than once. INLINE COMMENTS > abstract_egl_backend.cpp:346 > > +void AbstractEglBackend::aboutToDestroy(EglDmabufBuffer *buffer) > +{ Name should be more descriptive in relation to

D10750: wayland: Add support for zwp_linux_dmabuf

fredrik updated this revision to Diff 29331. fredrik added a comment. Import the context. REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10750?vs=27803=29331 REVISION DETAIL https://phabricator.kde.org/D10750 AFFECTED FILES

D10750: wayland: Add support for zwp_linux_dmabuf

fredrik added a comment. An issue that this patch does not fully address is switching compositing backends at runtime. Buffers are imported by the scene. The scene allocates and returns a subclassed LinuxDmabuf::Buffer that contains the file descriptors and backend specific objects,

D10750: wayland: Add support for zwp_linux_dmabuf

romangg added a task: T8067: Support zwp_linux_dmabuf. Restricted Application edited projects, added KWin; removed Plasma. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D10750 To: fredrik, #kwin, #plasma, davidedmundson, mart, graesslin Cc: anthonyfieroni, plasma-devel,

D10750: wayland: Add support for zwp_linux_dmabuf

anthonyfieroni added inline comments. Restricted Application edited projects, added Plasma; removed KWin. INLINE COMMENTS > abstract_egl_backend.cpp:117 > +for (auto *dmabuf : qAsConst(m_dmabufBuffers)) { > +dmabuf->destroyImage(); > +} Call delete dmabuf will have same effect.

D10750: wayland: Add support for zwp_linux_dmabuf

fredrik edited projects, added Plasma; removed KWin. fredrik added a comment. Restricted Application edited projects, added KWin; removed Plasma. In D10750#211784 , @graesslin wrote: > Concerning the tests: the ones requiring OpenGL work best if

D10750: wayland: Add support for zwp_linux_dmabuf

graesslin added a comment. Restricted Application edited projects, added KWin; removed Plasma. Concerning the tests: the ones requiring OpenGL work best if module vgem is loaded. That normally makes them pass. The tests regarding keyboard layout need env variable XDG_DEFAULT_LAYOUT being

D10750: wayland: Add support for zwp_linux_dmabuf

fredrik created this revision. fredrik added reviewers: KWin, Plasma, davidedmundson, mart, graesslin. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. fredrik requested review of this revision. Restricted Application edited projects,