D11308: Use the default Plasma wallpaper on the lock screen

ngraham added a comment. Landing per Marco's instructions, since the whole lockscreen thingy is going in. REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D11308 To: ngraham, #plasma, #vdg, graesslin, abetts, davidedmundson, mart Cc: fvogt, Fuchs, broulik,

D11308: Use the default Plasma wallpaper on the lock screen

This revision was not accepted when it landed; it landed in state "Needs Revision". This revision was automatically updated to reflect the committed changes. Closed by commit R133:6e5e6adad191: Use the default Plasma wallpaper on the lock screen (authored by ngraham). REPOSITORY R133

D11308: Use the default Plasma wallpaper on the lock screen

fvogt added a comment. I'll write my viewpoint as downstream maintainer here: We removed the blue background as default as soon as it landed as it is was complained about in various places. Also, our sddm theme also uses the wallpaper as background so it looks similiar now. (if a

D11308: Use the default Plasma wallpaper on the lock screen

davidedmundson added a comment. > (btw that leak i think should be solved, @davidedmundson also has a rewrite of the wallpaper code which should make it take less memory, as right now the first few times it changes memory gooes up not for an actual leak but more for the management not being

D11308: Use the default Plasma wallpaper on the lock screen

ngraham added a comment. In D11308#227361 , @graesslin wrote: > Sorry but no. I want to see it addressed before flipping it. We have shipped half finished things too often - especially on the look screen. Sorry but sometimes I wonder what you

D11308: Use the default Plasma wallpaper on the lock screen

graesslin added a comment. In D11308#227359 , @ngraham wrote: > In D11308#227358 , @graesslin wrote: > > > In D11308#227332 , @ngraham wrote: > > > >

D11308: Use the default Plasma wallpaper on the lock screen

graesslin added a comment. In D11308#227357 , @ngraham wrote: > In D11308#227356 , @graesslin wrote: > > > In D11308#227334 , @ngraham wrote: > > > >

D11308: Use the default Plasma wallpaper on the lock screen

ngraham added a comment. In D11308#227358 , @graesslin wrote: > In D11308#227332 , @ngraham wrote: > > > In D11308#227330 , @graesslin wrote: > > > >

D11308: Use the default Plasma wallpaper on the lock screen

graesslin added a comment. In D11308#227332 , @ngraham wrote: > In D11308#227330 , @graesslin wrote: > > > @ngraham Let's try to not work against our distros. Yes we could change that because we

D11308: Use the default Plasma wallpaper on the lock screen

ngraham added a comment. In D11308#227356 , @graesslin wrote: > In D11308#227334 , @ngraham wrote: > > > Also, Martin, this isn't about re-using the desktop wallpaper on the lock screen. It's

D11308: Use the default Plasma wallpaper on the lock screen

graesslin added a comment. In D11308#227334 , @ngraham wrote: > Also, Martin, this isn't about re-using the desktop wallpaper on the lock screen. It's about using the current Plasma wallpaper on the lock screen. Distros can and do override the

D11308: Use the default Plasma wallpaper on the lock screen

Fuchs added a comment. Personal opinions, based on discussions here and on TG - fixed, (default) wallpaper has the advantage of not risking privacy, not munching power and being usable in, at least from login to desktop to lock screen, have a consistent feel for new users. Downside is

D11308: Use the default Plasma wallpaper on the lock screen

abetts added a comment. In D11308#227330 , @graesslin wrote: > @ngraham Let's try to not work against our distros. Yes we could change that because we are upstream, we set the default. The result would be distros swapping the wallpaper and we

D11308: Use the default Plasma wallpaper on the lock screen

ngraham added a comment. Also, Martin, this isn't about re-using the desktop wallpaper on the lock screen. It's about using the current Plasma wallpaper on the lock screen. Distros can and do override the desktop wallpaper but to my knowledge most don't currently override the lockscreen

D11308: Use the default Plasma wallpaper on the lock screen

ngraham added a comment. In D11308#227330 , @graesslin wrote: > @ngraham Let's try to not work against our distros. Yes we could change that because we are upstream, we set the default. The result would be distros swapping the wallpaper and we

D11308: Use the default Plasma wallpaper on the lock screen

graesslin added a comment. @ngraham Let's try to not work against our distros. Yes we could change that because we are upstream, we set the default. The result would be distros swapping the wallpaper and we have unreadable text. This is something which will happen, I have been too long in

D11308: Use the default Plasma wallpaper on the lock screen

mart added a comment. In D11308#227248 , @broulik wrote: > > We can put the black bars back. Problem is because the UI is now stretched out a lot taller in order to cover the clock and switch user button I'd have to take up the entire screen.

D11308: Use the default Plasma wallpaper on the lock screen

ngraham added a comment. Sorry, I was going for whimsical, but I guess it didn't come out right. Will stick to technical. REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D11308 To: ngraham, #plasma, #vdg, graesslin, abetts Cc: broulik, davidedmundson, zzag,

D11308: Use the default Plasma wallpaper on the lock screen

davidedmundson added a comment. > if you can find it in your heart to approve this Lets keep review comments purely technical please. REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D11308 To: ngraham, #plasma, #vdg, graesslin, abetts Cc: broulik,

D11308: Use the default Plasma wallpaper on the lock screen

broulik added a comment. > We can put the black bars back. Problem is because the UI is now stretched out a lot taller in order to cover the clock and switch user button I'd have to take up the entire screen. We can make them vertical! REPOSITORY R133 KScreenLocker REVISION DETAIL

D11308: Use the default Plasma wallpaper on the lock screen

ngraham added a comment. I strongly agree that this UI needs more background contrast, and I volunteer to spearhead the initiative to improve that (https://bugs.kde.org/show_bug.cgi?id=369676) However, this patch as is doesn't //require// that. We as the upstream vendor have control

D11308: Use the default Plasma wallpaper on the lock screen

davidedmundson added a comment. We can put the black bars back. Problem is because the UI is now stretched out a lot taller in order to cover the clock and switch user button I'd have to take up the entire screen. REPOSITORY R133 KScreenLocker REVISION DETAIL

D11308: Use the default Plasma wallpaper on the lock screen

graesslin added a comment. In D11308#226836 , @ngraham wrote: > @graesslin, those are good comments for @mart's ideas for the other approach. Do you have any remaining concerns with this one that I can work on? As long as the lnf theme

D11308: Use the default Plasma wallpaper on the lock screen

ngraham added a comment. @graesslin, those are good comments for @mart's ideas for the other approach. Do you have any remaining concerns with this one that I can work on? REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D11308 To: ngraham, #plasma, #vdg,

D11308: Use the default Plasma wallpaper on the lock screen

graesslin added a comment. In D11308#226803 , @ngraham wrote: > Thanks @mart. I think using an animated slideshow by default will be really popular, especially if we do some work to add more nice images by default and polish up the slideshow

D11308: Use the default Plasma wallpaper on the lock screen

ngraham added a comment. Thanks @mart. I think using an animated slideshow by default will be really popular, especially if we do some work to add more nice images by default and polish up the slideshow plugin's UI a bit. I'm glad to hear that the memory issue is or should be resolved soon.

D11308: Use the default Plasma wallpaper on the lock screen

mart added a subscriber: davidedmundson. mart added a comment. In D11308#226767 , @ngraham wrote: > @mart You're essentially describing transforming the lock screen into a screensaver, with the default effect being an animated slideshow. I

D11308: Use the default Plasma wallpaper on the lock screen

ngraham added a comment. @mart You're essentially describing transforming the lock screen into a screensaver, with the default effect being an animated slideshow. I would favor this. Users like screensavers simply for the visual flair, and I've heard a lot of user feedback that they'd like

D11308: Use the default Plasma wallpaper on the lock screen

mart added a comment. That's a way i would like it: https://www.youtube.com/watch?v=BOsclMNpK3M (quick and dirty so the interaction and effects are very buggy) have the lockscreen by default to be a slideshow of the default installed wallpapers and show only the clock (in this mode the

D11308: Use the default Plasma wallpaper on the lock screen

hein added a comment. The argument that it's a semantic abuse of the highlight color is quite convincing to me. REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D11308 To: ngraham, #plasma, #vdg, graesslin Cc: richardbowen, zzag, Pitel, progwolff, abetts, hein,

D11308: Use the default Plasma wallpaper on the lock screen

richardbowen added a comment. Blue screen is fine with me but hey, I like blue. REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D11308 To: ngraham, #plasma, #vdg, graesslin Cc: richardbowen, zzag, Pitel, progwolff, abetts, hein, mart, graesslin, plasma-devel,

D11308: Use the default Plasma wallpaper on the lock screen

zzag added a comment. In D11308#225711 , @hein wrote: > > The blue background was not particularly well-received. > > Are you sure you are not reacting to a loud minority? The bright background has some practical benefits, e.g. it allows

D11308: Use the default Plasma wallpaper on the lock screen

zzag added a comment. In D11308#225401 , @mart wrote: > Sadly, the current design doesn't really allow for arbitrary wallpapers (and since is possible already to put any image, that's quite a problem) > if a wallpaper should become the

D11308: Use the default Plasma wallpaper on the lock screen

Pitel added a comment. +1 for picture instead of blue. With the current UI I would really appreciate option to choose text color independently on plasma color scheme (and such option would solve any static picture). Other possibility I was thinking about was 50 % opaque (default black)

D11308: Use the default Plasma wallpaper on the lock screen

ngraham added a comment. In D11308#225711 , @hein wrote: > > The blue background was not particularly well-received. > > Are you sure you are not reacting to a loud minority? The bright background has some practical benefits, e.g. it allows

D11308: Use the default Plasma wallpaper on the lock screen

progwolff added a comment. @hein might be right here. If it's the single-click/double-click thing or this issue here: People who are happy with the status quo won't reach out to us. Maybe we need to discuss at a different place if and how we can learn about the opinion of the majority of

D11308: Use the default Plasma wallpaper on the lock screen

hein added a comment. > The blue background was not particularly well-received. Are you sure you are not reacting to a loud minority? The bright background has some practical benefits, e.g. it allows people to type in their passwords in dark rooms without a backlit keyboard. There may

D11308: Use the default Plasma wallpaper on the lock screen

abetts added a comment. +1 REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D11308 To: ngraham, #plasma, #vdg, graesslin Cc: abetts, hein, mart, graesslin, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D11308: Use the default Plasma wallpaper on the lock screen

ngraham added a comment. In D11308#225251 , @graesslin wrote: > I think we first need to bring back some background for the UI elements. Otherwise it's too difficult to read. In D11308#225401

D11308: Use the default Plasma wallpaper on the lock screen

hein added a comment. FWIW: AIUI this patch isn't about making the lock screen use the current user wallpaper dynamically, which means the vendor gets control over making sure the default wallpaper they pick works with the UI elements at least. REPOSITORY R133 KScreenLocker REVISION

D11308: Use the default Plasma wallpaper on the lock screen

mart added a comment. Sadly, the current design doesn't really allow for arbitrary wallpapers (and since is possible already to put any image, that's quite a problem) if a wallpaper should become the default again, the text elements should either have a visible background for contrast (so

D11308: Use the default Plasma wallpaper on the lock screen

mart added a comment. -1 from me too REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D11308 To: ngraham, #plasma, #vdg, graesslin Cc: mart, graesslin, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D11308: Use the default Plasma wallpaper on the lock screen

graesslin requested changes to this revision. graesslin added a comment. This revision now requires changes to proceed. I think we first need to bring back some background for the UI elements. Otherwise it's too difficult to read. Personally I'm very confused as it was the vdg's wish to

D11308: Use the default Plasma wallpaper on the lock screen

ngraham created this revision. ngraham added reviewers: Plasma, VDG. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY As discussed and agreed to by VDG, change the lock screen