D12102: Port Language KCM to Qt Quick

hein added a comment. I've cleaned this up/out now. About half or so got reassigned to either systemsettings:kcm_formats or frameworks-sonnet. Some got closed as FIXED and WORKSFORME. There's a bunch left. 2-3 have a point (e.g. the the language names), the rest is weird stuff. Re

D12102: Port Language KCM to Qt Quick

davidedmundson added a comment. As part of porting can you please go through: https://bugs.kde.org/buglist.cgi?bug_status=UNCONFIRMED_status=CONFIRMED_status=ASSIGNED_status=REOPENED=kcm_language_id=1517561=systemsettings_format=advanced One about drag & drop is probably fixed by this,

D12102: Port Language KCM to Qt Quick

hein added a comment. Sorry, accident! The code in the Keyboard KCM is ... interesting and literally breaks my system trying to build it (it needs a two-digit amount of GB of memory to build thanks to a boost-based keyboard layout preview generator it even changes the LLVM template

D12102: Port Language KCM to Qt Quick

davidedmundson added a comment. That was a mistake. It has been restored. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12102 To: hein, #kirigami, mart Cc: yurchor, rkflx, aspotashev, davidedmundson, safaalfulaij, abetts, ngraham, plasma-devel, ragreen,

D12102: Port Language KCM to Qt Quick

yurchor added a comment. Please, can I ask why is it impossible now to configure the keyboard layout as a result of this? https://cgit.kde.org/plasma-desktop.git/diff/kcms/CMakeLists.txt?id=6055cfb94e1e8e42278cd4bea7d4debe4e745c7b REPOSITORY R119 Plasma Desktop REVISION DETAIL

D12102: Port Language KCM to Qt Quick

This revision was automatically updated to reflect the committed changes. Closed by commit R119:6055cfb94e1e: Port Language KCM to Qt Quick (authored by hein). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12102?vs=34121=34123 REVISION DETAIL

D12102: Port Language KCM to Qt Quick

hein updated this revision to Diff 34121. hein added a comment. Move removal into the C++ model code to avoid another model reset and speed up the UX. Please re-review now for 5.13 inclusion. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D12102: Port Language KCM to Qt Quick

hein updated this revision to Diff 34120. hein added a comment. Add back Move up/down actions. DND won't be ready in Kirigami for 5.13, but as this port fixes critical bugs vs. the old version - such as not actually saving settings ... - we still want this in 5.13. To prepare for

D12102: Port Language KCM to Qt Quick

hein updated this revision to Diff 34053. hein added a comment. Don't mutate source model while building list of langs to add to selection. This will likely fix Marco's problem. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D12102: Port Language KCM to Qt Quick

hein updated this revision to Diff 34051. hein added a comment. Remove width from delegate in sheet again. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12102?vs=33818=34051 BRANCH arcpatch-D12102_1 REVISION DETAIL

D12102: Port Language KCM to Qt Quick

hein added a comment. In D12102#261174 , @mart wrote: > if i select more than one language, only one will be added, the others will be added as "unknown" I can't reproduce this, but will have a look. REPOSITORY R119 Plasma Desktop

D12102: Port Language KCM to Qt Quick

mart added a comment. if i select more than one language, only one will be added, the others will be added as "unknown" REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12102 To: hein, #kirigami, mart Cc: rkflx, aspotashev, davidedmundson, safaalfulaij,

D12102: Port Language KCM to Qt Quick

mart requested changes to this revision. mart added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > main.qml:66 > +delegate: Kirigami.BasicListItem { > +width: ListView.view.width > + sorry, counter what i told you before, setting an

D12102: Port Language KCM to Qt Quick

hein added a comment. @mart Do you think I should push this before we work on the DND stuff? REPOSITORY R119 Plasma Desktop BRANCH arcpatch-D12102_1 REVISION DETAIL https://phabricator.kde.org/D12102 To: hein, #kirigami, mart Cc: rkflx, aspotashev, davidedmundson, safaalfulaij,

D12102: Port Language KCM to Qt Quick

mart accepted this revision. mart added a comment. This revision is now accepted and ready to land. on my side, code is all fine now REPOSITORY R119 Plasma Desktop BRANCH arcpatch-D12102_1 REVISION DETAIL https://phabricator.kde.org/D12102 To: hein, #kirigami, mart Cc: rkflx,

D12102: Port Language KCM to Qt Quick

hein updated this revision to Diff 33818. hein added a comment. Set explicit width for Material style REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12102?vs=33817=33818 BRANCH arcpatch-D12102_1 REVISION DETAIL

D12102: Port Language KCM to Qt Quick

hein updated this revision to Diff 33817. hein added a comment. - Right-align 'Add languages ...' button - Clean up cruft from a pre-ListView revision, thanks Marco REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12102?vs=33742=33817 BRANCH

D12102: Port Language KCM to Qt Quick

mart added a comment. +1 for moving the add language button bottom-right INLINE COMMENTS > main.qml:66 > +delegate: Kirigami.BasicListItem { > +Layout.fillWidth: true > + same consideration for Layout.* in delegates > main.qml:185 > + > +

D12102: Port Language KCM to Qt Quick

rkflx added a comment. In D12102#259446 , @hein wrote: > Helper text: It's at the top now, AIUI the discussion had evolved to leave it like this? Not sure. LGTM. REPOSITORY R119 Plasma Desktop REVISION DETAIL

D12102: Port Language KCM to Qt Quick

hein added a comment. Right-aligned button: Can do, sure. Helper text: It's at the top now, AIUI the discussion had evolved to leave it like this? Not sure. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12102 To: hein, #kirigami, mart Cc: rkflx,

D12102: Port Language KCM to Qt Quick

abetts added a comment. In D12102#254322 , @hein wrote: > New screenshot: > > F5823188: Screenshot_20180427_001323.png Is the Add Languages button able to be right aligned? Did we want to

D12102: Port Language KCM to Qt Quick

hein updated this revision to Diff 33742. hein added a comment. - Fix settings saving - String tweak This is done now from my end, other than DND which still requires Kirigami work. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D12102: Port Language KCM to Qt Quick

hein added a comment. I also just realized we seem to have zero keyboard nav support ... REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12102 To: hein, #kirigami, mart Cc: rkflx, aspotashev, davidedmundson, safaalfulaij, abetts, ngraham, plasma-devel,

D12102: Port Language KCM to Qt Quick

hein added a comment. New screenshot: F5823188: Screenshot_20180427_001323.png REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12102 To: hein, #kirigami, mart Cc: rkflx, aspotashev, davidedmundson, safaalfulaij,

D12102: Port Language KCM to Qt Quick

hein updated this revision to Diff 33150. hein added a comment. - Port to ScrollVieWKCM - Add list label at the top and show conditionally - Actions are now 'Make default' and 'Remove' with appropriate tooltips - Topmost language has a "(Default)" behind it - Code cleanups It's

D12102: Port Language KCM to Qt Quick

mart added a comment. In D12102#251163 , @ngraham wrote: > +1 for putting the text on the top rather than the bottom. Once we make the list draggable, it might be nice to incorporate that into the text too, e.g "drag languages into your

D12102: Port Language KCM to Qt Quick

mart added a comment. In D12102#251163 , @ngraham wrote: > +1 for putting the text on the top rather than the > Unfortunately, our use of the hamburger button precludes use of that elsewhere-fairly-universal "three bar" symbol to mean "this

D12102: Port Language KCM to Qt Quick

ngraham added a comment. +1 for putting the text on the top rather than the bottom. Once we make the list draggable, it might be nice to incorporate that into the text too, e.g "drag languages into your preferred order" or something like that. Unfortunately, our use of the hamburger

D12102: Port Language KCM to Qt Quick

hein added a comment. Adding 'Default' is pretty easy, no problem. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12102 To: hein, #kirigami, mart Cc: rkflx, aspotashev, davidedmundson, safaalfulaij, abetts, ngraham, plasma-devel, ragreen, Pitel, ZrenBot,

D12102: Port Language KCM to Qt Quick

rkflx added a comment. Looking better now ;) One more note: Users read the dialog from the top. Having "Default" added to the topmost entry like in @abetts' mockup would be great, if possible at all, because most users won't really get to the text at the bottom. As for the handle,

D12102: Port Language KCM to Qt Quick

hein added a comment. In D12102#251048 , @ngraham wrote: > For this list, where the items themselves don't do anything on click, I think it's sane to allow the whole list item to be a drag area. There's more of a challenge to allow re-ordering

D12102: Port Language KCM to Qt Quick

ngraham added a comment. For this list, where the items themselves don't do anything on click, I think it's sane to allow the whole list item to be a drag area. There's more of a challenge to allow re-ordering items that do something when you click on them, but we don't have that issue

D12102: Port Language KCM to Qt Quick

hein added a comment. https://www.youtube.com/watch?v=gdnuOa7tDco REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12102 To: hein, #kirigami, mart Cc: rkflx, aspotashev, davidedmundson, safaalfulaij, abetts, ngraham, plasma-devel, ragreen, Pitel, ZrenBot,

D12102: Port Language KCM to Qt Quick

ngraham added a comment. Lookin' pretty sharp! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12102 To: hein, #kirigami, mart Cc: rkflx, aspotashev, davidedmundson, safaalfulaij, abetts, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai,

D12102: Port Language KCM to Qt Quick

hein added a comment. So, how are we gonna approach this drag thing? Three dots? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12102 To: hein, #kirigami, mart Cc: rkflx, aspotashev, davidedmundson, safaalfulaij, abetts, ngraham, plasma-devel, ragreen,

D12102: Port Language KCM to Qt Quick

hein added a comment. With the right text and disabling the default action for the first item: F5816462: Screenshot_20180421_234449.png REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12102 To: hein, #kirigami,

D12102: Port Language KCM to Qt Quick

hein added a comment. Turns out tooltip support is there already: F5816427: Screenshot_20180421_233951.png REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12102 To: hein, #kirigami, mart Cc: rkflx, aspotashev,

D12102: Port Language KCM to Qt Quick

ngraham added a comment. In D12102#251008 , @hein wrote: > Yeah, I think duplicating the button text is goofy. I'm OK with the first sentence. > > Otherwise, personally I would like the list to be like this: > > (a) Have a drag handle

D12102: Port Language KCM to Qt Quick

hein added a comment. Another issue I have with SwipeListItem: In addition to the hover effect, there's always a fancy flashing effect on clicks, even though it doesn't do anything in my list. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12102 To: hein,

D12102: Port Language KCM to Qt Quick

hein added a comment. BTW: I think SwipeListItem actions should have support for tooltips, so those actions can have "Make default" and "Remove" tooltips. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12102 To: hein, #kirigami, mart Cc: rkflx, aspotashev,

D12102: Port Language KCM to Qt Quick

hein added a comment. Yeah, I think duplicating the button text is goofy. I'm OK with the first sentence. Otherwise, personally I would like the list to be like this: (a) Have a drag handle and be drag-reorderable (missing in Kirigami (b) On hover, show icon-based "Move to top"

D12102: Port Language KCM to Qt Quick

ngraham added a comment. > Pick your default language by moving topmost. To add more languages, click on the right. How about this? > The language at the top of this list is the one you want to see and use most often. To add more languages, click the "Add Languages..." button.

D12102: Port Language KCM to Qt Quick

hein added a comment. An early attempt at implementing @abetts new mockup: F5816409: Screenshot_20180421_232025.png F5816411: Screenshot_20180421_232046.png I didn't do the icons because: (a) I

D12102: Port Language KCM to Qt Quick

hein added a comment. I like the mockup, but yeah, still need to figure out ordering. As for the top text label, let's go with "Preferred languages" over "Installed languages" (also what the old KCM used). REPOSITORY R119 Plasma Desktop REVISION DETAIL

D12102: Port Language KCM to Qt Quick

rkflx added a comment. In D12102#250725 , @abetts wrote: > Here are additional mockups for thought.F5815917: Screen Shot 2018-04-20 at 10.54.07 PM.png Quite nice (the helpful text label in

D12102: Port Language KCM to Qt Quick

abetts added a comment. Here are additional mockups for thought.F5815917: Screen Shot 2018-04-20 at 10.54.07 PM.png F5815920: AddLanguageAnimation.mov REPOSITORY R119 Plasma Desktop REVISION DETAIL

D12102: Port Language KCM to Qt Quick

hein added a comment. Currently we use the following inline messages to communicate stuff btw: - An info box shown when there's no languages available to add (i.e. not installed) - An info box shown no languages have been added (but some are available) - An error box when some added

D12102: Port Language KCM to Qt Quick

abetts added a comment. I can make more REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12102 To: hein, #kirigami, mart Cc: rkflx, aspotashev, davidedmundson, safaalfulaij, abetts, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D12102: Port Language KCM to Qt Quick

hein added a comment. I think @rkflx gets that, he's talking just about the first list. I agree with his comments. Some more design mockups to work from would be nice :). REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12102 To: hein, #kirigami, mart Cc:

D12102: Port Language KCM to Qt Quick

abetts added a comment. In D12102#250486 , @rkflx wrote: > Hm, I could imagine regular users will have a hard time selecting their preferred language. They'll see a list of languages, and look for some kind of checkbox to "select what they

D12102: Port Language KCM to Qt Quick

rkflx added a comment. Hm, I could imagine regular users will have a hard time selecting their preferred language. They'll see a list of languages, and look for some kind of checkbox to "select what they want". How should they realize that the top-most language will be used as the default,

D12102: Port Language KCM to Qt Quick

hein added a comment. Updated screenshot, this time using the "Breeze" color scheme which has some contrast between window bg and view bg colors: F5815250: Screenshot_20180421_010244.png REPOSITORY R119 Plasma Desktop REVISION DETAIL

D12102: Port Language KCM to Qt Quick

hein updated this revision to Diff 32652. hein added a comment. Set color set, add padding, wrap in ScrollView. This is all a bit hacky and mostly to get VDG feedback. Known problems: - When the lang list grows out of bounds you get double-scrollbars because I couldn't find a

D12102: Port Language KCM to Qt Quick

hein added a comment. OK, the plot thickens. Turns out this is a color scheme problem. We have "Default" and "Breeze" color schemes. They used to be (and are supposed to be) identical. But right now, in my Colors KCM, switching between Default and Breeze produces different results.

D12102: Port Language KCM to Qt Quick

hein added a comment. Note btw that it's similarly broken for me in the new grid-based KCMs. We had the same discussion there where we want the grids to have the view background color behind them (white), but the grid in the Loon and Feel KCM for example is #fcfcfc for me. REPOSITORY

D12102: Port Language KCM to Qt Quick

hein added a comment. There's no white bg in the latest screenshot, the entire thing is #fcfcfc (window bg color). REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12102 To: hein, #kirigami, mart Cc: aspotashev, davidedmundson, safaalfulaij, abetts, ngraham,

D12102: Port Language KCM to Qt Quick

ngraham added a comment. Perhaps I'm blind, but in the latest screenshot it looks like there's already a white background. If anything, what we need is for the general background to be light gray like all the other KCMs, and for the list itself to retain its current white background

D12102: Port Language KCM to Qt Quick

hein added a comment. I'm actually having no luck with the white field thing currently. I tried setting `Kirigami.Theme.colorSet: Kirigami.Theme.View` on the ListView and then setting `backgroundColor: Kirigami.Theme.viewBackgroundColor` on the SwipeListItem delegate, which I would expect

D12102: Port Language KCM to Qt Quick

hein added a comment. I think we can do a white field. About the padding, I think it'd be cool if FormLayout could do this somehow. So it's automatic. (This code doesn't use FormLayout currently, though.) @mart? REPOSITORY R119 Plasma Desktop REVISION DETAIL

D12102: Port Language KCM to Qt Quick

abetts added a comment. Could the list be enclosed by a white field? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12102 To: hein, #kirigami, mart Cc: aspotashev, davidedmundson, safaalfulaij, abetts, ngraham, plasma-devel, ragreen, Pitel, ZrenBot,

D12102: Port Language KCM to Qt Quick

ngraham added a comment. And if this is a Kirigami convergence thing, IMHO we should think about having Kirigami automatically add a frame and some side padding when on desktop platforms, where having a list span the entire horizontal width rarely looks good. REPOSITORY R119 Plasma

D12102: Port Language KCM to Qt Quick

ngraham added a comment. I'm not a huge fan of the fact that the list items take up the entire horizontal width and have no side borders. Makes things feel rather visually muddy, like things are too big and flowing into one another. Could we put that whole list inside a frame with a

D12102: Port Language KCM to Qt Quick

hein added a comment. In D12102#250237 , @aspotashev wrote: > Looking at the screenshots, it's unclear which language do the up/down buttons belong to. Can we use drag'n'drop? Can we embed the buttons into the language row next to the language

D12102: Port Language KCM to Qt Quick

hein updated this revision to Diff 32647. hein added a comment. Add context to strings. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12102?vs=32597=32647 BRANCH master REVISION DETAIL https://phabricator.kde.org/D12102 AFFECTED FILES

D12102: Port Language KCM to Qt Quick

aspotashev added inline comments. INLINE COMMENTS > main.qml:59 > + > +header: Kirigami.Heading { text: i18n("Add Languages") } > + Please add context: i18nc("@title:window", "Add Languages") > main.qml:108 > + > +text: i18n("Add") > + Please add context for

D12102: Port Language KCM to Qt Quick

aspotashev added a comment. Looking at the screenshots, it's unclear which language do the up/down buttons belong to. Can we use drag'n'drop? Can we embed the buttons into the language row next to the language name? REPOSITORY R119 Plasma Desktop REVISION DETAIL

D12102: Port Language KCM to Qt Quick

hein updated this revision to Diff 32597. hein added a comment. Fix logic bug in managing the sheet's Add button enabled state. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12102?vs=32589=32597 BRANCH master REVISION DETAIL

D12102: Port Language KCM to Qt Quick

hein added a comment. About the overlay sheet close button missing a hover effect: @mart committed 66402004783 to kirigami.git, but it's not working for me and the icon on the button is also scaled wrong somehow

D12102: Port Language KCM to Qt Quick

hein added a comment. @mart Remaining issues: - I need an 'animating' property on OverlaySheet similar to other components, so I can delay unsetting the source model for the list view in the sheet until after the sheet is done animating. I want to unset the model to save resources but

D12102: Port Language KCM to Qt Quick

hein updated this revision to Diff 32589. hein added a comment. - Disable the "Add languages..." button when no languages are available and show an InlineMessage - Fix using the overlay sheet more than once to add languages within the same session (QStringList props and concat() with

D12102: Port Language KCM to Qt Quick

davidedmundson added a comment. It's looking a trillion times better than the early screenshots. Some feedback from a quick test: - close icon in the "add" popup doesn't have a mouseover effect so it looks a bit weird - I have no languages installed and that makes the popup look

D12102: Port Language KCM to Qt Quick

hein added a comment. + pushed a revert commit. Thanks! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12102 To: hein, #kirigami, mart Cc: davidedmundson, safaalfulaij, abetts, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D12102: Port Language KCM to Qt Quick

hein reopened this revision. hein added a comment. Reopen for review. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12102 To: hein, #kirigami, mart Cc: davidedmundson, safaalfulaij, abetts, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai,

D12102: Port Language KCM to Qt Quick

hein added a comment. Arf, no, sorry. I forgot over a week's worth of vacation that I had this on the same branch as something else. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12102 To: hein, #kirigami, mart Cc: davidedmundson, safaalfulaij, abetts,

D12102: Port Language KCM to Qt Quick

davidedmundson added a comment. > This revision was not accepted when it landed; it landed in state Changes Planned.Wed, Apr 18, 8:54 PM Was this intentionally merged? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12102 To: hein, #kirigami, mart Cc:

D12102: Port Language KCM to Qt Quick

This revision was not accepted when it landed; it landed in state "Changes Planned". This revision was automatically updated to reflect the committed changes. Closed by commit R119:5e6353d2824f: Port Language KCM to Qt Quick (authored by hein). REPOSITORY R119 Plasma Desktop CHANGES SINCE

D12102: Port Language KCM to Qt Quick

mart added a comment. on kirigami master the swipelistitem should look more desktopy REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12102 To: hein, #kirigami, mart Cc: safaalfulaij, abetts, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai,

D12102: Port Language KCM to Qt Quick

hein added a comment. In D12102#244758 , @abetts wrote: > Would it be hard to include a checkbox to the left of each list item that shows a selection when tapped? Sorry, can you explain which of the two lists and what "shows a selection

D12102: Port Language KCM to Qt Quick

safaalfulaij added inline comments. INLINE COMMENTS > translationsmodel.cpp:124 > + > +QString TranslationsModel::languageCodeToName(const QString& languageCode) > const > +{ About this and the fact the Qt doesn't still have an API for returning the language according to the current locale,

D12102: Port Language KCM to Qt Quick

abetts added a comment. Would it be hard to include a checkbox to the left of each list item that shows a selection when tapped? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12102 To: hein, #kirigami, mart Cc: abetts, ngraham, plasma-devel, ragreen,

D12102: Port Language KCM to Qt Quick

hein planned changes to this revision. hein added a comment. Still not meant for review. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12102 To: hein, #kirigami, mart Cc: abetts, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D12102: Port Language KCM to Qt Quick

hein updated this revision to Diff 31923. hein added a comment. Use ListViews REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12102?vs=31843=31923 BRANCH master REVISION DETAIL https://phabricator.kde.org/D12102 AFFECTED FILES

D12102: Port Language KCM to Qt Quick

hein added subscribers: ngraham, abetts. hein added a comment. Note: The screenshots don't look like the mockup in T7247 because that's outdated. The VDG channel had a long discussion about the KCM a few weeks ago and decided on a single list + modal

D12102: Port Language KCM to Qt Quick

hein added a comment. Some shots: F5803407: Screenshot_20180411_072428.png F5803409: Screenshot_20180411_072443.png REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12102

D12102: Port Language KCM to Qt Quick

hein created this revision. hein added reviewers: Kirigami, mart. Restricted Application added projects: Plasma, Kirigami. Restricted Application added a subscriber: plasma-devel. hein requested review of this revision. REVISION SUMMARY - Changed the overall design from two lists to one list