D12476: kcm_opengl: Fix retrieval of DRI information

This revision was automatically updated to reflect the committed changes. Closed by commit R102:e38d60fb23f7: kcm_opengl: Fix retrieval of DRI information (authored by roberts). REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12476?vs=33565=33701 REVISION

D12476: kcm_opengl: Fix retrieval of DRI information

alexeymin accepted this revision. alexeymin added a comment. This revision is now accepted and ready to land. In D12476#258427 , @roberts wrote: > It will fail gracefully, it checks for the presence of these /proc or /sys files and only acts if

D12476: kcm_opengl: Fix retrieval of DRI information

roberts added a comment. It will fail gracefully, it checks for the presence of these /proc or /sys files and only acts if they exist. This code is only called if an EGL context is successfully created in any case, and in fact on Wayland rendering _is_ always direct. REPOSITORY R102

D12476: kcm_opengl: Fix retrieval of DRI information

alexeymin added a comment. I'm not completely sure that IsDirect should be manually set to true in wayland code path (it looks like a hack just to test). What happens if IsDirect is set to true, but software rendering is active? Will get_dri_device() fail gracefully or something horrible

D12476: kcm_opengl: Fix retrieval of DRI information

roberts updated this revision to Diff 33565. roberts added a comment. Update to set IsDirect under Wayland. Managed to run kwin_wayland embedded in an X11 session to confirm. REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12476?vs=32999=33565

D12476: kcm_opengl: Fix retrieval of DRI information

roberts marked an inline comment as done. roberts added a comment. Alexey: That sounds great, but unfortunately I can't get a wayland session to log in no matter how hard I try, so I can't confirm your changes. I'd suggest creating a separate review with your additions if you want to pursue

D12476: kcm_opengl: Fix retrieval of DRI information

alexeymin added a comment. I've tested this and it seems to work! F5821132: kinfocenter DRI info wayland.png But in wayland I had to add some changes: set `IsDirect = true;` before calling `print_screen_info()` in `get_gl_info_egl_qt()` line ~

D12476: kcm_opengl: Fix retrieval of DRI information

roberts marked an inline comment as done. roberts added inline comments. INLINE COMMENTS > wbauer wrote in opengl.cpp:211 > Using just "/driver" (instead of "/driver/module") makes it display "radeon" > instead of "drm" here as I would expect. > > OTOH, as it already runs lspci to get the

D12476: kcm_opengl: Fix retrieval of DRI information

roberts updated this revision to Diff 32999. roberts added a comment. Update to use /driver over /driver/module per review. REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12476?vs=32904=32999 BRANCH kcm_opengl_fix_dri_info REVISION DETAIL

D12476: kcm_opengl: Fix retrieval of DRI information

wbauer added a comment. I gave the patch a try (openSUSE Leap 42.3 with kernel 4.4). The 3D accelerator info is displayed again now (as with kernel < 3.12), but it shows "drm" as kernel module instead of "radeon" as I would expect. INLINE COMMENTS > opengl.cpp:211 > +dri_info.pci =

D12476: kcm_opengl: Fix retrieval of DRI information

roberts created this revision. roberts added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. roberts requested review of this revision. REVISION SUMMARY Currently DRI information retrieval is attempted via /proc/dri,