D14339: Remove confusing icons from rotation combobox

gladhorn updated this revision to Diff 38486. gladhorn added a comment. Updated message hopefully REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14339?vs=38382=38486 BRANCH arcpatch-D14339 REVISION DETAIL https://phabricator.kde.org/D14339 AFFECTED

D14339: Remove confusing icons from rotation combobox

gladhorn added a comment. And I see that arc just threw away my updated commit message :(, that's just weird. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D14339 To: gladhorn, #plasma, #vdg, ngraham Cc: abetts, ngraham, plasma-devel, ragreen, Pitel, ZrenBot,

D14339: Remove confusing icons from rotation combobox

gladhorn added a comment. In D14339#297849 , @ngraham wrote: > Looks nice! > > I would approve of using radio buttons or four actual inline buttons instead of a combobox. > > Also +1 on "No Rotation" instead of "Normal", and for doing

D14339: Remove confusing icons from rotation combobox

ngraham added a comment. Looks nice! I would approve of using radio buttons or four actual inline buttons instead of a combobox. Also +1 on "No Rotation" instead of "Normal", and for doing that in another patch. REPOSITORY R104 KScreen REVISION DETAIL

D14339: Remove confusing icons from rotation combobox

gladhorn added a comment. Note: I'm all for text changes, but they should be another independent patch. I was also wondering if it makes sense to use a combo box in the first place - we know it's four options always, should it maybe just be four buttons/radio buttons/something else?

D14339: Remove confusing icons from rotation combobox

gladhorn added a comment. F6137062: kcm_rotation_preview.png REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D14339 To: gladhorn, #plasma, #vdg, ngraham Cc: abetts, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai,

D14339: Remove confusing icons from rotation combobox

gladhorn updated this revision to Diff 38382. gladhorn added a comment. Use preview icon REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14339?vs=38350=38382 BRANCH master REVISION DETAIL https://phabricator.kde.org/D14339 AFFECTED FILES

D14339: Remove confusing icons from rotation combobox

gladhorn added a comment. In D14339#297233 , @abetts wrote: > In D14339#297211 , @ngraham wrote: > > > Hmm, instead of removing them, I'd prefer if we used better icons. Maybe like that little icon

D14339: Remove confusing icons from rotation combobox

ngraham added a comment. Something like this set: F6136542: view-preview0.png F6136543: view-preview90.png F6136544: view-preview180.png F6136545:

D14339: Remove confusing icons from rotation combobox

abetts added a comment. In D14339#297211 , @ngraham wrote: > Hmm, instead of removing them, I'd prefer if we used better icons. Maybe like that little icon of a mountain and a sun within a frame that we already have--but rotated. > > With

D14339: Remove confusing icons from rotation combobox

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Hmm, instead of removing them, I'd prefer if we used better icons. Maybe like that little icon of a mountain and a sun within a frame that we already have--but rotated.

D14339: Remove confusing icons from rotation combobox

gladhorn added a comment. Before, with the icons: F6135574: kcm_rot_before.png Without: F6135577: kcm_rot_after.png Comments appreciated, maybe these should be buttons, but imho this is a low-hanging

D14339: Remove confusing icons from rotation combobox

gladhorn updated this revision to Diff 38350. gladhorn added a comment. Accidentally added new ui file, thanks arc :( REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14339?vs=38349=38350 BRANCH master REVISION DETAIL https://phabricator.kde.org/D14339

D14339: Remove confusing icons from rotation combobox

gladhorn created this revision. gladhorn added reviewers: Plasma, VDG. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. gladhorn requested review of this revision. REVISION SUMMARY Right now there is an icon associated with each rotation,