This revision was automatically updated to reflect the committed changes.
Closed by commit R98:6ec73bf06938: share common values for both Breeze and
Breeze-dark GTK themes (authored by Matthias Groß a.gr...@sub.red,
committed by ngraham).
CHANGED PRIOR TO COMMIT
ngraham added a comment.
@grmat, could you provide your full name and email address so I can add your
authorship information? Thanks!
REPOSITORY
R98 Breeze for Gtk
REVISION DETAIL
https://phabricator.kde.org/D16365
To: ohelin, jackg, #breeze, #plasma, ngraham
Cc: grmat, ngraham,
ngraham added a comment.
Nah, you did great! The only thing you could have done to make this easier
would have been to submit two patches: one to templatize the code, and a second
one to make functional changes. But Phabricator makes this workflow somewhat
awkward and more difficult than it
grmat added a comment.
Thanks for the comments, review and for splitting up the diff. I also know it
was daunting to review the patch in its original form and I could've done that
better.
REPOSITORY
R98 Breeze for Gtk
REVISION DETAIL
https://phabricator.kde.org/D16365
To: ohelin,
ngraham accepted this revision.
ngraham added a subscriber: grmat.
ngraham added a comment.
This revision is now accepted and ready to land.
I haven't noticed any problems running with this over the past few days. It's
unfortunate that neither the maintainer (@jackg) nor anyone else familiar
ohelin added a comment.
Nada from here, I'd say go ahead.
REPOSITORY
R98 Breeze for Gtk
REVISION DETAIL
https://phabricator.kde.org/D16365
To: ohelin, jackg, #breeze, #plasma
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas,
