D16945: Fix fallback to built-in ui

2019-01-12 Thread Martin Flöser
This revision was automatically updated to reflect the committed changes. Closed by commit R133:dfd02160746b: Fix fallback to built-in ui (authored by graesslin). REPOSITORY R133 KScreenLocker CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16945?vs=45744=49330 REVISION DETAIL

D16945: Fix fallback to built-in ui

2018-11-18 Thread Martin Flöser
graesslin updated this revision to Diff 45744. graesslin added a comment. Adjust in the way David suggested. REPOSITORY R133 KScreenLocker CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16945?vs=45633=45744 BRANCH fix-fallback REVISION DETAIL

D16945: Fix fallback to built-in ui

2018-11-18 Thread David Edmundson
davidedmundson added a comment. Ship it if you like, but I think there's a nicer solution. INLINE COMMENTS > greeterapp.cpp:313 > // on error, load the fallback lockscreen to not lock the user out > of the system > -if (view->status() == QQmlComponent::Error) { > +

D16945: Fix fallback to built-in ui

2018-11-17 Thread Martin Flöser
graesslin created this revision. graesslin added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. graesslin requested review of this revision. REVISION SUMMARY If the lock screen package is not available m_mainQmlPath is an empty URL. Thus