D16997: [kcm] Expose interface to control output property retention

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R104:62837af06b2b: [kcm] Expose interface to control output property retention (authored by romangg). REPOSITORY R104

D16997: [kcm] Expose interface to control output property retention

romangg updated this revision to Diff 59722. romangg added a comment. Rebase on series changes. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16997?vs=59670=59722 BRANCH 1controlKcm REVISION DETAIL https://phabricator.kde.org/D16997 AFFECTED FILES common/control.cpp

D16997: [kcm] Expose interface to control output property retention

romangg added a comment. I leave the text as is for now. Let's discuss next week at Plasma Sprint. I would like to see that the last bits of QWidgets get removed in the KCM as well. This could be done together then. Also as I said earlier having retention control per output is too

D16997: [kcm] Expose interface to control output property retention

romangg updated this revision to Diff 59670. romangg added a comment. Rebase on master. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16997?vs=57835=59670 BRANCH 1controlKcm REVISION DETAIL https://phabricator.kde.org/D16997 AFFECTED FILES common/control.cpp

D16997: [kcm] Expose interface to control output property retention

romangg updated this revision to Diff 57835. romangg added a comment. Rebase on series changes. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16997?vs=57720=57835 BRANCH 1controlKcm REVISION DETAIL https://phabricator.kde.org/D16997 AFFECTED FILES common/control.cpp

D16997: [kcm] Expose interface to control output property retention

romangg added a comment. Another detail is that currently in a display arrangement with multiple screens one of the screens could use arrangement-unique values while another screen could use global ones. This is imo too complicated. Either the user wants to write/read to global values for

D16997: [kcm] Expose interface to control output property retention

romangg added a comment. In D16997#462264 , @ngraham wrote: > In D16997#462197 , @romangg wrote: > > > [...] > > That's good wording. The only issue I see is that a display arrangement, which

D16997: [kcm] Expose interface to control output property retention

ngraham added a comment. In D16997#462197 , @romangg wrote: > In D16997#459604 , @ngraham wrote: > > > @romangg and I talked and now I understand the feature and think it's a good idea. It needs to

D16997: [kcm] Expose interface to control output property retention

romangg added a comment. In D16997#459604 , @ngraham wrote: > @romangg and I talked and now I understand the feature and think it's a good idea. It needs to be exposed to the user in a way that's immediately apparent though. Here's my

D16997: [kcm] Expose interface to control output property retention

romangg updated this revision to Diff 57720. romangg added a comment. Rebase on series changes. REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16997?vs=57671=57720 BRANCH 1controlKcm REVISION DETAIL https://phabricator.kde.org/D16997 AFFECTED FILES

D16997: [kcm] Expose interface to control output property retention

romangg planned changes to this revision. romangg added a comment. Changes still need to go back in other diffs in the series. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D16997 To: romangg, #plasma Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel,

D16997: [kcm] Expose interface to control output property retention

romangg updated this revision to Diff 57671. romangg added a comment. Rebase on series changes. REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16997?vs=45768=57671 BRANCH 1controlKcm REVISION DETAIL https://phabricator.kde.org/D16997 AFFECTED FILES

D16997: [kcm] Expose interface to control output property retention

ngraham added a comment. @romangg and I talked and now I understand the feature and think it's a good idea. It needs to be exposed to the user in a way that's immediately apparent though. Here's my recommendation 1. Default to global settings 2. When there is only configuration data

D16997: [kcm] Expose interface to control output property retention

romangg added a comment. In D16997#361978 , @ngraham wrote: > I'll admit just looking at the new UI, it's not entirely clear what either of the options do. Can you help me understand? Thanks Roman! I replied to your mail to the

D16997: [kcm] Expose interface to control output property retention

ngraham added a comment. Visually, let's follow the existing formlayout style in the KCM and put the label to the left of the radio buttons rather than using a group box. Also, the two radio button labels shouldn't end with periods. I'll admit just looking at the new UI, it's not

D16997: [kcm] Expose interface to control output property retention

romangg planned changes to this revision. romangg added a comment. This diff contains some fix, that need to go into earlier diffs in this patch series. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D16997 To: romangg, #plasma Cc: plasma-devel, ragreen, Pitel,

D16997: [kcm] Expose interface to control output property retention

romangg created this revision. romangg added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. romangg requested review of this revision. REVISION SUMMARY This adds two radio buttons to the kcm, that allow to change the output property retention of