D17321: Change panel edit mode icon from from a hamburger icon to a configure icon

2018-12-15 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes. Closed by commit R119:1ae7f9fece38: Change panel edit mode icon from from a hamburger icon to a configure icon (authored by GB_2, committed by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://

D17321: Change panel edit mode icon from from a hamburger icon to a configure icon

2018-12-15 Thread Björn Feber
GB_2 updated this revision to Diff 47615. GB_2 added a comment. Remove unneeded line. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17321?vs=46739&id=47615 REVISION DETAIL https://phabricator.kde.org/D17321 AFFECTED FILES toolboxes/paneltoolbo

D17321: Change panel edit mode icon from from a hamburger icon to a configure icon

2018-12-14 Thread Björn Feber
GB_2 requested review of this revision. GB_2 added inline comments. INLINE COMMENTS > davidedmundson wrote in main.qml:58 > This doesn't make sense.. > > We're re-evaulating because hasElement might have changed when switching > themes. So just remove the line? REPOSITORY R119 Plasma Deskto

D17321: Change panel edit mode icon from from a hamburger icon to a configure icon

2018-12-14 Thread Andres Betts
abetts added a comment. Thanks Dave! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17321 To: GB_2, #plasma, #vdg, ngraham, davidedmundson Cc: davidedmundson, abetts, ngraham, #vdg, plasma-devel, #plasma, squeakypancakes, alexde, IohannesPetros, GB_2, tricky

D17321: Change panel edit mode icon from from a hamburger icon to a configure icon

2018-12-14 Thread David Edmundson
davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. If Nate and Andy say to use this icon, go for it. One code change INLINE COMMENTS > main.qml:58 > imagePath: "widgets/configuration-icons" > -

D17321: Change panel edit mode icon from from a hamburger icon to a configure icon

2018-12-09 Thread Andres Betts
abetts added a comment. +1 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17321 To: GB_2, #plasma, #vdg, ngraham Cc: abetts, ngraham, #vdg, plasma-devel, #plasma, alexde, IohannesPetros, trickyricky26, ragreen, Pitel, crozbo, ndavis, ZrenBot, firef, skadinna

D17321: Change panel edit mode icon from from a hamburger icon to a configure icon

2018-12-09 Thread Nathaniel Graham
ngraham added a comment. #plasma folks, any comments, or shall we land this? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17321 To: GB_2, #plasma, #vdg, ngraham Cc: ngraham, #vdg, plasma-devel, #plasma, alexde, Ioh