D18805: Workaround for the bug 393630 - SystemTray part

This revision was automatically updated to reflect the committed changes. Closed by commit R120:6fcf9a5e03ba: Fix System Tray popup interactivity after echanging item visiblity (authored by trmdi, committed by ngraham). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D18805: Workaround for the bug 393630 - SystemTray part

trmdi added a comment. In D18805#407599 , @fvogt wrote: > You can select "Abandon revision" as action. Done. Thank you. :) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D18805 To: trmdi, #plasma,

D18805: Workaround for the bug 393630 - SystemTray part

fvogt added a comment. In D18805#407542 , @trmdi wrote: > Use @davidedmundson 's approach. > > @ngraham Could you please help me to discard D18804 ? This patch does not require it anymore. You can

D18805: Workaround for the bug 393630 - SystemTray part

trmdi added a comment. @davidedmundson Nice approach. I don't really understand the root cause though. So, could you please do it for me? Thank you! REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D18805 To: trmdi, #plasma, ngraham, broulik,

D18805: Workaround for the bug 393630 - SystemTray part

anthonyfieroni added a comment. Ok, so @trmdi you can apply exactly David suggest and discard D18804 , i've test it and it works. Push it in 5.15 not 5.16 that's bug fix not feature. 5.12 can be also interested path as LTS version. REPOSITORY R120

D18805: Workaround for the bug 393630 - SystemTray part

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. > I really don't know that sharing model between contexts cause a such behavior. Sorry, I used the wrong word. Sharing contexts is fine. Sharing across

D18805: Workaround for the bug 393630 - SystemTray part

anthonyfieroni added a comment. @davidedmundson it works. I really don't know that sharing model between contexts cause a such behavior. It's caused by some ref counting ? Did you know why, it's internal Qt issue that we can fix or it's expected ? REPOSITORY R120 Plasma Workspace

D18805: Workaround for the bug 393630 - SystemTray part

davidedmundson added a comment. If the only usage is the SNI model lets just rebuild the model on the ConfigEntries side. You're right that sharing objects between contexts seems to cause issues. It's backed by a datasource so all the heavy operations are already implicitly shared.

D18805: Workaround for the bug 393630 - SystemTray part

trmdi added a comment. In D18805#406916 , @anthonyfieroni wrote: > I notice that something with model goes wrong. I've try to fix it in D18249 but unfortunately I don't see problem in. Does my

D18805: Workaround for the bug 393630 - SystemTray part

anthonyfieroni added a comment. I notice that something with model goes wrong. I've try to fix it in D18249 but unfortunately I don't see problem in. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D18805 To: trmdi,

D18805: Workaround for the bug 393630 - SystemTray part

trmdi created this revision. trmdi added reviewers: Plasma, ngraham, broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. trmdi requested review of this revision. REVISION SUMMARY - Require: https://phabricator.kde.org/D18804 BUG: 393630 REPOSITORY R120