D21030: [WidgetExplorer] Fix blurry previews

2019-05-06 Thread Filip Fila
filipf added a comment. In D21030#461696 , @ngraham wrote: > Looks like you cherry-picked the commit onto each branch, is that right? In general it's preferred to land the commit onto the oldest branch and then merge forward. See

D21030: [WidgetExplorer] Fix blurry previews

2019-05-06 Thread Nathaniel Graham
ngraham added a comment. Looks like you cherry-picked the commit onto each branch, is that right? In general it's preferred to land the commit onto the oldest branch and then merge forward. See https://community.kde.org/Infrastructure/Phabricator#Landing_on_the_.22Stable_branch.22 I

D21030: [WidgetExplorer] Fix blurry previews

2019-05-06 Thread Filip Fila
This revision was automatically updated to reflect the committed changes. Closed by commit R119:29f0bea89889: [WidgetExplorer] Fix blurry previews (authored by filipf). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21030?vs=57617=57650 REVISION

D21030: [WidgetExplorer] Fix blurry previews

2019-05-06 Thread Nathaniel Graham
ngraham added a comment. I was thinking 5.15 only, but 5.12 too is probably fine for a focused change like this. https://community.kde.org/Infrastructure/Phabricator#Landing_on_the_.22Stable_branch.22 REPOSITORY R119 Plasma Desktop BRANCH no-blurry-previews-widget-explorer

D21030: [WidgetExplorer] Fix blurry previews

2019-05-06 Thread Filip Fila
filipf added a comment. In D21030#461363 , @ngraham wrote: > Nice! Stable branch please. So both 5.12 and 5.15? REPOSITORY R119 Plasma Desktop BRANCH no-blurry-previews-widget-explorer (branched from master) REVISION DETAIL

D21030: [WidgetExplorer] Fix blurry previews

2019-05-05 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Nice! Stable branch please. REPOSITORY R119 Plasma Desktop BRANCH no-blurry-previews-widget-explorer (branched from master) REVISION DETAIL https://phabricator.kde.org/D21030 To:

D21030: [WidgetExplorer] Fix blurry previews

2019-05-05 Thread Filip Fila
filipf updated this revision to Diff 57617. filipf added a comment. use Math.floor instead of Math.round REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21030?vs=57588=57617 BRANCH no-blurry-previews-widget-explorer (branched from master)

D21030: [WidgetExplorer] Fix blurry previews

2019-05-05 Thread Nathaniel Graham
ngraham requested changes to this revision. ngraham added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > WidgetExplorer.qml:295 > keyNavigationWraps: true > -cellWidth: (width - units.smallSpacing) / 2 > +cellWidth:

D21030: [WidgetExplorer] Fix blurry previews

2019-05-05 Thread Filip Fila
filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY Round the cell width to avoid getting blurry previews. NOTE: It also seems further improvements could be done for the icons