D23342: Add a per-process network information plugin

bcooksley added a comment. Please see https://build.kde.org/job/Plasma/job/ksysguard/job/kf5-qt5%20FreeBSDQt5.13/10/console This has now caused Dependency Builds to fail, which means CI for Plasma is now unmaintainable. Could we please get this fixed? REPOSITORY R106 KSysguard

D23342: Add a per-process network information plugin

This revision was automatically updated to reflect the committed changes. Closed by commit R106:842d64591d84: Add a per-process network information plugin (authored by ahiemstra). REPOSITORY R106 KSysguard CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23342?vs=65214=66195 REVISION

D23342: Add a per-process network information plugin

ahiemstra added a comment. That's correct. The reason for that is that a non-root process is not allowed to read which inodes root process has open, thus there is no way for the helper to map from incoming port to process ID. The only way I know of solving that is by having the helper run

D23342: Add a per-process network information plugin

meven added a comment. According to my testing, it does not measure traffic for root's processes such as apt. Am I missing something ? Can we improve on the situation ? REPOSITORY R106 KSysguard BRANCH network_plugin REVISION DETAIL https://phabricator.kde.org/D23342 To:

D23342: Add a per-process network information plugin

meven accepted this revision. meven added a comment. This revision is now accepted and ready to land. Seems good to me ! I am using this now, and it is great. But my review does not weight much as I am not a ksysguard maintainer/developer. It makes me want to add a network graph

D23342: Add a per-process network information plugin

ahiemstra added a comment. The readme already mentions it needs cap_net_raw. But I've now added a line on how to ensure that it has that. REPOSITORY R106 KSysguard REVISION DETAIL https://phabricator.kde.org/D23342 To: ahiemstra, #plasma, meven Cc: meven, davidedmundson, plasma-devel,

D23342: Add a per-process network information plugin

ahiemstra updated this revision to Diff 65214. ahiemstra added a comment. - Add a line that explains using setcap for cap_net_raw REPOSITORY R106 KSysguard CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23342?vs=64310=65214 BRANCH network_plugin REVISION DETAIL

D23342: Add a per-process network information plugin

meven added a comment. In D23342#523626 , @davidedmundson wrote: > > This could be run on package install by distributions, or we could add an action somewhere to let the user run it on demand. > > It is run automatically in the cmake. >

D23342: Add a per-process network information plugin

davidedmundson added a comment. > This could be run on package install by distributions, or we could add an action somewhere to let the user run it on demand. It is run automatically in the cmake. See plugins/process/network/helper/CMakeLists.txt I think that should be enough

D23342: Add a per-process network information plugin

meven requested changes to this revision. meven added a comment. This revision now requires changes to proceed. The command `sudo setcap cap_net_raw+ep ksgrd_network_helper` needs to be documented outside of just the commit message, in `plugins/process/network/README.md` at least. This

D23342: Add a per-process network information plugin

meven added a comment. It works nicely. I thought it missed a screenshot here. F7303942: Screenshot_20190901_084433.png REPOSITORY R106 KSysguard REVISION DETAIL https://phabricator.kde.org/D23342 To: ahiemstra, #plasma Cc: meven,

D23342: Add a per-process network information plugin

ahiemstra updated this revision to Diff 64310. ahiemstra added a comment. - Use libexec dir for the helper install location - Don't use nonexistant variables REPOSITORY R106 KSysguard CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23342?vs=64295=64310 BRANCH network_plugin

D23342: Add a per-process network information plugin

ahiemstra added inline comments. INLINE COMMENTS > davidedmundson wrote in CMakeLists.txt:26 > There's nothing at runtime, but we know KDE_INSTALL_LIBEXECDIR_FULL at > configure time, so we can pass that to the plugin. Oh, that's a good idea, I totally did not think about that. REPOSITORY

D23342: Add a per-process network information plugin

davidedmundson added inline comments. INLINE COMMENTS > ahiemstra wrote in CMakeLists.txt:26 > We can, if there is a decent way to find executables in libexec, because I > couldn't find anything in QStandardPaths. There's nothing at runtime, but we know KDE_INSTALL_LIBEXECDIR_FULL at

D23342: Add a per-process network information plugin

ahiemstra marked an inline comment as done. ahiemstra added inline comments. INLINE COMMENTS > davidedmundson wrote in CMakeLists.txt:26 > Can we use KDE_INSTALL_LIBEXECDIR? We can, if there is a decent way to find executables in libexec, because I couldn't find anything in QStandardPaths.

D23342: Add a per-process network information plugin

davidedmundson added inline comments. INLINE COMMENTS > CMakeLists.txt:21 > + > +if (HAVE_LIBCAP) > +install( This isn't set. libcap_FOUND is > CMakeLists.txt:26 > +CAP_NET_RAW=+ep > +\$ENV{DESTDIR}${CMAKE_INSTALL_FULL_BINDIR}/ksgrd_network_helper)" > +) Can we use

D23342: Add a per-process network information plugin

ahiemstra marked 2 inline comments as done. ahiemstra added inline comments. INLINE COMMENTS > davidedmundson wrote in network.cpp:74 > why 2? We call parts.at(6) > > Also code style {} Good point. I cannot recall why I used 2 so changed it to 7 now. REPOSITORY R106 KSysguard REVISION

D23342: Add a per-process network information plugin

ahiemstra updated this revision to Diff 64295. ahiemstra added a comment. - Reject lines <7 elements instead of <2 REPOSITORY R106 KSysguard CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23342?vs=64293=64295 BRANCH network_plugin REVISION DETAIL

D23342: Add a per-process network information plugin

ahiemstra updated this revision to Diff 64293. ahiemstra added a comment. - Add missing header and remove unneeded forward declares - Code style fixes REPOSITORY R106 KSysguard CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23342?vs=64289=64293 BRANCH network_plugin

D23342: Add a per-process network information plugin

davidedmundson added inline comments. INLINE COMMENTS > network.cpp:74 > +const auto parts = line.splitRef(QLatin1Char('|'), > QString::SkipEmptyParts); > +if (parts.size() < 2) > +continue; why 2? We call parts.at(6) Also code style {} >

D23342: Add a per-process network information plugin

ahiemstra created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ahiemstra requested review of this revision. REVISION SUMMARY This adds a ksysguard process plugin that provides information about how much data is being used by a certain process. Since