D27783: Add new Account portal

2020-03-23 Thread Jan Grulich
This revision was automatically updated to reflect the committed changes. Closed by commit R838:75a8fa728347: Add new Account portal (authored by jgrulich). REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop CHANGES SINCE LAST UPDATE

D27783: Add new Account portal

2020-03-23 Thread Jan Grulich
jgrulich added a comment. In D27783#632940 , @ngraham wrote: > Ah, thanks. LGTM. Would you be okay with me submitting a patch to alter/polish the UI after it lands? Absolutely! REPOSITORY R838 Flatpak Support: KDE Portal for XDG

D27783: Add new Account portal

2020-03-23 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Ah, thanks. LGTM. Would you be okay with me submitting a patch to alter/polish the UI after it lands? REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop BRANCH

D27783: Add new Account portal

2020-03-23 Thread Jan Grulich
jgrulich added a comment. In D27783#632900 , @ngraham wrote: > Ok. When trying to compile I get the following: > > In file included from ../libportal/portal-qt5.h:20, >from

D27783: Add new Account portal

2020-03-23 Thread Nathaniel Graham
ngraham added a comment. Ok. When trying to compile I get the following: In file included from ../libportal/portal-qt5.h:20, from libportal-qt/a370903@@LibPortalQt@sha/../../../libportal-qt/portal_p.h:24, from

D27783: Add new Account portal

2020-03-23 Thread Jan Grulich
jgrulich added a comment. In D27783#632600 , @ngraham wrote: > How can I test this? I don't know if there is any application using this, but I test it with my testing application in libportal. You can get it here:

D27783: Add new Account portal

2020-03-22 Thread Nathaniel Graham
ngraham added a comment. How can I test this? REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop REVISION DETAIL https://phabricator.kde.org/D27783 To: jgrulich, #plasma, ngraham Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas,

D27783: Add new Account portal

2020-03-21 Thread Jan Grulich
jgrulich added a comment. In D27783#630734 , @ngraham wrote: > UserInfoDialog.qml an Item with a Rectangle in it, could you use a Window? > > https://doc.qt.io/qt-5/qml-qtquick-window-window.html I don't think that would be correct

D27783: Add new Account portal

2020-03-19 Thread Nathaniel Graham
ngraham added a comment. UserInfoDialog.qml an Item with a Rectangle in it, could you use a Window? https://doc.qt.io/qt-5/qml-qtquick-window-window.html REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop REVISION DETAIL https://phabricator.kde.org/D27783 To: jgrulich,

D27783: Add new Account portal

2020-03-02 Thread Jan Grulich
jgrulich created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. jgrulich requested review of this revision. REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop BRANCH account-portal REVISION DETAIL https://phabricator.kde.org/D27783