D28989: [applets/notifications] Widen pop-up and reduce spacing when on top or bottom center

2020-04-22 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes. Closed by commit R120:0e40a1cadf48: [applets/notifications] Widen pop-up and reduce spacing when on top or bottom… (authored by ngraham). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D28989: [applets/notifications] Widen pop-up and reduce spacing when on top or bottom center

2020-04-22 Thread Bhushan Shah
bshah accepted this revision. bshah added a comment. Sorry for delay in testing this, works fine! REPOSITORY R120 Plasma Workspace BRANCH wider-notification-popu-when-on-top-or-bottom (branched from master) REVISION DETAIL https://phabricator.kde.org/D28989 To: ngraham, #vdg,

D28989: [applets/notifications] Widen pop-up and reduce spacing when on top or bottom center

2020-04-20 Thread Nathaniel Graham
ngraham added a subscriber: bshah. ngraham added a comment. @bshah I think you said you wanted to see how this worked for PlaMo before I landed it? Have you had a chance to do that yet? REPOSITORY R120 Plasma Workspace BRANCH wider-notification-popu-when-on-top-or-bottom (branched from

D28989: [applets/notifications] Widen pop-up and reduce spacing when on top or bottom center

2020-04-19 Thread Nathaniel Graham
ngraham added a comment. Well, they don't extend so far into the center of the screen as they used to. There's no way to make a notification pop-up not block anything. This patch is what feels best for me, as most of the tools and tabs I'm going to be using are more towards the edges of

D28989: [applets/notifications] Widen pop-up and reduce spacing when on top or bottom center

2020-04-19 Thread Ilya Bizyaev
IlyaBizyaev added a comment. On the screenshots, the notifications block tab bars and toolbars in 3 apps :) Are you sure it's more convenient? REPOSITORY R120 Plasma Workspace BRANCH wider-notification-popu-when-on-top-or-bottom (branched from master) REVISION DETAIL

D28989: [applets/notifications] Widen pop-up and reduce spacing when on top or bottom center

2020-04-19 Thread Kai Uwe Broulik
broulik accepted this revision. broulik added a comment. The lack of spacing looks bad but whatever REPOSITORY R120 Plasma Workspace BRANCH wider-notification-popu-when-on-top-or-bottom (branched from master) REVISION DETAIL https://phabricator.kde.org/D28989 To: ngraham, #vdg,

D28989: [applets/notifications] Widen pop-up and reduce spacing when on top or bottom center

2020-04-19 Thread Nathaniel Graham
ngraham added a comment. Heh, sorry! REPOSITORY R120 Plasma Workspace BRANCH wider-notification-popu-when-on-top-or-bottom (branched from master) REVISION DETAIL https://phabricator.kde.org/D28989 To: ngraham, #vdg, #plasma, broulik, ndavis Cc: ndavis, cblack, plasma-devel, Orage,

D28989: [applets/notifications] Widen pop-up and reduce spacing when on top or bottom center

2020-04-19 Thread Noah Davis
ndavis added a comment. Oof, what a sad set of example notifications  REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28989 To: ngraham, #vdg, #plasma, broulik Cc: ndavis, cblack, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus,

D28989: [applets/notifications] Widen pop-up and reduce spacing when on top or bottom center

2020-04-19 Thread Nathaniel Graham
ngraham created this revision. ngraham added reviewers: VDG, Plasma, broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Somehow the notification pop-up's positioning has never felt quite right to me.