D5227: Add a configuration option to hide the show password button

2017-07-17 Thread Fabian Vogt
fvogt abandoned this revision. REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D5227 To: fvogt, #plasma, graesslin Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D5227: Add a configuration option to hide the show password button

2017-03-28 Thread Fabian Vogt
fvogt added a comment. In https://phabricator.kde.org/D5227#98555, @graesslin wrote: > I'm against adding this option as the greeter does not have any influence over the lnf package. It works with our default but as soon as users change the theme we do not know. I'm against adding new op

D5227: Add a configuration option to hide the show password button

2017-03-28 Thread Martin Gräßlin
graesslin added a comment. I'm against adding this option as the greeter does not have any influence over the lnf package. It works with our default but as soon as users change the theme we do not know. I'm against adding new options which only work in the default setup. REPOSITORY R133 K

D5227: Add a configuration option to hide the show password button

2017-03-28 Thread Fabian Vogt
fvogt added a comment. In https://phabricator.kde.org/D5227#98542, @broulik wrote: > For show password button there's a kiosk restriction available: **lineedit_reveal_password** (see https://userbase.kde.org/KDE_System_Administration/Kiosk/Keys) Indeed, that works! Now if just th

D5227: Add a configuration option to hide the show password button

2017-03-28 Thread Kai Uwe Broulik
broulik added a comment. For show password button there's a kiosk restriction available: **lineedit_reveal_password** (see https://userbase.kde.org/KDE_System_Administration/Kiosk/Keys) REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D5227 To: fvogt, #plasma,

D5227: Add a configuration option to hide the show password button

2017-03-28 Thread Fabian Vogt
fvogt planned changes to this revision. fvogt added a comment. I would fix the clipboard content issue with klipper (although I find that approach wrong as it's too complicated as a seemingly unrelated component needs to support the screenlocker), but I do not have enough experience in that a

D5227: Add a configuration option to hide the show password button

2017-03-28 Thread Martin Gräßlin
graesslin requested changes to this revision. graesslin added a comment. This revision now requires changes to proceed. As already outlined in your thread on distributions I think this is wrong. And as the maintainer of the lock screen I'm against adding this option to the lock screen. It's t

D5227: Add a configuration option to hide the show password button

2017-03-28 Thread Fabian Vogt
fvogt updated this revision to Diff 12933. fvogt added a comment. Add a comment in greeterapp.cpp and also add a tooltip to the configuration option label. REPOSITORY R133 KScreenLocker CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5227?vs=12932&id=12933 BRANCH master REVISI

D5227: Add a configuration option to hide the show password button

2017-03-28 Thread Fabian Vogt
fvogt created this revision. Restricted Application added a project: Plasma. REVISION SUMMARY The show password button only makes sense with a virtual keyboard on touchscreens. On desktop PCs it's not only not useful, but it can also be used to show (partially) typed in passwords. It also