fvogt updated this revision to Diff 17287.
fvogt added a comment.
braces + const
A hasOwnProperty check is not needed here, that's accounted for by the if
(!favIconUrl) below
REPOSITORY
R856 Plasma Browser Integration
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6717?vs=16
broulik accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R856 Plasma Browser Integration
BRANCH
favicons (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D6717
To: fvogt, #plasma, broulik, davidedmundson
Cc: plasma-devel, ZrenBot, progw
This revision was automatically updated to reflect the committed changes.
Closed by commit R856:d435a59b0514: Expose base64-encoded favicons to the
tabsrunner (authored by fvogt).
REPOSITORY
R856 Plasma Browser Integration
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6717?vs=17287&
broulik added a comment.
Cool!
INLINE COMMENTS
> extension.js:495
> +var sendTabsIfComplete = function() {
> +if (--total > 0)
> +return;
Braces even for single line statements:
if (...) {
...
}
> extension.js:505
> +
> +for (let tabInd
fvogt marked 4 inline comments as done.
REPOSITORY
R856 Plasma Browser Integration
REVISION DETAIL
https://phabricator.kde.org/D6717
To: fvogt, #plasma, broulik, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart, lukas
fvogt updated this revision to Diff 16759.
fvogt added a comment.
Also send a request for the favicon without timeout to fill the cache for
next time.
Otherwise favicons from slow servers might never show up
REPOSITORY
R856 Plasma Browser Integration
CHANGES SINCE LAST UPDATE
https://p
fvogt added a comment.
It could also decode the base64 data in the plasma-browser-integration-host
already and send it as bytearray, I'm not sure what's simpler/better/faster.
REPOSITORY
R856 Plasma Browser Integration
REVISION DETAIL
https://phabricator.kde.org/D6717
To: fvogt, #plasma
fvogt created this revision.
Restricted Application added a project: Plasma.
REVISION SUMMARY
The browser has them in the cache already, so we avoid loading it ourselves,
also we might not even have access to the icons from our context.
Some browsers (Opera does) set the favIconUrl of the ta
